197408 2019-04-30 02:23:49 -0700 [Flatpak][Qt] Meson: Unknown type feature for gstreamer 2019-05-20 07:50:20 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ludovico.denittis webkit-unassigned commit-queue ews-feeder lforschler pnormand webkit-bug-importer oldest_to_newest 1531446 0 ludovico.denittis 2019-04-30 02:23:49 -0700 The flatpak build of WPE with the Qt extension enabled fails at compiling gstreamer 1.16.0 with the error "Unknown type feature". This is due to the fact that "feature" was introduced with meson 0.47.0, but at build time meson 0.46.0 is used. Steps to reproduce: $ ./Tools/Scripts/webkit-flatpak --wpe --wpe-extension=qt --update I'm going to submit a patch to fix it. 1531447 1 368545 ludovico.denittis 2019-04-30 02:31:19 -0700 Created attachment 368545 Patch 1531463 2 ludovico.denittis 2019-04-30 04:55:37 -0700 Now I'm getting this error, not sure if it is related to the kde runtime 5.12 bump. 1531464 3 ludovico.denittis 2019-04-30 04:55:52 -0700 Forgot the link: https://paste.ubuntu.com/p/nvWmBjpq65/ 1531507 4 ludovico.denittis 2019-04-30 08:10:18 -0700 The new error that I was receiving is not related to this patch. It's caused by another bug https://bugs.webkit.org/show_bug.cgi?id=197415 1537571 5 368545 ews-feeder 2019-05-20 07:15:24 -0700 Comment on attachment 368545 Patch Rejecting attachment 368545 from commit-queue. ludovico.denittis@collabora.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1537573 6 368545 commit-queue 2019-05-20 07:49:51 -0700 Comment on attachment 368545 Patch Clearing flags on attachment: 368545 Committed r245515: <https://trac.webkit.org/changeset/245515> 1537574 7 commit-queue 2019-05-20 07:49:53 -0700 All reviewed patches have been landed. Closing bug. 1537575 8 webkit-bug-importer 2019-05-20 07:50:20 -0700 <rdar://problem/50945849> 368545 2019-04-30 02:31:19 -0700 2019-05-20 07:49:51 -0700 Patch bug-197408-20190430113118.patch text/plain 1757 ludovico.denittis U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NzY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmJjNDgwNjQ3NzVkNWRkYzlmZmNhODkxZmZhZmNkMzFi MGU5M2E3MC4uMjFlMDBiNWMxMzQ4NWI0ODJiNDhlMmZmNzAzOGQ1NjE0YmM5NDE5MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE5LTA0LTMwICBMdWRvdmljbyBkZSBOaXR0aXMgIDxsdWRvdmljby5kZW5pdHRpc0Bj b2xsYWJvcmEuY29tPgorCisgICAgICAgIFtGbGF0cGFrXVtRdF0gTWVzb246IFVua25vd24gdHlw ZSBmZWF0dXJlIGZvciBnc3RyZWFtZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NzQwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgaXMgYSByZWdyZXNzaW9uIHRoYXQgaGFzIGJlZW4gaW50cm9k dWNlZCB3aGVuCisgICAgICAgIEdTdHJlYW1lciB3YXMgdXBkYXRlZCB0byB2ZXJzaW9uIDEuMTYu MAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3MTU3 CisKKyAgICAgICAgTm93IEdTdHJlYW1lciByZXF1aXJlcyBtZXNvbiA+PSAwLjQ3LjAKKyAgICAg ICAgVXBkYXRpbmcgdGhlIEtkZSBydW50aW1lIHRvIHZlcnNpb24gNS4xMiB3ZSBmdWxmaWxsCisg ICAgICAgIHRoaXMgcmVxdWlyZW1lbnQuCisKKyAgICAgICAgKiBmbGF0cGFrL29yZy53ZWJraXQu V1BFUVQueWFtbDoKKwogMjAxOS0wNC0yOSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MDI5OTM5Nj4gRml4IGlu dGVybmFsIEhpZ2ggU2llcnJhIGJ1aWxkCmRpZmYgLS1naXQgYS9Ub29scy9mbGF0cGFrL29yZy53 ZWJraXQuV1BFUVQueWFtbCBiL1Rvb2xzL2ZsYXRwYWsvb3JnLndlYmtpdC5XUEVRVC55YW1sCmlu ZGV4IDhmMTViOTU2MGFiNTNmNjNkNDJhMDRmZTVlZWZhYzQ2ZjRjYWI1ZWQuLmRlMzY5NTdhNDYx YmMzNDc5YTM4ZWZmZGU2ZDk1OGJkMDA3MjY3OGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2ZsYXRwYWsv b3JnLndlYmtpdC5XUEVRVC55YW1sCisrKyBiL1Rvb2xzL2ZsYXRwYWsvb3JnLndlYmtpdC5XUEVR VC55YW1sCkBAIC0xLDkgKzEsOSBAQAogYXBwLWlkOiBvcmcud2Via2l0LldQRVFUCiBydW50aW1l OiBvcmcua2RlLlBsYXRmb3JtCi1ydW50aW1lLXZlcnNpb246ICI1LjExIgorcnVudGltZS12ZXJz aW9uOiAiNS4xMiIKICMgQ29udHJvbCB0aGUgZXhhY3QgdmVyc2lvbiBvZiB0aGUgU2RrL1J1bnRp bWUgdGhhdCBpcyBiZWluZyB1c2VkLgotc2RrLWhhc2g6IGRkOWU1ZDNiMzEzNGMyNGZjMTkxMjI2 ZjA1OGZjNzhjNmJkZjFjMjVmZDdiZTM4YmVhOTc3ZmNiMTUzMDdlOTUKLXJ1bnRpbWUtaGFzaDog MDJlZGU4NGQzNTkxYTVlYTgwMjgyMDRkODYwNTliZmZhY2NiNzc4MTU5ZWM1M2M4NTliYmM2MGQ5 ZTcwMjVlOAorc2RrLWhhc2g6IGQ2ZWZhMjRlMjdjMWM4NzhhZDRmZGU3NmI3M2M5NmExMWJlMzJi NTk4YWU4N2FlZmJlMzM5ZWU0YmIxOWE4YmUKK3J1bnRpbWUtaGFzaDogMTAxODcxZTA5MTAwMDYx NmFkMmI2MzVlMDZjNDE0ZWIwZTFjNGUxYzM0MjkyYTIwNWM1MjM5OTM1ZWU1ZWE0NAogc2RrOiBv cmcua2RlLlNkawogY29tbWFuZDogJShDT01NQU5EKXMKIGZpbmlzaC1hcmdzOgo=