<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>197402</bug_id>
          
          <creation_ts>2019-04-29 19:54:12 -0700</creation_ts>
          <short_desc>Add a way to override the device name when building a user agent string</short_desc>
          <delta_ts>2019-04-29 20:11:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Wenson Hsieh">wenson_hsieh</reporter>
          <assigned_to name="Wenson Hsieh">wenson_hsieh</assigned_to>
          <cc>bdakin</cc>
    
    <cc>bfulgham</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1531412</commentid>
    <comment_count>0</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2019-04-29 19:54:12 -0700</bug_when>
    <thetext>&lt;rdar://problem/50141531&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1531415</commentid>
    <comment_count>1</comment_count>
      <attachid>368533</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2019-04-29 20:06:20 -0700</bug_when>
    <thetext>Created attachment 368533
Patch</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>368533</attachid>
            <date>2019-04-29 20:06:20 -0700</date>
            <delta_ts>2019-04-29 20:11:03 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-197402-20190429200619.patch</filename>
            <type>text/plain</type>
            <size>4827</size>
            <attacher name="Wenson Hsieh">wenson_hsieh</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmY4NzA0NTZjMDFkZjll
OGFiNGYzYWU4YzAyN2Q3ZDM2NjFkZTYzNS4uZWYzMTRlMjUyNTBkMTU5ZDZhNGRlNTdiYjMyZmQw
NWZlZmY3NDRiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA0LTI5ICBXZW5z
b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBhIHdheSB0
byBvdmVycmlkZSB0aGUgZGV2aWNlIG5hbWUgd2hlbiBidWlsZGluZyBhIHVzZXIgYWdlbnQgc3Ry
aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc0
MDIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUwMTQxNTMxPgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgYW4gb3B0aW9uYWwgZGV2aWNlIG5h
bWUgYXJndW1lbnQgdGhhdCwgaWYgc3BlY2lmaWVkLCB0YWtlcyBwcmVjZWRlbmNlIG92ZXIgdGhl
IHJlYWwgZGV2aWNlIG5hbWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9Vc2VyQWdlbnQuaDoKKyAg
ICAgICAgKFdlYkNvcmU6OnN0YW5kYXJkVXNlckFnZW50V2l0aEFwcGxpY2F0aW9uTmFtZSk6Cisg
ICAgICAgICogcGxhdGZvcm0vaW9zL1VzZXJBZ2VudElPUy5tbToKKyAgICAgICAgKFdlYkNvcmU6
OnN0YW5kYXJkVXNlckFnZW50V2l0aEFwcGxpY2F0aW9uTmFtZSk6CisgICAgICAgICogcGxhdGZv
cm0vbWFjL1VzZXJBZ2VudE1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OnN0YW5kYXJkVXNlckFn
ZW50V2l0aEFwcGxpY2F0aW9uTmFtZSk6CisKIDIwMTktMDQtMjggIFdlbnNvbiBIc2llaCAgPHdl
bnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gQWRkIGEgdmVyc2lvbiBvZiB2
aWV3cG9ydCBzaHJpbmstdG8tZml0IGhldXJpc3RpY3MgdGhhdCBwcmVzZXJ2ZXMgcGFnZSBsYXlv
dXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VzZXJBZ2VudC5oIGIvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50LmgKaW5kZXggM2M2ZWEyOTMwNzQ3ZmY0OWRh
YjdkNGEzYTNjMmVlNDc2OWUyNWQ3OC4uNDM2ZmNlMzgxZDkyOWY3ZmIxYzBlMDgzOTgyNjUwMzVl
ZTE3NWJiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50LmgK
KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50LmgKQEAgLTMyLDcgKzMyLDcg
QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAjaWYgUExBVEZPUk0oQ09DT0EpCiBlbnVtIGNsYXNz
IFVzZXJBZ2VudFR5cGUgeyBEZWZhdWx0LCBEZXNrdG9wIH07Ci1XRUJDT1JFX0VYUE9SVCBTdHJp
bmcgc3RhbmRhcmRVc2VyQWdlbnRXaXRoQXBwbGljYXRpb25OYW1lKGNvbnN0IFN0cmluZyYgYXBw
bGljYXRpb25OYW1lLCBVc2VyQWdlbnRUeXBlID0gVXNlckFnZW50VHlwZTo6RGVmYXVsdCk7CitX
RUJDT1JFX0VYUE9SVCBTdHJpbmcgc3RhbmRhcmRVc2VyQWdlbnRXaXRoQXBwbGljYXRpb25OYW1l
KGNvbnN0IFN0cmluZyYgYXBwbGljYXRpb25OYW1lLCBVc2VyQWdlbnRUeXBlID0gVXNlckFnZW50
VHlwZTo6RGVmYXVsdCwgY29uc3QgU3RyaW5nJiBvdmVycmlkZURldmljZU5hbWUgPSB7IH0pOwog
CiBTdHJpbmcgc3lzdGVtTWFya2V0aW5nVmVyc2lvbkZvclVzZXJBZ2VudFN0cmluZygpOwogI2Vs
c2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9Vc2VyQWdlbnRJT1Mu
bW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvVXNlckFnZW50SU9TLm1tCmluZGV4IDFh
OWExYTllNmJmMjVhMDhlZjZlMDc3OGQ3Y2FhZTkwODg1YjVmOTIuLjk4ZTM2YzZkNWYyNDc3NWE2
MDIzZTIwMDljOTZhNjBiNmFkN2U2OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2lvcy9Vc2VyQWdlbnRJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9z
L1VzZXJBZ2VudElPUy5tbQpAQCAtNzYsMTEgKzc2LDExIEBAIHN0YXRpYyBpbmxpbmUgU3RyaW5n
IGRldmljZU5hbWVGb3JVc2VyQWdlbnQoKQogICAgIHJldHVybiBuYW1lOwogfQogCi1TdHJpbmcg
c3RhbmRhcmRVc2VyQWdlbnRXaXRoQXBwbGljYXRpb25OYW1lKGNvbnN0IFN0cmluZyYgYXBwbGlj
YXRpb25OYW1lLCBVc2VyQWdlbnRUeXBlIHR5cGUpCitTdHJpbmcgc3RhbmRhcmRVc2VyQWdlbnRX
aXRoQXBwbGljYXRpb25OYW1lKGNvbnN0IFN0cmluZyYgYXBwbGljYXRpb25OYW1lLCBVc2VyQWdl
bnRUeXBlIHR5cGUsIGNvbnN0IFN0cmluZyYgb3ZlcnJpZGVEZXZpY2VOYW1lKQogewogICAgIGlm
ICh0eXBlID09IFVzZXJBZ2VudFR5cGU6OkRlc2t0b3ApIHsKICAgICAgICAgU3RyaW5nIGFwcE5h
bWVTdWZmaXggPSBhcHBsaWNhdGlvbk5hbWUuaXNFbXB0eSgpID8gIiIgOiBtYWtlU3RyaW5nKCIg
IiwgYXBwbGljYXRpb25OYW1lKTsKLSAgICAgICAgcmV0dXJuIG1ha2VTdHJpbmcoIk1vemlsbGEv
NS4wIChNYWNpbnRvc2g7IEludGVsIE1hYyBPUyBYIDEwXzE0KSBBcHBsZVdlYktpdC82MDUuMS4x
NSAoS0hUTUwsIGxpa2UgR2Vja28pIiwgYXBwTmFtZVN1ZmZpeCk7CisgICAgICAgIHJldHVybiBt
YWtlU3RyaW5nKCJNb3ppbGxhLzUuMCAoIiwgb3ZlcnJpZGVEZXZpY2VOYW1lLmlzRW1wdHkoKSA/
IFN0cmluZygiTWFjaW50b3NoIikgOiBvdmVycmlkZURldmljZU5hbWUsICI7IEludGVsIE1hYyBP
UyBYIDEwXzE0KSBBcHBsZVdlYktpdC82MDUuMS4xNSAoS0hUTUwsIGxpa2UgR2Vja28pIiwgYXBw
TmFtZVN1ZmZpeCk7CiAgICAgfQogCiAgICAgLy8gRklYTUU6IElzIHRoaXMgbmVlZGVkIGFueSBt
b3JlPyBNYWMgZG9lc24ndCBoYXZlIHRoaXMgY2hlY2ssCkBAIC05NSw3ICs5NSw3IEBAIFN0cmlu
ZyBzdGFuZGFyZFVzZXJBZ2VudFdpdGhBcHBsaWNhdGlvbk5hbWUoY29uc3QgU3RyaW5nJiBhcHBs
aWNhdGlvbk5hbWUsIFVzZXJBCiAgICAgU3RyaW5nIG9zVmVyc2lvbiA9IHN5c3RlbU1hcmtldGlu
Z1ZlcnNpb25Gb3JVc2VyQWdlbnRTdHJpbmcoKTsKICAgICBTdHJpbmcgYXBwTmFtZVN1ZmZpeCA9
IGFwcGxpY2F0aW9uTmFtZS5pc0VtcHR5KCkgPyAiIiA6IG1ha2VTdHJpbmcoIiAiLCBhcHBsaWNh
dGlvbk5hbWUpOwogCi0gICAgcmV0dXJuIG1ha2VTdHJpbmcoIk1vemlsbGEvNS4wICgiLCBkZXZp
Y2VOYW1lRm9yVXNlckFnZW50KCksICI7IENQVSAiLCBvc05hbWVGb3JVc2VyQWdlbnQoKSwgIiAi
LCBvc1ZlcnNpb24sICIgbGlrZSBNYWMgT1MgWCkgQXBwbGVXZWJLaXQvNjA1LjEuMTUgKEtIVE1M
LCBsaWtlIEdlY2tvKSIsIGFwcE5hbWVTdWZmaXgpOworICAgIHJldHVybiBtYWtlU3RyaW5nKCJN
b3ppbGxhLzUuMCAoIiwgb3ZlcnJpZGVEZXZpY2VOYW1lLmlzRW1wdHkoKSA/IGRldmljZU5hbWVG
b3JVc2VyQWdlbnQoKSA6IG92ZXJyaWRlRGV2aWNlTmFtZSwgIjsgQ1BVICIsIG9zTmFtZUZvclVz
ZXJBZ2VudCgpLCAiICIsIG9zVmVyc2lvbiwgIiBsaWtlIE1hYyBPUyBYKSBBcHBsZVdlYktpdC82
MDUuMS4xNSAoS0hUTUwsIGxpa2UgR2Vja28pIiwgYXBwTmFtZVN1ZmZpeCk7CiB9CiAKIH0gLy8g
bmFtZXNwYWNlIFdlYkNvcmUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t
YWMvVXNlckFnZW50TWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1VzZXJBZ2Vu
dE1hYy5tbQppbmRleCAzMjBjYWRhZDY1MzUzNDNjMTE3YWI3M2E2OGI5ZTBlNTkxOTdiZWMwLi45
NGE2YWU4MjdlMTNkMjFjOTEyODNmMTliNWIzMzZiMGE3NmVlOGVkIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvVXNlckFnZW50TWFjLm1tCisrKyBiL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL21hYy9Vc2VyQWdlbnRNYWMubW0KQEAgLTMyLDEyICszMiwxMiBAQAogCiBu
YW1lc3BhY2UgV2ViQ29yZSB7CiAKLVN0cmluZyBzdGFuZGFyZFVzZXJBZ2VudFdpdGhBcHBsaWNh
dGlvbk5hbWUoY29uc3QgU3RyaW5nJiBhcHBsaWNhdGlvbk5hbWUsIFVzZXJBZ2VudFR5cGUpCitT
dHJpbmcgc3RhbmRhcmRVc2VyQWdlbnRXaXRoQXBwbGljYXRpb25OYW1lKGNvbnN0IFN0cmluZyYg
YXBwbGljYXRpb25OYW1lLCBVc2VyQWdlbnRUeXBlLCBjb25zdCBTdHJpbmcmIG92ZXJyaWRlRGV2
aWNlTmFtZSkKIHsKICAgICBTdHJpbmcgb3NWZXJzaW9uID0gc3lzdGVtTWFya2V0aW5nVmVyc2lv
bkZvclVzZXJBZ2VudFN0cmluZygpOwogICAgIFN0cmluZyBhcHBOYW1lU3VmZml4ID0gYXBwbGlj
YXRpb25OYW1lLmlzRW1wdHkoKSA/ICIiIDogbWFrZVN0cmluZygiICIsIGFwcGxpY2F0aW9uTmFt
ZSk7CiAKLSAgICByZXR1cm4gbWFrZVN0cmluZygiTW96aWxsYS81LjAgKE1hY2ludG9zaDsgSW50
ZWwgTWFjIE9TIFggIiwgb3NWZXJzaW9uLCAiKSBBcHBsZVdlYktpdC82MDUuMS4xNSAoS0hUTUws
IGxpa2UgR2Vja28pIiwgYXBwTmFtZVN1ZmZpeCk7CisgICAgcmV0dXJuIG1ha2VTdHJpbmcoIk1v
emlsbGEvNS4wICgiLCBvdmVycmlkZURldmljZU5hbWUuaXNFbXB0eSgpID8gU3RyaW5nKCJNYWNp
bnRvc2giKSA6IG92ZXJyaWRlRGV2aWNlTmFtZSwgIjsgSW50ZWwgTWFjIE9TIFggIiwgb3NWZXJz
aW9uLCAiKSBBcHBsZVdlYktpdC82MDUuMS4xNSAoS0hUTUwsIGxpa2UgR2Vja28pIiwgYXBwTmFt
ZVN1ZmZpeCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK
</data>
<flag name="review"
          id="384810"
          type_id="1"
          status="+"
          setter="thorton"
    />
          </attachment>
      

    </bug>

</bugzilla>