197395 2019-04-29 16:55:01 -0700 [ews-build] Parse and display webkitpy failures 2019-04-30 07:52:18 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1531376 0 aakash_jain 2019-04-29 16:55:01 -0700 WebKitPy queue should parse the test failures from the json output, and include that information in step and build status. 1531378 1 368516 aakash_jain 2019-04-29 16:57:46 -0700 Created attachment 368516 Patch 1531379 2 ews-watchlist 2019-04-29 16:59:23 -0700 Attachment 368516 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:499: [RunWebKitPyTests.getResultSummary] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:499: [RunWebKitPyTests.getResultSummary] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:500: [RunWebKitPyTests.getResultSummary] Instance of 'RunWebKitPyTests' has no 'results' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:375: [TestWebKitPyTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:375: [TestWebKitPyTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1531408 3 368516 ap 2019-04-29 19:39:15 -0700 Comment on attachment 368516 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368516&action=review > Tools/ChangeLog:3 > + [ews-build] Parse and display webkitpy failures Python tests support JSON output. What is missing from it that requires parsing? 1531456 4 aakash_jain 2019-04-30 03:24:09 -0700 (In reply to Alexey Proskuryakov from comment #3) > Python tests support JSON output. What is missing from it that requires parsing? After running the tests, buildbot needs to read that JSON output, and set the build and step status strings which would contain the failing test names. This would also make the status bubble tooltip display the failing test names. 1531486 5 368516 commit-queue 2019-04-30 07:51:18 -0700 Comment on attachment 368516 Patch Clearing flags on attachment: 368516 Committed r244769: <https://trac.webkit.org/changeset/244769> 1531487 6 commit-queue 2019-04-30 07:51:20 -0700 All reviewed patches have been landed. Closing bug. 1531488 7 webkit-bug-importer 2019-04-30 07:52:18 -0700 <rdar://problem/50334787> 368516 2019-04-29 16:57:46 -0700 2019-04-30 07:51:18 -0700 Patch bug-197395-20190429195745.patch text/plain 3634 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDc2MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTA0LTI5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBQYXJzZSBhbmQgZGlzcGxheSB3ZWJraXRweSBmYWls dXJlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3 Mzk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBC dWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChSdW5XZWJLaXRQ eVRlc3RzLnN0YXJ0KTogSW5pdGlhbGl6ZSBsb2dfb2JzZXJ2ZXIgZm9yIGpzb24gb3V0cHV0Lgor ICAgICAgICAoUnVuV2ViS2l0UHlUZXN0cy5nZXRSZXN1bHRTdW1tYXJ5KTogVXBkYXRlIHN0ZXAg YW5kIGJ1aWxkIHN1bW1hcnkgYmFzZWQgb24gd2Via2l0cHkgcmVzdWx0cy4KKyAgICAgICAgKFJ1 bldlYktpdFB5VGVzdHMuX2FkZFRvTG9nKTogTWV0aG9kIHRvIGFkZCBtZXNzYWdlIHRvIGxvZy4K KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6 IFVwZGF0ZWQgdW5pdC10ZXN0IGFjY29yZGluZ2x5LgorCiAyMDE5LTA0LTI5ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzUwMjk5Mzk2PiBGaXggaW50ZXJuYWwgSGlnaCBTaWVycmEgYnVpbGQKSW5kZXg6IFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI0NDc2MSkK KysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBj b3B5KQpAQCAtNDkxLDYgKzQ5MSw0MiBAQCBjbGFzcyBSdW5XZWJLaXRQeVRlc3RzKHNoZWxsLlNo ZWxsQ29tbWFuCiAgICAgZGVmIF9faW5pdF9fKHNlbGYsICoqa3dhcmdzKToKICAgICAgICAgc3Vw ZXIoUnVuV2ViS2l0UHlUZXN0cywgc2VsZikuX19pbml0X18odGltZW91dD0yICogNjAsICoqa3dh cmdzKQogCisgICAgZGVmIHN0YXJ0KHNlbGYpOgorICAgICAgICBzZWxmLmxvZ19vYnNlcnZlciA9 IGxvZ29ic2VydmVyLkJ1ZmZlckxvZ09ic2VydmVyKCkKKyAgICAgICAgc2VsZi5hZGRMb2dPYnNl cnZlcignanNvbicsIHNlbGYubG9nX29ic2VydmVyKQorICAgICAgICByZXR1cm4gc2hlbGwuU2hl bGxDb21tYW5kLnN0YXJ0KHNlbGYpCisKKyAgICBkZWYgZ2V0UmVzdWx0U3VtbWFyeShzZWxmKToK KyAgICAgICAgaWYgc2VsZi5yZXN1bHRzID09IFNVQ0NFU1M6CisgICAgICAgICAgICBtZXNzYWdl ID0gJ1Bhc3NlZCB3ZWJraXRweSB0ZXN0cycKKyAgICAgICAgICAgIHNlbGYuYnVpbGQuYnVpbGRG aW5pc2hlZChbbWVzc2FnZV0sIFNVQ0NFU1MpCisgICAgICAgICAgICByZXR1cm4ge3Unc3RlcCc6 IHVuaWNvZGUobWVzc2FnZSl9CisKKyAgICAgICAgbG9nTGluZXMgPSBzZWxmLmxvZ19vYnNlcnZl ci5nZXRTdGRvdXQoKQorICAgICAgICBqc29uX3RleHQgPSAnJy5qb2luKFtsaW5lIGZvciBsaW5l IGluIGxvZ0xpbmVzLnNwbGl0bGluZXMoKV0pCisgICAgICAgIHRyeToKKyAgICAgICAgICAgIHdl YmtpdHB5X3Jlc3VsdHMgPSBqc29uLmxvYWRzKGpzb25fdGV4dCkKKyAgICAgICAgZXhjZXB0IEV4 Y2VwdGlvbiBhcyBleDoKKyAgICAgICAgICAgIHNlbGYuX2FkZFRvTG9nKCdzdGRlcnInLCAnRVJS T1I6IHVuYWJsZSB0byBwYXJzZSBkYXRhLCBleGNlcHRpb246IHt9Jy5mb3JtYXQoZXgpKQorICAg ICAgICAgICAgcmV0dXJuIHN1cGVyKFJ1bldlYktpdFB5VGVzdHMsIHNlbGYpLmdldFJlc3VsdFN1 bW1hcnkoKQorCisgICAgICAgIGZhaWx1cmVzID0gd2Via2l0cHlfcmVzdWx0cy5nZXQoJ2ZhaWx1 cmVzJykgKyB3ZWJraXRweV9yZXN1bHRzLmdldCgnZXJyb3JzJykKKyAgICAgICAgaWYgbm90IGZh aWx1cmVzOgorICAgICAgICAgICAgcmV0dXJuIHN1cGVyKFJ1bldlYktpdFB5VGVzdHMsIHNlbGYp LmdldFJlc3VsdFN1bW1hcnkoKQorICAgICAgICBwbHVyYWxTdWZmaXggPSAncycgaWYgbGVuKGZh aWx1cmVzKSA+IDEgZWxzZSAnJworICAgICAgICBmYWlsdXJlc19zdHJpbmcgPSAnLCAnLmpvaW4o W2ZhaWx1cmUuZ2V0KCduYW1lJykucmVwbGFjZSgnd2Via2l0cHkuJywgJycpIGZvciBmYWlsdXJl IGluIGZhaWx1cmVzXSkKKyAgICAgICAgbWVzc2FnZSA9ICdGb3VuZCB7fSBXZWJLaXRQeSB0ZXN0 IGZhaWx1cmV7fToge30nLmZvcm1hdChsZW4oZmFpbHVyZXMpLCBwbHVyYWxTdWZmaXgsIGZhaWx1 cmVzX3N0cmluZykKKyAgICAgICAgc2VsZi5idWlsZC5idWlsZEZpbmlzaGVkKFttZXNzYWdlXSwg RkFJTFVSRSkKKyAgICAgICAgcmV0dXJuIHt1J3N0ZXAnOiB1bmljb2RlKG1lc3NhZ2UpfQorCisg ICAgQGRlZmVyLmlubGluZUNhbGxiYWNrcworICAgIGRlZiBfYWRkVG9Mb2coc2VsZiwgbG9nTmFt ZSwgbWVzc2FnZSk6CisgICAgICAgIHRyeToKKyAgICAgICAgICAgIGxvZyA9IHNlbGYuZ2V0TG9n KGxvZ05hbWUpCisgICAgICAgIGV4Y2VwdCBLZXlFcnJvcjoKKyAgICAgICAgICAgIGxvZyA9IHlp ZWxkIHNlbGYuYWRkTG9nKGxvZ05hbWUpCisgICAgICAgIGxvZy5hZGRTdGRvdXQobWVzc2FnZSkK KwogCiBkZWYgYXBwZW5kQ3VzdG9tQnVpbGRGbGFncyhzdGVwLCBwbGF0Zm9ybSwgZnVsbFBsYXRm b3JtKToKICAgICAjIEZJWE1FOiBNYWtlIGEgY29tbW9uICdzdXBwb3J0ZWQgcGxhdGZvcm1zJyBs aXN0LgpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0 ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjQ0NzYxKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zNzIs NyArMzcyLDcgQEAgY2xhc3MgVGVzdFdlYktpdFB5VGVzdHMoQnVpbGRTdGVwTWl4aW5BZAogICAg ICAgICAgICAgICAgICAgICAgICAgKQogICAgICAgICAgICAgKyAwLAogICAgICAgICApCi0gICAg ICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSd3ZWJr aXRweS10ZXN0cycpCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywg c3RhdGVfc3RyaW5nPSdQYXNzZWQgd2Via2l0cHkgdGVzdHMnKQogICAgICAgICByZXR1cm4gc2Vs Zi5ydW5TdGVwKCkKIAogICAgIGRlZiB0ZXN0X2ZhaWx1cmUoc2VsZik6Cg==