19739 2008-06-24 00:44:44 -0700 REGRESSION: fast/js/property-getters-and-setters.html fails 2008-06-24 13:00:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED Regression P1 Normal --- 1 zwarich darin darin ggaren mjs oliver oldest_to_newest 84227 0 zwarich 2008-06-24 00:44:44 -0700 The layout test fast/js/property-getters-and-setters.html now fails. All tests were passing for me with r34751, so I suspect that r34754 is to blame. I'll go from r34753 to r34754 soon to double check, but going back and forth requires rebuilding the entire world due to the scope of the changes. 84256 1 darin 2008-06-24 08:29:17 -0700 That's strange. I had run all the regression tests with my changes. Maybe I made a tweak after the fact that broke this. I'll look at this ASAP. 84257 2 21905 darin 2008-06-24 08:43:58 -0700 Created attachment 21905 patch 84258 3 darin 2008-06-24 08:44:14 -0700 Sorry, it *was* something I tweaked after running all the tests. 84287 4 21905 zwarich 2008-06-24 10:50:47 -0700 Comment on attachment 21905 patch r=me 84294 5 darin 2008-06-24 13:00:59 -0700 Committed revision 34773. 21905 2008-06-24 08:43:58 -0700 2008-06-24 10:50:47 -0700 patch SetterPatch.txt text/plain 1978 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM0NzY3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDYtMjQgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIC0gZml4IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTczOQorICAgICAgICAgIFJFR1JFU1NJT046IGZhc3QvanMvcHJvcGVydHktZ2V0dGVy cy1hbmQtc2V0dGVycy5odG1sIGZhaWxzCisKKyAgICAgICAgKiBranMvSlNPYmplY3QuY3BwOgor ICAgICAgICAoS0pTOjpKU09iamVjdDo6cHV0KTogUmVtb3ZlIGFuIHVudGVzdGVkIG9wdGltaXph dGlvbiBJIGNoZWNrZWQgaW4gYnkgYWNjaWRlbnQuCisgICAgICAgIFRoZSB0d28gbG9vcHMgdXAg dGhlIHByb3RvdHlwZSBjaGFpbiBib3RoIG5lZWQgdG8gc3RhcnQgZnJvbSB0aGlzOyBpbnN0ZWFk IHRoZQorICAgICAgICBzZWNvbmQgbG9vcCB3YXMgc3RhcnRpbmcgd2hlcmUgdGhlIGZpcnN0IGxv b3AgbGVmdCBvZmYuCisKIDIwMDgtMDYtMjQgIEpvZXJnIEJvcm5lbWFubiAgPGpvZXJnLmJvcm5l bWFubkB0cm9sbHRlY2guY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uLgpJbmRleDog SmF2YVNjcmlwdENvcmUva2pzL0pTT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9ranMvSlNPYmplY3QuY3BwCShyZXZpc2lvbiAzNDc2NykKKysrIEphdmFTY3JpcHRDb3Jl L2tqcy9KU09iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMyw5ICsxMTMsOCBAQCB2b2lk IEpTT2JqZWN0OjpwdXQoRXhlY1N0YXRlKiBleGVjLCBjb25zCiAgIH0KIAogICAvLyBDaGVjayBp ZiB0aGVyZSBhcmUgYW55IHNldHRlcnMgb3IgZ2V0dGVycyBpbiB0aGUgcHJvdG90eXBlIGNoYWlu Ci0gIEpTT2JqZWN0KiBvYmo7CiAgIEpTVmFsdWUqIHByb3RvdHlwZTsKLSAgZm9yIChvYmogPSB0 aGlzOyAhb2JqLT5fcHJvcC5oYXNHZXR0ZXJTZXR0ZXJQcm9wZXJ0aWVzKCk7IG9iaiA9IHN0YXRp Y19jYXN0PEpTT2JqZWN0Kj4ocHJvdG90eXBlKSkgeworICBmb3IgKEpTT2JqZWN0KiBvYmogPSB0 aGlzOyAhb2JqLT5fcHJvcC5oYXNHZXR0ZXJTZXR0ZXJQcm9wZXJ0aWVzKCk7IG9iaiA9IHN0YXRp Y19jYXN0PEpTT2JqZWN0Kj4ocHJvdG90eXBlKSkgewogICAgIHByb3RvdHlwZSA9IG9iai0+X3By b3RvOwogICAgIGlmIChwcm90b3R5cGUgPT0ganNOdWxsKCkpIHsKICAgICAgIF9wcm9wLnB1dChw cm9wZXJ0eU5hbWUsIHZhbHVlLCAwLCB0cnVlKTsKQEAgLTEyNyw3ICsxMjYsNyBAQCB2b2lkIEpT T2JqZWN0OjpwdXQoRXhlY1N0YXRlKiBleGVjLCBjb25zCiAgIGlmIChfcHJvcC5nZXQocHJvcGVy dHlOYW1lLCBhdHRyaWJ1dGVzKSAmJiBhdHRyaWJ1dGVzICYgUmVhZE9ubHkpCiAgICAgcmV0dXJu OwogCi0gIGZvciAoOyA7IG9iaiA9IHN0YXRpY19jYXN0PEpTT2JqZWN0Kj4ocHJvdG90eXBlKSkg eworICBmb3IgKEpTT2JqZWN0KiBvYmogPSB0aGlzOyA7IG9iaiA9IHN0YXRpY19jYXN0PEpTT2Jq ZWN0Kj4ocHJvdG90eXBlKSkgewogICAgIGlmIChKU1ZhbHVlKiBncyA9IG9iai0+X3Byb3AuZ2V0 KHByb3BlcnR5TmFtZSwgYXR0cmlidXRlcykpIHsKICAgICAgIGlmIChhdHRyaWJ1dGVzICYgSXNH ZXR0ZXJTZXR0ZXIpIHsKICAgICAgICAgSlNPYmplY3QqIHNldHRlckZ1bmMgPSBzdGF0aWNfY2Fz dDxHZXR0ZXJTZXR0ZXIqPihncyktPnNldHRlcigpOyAgICAgICAgCg==