197352 2019-04-28 08:07:36 -0700 [Flatpak] webkit-build fails due to missing GTK2 in build environment 2019-05-07 09:16:19 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Linux RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez commit-queue lforschler mcatanzaro pnormand tsaunier webkit-bug-importer oldest_to_newest 1531051 0 aperez 2019-04-28 08:07:36 -0700 Just tested from a fresh repository (right after running “git clean -xdf”): % update-webkitgtk-flatpak [lots of output, build completes just fine] % build-webkit --gtk [cmake output, eventually fails with:] -- Checking for module 'gtk+-2.0' -- Package 'gtk+-2.0', required by 'virtual:world', not found CMake Error at /usr/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:137 (message): Could NOT find GTK2 (missing: GTK2_INCLUDE_DIRS GTK2_LIBRARIES) (Required is at least version "2.24.10") Call Stack (most recent call first): /usr/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE) Source/cmake/FindGTK2.cmake:49 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) Source/cmake/OptionsGTK.cmake:290 (find_package) Source/cmake/WebKitCommon.cmake:56 (include) CMakeLists.txt:167 (include) -- Configuring incomplete, errors occurred! 1531052 1 aperez 2019-04-28 08:13:14 -0700 As a workaround, once can use instead: % build-webkit --gtk --cmakeargs='-DENABLE_PLUGIN_PROCESS_GTK2=OFF' but in my opinion developers should not need to pass anything special to “build-webkit” to get a vanilla build done with the usual development compilation options. From what I understand, this is because the Flatpak SDK is not shipping GTK2 anymore, which means we have two ways to go about this: a.) Add GTK2 to our local build manifest. b.) When building inside the Flatpak environment, automatically disable the GTK2 plugin process. While I would prefer to to (b.) —and in the long run that is what will happen— at the moment we support the option, and threfore I think that we should routinely build with the option enabled to make sure the code does not bitrot, so right now I think we should go for (a.). 1531053 2 mcatanzaro 2019-04-28 08:46:55 -0700 That's weird, because we never had GTK2 in gnome-build-meta. 1533911 3 369282 aperez 2019-05-07 07:52:16 -0700 Created attachment 369282 Patch 1533916 4 369282 pnormand 2019-05-07 08:20:32 -0700 Comment on attachment 369282 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369282&action=review > Tools/flatpak/org.webkit.GTK.yaml:101 > + config-opts: Can examples also be disabled? 1533920 5 aperez 2019-05-07 08:40:20 -0700 (In reply to Philippe Normand from comment #4) > Comment on attachment 369282 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369282&action=review > > > Tools/flatpak/org.webkit.GTK.yaml:101 > > + config-opts: > > Can examples also be disabled? Unfortunately, there is no flag in the autotools configure script to disable the examples :-/ 1533942 6 369282 commit-queue 2019-05-07 09:15:17 -0700 Comment on attachment 369282 Patch Clearing flags on attachment: 369282 Committed r245011: <https://trac.webkit.org/changeset/245011> 1533943 7 commit-queue 2019-05-07 09:15:19 -0700 All reviewed patches have been landed. Closing bug. 1533945 8 webkit-bug-importer 2019-05-07 09:16:19 -0700 <rdar://problem/50542468> 369282 2019-05-07 07:52:16 -0700 2019-05-07 09:15:17 -0700 Patch bug-197352-20190507175214.patch text/plain 1808 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MDAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTdjYmVlNjY1NzQzYTM4NGNiZTRkZDQ0YzBmYjg4YTE3 YmFhYmRkNi4uNjkwZDFhYzQ3OGQ4OTdhNDU5ZmM4YjEyNjQ1MTJmNjcxMGUwYzliYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE5LTA1LTA3ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CisKKyAgICAgICAgW0ZsYXRwYWtdIHdlYmtpdC1idWlsZCBmYWlscyBkdWUgdG8gbWlzc2lu ZyBHVEsyIGluIGJ1aWxkIGVudmlyb25tZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTczNTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgRmxhdHBhayBydW50aW1lcyBkbyBub3QgaW5jbHVkZSBH VEsgMi54IGFueW1vcmUsIHdoaWNoIG1lYW5zIHRoYXQgd2UgbmVlZAorICAgICAgICB0byBidWls ZCBpdCBvdXJzZWx2ZXMgb24gdG9wIGluIG9yZGVyIHRvIGJlIGFibGUgdG8gYnVpbGQgdGhlIEdU SyAyLnggcGx1Z2luCisgICAgICAgIHByb2Nlc3MuCisKKyAgICAgICAgKiBmbGF0cGFrL29yZy53 ZWJraXQuR1RLLnlhbWw6IEFkZCBndGsyIHBhY2thZ2UuCisKIDIwMTktMDUtMDYgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgX292ZXJyaWRlVmlld3Bv cnRXaXRoQXJndW1lbnRzIGRvZXMgbm90IHdvcmsgd2hlbiBjYWxsZWQgYmVmb3JlIGxvYWRpbmcK ZGlmZiAtLWdpdCBhL1Rvb2xzL2ZsYXRwYWsvb3JnLndlYmtpdC5HVEsueWFtbCBiL1Rvb2xzL2Zs YXRwYWsvb3JnLndlYmtpdC5HVEsueWFtbAppbmRleCAxY2E0NjFlYmRhNTZlM2FlMTE3YjdmODM1 YWI4NmQ0MDk5ZGI3NTNjLi40OWVjY2ZkMTYzMDhmNGI0MTFhZGI3ODVkZjdiZmM4ZTBkZjU1ZDIx IDEwMDY0NAotLS0gYS9Ub29scy9mbGF0cGFrL29yZy53ZWJraXQuR1RLLnlhbWwKKysrIGIvVG9v bHMvZmxhdHBhay9vcmcud2Via2l0LkdUSy55YW1sCkBAIC04OCw2ICs4OCwyMyBAQAogICAgIC0g LS1kaXNhYmxlLWxvY2FsLXRyYW5zcG9ydAogICAgIC0gLS13aXRob3V0LWR0cmFjZQogCisjIFJl cXVpcmVkIGZvciB0aGUgR1RLMiBwbHVnaW4gcHJvY2VzcworLSBuYW1lOiBndGsyCisgIHNvdXJj ZXM6CisgIC0gdHlwZTogYXJjaGl2ZQorICAgIHVybDogaHR0cHM6Ly9kb3dubG9hZC5nbm9tZS5v cmcvc291cmNlcy9ndGsrLzIuMjQvZ3RrKy0yLjI0LjMyLnRhci54egorICAgIHNoYTI1NjogYjZj OGE5M2RkZGE1ZWFiZTNiZmVlMWViMzk2MzZjOWEwM2QyYTU2YzdiNjI4MjhiMzU5YmYxOTc5NDNj NTgyZQorICAtIHR5cGU6IHNjcmlwdAorICAgIGNvbW1hbmRzOgorICAgICAgLSAic2VkIC1pICcx cy9weXRob24kLyYyLycgZ3RrL2d0ay1idWlsZGVyLWNvbnZlcnQiCisgICAgICAtICJzZWQgLWkg LWUgJ3MvIC1zaGFyZWQgLyAtV2wsLU8xLC0tYXMtbmVlZGVkXDAvZycgbGlidG9vbCIKKyAgY29u ZmlnLW9wdHM6CisgICAgLSAtLWRpc2FibGUtZ3RrLWRvYworICAgIC0gLS1kaXNhYmxlLWN1cHMK KyAgICAtIC0tZGlzYWJsZS1wYXBpCisgICAgLSAtLWVuYWJsZS1pbnRyb3NwZWN0aW9uPW5vCisg ICAgLSAtLXdpdGgtZ2RrdGFyZ2V0PXgxMQorCiAjIFJlcXVpcmVkIGZvciBydW4tZ3RrLXRlc3Rz CiAtIG5hbWU6IHB5Y2Fpcm8KICAgYnVpbGRzeXN0ZW06IHNpbXBsZQo=