197341 2019-04-26 20:07:16 -0700 Lookup only looking up the first word in selection 2019-04-27 07:41:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner commit-queue thorton wenson_hsieh oldest_to_newest 1530916 0 megan_gardner 2019-04-26 20:07:16 -0700 Lookup only looking up the first word in selection 1530917 1 368383 megan_gardner 2019-04-26 20:14:06 -0700 Created attachment 368383 Patch 1530919 2 megan_gardner 2019-04-26 20:15:28 -0700 <rdar://problem/48221414> 1530924 3 368383 wenson_hsieh 2019-04-26 20:43:37 -0700 Comment on attachment 368383 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368383&action=review > Source/WebCore/ChangeLog:11 > + Reveal needs the full range in order to correctly create the item for the popover. Hmm...from the code change below, it seems like it needs the full range, minus the last character. Or should we actually be passing in the full range of the attributed string? 1530925 4 368385 megan_gardner 2019-04-26 20:52:10 -0700 Created attachment 368385 Patch 1530967 5 368385 commit-queue 2019-04-27 07:41:29 -0700 Comment on attachment 368385 Patch Clearing flags on attachment: 368385 Committed r244718: <https://trac.webkit.org/changeset/244718> 1530968 6 commit-queue 2019-04-27 07:41:31 -0700 All reviewed patches have been landed. Closing bug. 368383 2019-04-26 20:14:06 -0700 2019-04-26 20:52:08 -0700 Patch bug-197341-20190426221406.patch text/plain 3313 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NjYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2I3MmEzOTQ3NDA5ODFj N2FlNjA1MTQwMTI1OGVjZjE1YmJjODY5OS4uOTdlZWExMjVlMDU5MmZjZGIyOTc3Yjk4OGQzY2Qz ODI3OTY0MjFkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA0LTI2ICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgTG9va3VwIG9u bHkgbG9va2luZyB1cCB0aGUgZmlyc3Qgd29yZCBpbiBzZWxlY3Rpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzM0MQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNDgyMjE0MTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTG9va3VwIGlzIG5vdCB0ZXN0YWJsZS4KKworICAgICAgICBSZXZlYWwgbmVl ZHMgdGhlIGZ1bGwgcmFuZ2UgaW4gb3JkZXIgdG8gY29ycmVjdGx5IGNyZWF0ZSB0aGUgaXRlbSBm b3IgdGhlIHBvcG92ZXIuCisKKyAgICAgICAgKiBlZGl0aW5nL2NvY29hL0RpY3Rpb25hcnlMb29r dXAubW06CisgICAgICAgIChXZWJDb3JlOjpzaG93UG9wdXBPckNyZWF0ZUFuaW1hdGlvbkNvbnRy b2xsZXIpOgorCiAyMDE5LTA0LTI1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgRml4IG1vcmUgYnVpbGRzIGFmdGVyIHIyNDQ2NTMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvRGljdGlvbmFyeUxvb2t1cC5tbSBi L1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvRGljdGlvbmFyeUxvb2t1cC5tbQppbmRleCAx ZmY4YTcwOTA2NTNhNDUwZjUyODNiMjYyZmUyODg2MWE3NTMyM2ZhLi41OTM0YTIxOWVmNWI4OWIw NzJiNjg5ZmQxYTkzYWJlOWQ1Mzc1NmJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0 aW5nL2NvY29hL0RpY3Rpb25hcnlMb29rdXAubW0KKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9jb2NvYS9EaWN0aW9uYXJ5TG9va3VwLm1tCkBAIC00ODIsNyArNDgyLDcgQEAgc3RhdGljIFdL UmV2ZWFsQ29udHJvbGxlciBzaG93UG9wdXBPckNyZWF0ZUFuaW1hdGlvbkNvbnRyb2xsZXIoYm9v bCBjcmVhdGVBbmltYXQKICAgICBSZXRhaW5QdHI8V2ViUmV2ZWFsSGlnaGxpZ2h0PiB3ZWJIaWdo bGlnaHQgPSAgYWRvcHROUyhbW1dlYlJldmVhbEhpZ2hsaWdodCBhbGxvY10gaW5pdFdpdGhIaWdo bGlnaHRSZWN0OiBoaWdobGlnaHRSZWN0IHVzZURlZmF1bHRIaWdobGlnaHQ6IXRleHRJbmRpY2F0 b3IuZ2V0KCkuY29udGVudEltYWdlKCkgYXR0cmlidXRlZFN0cmluZzpkaWN0aW9uYXJ5UG9wdXBJ bmZvLmF0dHJpYnV0ZWRTdHJpbmcuZ2V0KCldKTsKICAgICBSZXRhaW5QdHI8UlZQcmVzZW50aW5n Q29udGV4dD4gY29udGV4dCA9IGFkb3B0TlMoW2FsbG9jUlZQcmVzZW50aW5nQ29udGV4dEluc3Rh bmNlKCkgaW5pdFdpdGhQb2ludGVyTG9jYXRpb25JblZpZXc6cG9pbnRlckxvY2F0aW9uIGluVmll dzp2aWV3IGhpZ2hsaWdodERlbGVnYXRlOihpZDxSVlByZXNlbnRlckhpZ2hsaWdodERlbGVnYXRl Pikgd2ViSGlnaGxpZ2h0LmdldCgpXSk7CiAgICAgCi0gICAgUmV0YWluUHRyPFJWSXRlbT4gaXRl bSA9IGFkb3B0TlMoW2FsbG9jUlZJdGVtSW5zdGFuY2UoKSBpbml0V2l0aFRleHQ6ZGljdGlvbmFy eVBvcHVwSW5mby5hdHRyaWJ1dGVkU3RyaW5nLmdldCgpLnN0cmluZyBzZWxlY3RlZFJhbmdlOk5T TWFrZVJhbmdlKDAsIDApXSk7CisgICAgUmV0YWluUHRyPFJWSXRlbT4gaXRlbSA9IGFkb3B0TlMo W2FsbG9jUlZJdGVtSW5zdGFuY2UoKSBpbml0V2l0aFRleHQ6ZGljdGlvbmFyeVBvcHVwSW5mby5h dHRyaWJ1dGVkU3RyaW5nLmdldCgpLnN0cmluZyBzZWxlY3RlZFJhbmdlOk5TTWFrZVJhbmdlKDAs IGRpY3Rpb25hcnlQb3B1cEluZm8uYXR0cmlidXRlZFN0cmluZy5nZXQoKS5zdHJpbmcubGVuZ3Ro LTEpXSk7CiAgICAgCiAgICAgW3dlYkhpZ2hsaWdodCBzZXRDbGVhclRleHRJbmRpY2F0b3I6W3dl YkhpZ2hsaWdodCA9IFdURk1vdmUod2ViSGlnaGxpZ2h0KSwgY2xlYXJUZXh0SW5kaWNhdG9yID0g V1RGTW92ZShjbGVhclRleHRJbmRpY2F0b3IpXSB7CiAgICAgICAgIGlmIChjbGVhclRleHRJbmRp Y2F0b3IpCkBAIC01MDQsOCArNTA0LDggQEAgc3RhdGljIFdLUmV2ZWFsQ29udHJvbGxlciBzaG93 UG9wdXBPckNyZWF0ZUFuaW1hdGlvbkNvbnRyb2xsZXIoYm9vbCBjcmVhdGVBbmltYXQKICAgICBh dXRvIHRleHRJbmRpY2F0b3IgPSBUZXh0SW5kaWNhdG9yOjpjcmVhdGUoZGljdGlvbmFyeVBvcHVw SW5mby50ZXh0SW5kaWNhdG9yKTsKICAgICAKICAgICBSZXRhaW5QdHI8V2ViUmV2ZWFsSGlnaGxp Z2h0PiB3ZWJIaWdobGlnaHQgPSBhZG9wdE5TKFtbV2ViUmV2ZWFsSGlnaGxpZ2h0IGFsbG9jXSBp bml0V2l0aEhpZ2hsaWdodFJlY3Q6W3ZpZXcgY29udmVydFJlY3Q6dGV4dEluZGljYXRvci0+c2Vs ZWN0aW9uUmVjdEluUm9vdFZpZXdDb29yZGluYXRlcygpIHRvVmlldzpuaWxdIHZpZXc6dmlldyBp bWFnZTp0ZXh0SW5kaWNhdG9yLT5jb250ZW50SW1hZ2UoKV0pOwotICAgIAotICAgIFJldGFpblB0 cjxSVkl0ZW0+IGl0ZW0gPSBhZG9wdE5TKFthbGxvY1JWSXRlbUluc3RhbmNlKCkgaW5pdFdpdGhU ZXh0OmRpY3Rpb25hcnlQb3B1cEluZm8uYXR0cmlidXRlZFN0cmluZy5nZXQoKS5zdHJpbmcgc2Vs ZWN0ZWRSYW5nZTpOU01ha2VSYW5nZSgwLCAwKV0pOworCisgICAgUmV0YWluUHRyPFJWSXRlbT4g aXRlbSA9IGFkb3B0TlMoW2FsbG9jUlZJdGVtSW5zdGFuY2UoKSBpbml0V2l0aFRleHQ6ZGljdGlv bmFyeVBvcHVwSW5mby5hdHRyaWJ1dGVkU3RyaW5nLmdldCgpLnN0cmluZyBzZWxlY3RlZFJhbmdl Ok5TTWFrZVJhbmdlKDAsIGRpY3Rpb25hcnlQb3B1cEluZm8uYXR0cmlidXRlZFN0cmluZy5nZXQo KS5zdHJpbmcubGVuZ3RoLTEpXSk7CiAgICAgCiAgICAgW1VJTlNTaGFyZWRSZXZlYWxDb250cm9s bGVyKCkgcmV2ZWFsSXRlbTppdGVtLmdldCgpIGxvY2F0aW9uSW5XaW5kb3c6ZGljdGlvbmFyeVBv cHVwSW5mby5vcmlnaW4gd2luZG93OnZpZXcud2luZG93IGhpZ2hsaWdodGVyOihpZDxVSVJWUHJl c2VudGVySGlnaGxpZ2h0RGVsZWdhdGU+KSB3ZWJIaWdobGlnaHQuZ2V0KCldOwogICAgIHJldHVy biBuaWw7Cg== 368385 2019-04-26 20:52:10 -0700 2019-04-27 07:41:29 -0700 Patch bug-197341-20190426225209.patch text/plain 3309 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NjYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2I3MmEzOTQ3NDA5ODFj N2FlNjA1MTQwMTI1OGVjZjE1YmJjODY5OS4uOTdlZWExMjVlMDU5MmZjZGIyOTc3Yjk4OGQzY2Qz ODI3OTY0MjFkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA0LTI2ICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgTG9va3VwIG9u bHkgbG9va2luZyB1cCB0aGUgZmlyc3Qgd29yZCBpbiBzZWxlY3Rpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzM0MQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNDgyMjE0MTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTG9va3VwIGlzIG5vdCB0ZXN0YWJsZS4KKworICAgICAgICBSZXZlYWwgbmVl ZHMgdGhlIGZ1bGwgcmFuZ2UgaW4gb3JkZXIgdG8gY29ycmVjdGx5IGNyZWF0ZSB0aGUgaXRlbSBm b3IgdGhlIHBvcG92ZXIuCisKKyAgICAgICAgKiBlZGl0aW5nL2NvY29hL0RpY3Rpb25hcnlMb29r dXAubW06CisgICAgICAgIChXZWJDb3JlOjpzaG93UG9wdXBPckNyZWF0ZUFuaW1hdGlvbkNvbnRy b2xsZXIpOgorCiAyMDE5LTA0LTI1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgRml4IG1vcmUgYnVpbGRzIGFmdGVyIHIyNDQ2NTMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvRGljdGlvbmFyeUxvb2t1cC5tbSBi L1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvRGljdGlvbmFyeUxvb2t1cC5tbQppbmRleCAx ZmY4YTcwOTA2NTNhNDUwZjUyODNiMjYyZmUyODg2MWE3NTMyM2ZhLi45NjhhMmMzMmZmZjYwYmUy YWQ5OTUyNmVmNTY4ZjZkYTY3MGQ5ZWM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0 aW5nL2NvY29hL0RpY3Rpb25hcnlMb29rdXAubW0KKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9jb2NvYS9EaWN0aW9uYXJ5TG9va3VwLm1tCkBAIC00ODIsNyArNDgyLDcgQEAgc3RhdGljIFdL UmV2ZWFsQ29udHJvbGxlciBzaG93UG9wdXBPckNyZWF0ZUFuaW1hdGlvbkNvbnRyb2xsZXIoYm9v bCBjcmVhdGVBbmltYXQKICAgICBSZXRhaW5QdHI8V2ViUmV2ZWFsSGlnaGxpZ2h0PiB3ZWJIaWdo bGlnaHQgPSAgYWRvcHROUyhbW1dlYlJldmVhbEhpZ2hsaWdodCBhbGxvY10gaW5pdFdpdGhIaWdo bGlnaHRSZWN0OiBoaWdobGlnaHRSZWN0IHVzZURlZmF1bHRIaWdobGlnaHQ6IXRleHRJbmRpY2F0 b3IuZ2V0KCkuY29udGVudEltYWdlKCkgYXR0cmlidXRlZFN0cmluZzpkaWN0aW9uYXJ5UG9wdXBJ bmZvLmF0dHJpYnV0ZWRTdHJpbmcuZ2V0KCldKTsKICAgICBSZXRhaW5QdHI8UlZQcmVzZW50aW5n Q29udGV4dD4gY29udGV4dCA9IGFkb3B0TlMoW2FsbG9jUlZQcmVzZW50aW5nQ29udGV4dEluc3Rh bmNlKCkgaW5pdFdpdGhQb2ludGVyTG9jYXRpb25JblZpZXc6cG9pbnRlckxvY2F0aW9uIGluVmll dzp2aWV3IGhpZ2hsaWdodERlbGVnYXRlOihpZDxSVlByZXNlbnRlckhpZ2hsaWdodERlbGVnYXRl Pikgd2ViSGlnaGxpZ2h0LmdldCgpXSk7CiAgICAgCi0gICAgUmV0YWluUHRyPFJWSXRlbT4gaXRl bSA9IGFkb3B0TlMoW2FsbG9jUlZJdGVtSW5zdGFuY2UoKSBpbml0V2l0aFRleHQ6ZGljdGlvbmFy eVBvcHVwSW5mby5hdHRyaWJ1dGVkU3RyaW5nLmdldCgpLnN0cmluZyBzZWxlY3RlZFJhbmdlOk5T TWFrZVJhbmdlKDAsIDApXSk7CisgICAgUmV0YWluUHRyPFJWSXRlbT4gaXRlbSA9IGFkb3B0TlMo W2FsbG9jUlZJdGVtSW5zdGFuY2UoKSBpbml0V2l0aFRleHQ6ZGljdGlvbmFyeVBvcHVwSW5mby5h dHRyaWJ1dGVkU3RyaW5nLmdldCgpLnN0cmluZyBzZWxlY3RlZFJhbmdlOk5TTWFrZVJhbmdlKDAs IGRpY3Rpb25hcnlQb3B1cEluZm8uYXR0cmlidXRlZFN0cmluZy5nZXQoKS5zdHJpbmcubGVuZ3Ro KV0pOwogICAgIAogICAgIFt3ZWJIaWdobGlnaHQgc2V0Q2xlYXJUZXh0SW5kaWNhdG9yOlt3ZWJI aWdobGlnaHQgPSBXVEZNb3ZlKHdlYkhpZ2hsaWdodCksIGNsZWFyVGV4dEluZGljYXRvciA9IFdU Rk1vdmUoY2xlYXJUZXh0SW5kaWNhdG9yKV0gewogICAgICAgICBpZiAoY2xlYXJUZXh0SW5kaWNh dG9yKQpAQCAtNTA0LDggKzUwNCw4IEBAIHN0YXRpYyBXS1JldmVhbENvbnRyb2xsZXIgc2hvd1Bv cHVwT3JDcmVhdGVBbmltYXRpb25Db250cm9sbGVyKGJvb2wgY3JlYXRlQW5pbWF0CiAgICAgYXV0 byB0ZXh0SW5kaWNhdG9yID0gVGV4dEluZGljYXRvcjo6Y3JlYXRlKGRpY3Rpb25hcnlQb3B1cElu Zm8udGV4dEluZGljYXRvcik7CiAgICAgCiAgICAgUmV0YWluUHRyPFdlYlJldmVhbEhpZ2hsaWdo dD4gd2ViSGlnaGxpZ2h0ID0gYWRvcHROUyhbW1dlYlJldmVhbEhpZ2hsaWdodCBhbGxvY10gaW5p dFdpdGhIaWdobGlnaHRSZWN0Olt2aWV3IGNvbnZlcnRSZWN0OnRleHRJbmRpY2F0b3ItPnNlbGVj dGlvblJlY3RJblJvb3RWaWV3Q29vcmRpbmF0ZXMoKSB0b1ZpZXc6bmlsXSB2aWV3OnZpZXcgaW1h Z2U6dGV4dEluZGljYXRvci0+Y29udGVudEltYWdlKCldKTsKLSAgICAKLSAgICBSZXRhaW5QdHI8 UlZJdGVtPiBpdGVtID0gYWRvcHROUyhbYWxsb2NSVkl0ZW1JbnN0YW5jZSgpIGluaXRXaXRoVGV4 dDpkaWN0aW9uYXJ5UG9wdXBJbmZvLmF0dHJpYnV0ZWRTdHJpbmcuZ2V0KCkuc3RyaW5nIHNlbGVj dGVkUmFuZ2U6TlNNYWtlUmFuZ2UoMCwgMCldKTsKKworICAgIFJldGFpblB0cjxSVkl0ZW0+IGl0 ZW0gPSBhZG9wdE5TKFthbGxvY1JWSXRlbUluc3RhbmNlKCkgaW5pdFdpdGhUZXh0OmRpY3Rpb25h cnlQb3B1cEluZm8uYXR0cmlidXRlZFN0cmluZy5nZXQoKS5zdHJpbmcgc2VsZWN0ZWRSYW5nZTpO U01ha2VSYW5nZSgwLCBkaWN0aW9uYXJ5UG9wdXBJbmZvLmF0dHJpYnV0ZWRTdHJpbmcuZ2V0KCku c3RyaW5nLmxlbmd0aCldKTsKICAgICAKICAgICBbVUlOU1NoYXJlZFJldmVhbENvbnRyb2xsZXIo KSByZXZlYWxJdGVtOml0ZW0uZ2V0KCkgbG9jYXRpb25JbldpbmRvdzpkaWN0aW9uYXJ5UG9wdXBJ bmZvLm9yaWdpbiB3aW5kb3c6dmlldy53aW5kb3cgaGlnaGxpZ2h0ZXI6KGlkPFVJUlZQcmVzZW50 ZXJIaWdobGlnaHREZWxlZ2F0ZT4pIHdlYkhpZ2hsaWdodC5nZXQoKV07CiAgICAgcmV0dXJuIG5p bDsK