197336 2019-04-26 18:07:25 -0700 Storage::deleteOldVersions does not need to retain Storage 2019-04-30 01:31:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=197406 InRadar P2 Normal --- 1 achristensen achristensen cdumez cgarcia darin ews-watchlist webkit-bug-importer oldest_to_newest 1530891 0 achristensen 2019-04-26 18:07:25 -0700 Storage::deleteOldVersions does not need to retain Storage 1530892 1 368373 achristensen 2019-04-26 18:08:25 -0700 Created attachment 368373 Patch 1530893 2 achristensen 2019-04-26 18:08:28 -0700 <rdar://problem/48679972> 1531266 3 achristensen 2019-04-29 13:32:59 -0700 http://trac.webkit.org/r244750 1531289 4 368373 cdumez 2019-04-29 14:09:07 -0700 Comment on attachment 368373 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368373&action=review > Source/WebKit/ChangeLog:5 > + <rdar://problem/48679972> How does this bug explain <rdar://problem/48679972> ? What's the CompletionHandler that crashes here? 1531338 5 achristensen 2019-04-29 15:28:46 -0700 rdar://problem/47759337 not rdar://problem/48679972 1531344 6 achristensen 2019-04-29 15:40:24 -0700 Hmmm, now I'm not sure. I definitely saw the destructor of this lambda being the cause of a crash but now I can't find it. 368373 2019-04-26 18:08:25 -0700 2019-04-27 14:33:37 -0700 Patch bug-197336-20190426180825.patch text/plain 1784 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQ3MTMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTI2ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgU3RvcmFnZTo6ZGVs ZXRlT2xkVmVyc2lvbnMgZG9lcyBub3QgbmVlZCB0byByZXRhaW4gU3RvcmFnZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3MzM2CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS80ODY3OTk3Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3Jh Z2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OlN0b3JhZ2U6OmRlbGV0ZU9s ZFZlcnNpb25zKToKKyAgICAgICAgU29tZXRoaW5nIGlzIHdyb25nIHdpdGggdGhlIGxpZmV0aW1l IG9mIFN0b3JhZ2UsIGJ1dCB3ZSBvbmx5IG5lZWQgYSBTdHJpbmcsIG5vdCB0aGUgd2hvbGUgU3Rv cmFnZS4KKwogMjAxOS0wNC0yNiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgVXNlIGtETlNTZXJ2aWNlRmxhZ3NLbm93blVuaXF1ZSB0byBzcGVlZCB1cCBtZG5z IG5hbWUgcmVnaXN0cmF0aW9uIGZvciBJQ0UgY2FuZGlkYXRlcwpJbmRleDogU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdlLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3Jh Z2UuY3BwCShyZXZpc2lvbiAyNDQ2OTQpCisrKyBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz L2NhY2hlL05ldHdvcmtDYWNoZVN0b3JhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTA5LDkg KzExMDksOCBAQCB2b2lkIFN0b3JhZ2U6OnNocmluaygpCiAKIHZvaWQgU3RvcmFnZTo6ZGVsZXRl T2xkVmVyc2lvbnMoKQogewotICAgIGJhY2tncm91bmRJT1F1ZXVlKCkuZGlzcGF0Y2goW3RoaXMs IHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKV0gKCkgbXV0YWJsZSB7Ci0gICAgICAgIGF1 dG8gY2FjaGVQYXRoID0gYmFzZVBhdGgoKTsKLSAgICAgICAgdHJhdmVyc2VEaXJlY3RvcnkoY2Fj aGVQYXRoLCBbJmNhY2hlUGF0aF0oY29uc3QgU3RyaW5nJiBzdWJkaXJOYW1lLCBEaXJlY3RvcnlF bnRyeVR5cGUgdHlwZSkgeworICAgIGJhY2tncm91bmRJT1F1ZXVlKCkuZGlzcGF0Y2goW2NhY2hl UGF0aCA9IGJhc2VQYXRoKCldICgpIG11dGFibGUgeworICAgICAgICB0cmF2ZXJzZURpcmVjdG9y eShjYWNoZVBhdGgsIFtjYWNoZVBhdGggPSBXVEZNb3ZlKGNhY2hlUGF0aCldKGNvbnN0IFN0cmlu ZyYgc3ViZGlyTmFtZSwgRGlyZWN0b3J5RW50cnlUeXBlIHR5cGUpIHsKICAgICAgICAgICAgIGlm ICh0eXBlICE9IERpcmVjdG9yeUVudHJ5VHlwZTo6RGlyZWN0b3J5KQogICAgICAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgICAgIGlmICghc3ViZGlyTmFtZS5zdGFydHNXaXRoKHZlcnNpb25E aXJlY3RvcnlQcmVmaXgpKQo=