197335 2019-04-26 17:56:48 -0700 Reduce the number of copies made during SourceBufferPrivateAVFObjC::append() using SharedBuffer 2019-04-26 22:38:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble achristensen commit-queue eric.carlson webkit-bug-importer oldest_to_newest 1530883 0 jer.noble 2019-04-26 17:56:48 -0700 Reduce the number of copies made during SourceBufferPrivateAVFObjC::append() using SharedBuffer 1530886 1 jer.noble 2019-04-26 18:01:06 -0700 <rdar://problem/49175604> 1530887 2 webkit-bug-importer 2019-04-26 18:01:26 -0700 <rdar://problem/50263451> 1530888 3 368372 jer.noble 2019-04-26 18:02:11 -0700 Created attachment 368372 Patch 1530889 4 jer.noble 2019-04-26 18:02:26 -0700 <rdar://problem/49175604> 1530890 5 368372 jer.noble 2019-04-26 18:04:00 -0700 Comment on attachment 368372 Patch Will cq+ once the EWS bots chew through this patch. 1530934 6 368372 commit-queue 2019-04-26 22:38:45 -0700 Comment on attachment 368372 Patch Clearing flags on attachment: 368372 Committed r244716: <https://trac.webkit.org/changeset/244716> 1530935 7 commit-queue 2019-04-26 22:38:47 -0700 All reviewed patches have been landed. Closing bug. 368372 2019-04-26 18:02:11 -0700 2019-04-26 22:38:45 -0700 Patch bug-197335-20190426180204.patch text/plain 2620 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDFlYjI0ZjY5NzQ5YzE0 ZDQ1YjFmYzFjNzRhNTVjNzg4Y2I4NmYyNC4uMGU0NTNmNWZiY2UxOTdkMWIyYTI0YTAyMzhiNTAx YTFmNDJmZjU0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA0LTI2ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJlZHVjZSB0aGUgbnVtYmVy IG9mIGNvcGllcyBtYWRlIGR1cmluZyBTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQzo6YXBwZW5k KCkgdXNpbmcgU2hhcmVkQnVmZmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTczMzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5MTc1NjA0Pgor CisgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEFsZXggQ2hyaXN0ZW5zZW4uCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Tb3VyY2VCdWZmZXJQcml2YXRl QVZGT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlNvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpD OjphcHBlbmQpOgorCiAyMDE5LTA0LTE5ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29t PgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI0Mzk1OCk6IFVubmVjZXNzYXJ5IGRlYWN0aXZhdGlv biBvZiBBdWRpb1Nlc3Npb24gKFBMVCBSZWdyZXNzaW9uKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvU291cmNlQnVmZmVyUHJp dmF0ZUFWRk9iakMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5k YXRpb24vb2JqYy9Tb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQy5tbQppbmRleCBjYjk0ZDY2NTky ZjU3NTdkODAzZDEwN2QwMGEyMTgwMTQzMTg1OGQ3Li40M2YwNDU3ZGRjNzMxYzliMmExYWJhMDA2 ODNlMTM4ZDhkM2U4NDZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9hdmZvdW5kYXRpb24vb2JqYy9Tb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQy5tbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Tb3Vy Y2VCdWZmZXJQcml2YXRlQVZGT2JqQy5tbQpAQCAtNzI4LDE2ICs3MjgsMTIgQEAgdm9pZCBTb3Vy Y2VCdWZmZXJQcml2YXRlQVZGT2JqQzo6YXBwZW5kKFZlY3Rvcjx1bnNpZ25lZCBjaGFyPiYmIGRh dGEpCiB7CiAgICAgREVCVUdfTE9HKExPR0lERU5USUZJRVIsICJkYXRhIGxlbmd0aCA9ICIsIGRh dGEuc2l6ZSgpKTsKIAotICAgIC8vIEZJWE1FOiBBdm9pZCB0aGUgZGF0YSBjb3B5IGJ5IHdyYXBw aW5nIGFyb3VuZCB0aGUgVmVjdG9yPD4gb2JqZWN0LgotICAgIFJldGFpblB0cjxOU0RhdGE+IG5z RGF0YSA9IGFkb3B0TlMoW1tOU0RhdGEgYWxsb2NdIGluaXRXaXRoQnl0ZXM6ZGF0YS5kYXRhKCkg bGVuZ3RoOmRhdGEuc2l6ZSgpXSk7Ci0gICAgV2Vha1B0cjxTb3VyY2VCdWZmZXJQcml2YXRlQVZG T2JqQz4gd2Vha1RoaXMgPSBtX2FwcGVuZFdlYWtGYWN0b3J5LmNyZWF0ZVdlYWtQdHIoKnRoaXMp OwotICAgIFJldGFpblB0cjxBVlN0cmVhbURhdGFQYXJzZXI+IHBhcnNlciA9IG1fcGFyc2VyOwot ICAgIFJldGFpblB0cjxXZWJBVlN0cmVhbURhdGFQYXJzZXJMaXN0ZW5lcj4gZGVsZWdhdGUgPSBt X2RlbGVnYXRlOwotCiAgICAgbV9wYXJzaW5nU3VjY2VlZGVkID0gdHJ1ZTsKICAgICBkaXNwYXRj aF9ncm91cF9lbnRlcihtX2lzQXBwZW5kaW5nR3JvdXAuZ2V0KCkpOwogCi0gICAgZGlzcGF0Y2hf YXN5bmMoZ2xvYmFsRGF0YVBhcnNlclF1ZXVlKCksIFtuc0RhdGEsIHdlYWtUaGlzLCBwYXJzZXIs IGRlbGVnYXRlLCBpc0FwcGVuZGluZ0dyb3VwID0gbV9pc0FwcGVuZGluZ0dyb3VwLCBwYXJzZXJT dGF0ZVdhc1Jlc2V0ID0gbV9wYXJzZXJTdGF0ZVdhc1Jlc2V0XSB7CisgICAgZGlzcGF0Y2hfYXN5 bmMoZ2xvYmFsRGF0YVBhcnNlclF1ZXVlKCksIFtkYXRhID0gV1RGTW92ZShkYXRhKSwgd2Vha1Ro aXMgPSBtX2FwcGVuZFdlYWtGYWN0b3J5LmNyZWF0ZVdlYWtQdHIoKnRoaXMpLCBwYXJzZXIgPSBt X3BhcnNlciwgZGVsZWdhdGUgPSBtX2RlbGVnYXRlLCBpc0FwcGVuZGluZ0dyb3VwID0gbV9pc0Fw cGVuZGluZ0dyb3VwLCBwYXJzZXJTdGF0ZVdhc1Jlc2V0ID0gbV9wYXJzZXJTdGF0ZVdhc1Jlc2V0 XSAoKSBtdXRhYmxlIHsKKyAgICAgICAgYXV0byBzaGFyZWREYXRhID0gU2hhcmVkQnVmZmVyOjpj cmVhdGUoV1RGTW92ZShkYXRhKSk7CisgICAgICAgIGF1dG8gbnNEYXRhID0gc2hhcmVkRGF0YS0+ Y3JlYXRlTlNEYXRhKCk7CiAgICAgICAgIGlmIChwYXJzZXJTdGF0ZVdhc1Jlc2V0KQogICAgICAg ICAgICAgW3BhcnNlciBhcHBlbmRTdHJlYW1EYXRhOm5zRGF0YS5nZXQoKSB3aXRoRmxhZ3M6QVZT dHJlYW1EYXRhUGFyc2VyU3RyZWFtRGF0YURpc2NvbnRpbnVpdHldOwogICAgICAgICBlbHNlCg==