197303 2019-04-25 18:51:35 -0700 propertyRegistry() was not overridden for SVGFEFloodElement and SVGFEMergeElement 2019-04-26 09:32:32 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa achristensen commit-queue webkit-bug-importer zimmermann oldest_to_newest 1530598 0 sabouhallawa 2019-04-25 18:51:35 -0700 This part was missing when the tear-off objects were removed. Any change in the standard properties of these elements through DOM will fail because SVGElement:: commitPropertyChange() will not be able to find the attribute name of the SVGProperty. 1530599 1 368295 sabouhallawa 2019-04-25 18:56:27 -0700 Created attachment 368295 Patch 1530600 2 sabouhallawa 2019-04-25 18:57:55 -0700 <rdar://problem/50113907> 1530695 3 368295 commit-queue 2019-04-26 09:32:31 -0700 Comment on attachment 368295 Patch Clearing flags on attachment: 368295 Committed r244690: <https://trac.webkit.org/changeset/244690> 1530696 4 commit-queue 2019-04-26 09:32:32 -0700 All reviewed patches have been landed. Closing bug. 368295 2019-04-25 18:56:27 -0700 2019-04-26 09:32:31 -0700 Patch bug-197303-20190425185626.patch text/plain 5798 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGI1YmU2MWNkNGQyNzA2 YjEyNjYyYjMwNTczM2ZjZmU4NTg2YWQ5Yi4uMDkxMzdiYzExMWE4MDA4NjUwNjNmYmM5Y2NlYjg3 NDdmNDY5OGJlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA0LTI1ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgcHJvcGVy dHlSZWdpc3RyeSgpIHdhcyBub3Qgb3ZlcnJpZGRlbiBmb3IgU1ZHRkVGbG9vZEVsZW1lbnQgYW5k IFNWR0ZFTWVyZ2VFbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTczMDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGVyZWZvcmUgU1ZHRWxlbWVudDo6cHJvcGVydHlSZWdpc3RyeSgpIHdhcyBj YWxsZWQgaW5zdGVhZC4gVGhpcyBtZWFucworICAgICAgICB0aGVzZSB0d28gZWxlbWVudHMgd2ls bCBub3QgaGF2ZSBhY2Nlc3MgdG8gdGhlIHByb3BlcnRpZXMgb2YgdGhlIGJhc2UKKyAgICAgICAg Y2xhc3MgU1ZHRmlsdGVyUHJpbWl0aXZlU3RhbmRhcmRBdHRyaWJ1dGVzLgorCisgICAgICAgIFRl c3RzOiBzdmcvZG9tL1NWR0ZFRmxvb2RFbGVtZW50LWZpbHRlci1zdGFuZGFyZC1hdHRyaWJ1dGVz LnN2ZworCisgICAgICAgICogc3ZnL1NWR0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U1ZHRWxlbWVudDo6Y29tbWl0UHJvcGVydHlDaGFuZ2UpOgorICAgICAgICAqIHN2Zy9TVkdGRUZs b29kRWxlbWVudC5oOgorICAgICAgICAqIHN2Zy9TVkdGRU1lcmdlRWxlbWVudC5oOgorCiAyMDE5 LTA0LTI0ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBYTUxI VFRQUmVxdWVzdCBQT1NUcyB0byBhIGN1c3RvbSBXS1VSTFNjaGVtZUhhbmRsZXIgcHJvdG9jb2wg YXJlIG1pc3NpbmcgdGhlIEhUVFAgYm9keS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2 Zy9TVkdFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmNwcAppbmRl eCA4NWQ3NjAwNzJjYWJmMWExMWM0ZDRjN2JmMDViMGI1NWM4ZWMzNGU0Li5jYzViNmZkMjVlODVi N2Y5Y2E5ZWNhMmUxYWVhZDRlZjQ1OGY2MTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9z dmcvU1ZHRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQuY3Bw CkBAIC01ODMsNiArNTgzLDcgQEAgdm9pZCBTVkdFbGVtZW50Ojpjb21taXRQcm9wZXJ0eUNoYW5n ZShTVkdQcm9wZXJ0eSogcHJvcGVydHkpCiB2b2lkIFNWR0VsZW1lbnQ6OmNvbW1pdFByb3BlcnR5 Q2hhbmdlKFNWR0FuaW1hdGVkUHJvcGVydHkmIGFuaW1hdGVkUHJvcGVydHkpCiB7CiAgICAgUXVh bGlmaWVkTmFtZSBhdHRyaWJ1dGVOYW1lID0gcHJvcGVydHlSZWdpc3RyeSgpLmFuaW1hdGVkUHJv cGVydHlBdHRyaWJ1dGVOYW1lKGFuaW1hdGVkUHJvcGVydHkpOworICAgIEFTU0VSVChhdHRyaWJ1 dGVOYW1lICE9IG51bGxRTmFtZSgpKTsKIAogICAgIC8vIEEgY2hhbmdlIGluIGEgc3R5bGUgcHJv cGVydHksIGUuZyBTVkdSZWN0RWxlbWVudDo6eCBzaG91bGQgYmUgc2VyaWFsaXplZCB0bwogICAg IC8vIHRoZSBhdHRyaWJ1dGUgaW1tZWRpYXRlbHkuIE90aGVyd2lzZSBpdCBpcyBva2F5IHRvIGJl IGxhenkgaW4gdGhpcyByZWdhcmQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZH RkVGbG9vZEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdGRUZsb29kRWxlbWVudC5o CmluZGV4IGI1NjEzNWE3ZjQ4MTMxMGQ0MDdjYmVlNGRlODFhZTcwOGE3OTZlZjkuLmI5NmE0M2Fh MzEzZTc1ZTRhMzE2NzI0OGExYjZmNWNmNTFmZWU5MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3N2Zy9TVkdGRUZsb29kRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdG RUZsb29kRWxlbWVudC5oCkBAIC0zMiw4ICszMiwxMyBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAg IFNWR0ZFRmxvb2RFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmLCBEb2N1bWVudCYpOwogCisg ICAgdXNpbmcgUHJvcGVydHlSZWdpc3RyeSA9IFNWR1Byb3BlcnR5T3duZXJSZWdpc3RyeTxTVkdG RUZsb29kRWxlbWVudCwgU1ZHRmlsdGVyUHJpbWl0aXZlU3RhbmRhcmRBdHRyaWJ1dGVzPjsKKyAg ICBjb25zdCBTVkdQcm9wZXJ0eVJlZ2lzdHJ5JiBwcm9wZXJ0eVJlZ2lzdHJ5KCkgY29uc3QgZmlu YWwgeyByZXR1cm4gbV9wcm9wZXJ0eVJlZ2lzdHJ5OyB9CisKICAgICBib29sIHNldEZpbHRlckVm ZmVjdEF0dHJpYnV0ZShGaWx0ZXJFZmZlY3QqLCBjb25zdCBRdWFsaWZpZWROYW1lJiBhdHRyTmFt ZSkgb3ZlcnJpZGU7CiAgICAgUmVmUHRyPEZpbHRlckVmZmVjdD4gYnVpbGQoU1ZHRmlsdGVyQnVp bGRlciosIEZpbHRlciYpIGNvbnN0IG92ZXJyaWRlOworCisgICAgUHJvcGVydHlSZWdpc3RyeSBt X3Byb3BlcnR5UmVnaXN0cnkgeyAqdGhpcyB9OwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ZFTWVyZ2VFbGVtZW50LmggYi9T b3VyY2UvV2ViQ29yZS9zdmcvU1ZHRkVNZXJnZUVsZW1lbnQuaAppbmRleCA4NDMzYzlhNDgxZWFl MTBkMjZhYWZkMjYxMWQ0NzgyODQ3M2JkMjc5Li43NDUwODY4MTZmNjk3NmM2Njk3ZGM1MTA3NTgw MmQyODNjZjRlM2MyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRkVNZXJnZUVs ZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRkVNZXJnZUVsZW1lbnQuaApAQCAt MzIsNyArMzIsMTIgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICBTVkdGRU1lcmdlRWxlbWVudChj b25zdCBRdWFsaWZpZWROYW1lJiwgRG9jdW1lbnQmKTsKIAorICAgIHVzaW5nIFByb3BlcnR5UmVn aXN0cnkgPSBTVkdQcm9wZXJ0eU93bmVyUmVnaXN0cnk8U1ZHRkVNZXJnZUVsZW1lbnQsIFNWR0Zp bHRlclByaW1pdGl2ZVN0YW5kYXJkQXR0cmlidXRlcz47CisgICAgY29uc3QgU1ZHUHJvcGVydHlS ZWdpc3RyeSYgcHJvcGVydHlSZWdpc3RyeSgpIGNvbnN0IGZpbmFsIHsgcmV0dXJuIG1fcHJvcGVy dHlSZWdpc3RyeTsgfQorCiAgICAgUmVmUHRyPEZpbHRlckVmZmVjdD4gYnVpbGQoU1ZHRmlsdGVy QnVpbGRlciosIEZpbHRlciYpIGNvbnN0IG92ZXJyaWRlOworCisgICAgUHJvcGVydHlSZWdpc3Ry eSBtX3Byb3BlcnR5UmVnaXN0cnkgeyAqdGhpcyB9OwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2Vi Q29yZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCmluZGV4IGY4MTIzZWM4ODQ0Zjg5MjQwMDdiMjkzZGZmNmE2YjIyMTM0MTMwMzkuLmQx ZGIyMjNmNGNmZGQ2NjNiZmQwNDIxNDBlZmU5OGUyYmYzNjhjNDIgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx MyBAQAorMjAxOS0wNC0yNSAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUu Y29tPgorCisgICAgICAgIHByb3BlcnR5UmVnaXN0cnkoKSB3YXMgbm90IG92ZXJyaWRkZW4gZm9y IFNWR0ZFRmxvb2RFbGVtZW50IGFuZCBTVkdGRU1lcmdlRWxlbWVudAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3MzAzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdmcvZG9tL1NWR0ZFRmxvb2RFbGVt ZW50LWZpbHRlci1zdGFuZGFyZC1hdHRyaWJ1dGVzLWV4cGVjdGVkLnN2ZzogQWRkZWQuCisgICAg ICAgICogc3ZnL2RvbS9TVkdGRUZsb29kRWxlbWVudC1maWx0ZXItc3RhbmRhcmQtYXR0cmlidXRl cy5zdmc6IEFkZGVkLgorCiAyMDE5LTA0LTI0ICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBw bGUuY29tPgogCiAgICAgICAgIEFnZSBvdXQgdW5jb252ZXJ0ZWQgQWQgQ2xpY2sgQXR0cmlidXRp b25zIGFmdGVyIG9uZSB3ZWVrLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2RvbS9TVkdG RUZsb29kRWxlbWVudC1maWx0ZXItc3RhbmRhcmQtYXR0cmlidXRlcy1leHBlY3RlZC5zdmcgYi9M YXlvdXRUZXN0cy9zdmcvZG9tL1NWR0ZFRmxvb2RFbGVtZW50LWZpbHRlci1zdGFuZGFyZC1hdHRy aWJ1dGVzLWV4cGVjdGVkLnN2ZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45ZDE0MjRkMTI1MTIzNDY4NmE5NWJlNDcz MjEyZjU2MGZkMGFmYThkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2RvbS9T VkdGRUZsb29kRWxlbWVudC1maWx0ZXItc3RhbmRhcmQtYXR0cmlidXRlcy1leHBlY3RlZC5zdmcK QEAgLTAsMCArMSwzIEBACis8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+ CisgICAgPHJlY3QgeD0iMTAiIHk9IjEwIiB3aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCIgZmlsbD0i Z3JlZW4iLz4KKzwvc3ZnPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2RvbS9TVkdGRUZs b29kRWxlbWVudC1maWx0ZXItc3RhbmRhcmQtYXR0cmlidXRlcy5zdmcgYi9MYXlvdXRUZXN0cy9z dmcvZG9tL1NWR0ZFRmxvb2RFbGVtZW50LWZpbHRlci1zdGFuZGFyZC1hdHRyaWJ1dGVzLnN2Zwpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi5jYzI5Y2EyMWFlNDFlMjEzMzJmZjNkNTlmMTE3NzNlYTRhY2QzMDdiCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2RvbS9TVkdGRUZsb29kRWxlbWVudC1maWx0 ZXItc3RhbmRhcmQtYXR0cmlidXRlcy5zdmcKQEAgLTAsMCArMSwxNSBAQAorPHN2ZyB4bWxucz0i aHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPgorICAgIDxkZWZzPgorICAgICAgICA8ZmlsdGVy IGlkPSJmaWx0ZXIiIGZpbHRlclVuaXRzPSJ1c2VyU3BhY2VPblVzZSI+CisgICAgICAgICAgICA8 ZmVGbG9vZCBpZD0iZmVGbG9vZCIgeD0iMCIgeT0iMCIgd2lkdGg9IjUwIiBoZWlnaHQ9IjUwIiBm bG9vZC1jb2xvcj0iZ3JlZW4iLz4KKyAgICAgICAgPC9maWx0ZXI+CisgICAgPC9kZWZzPgorICAg IDx1c2Ugc3R5bGU9ImZpbHRlcjogdXJsKCNmaWx0ZXIpOyIvPgorICAgIDxzY3JpcHQ+CisgICAg ICAgIHZhciBmZUZsb29kID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcigiI2ZlRmxvb2QiKTsKKyAg ICAgICAgZmVGbG9vZC54LmJhc2VWYWwubmV3VmFsdWVTcGVjaWZpZWRVbml0cyhTVkdMZW5ndGgu U1ZHX0xFTkdUSFRZUEVfTlVNQkVSLCAxMCk7CisgICAgICAgIGZlRmxvb2QueS5iYXNlVmFsLm5l d1ZhbHVlU3BlY2lmaWVkVW5pdHMoU1ZHTGVuZ3RoLlNWR19MRU5HVEhUWVBFX05VTUJFUiwgMTAp OworICAgICAgICBmZUZsb29kLndpZHRoLmJhc2VWYWwubmV3VmFsdWVTcGVjaWZpZWRVbml0cyhT VkdMZW5ndGguU1ZHX0xFTkdUSFRZUEVfTlVNQkVSLCAxMDApOworICAgICAgICBmZUZsb29kLmhl aWdodC5iYXNlVmFsLm5ld1ZhbHVlU3BlY2lmaWVkVW5pdHMoU1ZHTGVuZ3RoLlNWR19MRU5HVEhU WVBFX05VTUJFUiwgMTAwKTsKKyAgICA8L3NjcmlwdD4KKzwvc3ZnPgo=