19730 2008-06-23 12:45:47 -0700 REGRESSION (r34497): Text in alerts in "Leisure suit Larry" is not wrapped 2008-06-24 02:39:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://web.ist.utl.pt/~antonio.afonso/agi/ HasReduction, Regression P1 Normal --- 1 ap zwarich mitz zwarich oldest_to_newest 84173 0 ap 2008-06-23 12:45:47 -0700 Steps to reproduce: 1. Open http://web.ist.utl.pt/~antonio.afonso/agi/ 2. Press Return. An in-game alert about "some elements of plot which may not be considered appropriate for some children" appears. It is too wide in ToT, as text is not wrapped. It is wrapped in Firefox 2 and in Safari 3.1.1 84179 1 mitz 2008-06-23 13:25:58 -0700 Looking around a little (until the inspector hit an assertion failure) did not convince me that this was necessarily a layout bug. 84220 2 21895 ap 2008-06-23 23:15:46 -0700 Created attachment 21895 reduction 84221 3 21896 ap 2008-06-23 23:48:09 -0700 Created attachment 21896 further reduction 84224 4 zwarich 2008-06-24 00:02:48 -0700 The codegen tells me that this is probably my fault. I am pretty sure I know how to fix it. Assigning the bug to myself. 84228 5 zwarich 2008-06-24 00:47:09 -0700 This is caused by r34497. Rolling out the change by hand fixes the bug. 84231 6 21899 zwarich 2008-06-24 02:00:39 -0700 Created attachment 21899 Proposed patch I am writing some comprehensive tests for this class of bug right now, but I'll let someone review it first. 84232 7 21899 oliver 2008-06-24 02:01:57 -0700 Comment on attachment 21899 Proposed patch r=me, once you have some testcases 84234 8 zwarich 2008-06-24 02:39:20 -0700 Landed in r34758. 21895 2008-06-23 23:15:46 -0700 2008-06-23 23:48:09 -0700 reduction reduction.html text/html 877 ap PHNjcmlwdD4KZnVuY3Rpb24gY2FsY3VsYXRlX3dvcmRfd3JhcCggc3RyLCBsZW4gKQp7Cgl2YXIg czsKCXZhciBtYXhjID0gLTE7Cgl2YXIgbWF4bGVuID0gc3RyLmxlbmd0aDsKCXZhciBjOwoJCgl3 aGlsZSAoIHN0ci5sZW5ndGggPiBsZW4gfHwgc3RyLmluZGV4T2YoICJcbiIgKT4tMSApCgl7CgkJ cyA9IHN0ci5zdWJzdHJpbmcoIDAsIGxlbiApCgkJc3RyID0gc3RyLnN1YnN0cmluZyggbGVuICk7 CgkJCgkJLy8gZmluZCB0aGUgbGFzdCBzcGFjZSBvciB0aGUgZmlyc3QgbmV3IGxpbmUgdG8gYnJl YWsgdGhlIGxpbmUKCQlzcGFjZSA9IHMubGFzdEluZGV4T2YoICcgJyApOwoJCWlmICggc3BhY2Ug PT0gLTEgKSB7IHNwYWNlID0gbWF4bGVuOyB9CgkJbmV3bGluZSA9IHMuaW5kZXhPZiggIlxuIiAp OwoJCWlmICggbmV3bGluZSA9PSAtMSApIHsgbmV3bGluZSA9IG1heGxlbjsgfQoJCWMgPSBNYXRo Lm1pbiggc3BhY2UsIG5ld2xpbmUgKTsKCQkKCQlpZiAoIGMgPiBtYXhjICkgeyBtYXhjID0gYzsg fQoJCXN0ciA9IHMuc3Vic3RyaW5nKCBjKzEgKSArIHN0cjsKCX0KCQoJaWYgKCBzdHIubGVuZ3Ro ID4gbWF4YyApIHsgbWF4YyA9IHN0ci5sZW5ndGg7IH0KCQoJcmV0dXJuIG1heGM7Cn0KCnZhciB3 cmFwID0gY2FsY3VsYXRlX3dvcmRfd3JhcCgiV2FybmluZzpcblxuXCJMZWlzdXJlIFN1aXQgTGFy cnkgaW4gdGhlIExhbmQgb2YgdGhlIExvdW5nZSBMaXphcmRzXCIgY29udGFpbnMgc29tZSBlbGVt ZW50cyBvZiBwbG90IHdoaWNoIG1heSBub3QgYmUgIGNvbnNpZGVyZWQgYXBwcm9wcmlhdGUgZm9y IHNvbWUgY2hpbGRyZW4uIiwgMzIpOwoKYWxlcnQoKHdyYXAgPT0gMzEpID8gIlNVQ0NFU1MiIDog IkZBSUxVUkUiKTsKPC9zY3JpcHQ+Cg== 21896 2008-06-23 23:48:09 -0700 2008-06-23 23:48:09 -0700 further reduction reduction.html text/html 417 ap PHNjcmlwdD4KICAgIHZhciBzdHIgPSAiV2FybmluZzpcblxuXCJMZWlzdXJlIFN1aXQgTGFycnkg aW4gdGhlIExhbmQgb2YgdGhlIExvdW5nZSBMaXphcmRzXCIgY29udGFpbnMgc29tZSBlbGVtZW50 cyBvZiBwbG90IHdoaWNoIG1heSBub3QgYmUgIGNvbnNpZGVyZWQgYXBwcm9wcmlhdGUgZm9yIHNv bWUgY2hpbGRyZW4uIjsKICAgIHZhciBsZW4gPSAzMjsKCiAgICB0cnkgewoJCiAgICAgICAgd2hp bGUgKCBzdHIubGVuZ3RoID4gbGVuIHx8IHN0ci5pbmRleE9mKCAiXG4iICk+LTEgKQogICAgICAg IHsKICAgICAgICAgICAgdGhyb3cgIlNVQ0NFU1MiOwogICAgICAgIH0KICAgICAgICAKICAgICAg ICBhbGVydCgiRkFJTFVSRSIpOwoKICAgIH0gY2F0Y2ggKGV4KSB7CiAgICAgICAgYWxlcnQoZXgp OwogICAgfQo8L3NjcmlwdD4K 21899 2008-06-24 02:00:39 -0700 2008-06-24 02:01:57 -0700 Proposed patch larry.diff text/plain 1242 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM0NzU2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMDYt MjQgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE5NzMwOiBSRUdSRVNT SU9OIChyMzQ0OTcpOiBUZXh0IGluIGFsZXJ0cyBpbiAiTGVpc3VyZSBzdWl0IExhcnJ5IiBpcyBu b3Qgd3JhcHBlZAorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5NzMwPgorCisgICAgICAgIERvIG5vdCBjb252ZXJ0IHRoZSBwYWlyIChsZXNzLCBqdHJ1 ZSkgdG8gamxlc3Mgd2hlbiBqdHJ1ZSBpcyBhIGp1bXAKKyAgICAgICAgdGFyZ2V0LiBBbiBleGFt cGxlIG9mIHRoaXMgaXMgd2hlbiB0aGUgY29uZGl0aW9uIG9mIGEgd2hpbGUgbG9vcCBpcworICAg ICAgICBhIExvZ2ljYWxPck5vZGUuIAorCisgICAgICAgICogVk0vQ29kZUdlbmVyYXRvci5jcHA6 CisgICAgICAgIChLSlM6OkNvZGVHZW5lcmF0b3I6OmVtaXRMYWJlbCk6CisKIDIwMDgtMDYtMjMg IE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2 ZXIgSHVudC4KSW5kZXg6IFZNL0NvZGVHZW5lcmF0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFZNL0Nv ZGVHZW5lcmF0b3IuY3BwCShyZXZpc2lvbiAzNDc1NikKKysrIFZNL0NvZGVHZW5lcmF0b3IuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zOTAsNiArMzkwLDEwIEBAIFBhc3NSZWZQdHI8TGFiZWxJRD4g Q29kZUdlbmVyYXRvcjo6bmV3TGEKIFBhc3NSZWZQdHI8TGFiZWxJRD4gQ29kZUdlbmVyYXRvcjo6 ZW1pdExhYmVsKExhYmVsSUQqIGwwKQogewogICAgIGwwLT5zZXRMb2NhdGlvbihpbnN0cnVjdGlv bnMoKS5zaXplKCkpOworICAgIAorICAgIC8vIFRoaXMgZGlzYWJsZXMgcGVlcGhvbGUgb3B0aW1p emF0aW9ucyB3aGVuIGFuIGluc3RydWN0aW9uIGlzIGEganVtcCB0YXJnZXQKKyAgICBtX2xhc3RP cGNvZGVJRCA9IG9wX2VuZDsKKyAgICAKICAgICByZXR1cm4gbDA7CiB9CiAK