197298 2019-04-25 15:23:35 -0700 webkitpy: Including skipped tests in the final count 2019-04-25 17:17:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard ap commit-queue ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1530546 0 jbedard 2019-04-25 15:23:35 -0700 Lucas pointed out to me that upon completion of a layout test run, we will print out a description of how many tests passed vs the total number of tests. The problem with this metric is that the total number of tests includes the tests rightfully skipped because they are not run on the specified port. 1530547 1 jbedard 2019-04-25 15:24:05 -0700 <rdar://problem/49705424> 1530556 2 368280 jbedard 2019-04-25 15:55:03 -0700 Created attachment 368280 Patch 1530584 3 368280 commit-queue 2019-04-25 17:17:45 -0700 Comment on attachment 368280 Patch Clearing flags on attachment: 368280 Committed r244671: <https://trac.webkit.org/changeset/244671> 1530585 4 commit-queue 2019-04-25 17:17:46 -0700 All reviewed patches have been landed. Closing bug. 368280 2019-04-25 15:55:03 -0700 2019-04-25 17:17:45 -0700 Patch bug-197298-20190425155502.patch text/plain 1370 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDY2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTA0LTI1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogSW5jbHVkaW5nIHNraXBwZWQgdGVzdHMgaW4gdGhlIGZp bmFsIGNvdW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTcyOTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5NzA1NDI0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvdmlld3MvYnVpbGRib3RfcmVzdWx0cy5weToKKyAgICAgICAgKEJ1aWxkQm90 UHJpbnRlci5wcmludF9ydW5fcmVzdWx0cyk6IFRoZSB0b3RhbCBudW1iZXIgb2YgdGVzdHMgcnVu IHNob3VsZCBleGNsdWRlIGRlbGlicmF0ZWx5IHNraXBwZWQgdGVzdHMuCisKIDIwMTktMDQtMjUg IFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIERpc2FibGUg ZGF0ZSBhbmQgdGltZSBpbnB1dHMgb24gaU9TTWFjLgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvdmlld3MvYnVpbGRib3RfcmVzdWx0cy5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy92aWV3cy9idWlsZGJvdF9yZXN1 bHRzLnB5CShyZXZpc2lvbiAyNDQ2NjMpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy92aWV3cy9idWlsZGJvdF9yZXN1bHRzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC01Niw3 ICs1Niw3IEBAIGNsYXNzIEJ1aWxkQm90UHJpbnRlcihvYmplY3QpOgogCiAgICAgZGVmIHByaW50 X3J1bl9yZXN1bHRzKHNlbGYsIHJ1bl9yZXN1bHRzKToKICAgICAgICAgZmFpbGVkID0gcnVuX3Jl c3VsdHMudG90YWxfZmFpbHVyZXMKLSAgICAgICAgdG90YWwgPSBydW5fcmVzdWx0cy50b3RhbAor ICAgICAgICB0b3RhbCA9IHJ1bl9yZXN1bHRzLnRvdGFsIC0gcnVuX3Jlc3VsdHMuZXhwZWN0ZWRf c2tpcHMKICAgICAgICAgcGFzc2VkID0gdG90YWwgLSBmYWlsZWQgLSBydW5fcmVzdWx0cy5yZW1h aW5pbmcKICAgICAgICAgcGVyY2VudF9wYXNzZWQgPSAwLjAKICAgICAgICAgaWYgdG90YWwgPiAw Ogo=