197286 2019-04-25 10:18:40 -0700 REGRESSION (r244182) [Mac WK2] Layout Test imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html is a flaky failure 2019-05-29 16:23:57 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sroberts sabouhallawa commit-queue jlewis3 lforschler ryanhaddad sabouhallawa simon.fraser tsavell webkit-bug-importer oldest_to_newest 1530411 0 sroberts 2019-04-25 10:18:40 -0700 The following layout test is flaky on Mac WK2 Release and Debug imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html Probable cause: It appears changes in https://trac.webkit.org/changeset/244182/webkit have made this test more flaky. Local testing on Debug is yielding close to 90% failure in 500 iterations. Testing done on r244181 and older yield on average 1 failure in 500 iterations. Reproduced with : run-webkit-tests imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html --iterations 500 -f --debug --exit-after-n-failures=5 Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fvisual-viewport%2Fviewport-resize-event-on-load-overflowing-page.html Diff: --- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page-actual.txt @@ -3,5 +3,5 @@ Test Description: This test ensures that we fire a resize event against window.visualViewport if the page has overflow (since this creates a scrollbar and thus changes the viewport size). -PASS Resize event fired exactly once against window.visualViewport if scrollbars affect layout. +FAIL Resize event fired exactly once against window.visualViewport if scrollbars affect layout. assert_equals: expected 1 but got 0 1530415 1 sroberts 2019-04-25 10:24:57 -0700 Marked flaky in https://trac.webkit.org/changeset/244651/webkit 1530416 2 webkit-bug-importer 2019-04-25 10:25:13 -0700 <rdar://problem/50209891> 1530417 3 webkit-bug-importer 2019-04-25 10:25:13 -0700 <rdar://problem/50209894> 1537929 4 370329 sabouhallawa 2019-05-21 11:08:45 -0700 Created attachment 370329 Patch 1537940 5 370329 simon.fraser 2019-05-21 11:49:19 -0700 Comment on attachment 370329 Patch Does our behavior differ from other browsers here? 1537951 6 sabouhallawa 2019-05-21 12:22:49 -0700 The test has an overflow scrolling: body { /* Ensure overflow */ height: 200%; } The script waits for the first layout to be done. -- If the browser shows decides it is going to show classic scrollbar for the overflow scroll, the 'resize' event will fire. -- If the bowser decided it is going to show overlay scrollbar, the the 'resize' event will not fire because overlay scroll does not affect the layout. The test then asserts that "if the resize event was fired, the browser would show classic scrollbar for the overflow scroll". Firing the 'resize' event should happen only once. But the test has to wait enough time to ensure the first layout was done, the event was enqueued and the event was dispatched. The patch here makes the waiting time a little bit longer, extra 16ms. So this should not affect other browsers if they adopt the same change. 1537958 7 sabouhallawa 2019-05-21 12:50:25 -0700 Running: run-webkit-httpd LayoutTests/imported/w3c/web-platform-tests/ opt-tests Then opening the modified test from "http://localhost:8800/visual-viewport/viewport-resize-event-on-load-overflowing-page.html" in both Safari and Chrome shows that the test passes. But this bug is about the test being flaky. 1540173 8 370329 commit-queue 2019-05-29 16:23:55 -0700 Comment on attachment 370329 Patch Clearing flags on attachment: 370329 Committed r245877: <https://trac.webkit.org/changeset/245877> 1540174 9 commit-queue 2019-05-29 16:23:57 -0700 All reviewed patches have been landed. Closing bug. 370329 2019-05-21 11:08:45 -0700 2019-05-29 16:23:55 -0700 Patch bug-197286-20190521110844.patch text/plain 4063 sabouhallawa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI0NTU4MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA1LTIxICBTYWlkIEFib3UtSGFsbGF3 YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI0NDE4 MikgW01hYyBXSzJdIExheW91dCBUZXN0IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv dmlzdWFsLXZpZXdwb3J0L3ZpZXdwb3J0LXJlc2l6ZS1ldmVudC1vbi1sb2FkLW92ZXJmbG93aW5n LXBhZ2UuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzI4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25z OgorCiAyMDE5LTA1LTIxICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAg ICAgICBSVEwvb3ZlcmZsb3cgc2Nyb2xsIHRlc3RzIGZhaWwgd2l0aCBhc3luYyBvdmVyZmxvdyBl bmFibGVkCkluZGV4OiBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NTU4 MykKKysrIExheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwyMCBAQAorMjAxOS0wNS0yMSAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhh bGxhd2FAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNDQxODIpIFtNYWMgV0sy XSBMYXlvdXQgVGVzdCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3Zpc3VhbC12aWV3 cG9ydC92aWV3cG9ydC1yZXNpemUtZXZlbnQtb24tbG9hZC1vdmVyZmxvd2luZy1wYWdlLmh0bWwg aXMgYSBmbGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTcyODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIGlzIGEgdGltZSBzZW5zaXRpdmUgdGVzdC4gSXQgZXhwZWN0cyB0byBy ZWNlaXZlIGEgcmVzaXplIGV2ZW50IHdpdGhpbgorICAgICAgICB0d28gZnJhbWVzIGFmdGVyIHRo ZSBwYWdlIGxvYWQuIFNjaGVkdWxpbmcgdGhlIHBhZ2UgdXBkYXRlIHRocm91Z2ggdGhlIAorICAg ICAgICBSZW5kZXJpbmdVcGRhdGUgbWFkZSB1cGRhdGluZyB0aGUgcGFnZSBmb3IgdGhlIGZpcnN0 IHRpbWUgaGFwcGVucyBub3QgCisgICAgICAgIGltbWVkaWF0ZWx5IGFmdGVyIHRoZSBwYWdlIGxv YWQgYnV0IGFmdGVyIGFuIGFkZGl0aW9uYWwgZnJhbWUuCisKKyAgICAgICAgU28gd2UgbmVlZCB0 byB3YWl0IGZvciB0aGlzIGFkZGl0aW9uYWwgZnJhbWUgYmVmb3JlIGNoZWNraW5nIHdoZXRoZXIg dGhlCisgICAgICAgICdyZXNpemUnIGV2ZW50IHdhcyBmaXJlZC4KKworICAgICAgICAqIHdlYi1w bGF0Zm9ybS10ZXN0cy92aXN1YWwtdmlld3BvcnQvdmlld3BvcnQtcmVzaXplLWV2ZW50LW9uLWxv YWQtb3ZlcmZsb3dpbmctcGFnZS5odG1sOgorCiAyMDE5LTA1LTE3ICBSb2IgQnVpcyAgPHJidWlz QGlnYWxpYS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IGltYWdlc3Jjc2V0IGFuZCBpbWFnZXNp emVzIGF0dHJpYnV0ZXMgb24gbGluayByZWw9cHJlbG9hZApJbmRleDogTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy92aXN1YWwtdmlld3BvcnQvdmlld3BvcnQtcmVz aXplLWV2ZW50LW9uLWxvYWQtb3ZlcmZsb3dpbmctcGFnZS5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvdmlzdWFsLXZpZXdwb3J0 L3ZpZXdwb3J0LXJlc2l6ZS1ldmVudC1vbi1sb2FkLW92ZXJmbG93aW5nLXBhZ2UuaHRtbAkocmV2 aXNpb24gMjQ1NTgzKQorKysgTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy92aXN1YWwtdmlld3BvcnQvdmlld3BvcnQtcmVzaXplLWV2ZW50LW9uLWxvYWQtb3ZlcmZs b3dpbmctcGFnZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw5ICsyNiwxNSBAQAogICAgICAg ICAgICAgICAgIH0pOwogCiAgICAgICAgICAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIo J2xvYWQnLCBmdW5jdGlvbigpIHsKLSAgICAgICAgICAgICAgICAgIHJlcXVlc3RBbmltYXRpb25G cmFtZShmdW5jdGlvbigpIHsKLSAgICAgICAgICAgICAgICAgICAgcmVxdWVzdEFuaW1hdGlvbkZy YW1lKAotICAgICAgICAgICAgICAgICAgICAgICAgdC5zdGVwX2Z1bmNfZG9uZShmdW5jdGlvbigp IHsKKyAgICAgICAgICAgICAgICAgICAgdmFyIGNvdW50ID0gMDsKKyAgICAgICAgICAgICAgICAg ICAgcmVxdWVzdEFuaW1hdGlvbkZyYW1lKGZ1bmN0aW9uIHN0ZXAoKSB7CisgICAgICAgICAgICAg ICAgICAgICAgICAvLyBXYWl0IGZvciB0d28gUmVuZGVyaW5nVXBkYXRlcyBiZWZvcmUgY2hlY2tp bmcgdGhlIHZhbHVlIG9mIG51bVZpZXdSZXNpemVzLgorICAgICAgICAgICAgICAgICAgICAgICAg aWYgKGNvdW50KysgPCAyKSB7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVxdWVzdEFu aW1hdGlvbkZyYW1lKHN0ZXApOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgICAgICAgICAgICAgICAgIH0KKworICAgICAgICAgICAgICAgICAgICAgICAgcmVx dWVzdEFuaW1hdGlvbkZyYW1lKHQuc3RlcF9mdW5jX2RvbmUoZnVuY3Rpb24oKSB7CiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgdmFyIGlzT3ZlcmxheSA9IGNhbGN1bGF0ZVNjcm9sbGJhclRo aWNrbmVzcygpID09IDA7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYXNzZXJ0X2VxdWFs cyhudW1WaWV3UmVzaXplcywgaXNPdmVybGF5ID8gMCA6IDEpOwogICAgICAgICAgICAgICAgICAg ICAgICAgfSkpOwpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0 YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4 cGVjdGF0aW9ucwkocmV2aXNpb24gMjQ1NTgzKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj LXdrMi9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC05MzMsOCArOTMzLDYgQEAg d2Via2l0Lm9yZy9iLzE5NzI4NSBbIERlYnVnIF0gaHR0cC90ZXN0cwogCiB3ZWJraXQub3JnL2Iv MTk3MjA3IGh0dHAvd3B0L3Jlc291cmNlLXRpbWluZy9ydC1yZXNvdXJjZXMtcGVyLWZyYW1lLmh0 bWwgWyBQYXNzIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTk3Mjg2IGltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvdmlzdWFsLXZpZXdwb3J0L3ZpZXdwb3J0LXJlc2l6ZS1ldmVudC1v bi1sb2FkLW92ZXJmbG93aW5nLXBhZ2UuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCi0KIHdlYmtpdC5v cmcvYi8xOTc0MjUgWyBNb2phdmUgRGVidWcgXSBzY3JvbGxpbmdjb29yZGluYXRvci9zY3JvbGxp bmctdHJlZS9zY3JvbGxpbmctdHJlZS1pbmNsdWRlcy1mcmFtZS5odG1sIFsgUGFzcyBGYWlsdXJl IF0KIAogd2Via2l0Lm9yZy9iLzE5NzY2MiBbIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy93ZWJydGMvUlRDUGVlckNvbm5lY3Rpb24tZ2V0U3RhdHMuaHR0cHMuaHRtbCBb IFBhc3MgRmFpbHVyZSBdCg==