197235 2019-04-24 09:32:33 -0700 AX: Build failure in WKFullKeyboardAccessWatcher.mm 2019-04-24 10:32:45 -0700 1 1 1 Unclassified WebKit Accessibility Other All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach commit-queue ryanhaddad webkit-bug-importer oldest_to_newest 1530015 0 cfleizach 2019-04-24 09:32:33 -0700 WKFullKeyboardAccessWatcher.mm:55:33: error: use of undeclared identifier '_AXSFullKeyboardAccessEnabled'; did you mean 'WebKit::ServiceWorkerProcessProxy::fullKeyboardAccessEnabled'? 1530016 1 webkit-bug-importer 2019-04-24 09:32:48 -0700 <rdar://problem/50170205> 1530018 2 368131 cfleizach 2019-04-24 09:35:28 -0700 Created attachment 368131 patch 1530038 3 368131 commit-queue 2019-04-24 10:26:20 -0700 Comment on attachment 368131 patch Rejecting attachment 368131 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 368131, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=368131&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=197235&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 368131 from bug 197235. Fetching: https://bugs.webkit.org/attachment.cgi?id=368131 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Fleizach']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/UIProcess/Cocoa/WKFullKeyboardAccessWatcher.mm Hunk #1 FAILED at 28. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/UIProcess/Cocoa/WKFullKeyboardAccessWatcher.mm.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Fleizach']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/UIProcess/Cocoa/WKFullKeyboardAccessWatcher.mm Hunk #1 FAILED at 28. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/UIProcess/Cocoa/WKFullKeyboardAccessWatcher.mm.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Fleizach']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit b2e96ad65ba..2d8ce3cf1f9 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 244593 = b2e96ad65ba9a0cb9c820d25ce5db807036b737d r244594 = 7bdeec136717857a3b650836ff1d461015f3f0f7 r244595 = 629ca74f74ea0fec79c914acdd2982a2a786f715 r244596 = 2d8ce3cf1f916a1752be87bfd008df23dd4174f2 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/11984531 1530039 4 ryanhaddad 2019-04-24 10:32:21 -0700 David fixed this in https://trac.webkit.org/changeset/244596/webkit 368131 2019-04-24 09:35:28 -0700 2019-04-24 10:32:45 -0700 patch patch text/plain 1100 cfleizach SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQ1OTMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA0LTI0ICBDaHJpcyBGbGVp emFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEJ1aWxkIGZhaWx1cmUg aW4gV0tGdWxsS2V5Ym9hcmRBY2Nlc3NXYXRjaGVyLm1tCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcyMzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzUwMTcwMjA1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVUlQcm9jZXNzL0NvY29hL1dLRnVsbEtleWJvYXJkQWNjZXNzV2F0Y2hlci5tbToKKwog MjAxOS0wNC0yNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVS TCBzZXQgYnkgZG9jdW1lbnQub3BlbigpIGlzIGNvbW11bmljYXRlZCB3aXRoIHRoZSBXZWJQYWdl UHJveHkgYnV0IG5vdCB0aGUgV2ViRnJhbWVQcm94eQpJbmRleDogU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQ29jb2EvV0tGdWxsS2V5Ym9hcmRBY2Nlc3NXYXRjaGVyLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dLRnVsbEtleWJvYXJkQWNjZXNzV2F0Y2hl ci5tbQkocmV2aXNpb24gMjQ0NTkzKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2Ev V0tGdWxsS2V5Ym9hcmRBY2Nlc3NXYXRjaGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw2ICsy OCw3IEBACiAKICNpZiBFTkFCTEUoRlVMTF9LRVlCT0FSRF9BQ0NFU1MpCiAKKyNpbXBvcnQgIkFj Y2Vzc2liaWxpdHlTdXBwb3J0U1BJLmgiCiAjaW1wb3J0ICJXZWJQcm9jZXNzUG9vbC5oIgogCiAj aWYgUExBVEZPUk0oTUFDKQo=