197209 2019-04-23 13:09:37 -0700 Build fix after r244545 2019-04-23 13:48:18 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rdemarest webkit-unassigned commit-queue ews-watchlist rdemarest thorton webkit-bug-importer oldest_to_newest 1529700 0 rdemarest 2019-04-23 13:09:37 -0700 I broke the build in High Sierra with my r244545 patch. 1529701 1 368055 rdemarest 2019-04-23 13:10:07 -0700 Created attachment 368055 Patch 1529702 2 ews-watchlist 2019-04-23 13:12:37 -0700 Attachment 368055 did not pass style-queue: ERROR: Source/WebKit/Platform/spi/mac/AppKitSPI.h:60: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1529705 3 368056 rdemarest 2019-04-23 13:16:29 -0700 Created attachment 368056 Better Patch 1529709 4 ews-watchlist 2019-04-23 13:20:17 -0700 Attachment 368056 did not pass style-queue: ERROR: Source/WebKit/Platform/spi/mac/AppKitSPI.h:45: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Source/WebKit/Platform/spi/mac/AppKitSPI.h:62: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1529711 5 368057 rdemarest 2019-04-23 13:22:10 -0700 Created attachment 368057 For Real This Time Patch 1529712 6 ews-watchlist 2019-04-23 13:23:26 -0700 Attachment 368057 did not pass style-queue: ERROR: Source/WebKit/Platform/spi/mac/AppKitSPI.h:50: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Source/WebKit/Platform/spi/mac/AppKitSPI.h:62: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1529739 7 368057 commit-queue 2019-04-23 13:47:48 -0700 Comment on attachment 368057 For Real This Time Patch Clearing flags on attachment: 368057 Committed r244564: <https://trac.webkit.org/changeset/244564> 1529740 8 commit-queue 2019-04-23 13:47:50 -0700 All reviewed patches have been landed. Closing bug. 1529741 9 webkit-bug-importer 2019-04-23 13:48:18 -0700 <rdar://problem/50142673> 368055 2019-04-23 13:10:07 -0700 2019-04-23 13:16:29 -0700 Patch BuildFix.patch text/plain 972 rdemarest ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZDMzNDcxMzhmMjUuLmE1Y2I1MzczNTBjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDE5LTA0LTIzICBSZW15IERlbWFyZXN0ICA8cmRlbWFyZXN0QGFwcGxlLmNvbT4K KworICAgICAgICBCdWlsZCBmaXggYWZ0ZXIgcjI0NDU0NS4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtL3NwaS9tYWMvQXBwS2l0U1BJ Lmg6CisgICAgICAgIFRoZSBTUEkgd2FzIGFuIElQSSBpbiBIaWdoIFNpZXJyYS4KKwogMjAxOS0w NC0yMiAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIGFkZGl0 aW9uYWwgbWVtYmVycyBhbmQgcHJvdG9jb2xzIGZyb20gV2ViS2l0QWRkaXRpb25zIGluIFdLQ29u dGVudFZpZXdJbnRlcmFjdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9z cGkvbWFjL0FwcEtpdFNQSS5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvbWFjL0FwcEtp dFNQSS5oCmluZGV4IGEyZjkyMWUzNDgwLi45ZmUzNWY3ZmMwMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9QbGF0Zm9ybS9zcGkvbWFjL0FwcEtpdFNQSS5oCisrKyBiL1NvdXJjZS9XZWJLaXQv UGxhdGZvcm0vc3BpL21hYy9BcHBLaXRTUEkuaApAQCAtNTYsMyArNTYsOSBAQAogQGludGVyZmFj ZSBOU0luc3BlY3RvckJhciAoSVBJKQogLSAodm9pZClfdXBkYXRlOwogQGVuZAorCisjaWYgX19N QUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VEIDwgMTAxNDAwCitAaW50ZXJmYWNlIE5TV2luZG93 IChJUEkpCitAcHJvcGVydHkgQ0dGbG9hdCB0aXRsZWJhckFscGhhVmFsdWU7CitAZW5kCisjZW5k aWYK 368056 2019-04-23 13:16:29 -0700 2019-04-23 13:22:10 -0700 Better Patch BuildFix.patch text/plain 1305 rdemarest ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZDMzNDcxMzhmMjUuLmE1Y2I1MzczNTBjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDE5LTA0LTIzICBSZW15IERlbWFyZXN0ICA8cmRlbWFyZXN0QGFwcGxlLmNvbT4K KworICAgICAgICBCdWlsZCBmaXggYWZ0ZXIgcjI0NDU0NS4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtL3NwaS9tYWMvQXBwS2l0U1BJ Lmg6CisgICAgICAgIFRoZSBTUEkgd2FzIGFuIElQSSBpbiBIaWdoIFNpZXJyYS4KKwogMjAxOS0w NC0yMiAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIGFkZGl0 aW9uYWwgbWVtYmVycyBhbmQgcHJvdG9jb2xzIGZyb20gV2ViS2l0QWRkaXRpb25zIGluIFdLQ29u dGVudFZpZXdJbnRlcmFjdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9z cGkvbWFjL0FwcEtpdFNQSS5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvbWFjL0FwcEtp dFNQSS5oCmluZGV4IGEyZjkyMWUzNDgwLi5mMmZmMzEyZjY0NSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9QbGF0Zm9ybS9zcGkvbWFjL0FwcEtpdFNQSS5oCisrKyBiL1NvdXJjZS9XZWJLaXQv UGxhdGZvcm0vc3BpL21hYy9BcHBLaXRTUEkuaApAQCAtNDIsMTAgKzQyLDEyIEBACiBAcHJvdG9j b2wgTlNUZXh0SW5wdXRDbGllbnRfQXN5bmMKIEBlbmQKIAorI2lmIF9fTUFDX09TX1hfVkVSU0lP Tl9NQVhfQUxMT1dFRCA+PSAxMDE0MDAKIEBpbnRlcmZhY2UgTlNXaW5kb3cgKE5TSW5zcGVjdG9y QmFyU3VwcG9ydCkKIC0gKE5TSW5zcGVjdG9yQmFyICopaW5zcGVjdG9yQmFyOwogLSAodm9pZClz ZXRJbnNwZWN0b3JCYXI6KE5TSW5zcGVjdG9yQmFyICopYmFyOwogQGVuZAorI2VuZGlmCiAKIEBp bnRlcmZhY2UgTlNXaW5kb3cgKEZ1bGxTY3JlZW5TdXBwb3J0KQogQHByb3BlcnR5IENHRmxvYXQg dGl0bGViYXJBbHBoYVZhbHVlOwpAQCAtNTYsMyArNTgsOSBAQAogQGludGVyZmFjZSBOU0luc3Bl Y3RvckJhciAoSVBJKQogLSAodm9pZClfdXBkYXRlOwogQGVuZAorCisjaWYgX19NQUNfT1NfWF9W RVJTSU9OX01BWF9BTExPV0VEIDwgMTAxNDAwCitAaW50ZXJmYWNlIE5TV2luZG93IChJUEkpCitA cHJvcGVydHkgQ0dGbG9hdCB0aXRsZWJhckFscGhhVmFsdWU7CitAZW5kCisjZW5kaWYK 368057 2019-04-23 13:22:10 -0700 2019-04-23 13:47:48 -0700 For Real This Time Patch BuildFix.patch text/plain 1182 rdemarest ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZDMzNDcxMzhmMjUuLmE1Y2I1MzczNTBjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDE5LTA0LTIzICBSZW15IERlbWFyZXN0ICA8cmRlbWFyZXN0QGFwcGxlLmNvbT4K KworICAgICAgICBCdWlsZCBmaXggYWZ0ZXIgcjI0NDU0NS4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtL3NwaS9tYWMvQXBwS2l0U1BJ Lmg6CisgICAgICAgIFRoZSBTUEkgd2FzIGFuIElQSSBpbiBIaWdoIFNpZXJyYS4KKwogMjAxOS0w NC0yMiAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIGFkZGl0 aW9uYWwgbWVtYmVycyBhbmQgcHJvdG9jb2xzIGZyb20gV2ViS2l0QWRkaXRpb25zIGluIFdLQ29u dGVudFZpZXdJbnRlcmFjdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9z cGkvbWFjL0FwcEtpdFNQSS5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvbWFjL0FwcEtp dFNQSS5oCmluZGV4IGEyZjkyMWUzNDgwLi5mMzA1ZDUxNTQxMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9QbGF0Zm9ybS9zcGkvbWFjL0FwcEtpdFNQSS5oCisrKyBiL1NvdXJjZS9XZWJLaXQv UGxhdGZvcm0vc3BpL21hYy9BcHBLaXRTUEkuaApAQCAtNDcsMTIgKzQ3LDIwIEBACiAtICh2b2lk KXNldEluc3BlY3RvckJhcjooTlNJbnNwZWN0b3JCYXIgKiliYXI7CiBAZW5kCiAKKyNpZiBfX01B Q19PU19YX1ZFUlNJT05fTUFYX0FMTE9XRUQgPj0gMTAxNDAwCiBAaW50ZXJmYWNlIE5TV2luZG93 IChGdWxsU2NyZWVuU3VwcG9ydCkKIEBwcm9wZXJ0eSBDR0Zsb2F0IHRpdGxlYmFyQWxwaGFWYWx1 ZTsKIEBlbmQKKyNlbmRpZgogCiAjZW5kaWYKIAogQGludGVyZmFjZSBOU0luc3BlY3RvckJhciAo SVBJKQogLSAodm9pZClfdXBkYXRlOwogQGVuZAorCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01B WF9BTExPV0VEIDwgMTAxNDAwCitAaW50ZXJmYWNlIE5TV2luZG93IChJUEkpCitAcHJvcGVydHkg Q0dGbG9hdCB0aXRsZWJhckFscGhhVmFsdWU7CitAZW5kCisjZW5kaWYK