197203 2019-04-23 11:09:16 -0700 Speed up RenderTheme::systemColor on Speedometer2 2019-04-23 12:13:54 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bfulgham cdumez commit-queue megan_gardner simon.fraser thorton webkit-bug-importer zalan oldest_to_newest 1529660 0 timothy 2019-04-23 11:09:16 -0700 We can avoid some allocations in LocalDefaultSystemAppearance when a CSS color is in the system color cache. <rdar://problem/50056756> 1529663 1 368043 timothy 2019-04-23 11:12:38 -0700 Created attachment 368043 Patch 1529680 2 368043 commit-queue 2019-04-23 12:13:53 -0700 Comment on attachment 368043 Patch Clearing flags on attachment: 368043 Committed r244554: <https://trac.webkit.org/changeset/244554> 1529681 3 commit-queue 2019-04-23 12:13:54 -0700 All reviewed patches have been landed. Closing bug. 368043 2019-04-23 11:12:38 -0700 2019-04-23 12:13:53 -0700 Patch bug-197203-20190423111237.patch text/plain 4848 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY2ZmM3MzhlMjI2OTNh NDg3M2QzN2M4NzJhNzI0OWQxNzMwNjEyMy4uNDMwM2IyNGZmNGY2YzZjZTZlY2E3ZGZlYTljYTkw YzJmMGZjZmQ2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA0LTIzICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBTcGVlZCB1cCBSZW5k ZXJUaGVtZTo6c3lzdGVtQ29sb3Igb24gU3BlZWRvbWV0ZXIyLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3MjAzCisgICAgICAgIHJkYXI6Ly9wcm9i bGVtLzUwMDU2NzU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MubW06CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJUaGVtZUlPUzo6c3lzdGVtQ29sb3IgY29uc3QpOiBSZW1vdmUgc29tZSB1bnVzZWQgY29k ZS4gQW5kIGZldGNoIHRoZSBjYWNoZSBhZnRlciBhbiBlYXJseSByZXR1cm4uCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhl bWVNYWM6OnN5c3RlbUNvbG9yIGNvbnN0KTogQXZvaWQgc29tZSBhbGxvY2F0aW9ucyBpbiBMb2Nh bERlZmF1bHRTeXN0ZW1BcHBlYXJhbmNlCisgICAgICAgIHdoZW4gYSBDU1MgY29sb3IgaXMgaW4g dGhlIHN5c3RlbSBjb2xvciBjYWNoZS4KKwogMjAxOS0wNC0xOSAgV2Vuc29uIEhzaWVoICA8d2Vu c29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBBZGQgcXVpcmtzIHRvIGRpc2Fi bGUgYXV0b2NvcnJlY3Rpb24gYW5kIGF1dG9jYXBpdGFsaXphdGlvbiBpbiBoaWRkZW4gZWRpdGFi bGUgYXJlYXMgb24gc29tZSB3ZWJzaXRlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRoZW1lSU9TLm1tIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRoZW1lSU9TLm1tCmluZGV4IDExMzc0M2Y0ZTI5MGZlYjYwMzU0NzQ4YThiNTRjNTk2M2Q2NmFm MWEuLjE5M2QwNzkzMWJlOTlmZGUxOTc4M2I3YzA0OWNmNmFkMjJiODUzODcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5tbQorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MubW0KQEAgLTE0MTgsMjUgKzE0MTgsMjIg QEAgU3RyaW5nIFJlbmRlclRoZW1lSU9TOjptZWRpYUNvbnRyb2xzQmFzZTY0U3RyaW5nRm9ySWNv bk5hbWVBbmRUeXBlKGNvbnN0IFN0cmluZyYKIAogQ29sb3IgUmVuZGVyVGhlbWVJT1M6OnN5c3Rl bUNvbG9yKENTU1ZhbHVlSUQgY3NzVmFsdWVJRCwgT3B0aW9uU2V0PFN0eWxlQ29sb3I6Ok9wdGlv bnM+IG9wdGlvbnMpIGNvbnN0CiB7Ci0gICAgY29uc3QgYm9vbCB1c2VTeXN0ZW1BcHBlYXJhbmNl ID0gb3B0aW9ucy5jb250YWlucyhTdHlsZUNvbG9yOjpPcHRpb25zOjpVc2VTeXN0ZW1BcHBlYXJh bmNlKTsKICAgICBjb25zdCBib29sIGZvclZpc2l0ZWRMaW5rID0gb3B0aW9ucy5jb250YWlucyhT dHlsZUNvbG9yOjpPcHRpb25zOjpGb3JWaXNpdGVkTGluayk7CiAKLSAgICBhdXRvJiBjYWNoZSA9 IGNvbG9yQ2FjaGUob3B0aW9ucyk7Ci0KLSNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKSAmJiBf X2hhc19pbmNsdWRlKDxXZWJLaXRBZGRpdGlvbnMvUmVuZGVyVGhlbWVJT1NTeXN0ZW1Db2xvckFk ZGl0aW9ucy5tbT4pCi0jaW5jbHVkZSA8V2ViS2l0QWRkaXRpb25zL1JlbmRlclRoZW1lSU9TU3lz dGVtQ29sb3JBZGRpdGlvbnMubW0+Ci0jZW5kaWYKLQogICAgIC8vIFRoZSBzeXN0ZW0gY29sb3Ig Y2FjaGUgYmVsb3cgY2FuJ3QgaGFuZGxlIHZpc2l0ZWQgbGlua3MuIFRoZSBvbmx5IGNvbG9yIHZh bHVlCiAgICAgLy8gdGhhdCBjYXJlcyBhYm91dCB2aXNpdGVkIGxpbmtzIGlzIENTU1ZhbHVlV2Vi a2l0TGluaywgc28gaGFuZGxlIGl0IGhlcmUgYnkKICAgICAvLyBjYWxsaW5nIHRocm91Z2ggdG8g UmVuZGVyVGhlbWUncyBiYXNlIGltcGxlbWVudGF0aW9uLgogICAgIGlmIChmb3JWaXNpdGVkTGlu ayAmJiBjc3NWYWx1ZUlEID09IENTU1ZhbHVlV2Via2l0TGluaykKICAgICAgICAgcmV0dXJuIFJl bmRlclRoZW1lOjpzeXN0ZW1Db2xvcihjc3NWYWx1ZUlELCBvcHRpb25zKTsKIAotICAgIEFTU0VS VF9VTlVTRUQodXNlU3lzdGVtQXBwZWFyYW5jZSwgIXVzZVN5c3RlbUFwcGVhcmFuY2UpOwogICAg IEFTU0VSVCghZm9yVmlzaXRlZExpbmspOwogCisgICAgYXV0byYgY2FjaGUgPSBjb2xvckNhY2hl KG9wdGlvbnMpOwogICAgIHJldHVybiBjYWNoZS5zeXN0ZW1TdHlsZUNvbG9ycy5lbnN1cmUoY3Nz VmFsdWVJRCwgW3RoaXMsIGNzc1ZhbHVlSUQsIG9wdGlvbnNdICgpIC0+IENvbG9yIHsKKyNpZiBV U0UoQVBQTEVfSU5URVJOQUxfU0RLKSAmJiBfX2hhc19pbmNsdWRlKDxXZWJLaXRBZGRpdGlvbnMv UmVuZGVyVGhlbWVJT1NTeXN0ZW1Db2xvckFkZGl0aW9ucy5tbT4pCisjaW5jbHVkZSA8V2ViS2l0 QWRkaXRpb25zL1JlbmRlclRoZW1lSU9TU3lzdGVtQ29sb3JBZGRpdGlvbnMubW0+CisjZW5kaWYK KwogICAgICAgICBhdXRvIGNzc0NvbG9yVG9TZWxlY3RvciA9IFtjc3NWYWx1ZUlEXSAoKSAtPiBT RUwgewogI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspICYmIF9faGFzX2luY2x1ZGUoPFdlYktp dEFkZGl0aW9ucy9SZW5kZXJUaGVtZUlPU0NvbG9yVG9TZWxlY3RvckFkZGl0aW9ucy5tbT4pCiAj aW5jbHVkZSA8V2ViS2l0QWRkaXRpb25zL1JlbmRlclRoZW1lSU9TQ29sb3JUb1NlbGVjdG9yQWRk aXRpb25zLm1tPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCmlu ZGV4IDU3YTU5MGU4YTU0YTQ5ZGRiZTUyNGRkY2I4N2EwNzYzYjY4ZmJlMWUuLmNjMWYwNmY4YTZl ZTRmZGY4MDcyYjMxNDBmYTRiZDZmNDZmMjBlMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGhlbWVNYWMubW0KQEAgLTYwNCwxNCArNjA0LDEzIEBAIENvbG9yIFJlbmRlclRo ZW1lTWFjOjpzeXN0ZW1Db2xvcihDU1NWYWx1ZUlEIGNzc1ZhbHVlSUQsIE9wdGlvblNldDxTdHls ZUNvbG9yOjpPCiAgICAgY29uc3QgYm9vbCB1c2VEYXJrQXBwZWFyYW5jZSA9IG9wdGlvbnMuY29u dGFpbnMoU3R5bGVDb2xvcjo6T3B0aW9uczo6VXNlRGFya0FwcGVhcmFuY2UpOwogICAgIGNvbnN0 IGJvb2wgZm9yVmlzaXRlZExpbmsgPSBvcHRpb25zLmNvbnRhaW5zKFN0eWxlQ29sb3I6Ok9wdGlv bnM6OkZvclZpc2l0ZWRMaW5rKTsKIAotICAgIExvY2FsRGVmYXVsdFN5c3RlbUFwcGVhcmFuY2Ug bG9jYWxBcHBlYXJhbmNlKHVzZURhcmtBcHBlYXJhbmNlKTsKLQogICAgIGF1dG8mIGNhY2hlID0g Y29sb3JDYWNoZShvcHRpb25zKTsKIAogICAgIGlmICh1c2VTeXN0ZW1BcHBlYXJhbmNlKSB7CiAg ICAgICAgIC8vIFNwZWNpYWwgaGFuZGxpbmcgZm9yIGxpbmtzIGFuZCBvdGhlciBzeXN0ZW0gY29s b3JzIHdoZW4gdGhlIHN5c3RlbSBhcHBlYXJhbmNlIGlzIGRlc2lyZWQuCi0gICAgICAgIGF1dG8g c3lzdGVtQXBwZWFyYW5jZUNvbG9yID0gW10gKENvbG9yJiBjb2xvciwgU0VMIHNlbGVjdG9yKSAt PiBDb2xvciB7CisgICAgICAgIGF1dG8gc3lzdGVtQXBwZWFyYW5jZUNvbG9yID0gW3VzZURhcmtB cHBlYXJhbmNlXSAoQ29sb3ImIGNvbG9yLCBTRUwgc2VsZWN0b3IpIC0+IENvbG9yIHsKICAgICAg ICAgICAgIGlmICghY29sb3IuaXNWYWxpZCgpKSB7CisgICAgICAgICAgICAgICAgTG9jYWxEZWZh dWx0U3lzdGVtQXBwZWFyYW5jZSBsb2NhbEFwcGVhcmFuY2UodXNlRGFya0FwcGVhcmFuY2UpOwog ICAgICAgICAgICAgICAgIGF1dG8gc3lzdGVtQ29sb3IgPSB3dGZPYmpDTXNnU2VuZDxOU0NvbG9y ICo+KFtOU0NvbG9yIGNsYXNzXSwgc2VsZWN0b3IpOwogICAgICAgICAgICAgICAgIGNvbG9yID0g c2VtYW50aWNDb2xvckZyb21OU0NvbG9yKHN5c3RlbUNvbG9yKTsKICAgICAgICAgICAgIH0KQEAg LTY2Miw3ICs2NjEsOSBAQCBDb2xvciBSZW5kZXJUaGVtZU1hYzo6c3lzdGVtQ29sb3IoQ1NTVmFs dWVJRCBjc3NWYWx1ZUlELCBPcHRpb25TZXQ8U3R5bGVDb2xvcjo6TwogCiAgICAgQVNTRVJUKCFm b3JWaXNpdGVkTGluayk7CiAKLSAgICByZXR1cm4gY2FjaGUuc3lzdGVtU3R5bGVDb2xvcnMuZW5z dXJlKGNzc1ZhbHVlSUQsIFt0aGlzLCBjc3NWYWx1ZUlELCBvcHRpb25zLCAmbG9jYWxBcHBlYXJh bmNlXSAoKSAtPiBDb2xvciB7CisgICAgcmV0dXJuIGNhY2hlLnN5c3RlbVN0eWxlQ29sb3JzLmVu c3VyZShjc3NWYWx1ZUlELCBbdGhpcywgY3NzVmFsdWVJRCwgb3B0aW9ucywgdXNlRGFya0FwcGVh cmFuY2VdICgpIC0+IENvbG9yIHsKKyAgICAgICAgTG9jYWxEZWZhdWx0U3lzdGVtQXBwZWFyYW5j ZSBsb2NhbEFwcGVhcmFuY2UodXNlRGFya0FwcGVhcmFuY2UpOworCiAgICAgICAgIGF1dG8gc2Vs ZWN0Q29jb2FDb2xvciA9IFtjc3NWYWx1ZUlEXSAoKSAtPiBTRUwgewogICAgICAgICAgICAgc3dp dGNoIChjc3NWYWx1ZUlEKSB7CiAgICAgICAgICAgICBjYXNlIENTU1ZhbHVlQWN0aXZlY2FwdGlv bjoK