197197 2019-04-23 07:41:59 -0700 [ews-build] Add unit tests for UnApplyPatchIfRequired 2019-04-23 11:05:10 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dewei_zhu ews-watchlist jbedard lforschler webkit-bug-importer oldest_to_newest 1529575 0 aakash_jain 2019-04-23 07:41:59 -0700 Add unit tests for UnApplyPatchIfRequired build step. 1529577 1 368029 aakash_jain 2019-04-23 07:43:42 -0700 Created attachment 368029 Patch 1529578 2 ews-watchlist 2019-04-23 07:46:17 -0700 Attachment 368029 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:839: [TestUnApplyPatchIfRequired.test_success] Undefined variable 'UnApplyPatchIfRequired' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:848: [TestUnApplyPatchIfRequired.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:848: [TestUnApplyPatchIfRequired.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:852: [TestUnApplyPatchIfRequired.test_failure] Undefined variable 'UnApplyPatchIfRequired' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:862: [TestUnApplyPatchIfRequired.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:862: [TestUnApplyPatchIfRequired.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:866: [TestUnApplyPatchIfRequired.test_skip] Undefined variable 'UnApplyPatchIfRequired' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:868: [TestUnApplyPatchIfRequired.test_skip] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:868: [TestUnApplyPatchIfRequired.test_skip] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 9 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1529657 3 aakash_jain 2019-04-23 11:02:58 -0700 Committed r244551: <https://trac.webkit.org/changeset/244551> 1529658 4 webkit-bug-importer 2019-04-23 11:05:10 -0700 <rdar://problem/50136409> 368029 2019-04-23 07:43:42 -0700 2019-04-23 10:23:44 -0700 Patch bug-197197-20190423104341.patch text/plain 2766 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDUzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTA0LTIzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgdW5pdCB0ZXN0cyBmb3IgVW5BcHBseVBhdGNo SWZSZXF1aXJlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk3MTk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6CisgICAg ICAgIChUZXN0VW5BcHBseVBhdGNoSWZSZXF1aXJlZCk6CisgICAgICAgIChUZXN0VW5BcHBseVBh dGNoSWZSZXF1aXJlZC50ZXN0X3N1Y2Nlc3MpOgorICAgICAgICAoVGVzdFVuQXBwbHlQYXRjaElm UmVxdWlyZWQudGVzdF9mYWlsdXJlKToKKyAgICAgICAgKFRlc3RVbkFwcGx5UGF0Y2hJZlJlcXVp cmVkLnRlc3Rfc2tpcCk6CisKIDIwMTktMDQtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtBVEtdIEltcGxlbWVudCBBdGtDb21wb25lbnRJ ZmFjZSBzY3JvbGxfdG8gbWV0aG9kcwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjQ0NTM4KQorKysg VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC04MjcsNiArODI3LDQ4IEBAIGNsYXNzIFRlc3RSdW5XZWJLaXQxVGVzdHMo QnVpbGRTdGVwTWl4aW4KICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKIAorY2xhc3Mg VGVzdFVuQXBwbHlQYXRjaElmUmVxdWlyZWQoQnVpbGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVuaXR0 ZXN0LlRlc3RDYXNlKToKKyAgICBkZWYgc2V0VXAoc2VsZik6CisgICAgICAgIHNlbGYubG9uZ01l c3NhZ2UgPSBUcnVlCisgICAgICAgIHJldHVybiBzZWxmLnNldFVwQnVpbGRTdGVwKCkKKworICAg IGRlZiB0ZWFyRG93bihzZWxmKToKKyAgICAgICAgcmV0dXJuIHNlbGYudGVhckRvd25CdWlsZFN0 ZXAoKQorCisgICAgZGVmIHRlc3Rfc3VjY2VzcyhzZWxmKToKKyAgICAgICAgc2VsZi5zZXR1cFN0 ZXAoVW5BcHBseVBhdGNoSWZSZXF1aXJlZCgpKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdw YXRjaEZhaWxlZFRvQnVpbGQnLCBUcnVlKQorICAgICAgICBzZWxmLmV4cGVjdEhpZGRlbihGYWxz ZSkKKyAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKKyAgICAgICAgICAgIEV4cGVj dFNoZWxsKHdvcmtkaXI9J3drZGlyJywKKyAgICAgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQ9 WydUb29scy9TY3JpcHRzL2NsZWFuLXdlYmtpdCddLAorICAgICAgICAgICAgICAgICAgICAgICAg KQorICAgICAgICAgICAgKyAwLAorICAgICAgICApCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29t ZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdVbmFwcGxpZWQgcGF0Y2gnKQorICAgICAg ICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKKworICAgIGRlZiB0ZXN0X2ZhaWx1cmUoc2VsZik6Cisg ICAgICAgIHNlbGYuc2V0dXBTdGVwKFVuQXBwbHlQYXRjaElmUmVxdWlyZWQoKSkKKyAgICAgICAg c2VsZi5zZXRQcm9wZXJ0eSgncGF0Y2hGYWlsZWRUb0J1aWxkJywgVHJ1ZSkKKyAgICAgICAgc2Vs Zi5leHBlY3RIaWRkZW4oRmFsc2UpCisgICAgICAgIHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMo CisgICAgICAgICAgICBFeHBlY3RTaGVsbCh3b3JrZGlyPSd3a2RpcicsCisgICAgICAgICAgICAg ICAgICAgICAgICBjb21tYW5kPVsnVG9vbHMvU2NyaXB0cy9jbGVhbi13ZWJraXQnXSwKKyAgICAg ICAgICAgICAgICAgICAgICAgICkKKyAgICAgICAgICAgICsgRXhwZWN0U2hlbGwubG9nKCdzdGRp bycsIHN0ZG91dD0nVW5leHBlY3RlZCBmYWlsdXJlLicpCisgICAgICAgICAgICArIDIsCisgICAg ICAgICkKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9z dHJpbmc9J1VuYXBwbGllZCBwYXRjaCAoZmFpbHVyZSknKQorICAgICAgICByZXR1cm4gc2VsZi5y dW5TdGVwKCkKKworICAgIGRlZiB0ZXN0X3NraXAoc2VsZik6CisgICAgICAgIHNlbGYuc2V0dXBT dGVwKFVuQXBwbHlQYXRjaElmUmVxdWlyZWQoKSkKKyAgICAgICAgc2VsZi5leHBlY3RIaWRkZW4o VHJ1ZSkKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TS0lQUEVELCBzdGF0ZV9z dHJpbmc9J1VuYXBwbGllZCBwYXRjaCAoc2tpcHBlZCknKQorICAgICAgICByZXR1cm4gc2VsZi5y dW5TdGVwKCkKKworCiBjbGFzcyBUZXN0QXJjaGl2ZUJ1aWx0UHJvZHVjdChCdWlsZFN0ZXBNaXhp bkFkZGl0aW9ucywgdW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGRlZiBzZXRVcChzZWxmKToKICAg ICAgICAgc2VsZi5sb25nTWVzc2FnZSA9IFRydWUK