197195 2019-04-23 07:01:37 -0700 [ews-build] Add unit tests for CleanWorkingDirectory 2019-04-23 10:59:18 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1529569 0 aakash_jain 2019-04-23 07:01:37 -0700 Add unit tests for CleanWorkingDirectory build step. 1529571 1 368026 aakash_jain 2019-04-23 07:02:59 -0700 Created attachment 368026 Patch 1529572 2 ews-watchlist 2019-04-23 07:05:46 -0700 Attachment 368026 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:839: [TestCleanWorkingDirectory.test_success] Undefined variable 'CleanWorkingDirectory' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:846: [TestCleanWorkingDirectory.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:846: [TestCleanWorkingDirectory.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:850: [TestCleanWorkingDirectory.test_failure] Undefined variable 'CleanWorkingDirectory' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:858: [TestCleanWorkingDirectory.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:858: [TestCleanWorkingDirectory.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1529654 3 368026 commit-queue 2019-04-23 10:58:26 -0700 Comment on attachment 368026 Patch Clearing flags on attachment: 368026 Committed r244550: <https://trac.webkit.org/changeset/244550> 1529655 4 commit-queue 2019-04-23 10:58:28 -0700 All reviewed patches have been landed. Closing bug. 1529656 5 webkit-bug-importer 2019-04-23 10:59:18 -0700 <rdar://problem/50136092> 368026 2019-04-23 07:02:59 -0700 2019-04-23 10:58:26 -0700 Patch bug-197195-20190423100257.patch text/plain 2326 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDUzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTA0LTIzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgdW5pdCB0ZXN0cyBmb3IgQ2xlYW5Xb3JraW5n RGlyZWN0b3J5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTcxOTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weToKKyAgICAg ICAgKFRlc3RDbGVhbldvcmtpbmdEaXJlY3RvcnkpOgorICAgICAgICAoVGVzdENsZWFuV29ya2lu Z0RpcmVjdG9yeS50ZXN0X3N1Y2Nlc3MpOgorICAgICAgICAoVGVzdENsZWFuV29ya2luZ0RpcmVj dG9yeS50ZXN0X2ZhaWx1cmUpOgorCiAyMDE5LTA0LTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQVRLXSBJbXBsZW1lbnQgQXRrQ29tcG9u ZW50SWZhY2Ugc2Nyb2xsX3RvIG1ldGhvZHMKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI0NDUzOCkK KysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQko d29ya2luZyBjb3B5KQpAQCAtODI3LDYgKzgyNywzOCBAQCBjbGFzcyBUZXN0UnVuV2ViS2l0MVRl c3RzKEJ1aWxkU3RlcE1peGluCiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQogCiAKK2Ns YXNzIFRlc3RDbGVhbldvcmtpbmdEaXJlY3RvcnkoQnVpbGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVu aXR0ZXN0LlRlc3RDYXNlKToKKyAgICBkZWYgc2V0VXAoc2VsZik6CisgICAgICAgIHNlbGYubG9u Z01lc3NhZ2UgPSBUcnVlCisgICAgICAgIHJldHVybiBzZWxmLnNldFVwQnVpbGRTdGVwKCkKKwor ICAgIGRlZiB0ZWFyRG93bihzZWxmKToKKyAgICAgICAgcmV0dXJuIHNlbGYudGVhckRvd25CdWls ZFN0ZXAoKQorCisgICAgZGVmIHRlc3Rfc3VjY2VzcyhzZWxmKToKKyAgICAgICAgc2VsZi5zZXR1 cFN0ZXAoQ2xlYW5Xb3JraW5nRGlyZWN0b3J5KCkpCisgICAgICAgIHNlbGYuZXhwZWN0UmVtb3Rl Q29tbWFuZHMoCisgICAgICAgICAgICBFeHBlY3RTaGVsbCh3b3JrZGlyPSd3a2RpcicsCisgICAg ICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsnVG9vbHMvU2NyaXB0cy9jbGVhbi13ZWJraXQn XSwKKyAgICAgICAgICAgICAgICAgICAgICAgICkKKyAgICAgICAgICAgICsgMCwKKyAgICAgICAg KQorICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmlu Zz0nQ2xlYW5lZCB3b3JraW5nIGRpcmVjdG9yeScpCisgICAgICAgIHJldHVybiBzZWxmLnJ1blN0 ZXAoKQorCisgICAgZGVmIHRlc3RfZmFpbHVyZShzZWxmKToKKyAgICAgICAgc2VsZi5zZXR1cFN0 ZXAoQ2xlYW5Xb3JraW5nRGlyZWN0b3J5KCkpCisgICAgICAgIHNlbGYuZXhwZWN0UmVtb3RlQ29t bWFuZHMoCisgICAgICAgICAgICBFeHBlY3RTaGVsbCh3b3JrZGlyPSd3a2RpcicsCisgICAgICAg ICAgICAgICAgICAgICAgICBjb21tYW5kPVsnVG9vbHMvU2NyaXB0cy9jbGVhbi13ZWJraXQnXSwK KyAgICAgICAgICAgICAgICAgICAgICAgICkKKyAgICAgICAgICAgICsgRXhwZWN0U2hlbGwubG9n KCdzdGRpbycsIHN0ZG91dD0nVW5leHBlY3RlZCBmYWlsdXJlLicpCisgICAgICAgICAgICArIDIs CisgICAgICAgICkKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBz dGF0ZV9zdHJpbmc9J0NsZWFuZWQgd29ya2luZyBkaXJlY3RvcnkgKGZhaWx1cmUpJykKKyAgICAg ICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCisKKwogY2xhc3MgVGVzdEFyY2hpdmVCdWlsdFByb2R1 Y3QoQnVpbGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICBkZWYg c2V0VXAoc2VsZik6CiAgICAgICAgIHNlbGYubG9uZ01lc3NhZ2UgPSBUcnVlCg==