197194 2019-04-23 06:27:45 -0700 [ews-build] Use explicit imports instead of wildcard imports 2019-04-23 10:55:37 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu jbedard lforschler webkit-bug-importer oldest_to_newest 1529565 0 aakash_jain 2019-04-23 06:27:45 -0700 PEP8 says: "Wildcard imports (from <module> import *) should be avoided, as they make it unclear which names are present in the namespace, confusing both readers and many automated tools." https://www.python.org/dev/peps/pep-0008/ We should remove wildcard imports and use explicit imports. 1529567 1 368025 aakash_jain 2019-04-23 06:31:37 -0700 Created attachment 368025 Patch 1529651 2 368025 commit-queue 2019-04-23 10:54:40 -0700 Comment on attachment 368025 Patch Clearing flags on attachment: 368025 Committed r244549: <https://trac.webkit.org/changeset/244549> 1529652 3 commit-queue 2019-04-23 10:54:42 -0700 All reviewed patches have been landed. Closing bug. 1529653 4 webkit-bug-importer 2019-04-23 10:55:37 -0700 <rdar://problem/50135923> 368025 2019-04-23 06:31:37 -0700 2019-04-23 10:54:40 -0700 Patch bug-197194-20190423093136.patch text/plain 4464 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDUzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTA0LTIzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBVc2UgZXhwbGljaXQgaW1wb3J0cyBpbnN0ZWFkIG9m IHdpbGRjYXJkIGltcG9ydHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5NzE5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weToKKyAg ICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZy5weToKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6CisKIDIw MTktMDQtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtBVEtdIEltcGxlbWVudCBBdGtDb21wb25lbnRJZmFjZSBzY3JvbGxfdG8gbWV0aG9k cwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVz LnB5CShyZXZpc2lvbiAyNDQ1MzgpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvZmFjdG9yaWVzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNCw3ICsyNCwxMiBAQAogZnJvbSBi dWlsZGJvdC5wcm9jZXNzIGltcG9ydCBmYWN0b3J5CiBmcm9tIGJ1aWxkYm90LnN0ZXBzIGltcG9y dCB0cmlnZ2VyCiAKLWZyb20gc3RlcHMgaW1wb3J0ICoKK2Zyb20gc3RlcHMgaW1wb3J0IChBcHBs eVBhdGNoLCBDaGVja091dFNvdXJjZSwgQ2hlY2tQYXRjaFJlbGV2YW5jZSwgQ2hlY2tTdHlsZSwK KyAgICAgICAgICAgICAgICAgICBDb21waWxlSlNDT25seSwgQ29tcGlsZUpTQ09ubHlUb1QsIENv bXBpbGVXZWJLaXQsIENvbmZpZ3VyZUJ1aWxkLAorICAgICAgICAgICAgICAgICAgIERvd25sb2Fk QnVpbHRQcm9kdWN0LCBFeHRyYWN0QnVpbHRQcm9kdWN0LCBLaWxsT2xkUHJvY2Vzc2VzLAorICAg ICAgICAgICAgICAgICAgIFByaW50Q29uZmlndXJhdGlvbiwgUmVSdW5KYXZhU2NyaXB0Q29yZVRl c3RzLCBSdW5BUElUZXN0cywgUnVuQmluZGluZ3NUZXN0cywKKyAgICAgICAgICAgICAgICAgICBS dW5KYXZhU2NyaXB0Q29yZVRlc3RzLCBSdW5KYXZhU2NyaXB0Q29yZVRlc3RzVG9ULCBSdW5XZWJL aXQxVGVzdHMsIFJ1bldlYktpdFBlcmxUZXN0cywKKyAgICAgICAgICAgICAgICAgICBSdW5XZWJL aXRQeVRlc3RzLCBSdW5XZWJLaXRUZXN0cywgVW5BcHBseVBhdGNoSWZSZXF1aXJlZCwgVmFsaWRh dGVQYXRjaCkKIAogCiBjbGFzcyBGYWN0b3J5KGZhY3RvcnkuQnVpbGRGYWN0b3J5KToKSW5kZXg6 IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5CShy ZXZpc2lvbiAyNDQ1MzgpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbG9h ZENvbmZpZy5weQkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLSMgQ29weXJpZ2h0IChD KSAyMDE4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChDKSAy MDE4LTIwMTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogIwogIyBSZWRpc3RyaWJ1 dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK ICMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2lu ZyBjb25kaXRpb25zCkBAIC0zMCw3ICszMCwxMCBAQCBmcm9tIGJ1aWxkYm90LnNjaGVkdWxlcnMu dHJ5c2NoZWQgaW1wb3J0CiBmcm9tIGJ1aWxkYm90LndvcmtlciBpbXBvcnQgV29ya2VyCiBmcm9t IGJ1aWxkYm90LnV0aWwgaW1wb3J0IGlkZW50aWZpZXJzIGFzIGJ1aWxkYm90X2lkZW50aWZpZXJz CiAKLWZyb20gZmFjdG9yaWVzIGltcG9ydCAqCitmcm9tIGZhY3RvcmllcyBpbXBvcnQgKEFQSVRl c3RzRmFjdG9yeSwgQmluZGluZ3NGYWN0b3J5LCBCdWlsZEZhY3RvcnksIEZhY3RvcnksIEdUS0Zh Y3RvcnksCisgICAgICAgICAgICAgICAgICAgICAgIEpTQ1Rlc3RzRmFjdG9yeSwgU3R5bGVGYWN0 b3J5LCBUZXN0RmFjdG9yeSwgV1BFRmFjdG9yeSwgV2ViS2l0UGVybEZhY3RvcnksCisgICAgICAg ICAgICAgICAgICAgICAgIFdlYktpdFB5RmFjdG9yeSwgV2luQ2Fpcm9GYWN0b3J5LCBXaW5kb3dz RmFjdG9yeSwgaU9TQnVpbGRGYWN0b3J5LCBpT1NUZXN0c0ZhY3RvcnksCisgICAgICAgICAgICAg ICAgICAgICAgIG1hY09TQnVpbGRGYWN0b3J5LCBtYWNPU1dLMUZhY3RvcnksIG1hY09TV0syRmFj dG9yeSkKIAogQlVJTERFUl9OQU1FX0xFTkdUSF9MSU1JVCA9IDcwCiBTVEVQX05BTUVfTEVOR1RI X0xJTUlUID0gNTAKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVw c191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3Mt YnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI0NDUzOCkKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpA QCAtMSw0ICsxLDQgQEAKLSMgQ29weXJpZ2h0IChDKSAyMDE4IEFwcGxlIEluYy4gQWxsIHJpZ2h0 cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChDKSAyMDE4LTIwMTkgQXBwbGUgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLgogIwogIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQg YmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0 dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0zNCw3ICszNCwx NCBAQCBmcm9tIHR3aXN0ZWQuaW50ZXJuZXQgaW1wb3J0IGVycm9yLCByZWFjCiBmcm9tIHR3aXN0 ZWQucHl0aG9uIGltcG9ydCBmYWlsdXJlLCBsb2cKIGZyb20gdHdpc3RlZC50cmlhbCBpbXBvcnQg dW5pdHRlc3QKIAotZnJvbSBzdGVwcyBpbXBvcnQgKgorZnJvbSBzdGVwcyBpbXBvcnQgKEFuYWx5 emVBUElUZXN0c1Jlc3VsdHMsIEFwcGx5UGF0Y2gsIEFyY2hpdmVCdWlsdFByb2R1Y3QsIEFyY2hp dmVUZXN0UmVzdWx0cywKKyAgICAgICAgICAgICAgICAgICBDaGVja091dFNvdXJjZSwgQ2hlY2tQ YXRjaFJlbGV2YW5jZSwgQ2hlY2tTdHlsZSwgQ2xlYW5CdWlsZCwgQ2xlYW5Xb3JraW5nRGlyZWN0 b3J5LAorICAgICAgICAgICAgICAgICAgIENvbXBpbGVKU0NPbmx5LCBDb21waWxlSlNDT25seVRv VCwgQ29tcGlsZVdlYktpdCwgQ29tcGlsZVdlYktpdFRvVCwgQ29uZmlndXJlQnVpbGQsCisgICAg ICAgICAgICAgICAgICAgRG93bmxvYWRCdWlsdFByb2R1Y3QsIEV4dHJhY3RCdWlsdFByb2R1Y3Qs IEV4dHJhY3RUZXN0UmVzdWx0cywgS2lsbE9sZFByb2Nlc3NlcywKKyAgICAgICAgICAgICAgICAg ICBQcmludENvbmZpZ3VyYXRpb24sIFJlUnVuQVBJVGVzdHMsIFJlUnVuSmF2YVNjcmlwdENvcmVU ZXN0cywgUnVuQVBJVGVzdHMsIFJ1bkFQSVRlc3RzV2l0aG91dFBhdGNoLAorICAgICAgICAgICAg ICAgICAgIFJ1bkJpbmRpbmdzVGVzdHMsIFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMsIFJ1bkphdmFT Y3JpcHRDb3JlVGVzdHNUb1QsIFJ1bldlYktpdDFUZXN0cywgUnVuV2ViS2l0UGVybFRlc3RzLAor ICAgICAgICAgICAgICAgICAgIFJ1bldlYktpdFB5VGVzdHMsIFJ1bldlYktpdFRlc3RzLCBUZXN0 V2l0aEZhaWx1cmVDb3VudCwgVHJpZ2dlciwgVW5BcHBseVBhdGNoSWZSZXF1aXJlZCwgVXBsb2Fk QnVpbHRQcm9kdWN0LAorICAgICAgICAgICAgICAgICAgIFVwbG9hZFRlc3RSZXN1bHRzLCBWYWxp ZGF0ZVBhdGNoKQogCiAjIFdvcmthcm91bmQgZm9yIGh0dHBzOi8vZ2l0aHViLmNvbS9idWlsZGJv dC9idWlsZGJvdC9pc3N1ZXMvNDY2OQogZnJvbSBidWlsZGJvdC50ZXN0LmZha2UuZmFrZWJ1aWxk IGltcG9ydCBGYWtlQnVpbGQK