197193 2019-04-23 05:45:29 -0700 [ews-build] Add unit tests for DownloadBuiltProduct 2019-04-23 10:54:19 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu ews-watchlist jbedard lforschler webkit-bug-importer oldest_to_newest 1529562 0 aakash_jain 2019-04-23 05:45:29 -0700 Add unit tests for DownloadBuiltProduct build step. 1529563 1 368024 aakash_jain 2019-04-23 05:46:58 -0700 Created attachment 368024 Patch 1529564 2 ews-watchlist 2019-04-23 05:48:35 -0700 Attachment 368024 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:926: [TestDownloadBuiltProduct.test_success] Undefined variable 'DownloadBuiltProduct' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:938: [TestDownloadBuiltProduct.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:938: [TestDownloadBuiltProduct.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:942: [TestDownloadBuiltProduct.test_failure] Undefined variable 'DownloadBuiltProduct' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:955: [TestDownloadBuiltProduct.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:955: [TestDownloadBuiltProduct.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1529648 3 368024 commit-queue 2019-04-23 10:53:31 -0700 Comment on attachment 368024 Patch Clearing flags on attachment: 368024 Committed r244548: <https://trac.webkit.org/changeset/244548> 1529649 4 commit-queue 2019-04-23 10:53:33 -0700 All reviewed patches have been landed. Closing bug. 1529650 5 webkit-bug-importer 2019-04-23 10:54:19 -0700 <rdar://problem/50135852> 368024 2019-04-23 05:46:58 -0700 2019-04-23 10:53:31 -0700 Patch bug-197193-20190423084657.patch text/plain 3198 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDUzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTA0LTIzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgdW5pdCB0ZXN0cyBmb3IgRG93bmxvYWRCdWls dFByb2R1Y3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5NzE5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OgorICAgICAg ICAoVGVzdERvd25sb2FkQnVpbHRQcm9kdWN0KToKKyAgICAgICAgKFRlc3REb3dubG9hZEJ1aWx0 UHJvZHVjdC5zZXRVcCk6CisgICAgICAgIChUZXN0RG93bmxvYWRCdWlsdFByb2R1Y3QudGVhckRv d24pOgorICAgICAgICAoVGVzdERvd25sb2FkQnVpbHRQcm9kdWN0LnRlc3Rfc3VjY2Vzcyk6Cisg ICAgICAgIChUZXN0RG93bmxvYWRCdWlsdFByb2R1Y3QudGVzdF9mYWlsdXJlKToKKwogMjAxOS0w NC0yMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0FUS10gSW1wbGVtZW50IEF0a0NvbXBvbmVudElmYWNlIHNjcm9sbF90byBtZXRob2RzCklu ZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3Vu aXR0ZXN0LnB5CShyZXZpc2lvbiAyNDQ1MzgpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTkxNCw2ICs5MTQs NDggQEAgY2xhc3MgVGVzdFVwbG9hZEJ1aWx0UHJvZHVjdChCdWlsZFN0ZXBNaQogICAgICAgICBy ZXR1cm4gc2VsZi5ydW5TdGVwKCkKIAogCitjbGFzcyBUZXN0RG93bmxvYWRCdWlsdFByb2R1Y3Qo QnVpbGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAgICBkZWYgc2V0 VXAoc2VsZik6CisgICAgICAgIHNlbGYubG9uZ01lc3NhZ2UgPSBUcnVlCisgICAgICAgIHJldHVy biBzZWxmLnNldFVwQnVpbGRTdGVwKCkKKworICAgIGRlZiB0ZWFyRG93bihzZWxmKToKKyAgICAg ICAgcmV0dXJuIHNlbGYudGVhckRvd25CdWlsZFN0ZXAoKQorCisgICAgZGVmIHRlc3Rfc3VjY2Vz cyhzZWxmKToKKyAgICAgICAgc2VsZi5zZXR1cFN0ZXAoRG93bmxvYWRCdWlsdFByb2R1Y3QoKSkK KyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgncGxhdGZvcm0nLCAnaW9zJykKKyAgICAgICAgc2Vs Zi5zZXRQcm9wZXJ0eSgnZnVsbFBsYXRmb3JtJywgJ2lvcy1zaW11bGF0b3ItMTInKQorICAgICAg ICBzZWxmLnNldFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ3JlbGVhc2UnKQorICAgICAgICBz ZWxmLnNldFByb3BlcnR5KCdhcmNoaXRlY3R1cmUnLCAneDg2XzY0JykKKyAgICAgICAgc2VsZi5z ZXRQcm9wZXJ0eSgncGF0Y2hfaWQnLCAnMTIzNCcpCisgICAgICAgIHNlbGYuZXhwZWN0UmVtb3Rl Q29tbWFuZHMoCisgICAgICAgICAgICBFeHBlY3RTaGVsbCh3b3JrZGlyPSd3a2RpcicsCisgICAg ICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsncHl0aG9uJywgJ1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2Rvd25sb2FkLWJ1aWx0LXByb2R1Y3QnLCAnLS1wbGF0Zm9ybT1pb3MnLCAgJy0tcmVs ZWFzZScsICdodHRwczovL2V3cy1idWlsZC53ZWJraXQub3JnL2FyY2hpdmVzL2lvcy1zaW11bGF0 b3ItMTIteDg2XzY0LXJlbGVhc2UvMTIzNC56aXAnXSwKKyAgICAgICAgICAgICAgICAgICAgICAg ICkKKyAgICAgICAgICAgICsgMCwKKyAgICAgICAgKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNv bWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0nRG93bmxvYWRlZCBidWlsdCBwcm9kdWN0 JykKKyAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCisKKyAgICBkZWYgdGVzdF9mYWlsdXJl KHNlbGYpOgorICAgICAgICBzZWxmLnNldHVwU3RlcChEb3dubG9hZEJ1aWx0UHJvZHVjdCgpKQor ICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdwbGF0Zm9ybScsICdtYWMnKQorICAgICAgICBzZWxm LnNldFByb3BlcnR5KCdmdWxsUGxhdGZvcm0nLCAnbWFjLXNpZXJyYScpCisgICAgICAgIHNlbGYu c2V0UHJvcGVydHkoJ2NvbmZpZ3VyYXRpb24nLCAnZGVidWcnKQorICAgICAgICBzZWxmLnNldFBy b3BlcnR5KCdhcmNoaXRlY3R1cmUnLCAneDg2XzY0JykKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0 eSgncGF0Y2hfaWQnLCAnMTIzNDU2JykKKyAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5k cygKKyAgICAgICAgICAgIEV4cGVjdFNoZWxsKHdvcmtkaXI9J3drZGlyJywKKyAgICAgICAgICAg ICAgICAgICAgICAgIGNvbW1hbmQ9WydweXRob24nLCAnVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZG93bmxvYWQtYnVpbHQtcHJvZHVjdCcsICctLXBsYXRmb3JtPW1hYycsICAnLS1kZWJ1ZycsICdo dHRwczovL2V3cy1idWlsZC53ZWJraXQub3JnL2FyY2hpdmVzL21hYy1zaWVycmEteDg2XzY0LWRl YnVnLzEyMzQ1Ni56aXAnXSwKKyAgICAgICAgICAgICAgICAgICAgICAgICkKKyAgICAgICAgICAg ICsgRXhwZWN0U2hlbGwubG9nKCdzdGRpbycsIHN0ZG91dD0nVW5leHBlY3RlZCBmYWlsdXJlLicp CisgICAgICAgICAgICArIDIsCisgICAgICAgICkKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21l KHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9J0Rvd25sb2FkZWQgYnVpbHQgcHJvZHVjdCAo ZmFpbHVyZSknKQorICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKKworCiBjbGFzcyBUZXN0 RXh0cmFjdEJ1aWx0UHJvZHVjdChCdWlsZFN0ZXBNaXhpbkFkZGl0aW9ucywgdW5pdHRlc3QuVGVz dENhc2UpOgogICAgIGRlZiBzZXRVcChzZWxmKToKICAgICAgICAgc2VsZi5sb25nTWVzc2FnZSA9 IFRydWUK