197182 2019-04-22 16:26:14 -0700 [ews-build] Improve summary for UploadBuiltProduct step 2019-04-22 17:23:29 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dewei_zhu ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1529453 0 aakash_jain 2019-04-22 16:26:14 -0700 The summary automatically generated by Buildbot for UploadBuiltProduct step (which uses Buildbot base class git.Git) is 'uploading release.zip'. We should improve this. 1529454 1 367993 aakash_jain 2019-04-22 16:29:17 -0700 Created attachment 367993 Patch 1529457 2 ews-watchlist 2019-04-22 16:31:40 -0700 Attachment 367993 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:678: [UploadBuiltProduct.getResultSummary] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:679: [UploadBuiltProduct.getResultSummary] Instance of 'UploadBuiltProduct' has no 'results' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:892: [TestUploadBuiltProduct.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:892: [TestUploadBuiltProduct.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:913: [TestUploadBuiltProduct.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:913: [TestUploadBuiltProduct.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1529460 3 aakash_jain 2019-04-22 16:36:45 -0700 (In reply to Aakash Jain from comment #0) > (which uses Buildbot base class git.Git) typo here. base class is transfer.FileUpload. 1529488 4 aakash_jain 2019-04-22 17:22:09 -0700 Committed r244533: <https://trac.webkit.org/changeset/244533> 1529490 5 webkit-bug-importer 2019-04-22 17:23:29 -0700 <rdar://problem/50113946> 367993 2019-04-22 16:29:17 -0700 2019-04-22 16:40:44 -0700 Patch bug-197182-20190422192916.patch text/plain 3807 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDUyMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTA0LTIyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBJbXByb3ZlIHN1bW1hcnkgZm9yIFVwbG9hZEJ1aWx0 UHJvZHVjdCBzdGVwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTcxODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKFVw bG9hZEJ1aWx0UHJvZHVjdCk6IEFkZGVkIGRlc2NyaXB0aW9uRG9uZS4KKyAgICAgICAgKFVwbG9h ZEJ1aWx0UHJvZHVjdC5nZXRSZXN1bHRTdW1tYXJ5KTogT3ZlcnJpZGVkIGdldFJlc3VsdFN1bW1h cnkuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0 LnB5OgorICAgICAgICAoVGVzdFVwbG9hZEJ1aWx0UHJvZHVjdC50ZXN0X3N1Y2Nlc3MpOiBVcGRh dGVkIHVuaXQtdGVzdC4KKyAgICAgICAgKFRlc3RVcGxvYWRCdWlsdFByb2R1Y3QudGVzdF9mYWls dXJlKTogQWRkZWQgdW5pdC10ZXN0IGZvciBmYWlsdXJlIGNhc2UuCisKIDIwMTktMDQtMjIgIEFs ZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdS RVNTSU9OKHIyMzA2ODEpIERvIG5vdCB1c2Ugc3RvcmVkIGNyZWRlbnRpYWxzIGlmIFdLQnVuZGxl UGFnZVJlc291cmNlTG9hZENsaWVudC5zaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZSByZXR1cm5z IGZhbHNlCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5 CShyZXZpc2lvbiAyNDQ1MjIpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv c3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTY2NSw2ICs2NjUsNyBAQCBjbGFzcyBVcGxvYWRC dWlsdFByb2R1Y3QodHJhbnNmZXIuRmlsZVVwCiAgICAgbmFtZSA9ICd1cGxvYWQtYnVpbHQtcHJv ZHVjdCcKICAgICB3b3JrZXJzcmMgPSBXaXRoUHJvcGVydGllcygnV2ViS2l0QnVpbGQvJShjb25m aWd1cmF0aW9uKXMuemlwJykKICAgICBtYXN0ZXJkZXN0ID0gV2l0aFByb3BlcnRpZXMoJ3B1Ymxp Y19odG1sL2FyY2hpdmVzLyUoZnVsbFBsYXRmb3JtKXMtJShhcmNoaXRlY3R1cmUpcy0lKGNvbmZp Z3VyYXRpb24pcy8lKHBhdGNoX2lkKXMuemlwJykKKyAgICBkZXNjcmlwdGlvbkRvbmUgPSBbJ1Vw bG9hZGVkIGJ1aWx0IHByb2R1Y3QnXQogICAgIGhhbHRPbkZhaWx1cmUgPSBUcnVlCiAKICAgICBk ZWYgX19pbml0X18oc2VsZiwgKiprd2FyZ3MpOgpAQCAtNjc0LDYgKzY3NSwxMSBAQCBjbGFzcyBV cGxvYWRCdWlsdFByb2R1Y3QodHJhbnNmZXIuRmlsZVVwCiAgICAgICAgIGt3YXJnc1snYmxvY2tz aXplJ10gPSAxMDI0ICogMjU2CiAgICAgICAgIHRyYW5zZmVyLkZpbGVVcGxvYWQuX19pbml0X18o c2VsZiwgKiprd2FyZ3MpCiAKKyAgICBkZWYgZ2V0UmVzdWx0U3VtbWFyeShzZWxmKToKKyAgICAg ICAgaWYgc2VsZi5yZXN1bHRzICE9IFNVQ0NFU1M6CisgICAgICAgICAgICByZXR1cm4ge3Unc3Rl cCc6IHUnRmFpbGVkIHRvIHVwbG9hZCBidWlsdCBwcm9kdWN0J30KKyAgICAgICAgcmV0dXJuIHN1 cGVyKFVwbG9hZEJ1aWx0UHJvZHVjdCwgc2VsZikuZ2V0UmVzdWx0U3VtbWFyeSgpCisKIAogY2xh c3MgRG93bmxvYWRCdWlsdFByb2R1Y3Qoc2hlbGwuU2hlbGxDb21tYW5kKToKICAgICBjb21tYW5k ID0gWydweXRob24nLCAnVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZG93bmxvYWQtYnVpbHQtcHJv ZHVjdCcsCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5p dHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxk L3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNDQ1MjIpCisrKyBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTg4 OSw3ICs4ODksMjggQEAgY2xhc3MgVGVzdFVwbG9hZEJ1aWx0UHJvZHVjdChCdWlsZFN0ZXBNaQog ICAgICAgICApCiAgICAgICAgIHNlbGYuZXhwZWN0VXBsb2FkZWRGaWxlKCdwdWJsaWNfaHRtbC9h cmNoaXZlcy9tYWMtc2llcnJhLXg4Nl82NC1yZWxlYXNlLzEyMzQuemlwJykKIAotICAgICAgICBz ZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0ndXBsb2FkaW5n IHJlbGVhc2UuemlwJykKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUNDRVNT LCBzdGF0ZV9zdHJpbmc9J1VwbG9hZGVkIGJ1aWx0IHByb2R1Y3QnKQorICAgICAgICByZXR1cm4g c2VsZi5ydW5TdGVwKCkKKworICAgIGRlZiB0ZXN0X2ZhaWx1cmUoc2VsZik6CisgICAgICAgIHNl bGYuc2V0dXBTdGVwKFVwbG9hZEJ1aWx0UHJvZHVjdCgpKQorICAgICAgICBzZWxmLnNldFByb3Bl cnR5KCdmdWxsUGxhdGZvcm0nLCAnbWFjLXNpZXJyYScpCisgICAgICAgIHNlbGYuc2V0UHJvcGVy dHkoJ2NvbmZpZ3VyYXRpb24nLCAncmVsZWFzZScpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHko J2FyY2hpdGVjdHVyZScsICd4ODZfNjQnKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdwYXRj aF9pZCcsICcxMjM0JykKKyAgICAgICAgc2VsZi5leHBlY3RIaWRkZW4oRmFsc2UpCisgICAgICAg IHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMoCisgICAgICAgICAgICBFeHBlY3QoJ3VwbG9hZEZp bGUnLCBkaWN0KAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHdvcmtl cnNyYz0nV2ViS2l0QnVpbGQvcmVsZWFzZS56aXAnLCB3b3JrZGlyPSd3a2RpcicsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYmxvY2tzaXplPTEwMjQgKiAyNTYsIG1h eHNpemU9Tm9uZSwga2VlcHN0YW1wPUZhbHNlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHdyaXRlcj1FeHBlY3RSZW1vdGVSZWYocmVtb3RldHJhbnNmZXIuRmlsZVdy aXRlciksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKSkKKyAgICAgICAg ICAgICsgRXhwZWN0LmJlaGF2aW9yKHVwbG9hZEZpbGVXaXRoQ29udGVudHNPZlN0cmluZygnRHVt bXkgemlwIGZpbGUgY29udGVudC4nKSkKKyAgICAgICAgICAgICsgMSwKKyAgICAgICAgKQorICAg ICAgICBzZWxmLmV4cGVjdFVwbG9hZGVkRmlsZSgncHVibGljX2h0bWwvYXJjaGl2ZXMvbWFjLXNp ZXJyYS14ODZfNjQtcmVsZWFzZS8xMjM0LnppcCcpCisKKyAgICAgICAgc2VsZi5leHBlY3RPdXRj b21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9J0ZhaWxlZCB0byB1cGxvYWQgYnVpbHQg cHJvZHVjdCcpCiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQogCiAK