197180 2019-04-22 15:53:30 -0700 [ews-build] Trigger queues only after uploading the archive 2019-04-22 17:17:17 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1529441 0 aakash_jain 2019-04-22 15:53:30 -0700 Builders should trigger tester queues only after uploading the archive. Currently the trigger step is run even if WebKit fails to compile. In that case the triggered build always fails with the error 'Downloaded built product (failure)'. This is because archive was never uploaded after WebKit failed to Compile. e.g.: https://ews-build.webkit.org/#/builders/7/builds/962 https://ews-build.webkit.org/#/builders/3/builds/871 We should triggers the testers only after the Upload step is successfully complete. 1529444 1 367989 aakash_jain 2019-04-22 16:09:34 -0700 Created attachment 367989 Patch 1529445 2 ews-watchlist 2019-04-22 16:12:07 -0700 Attachment 367989 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:46: [ConfigureBuild.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:390: [Trigger.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:697: [UploadBuiltProduct.finished] Use of super on an old style class [pylint/E1002] [5] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1529463 3 367989 lforschler 2019-04-22 16:44:28 -0700 Comment on attachment 367989 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367989&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:394 > + def propertiesToPassToTriggers(self): how about renaming this to triggerProperties? otherwise, lgtm! 1529479 4 367989 commit-queue 2019-04-22 17:16:53 -0700 Comment on attachment 367989 Patch Clearing flags on attachment: 367989 Committed r244532: <https://trac.webkit.org/changeset/244532> 1529480 5 commit-queue 2019-04-22 17:16:54 -0700 All reviewed patches have been landed. Closing bug. 1529481 6 webkit-bug-importer 2019-04-22 17:17:17 -0700 <rdar://problem/50113791> 367989 2019-04-22 16:09:34 -0700 2019-04-22 17:16:53 -0700 Patch bug-197180-20190422190933.patch text/plain 7158 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDUxNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDE5LTA0LTIyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBUcmlnZ2VyIHF1ZXVlcyBvbmx5IGFmdGVyIHVwbG9h ZGluZyB0aGUgYXJjaGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk3MTgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5OgorICAg ICAgICAoRmFjdG9yeS5fX2luaXRfXyk6CisgICAgICAgIChCdWlsZEZhY3RvcnkuX19pbml0X18p OiBSZW1vdmUgdHJpZ2dlciBzdGVwIGZyb20gZmFjdG9yaWVzLgorICAgICAgICAoQnVpbGRGYWN0 b3J5LnByb3BlcnRpZXNUb1Bhc3NUb1RyaWdnZXJzKTogRGVsZXRlZC4KKyAgICAgICAgKiBCdWls ZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChDb25maWd1cmVCdWls ZC5fX2luaXRfXyk6IENvbmZpdXJlIHRyaWdnZXJzIHByb3BlcnR5LgorICAgICAgICAoVHJpZ2dl cik6IFN0ZXAgdG8gdHJpZ2dlciBvdGhlciBxdWV1ZXMuCisgICAgICAgIChUcmlnZ2VyLnByb3Bl cnRpZXNUb1Bhc3NUb1RyaWdnZXJzKTogTWV0aG9kIHRvIGNvbnN0cnVjdCBwcm9wZXJ0aWVzIHRv IHBhc3MgdG8gdHJpZ2dlcnJlZCBidWlsZHMuCisgICAgICAgIChVcGxvYWRCdWlsdFByb2R1Y3Qu ZmluaXNoZWQpOiBUcmlnZ2VyIGJ1aWxkcyBhZnRlciB1cGxvYWQgaXMgc3VjY2Vzc2Z1bC4KKwog MjAxOS0wNC0yMiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIERl bGF5ZWQgV2ViUHJvY2Vzc0xhdW5jaCBtYXkgYnJlYWsgdGhlIF9yZWxhdGVkV2ViVmlldyBTUEkK SW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5w eQkocmV2aXNpb24gMjQ0NTE3KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxk L2ZhY3Rvcmllcy5weQkod29ya2luZyBjb3B5KQpAQCAtMjEsMTggKzIxLDE2IEBACiAjIE9GIFRI SVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBE QU1BR0UuCiAKIAotZnJvbSBidWlsZGJvdC5wcm9jZXNzIGltcG9ydCBmYWN0b3J5LCBwcm9wZXJ0 aWVzCitmcm9tIGJ1aWxkYm90LnByb2Nlc3MgaW1wb3J0IGZhY3RvcnkKIGZyb20gYnVpbGRib3Qu c3RlcHMgaW1wb3J0IHRyaWdnZXIKIAogZnJvbSBzdGVwcyBpbXBvcnQgKgogCi1Qcm9wZXJ0eSA9 IHByb3BlcnRpZXMuUHJvcGVydHkKLQogCiBjbGFzcyBGYWN0b3J5KGZhY3RvcnkuQnVpbGRGYWN0 b3J5KToKLSAgICBkZWYgX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb249Tm9u ZSwgYXJjaGl0ZWN0dXJlcz1Ob25lLCBidWlsZE9ubHk9VHJ1ZSwgYWRkaXRpb25hbEFyZ3VtZW50 cz1Ob25lLCBjaGVja1JlbGV2YW5jZT1GYWxzZSwgKiprd2FyZ3MpOgorICAgIGRlZiBfX2luaXRf XyhzZWxmLCBwbGF0Zm9ybSwgY29uZmlndXJhdGlvbj1Ob25lLCBhcmNoaXRlY3R1cmVzPU5vbmUs IGJ1aWxkT25seT1UcnVlLCB0cmlnZ2Vycz1Ob25lLCBhZGRpdGlvbmFsQXJndW1lbnRzPU5vbmUs IGNoZWNrUmVsZXZhbmNlPUZhbHNlLCAqKmt3YXJncyk6CiAgICAgICAgIGZhY3RvcnkuQnVpbGRG YWN0b3J5Ll9faW5pdF9fKHNlbGYpCi0gICAgICAgIHNlbGYuYWRkU3RlcChDb25maWd1cmVCdWls ZChwbGF0Zm9ybSwgY29uZmlndXJhdGlvbiwgYXJjaGl0ZWN0dXJlcywgYnVpbGRPbmx5LCBhZGRp dGlvbmFsQXJndW1lbnRzKSkKKyAgICAgICAgc2VsZi5hZGRTdGVwKENvbmZpZ3VyZUJ1aWxkKHBs YXRmb3JtLCBjb25maWd1cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCBidWlsZE9ubHksIHRyaWdnZXJz LCBhZGRpdGlvbmFsQXJndW1lbnRzKSkKICAgICAgICAgaWYgY2hlY2tSZWxldmFuY2U6CiAgICAg ICAgICAgICBzZWxmLmFkZFN0ZXAoQ2hlY2tQYXRjaFJlbGV2YW5jZSgpKQogICAgICAgICBzZWxm LmFkZFN0ZXAoVmFsaWRhdGVQYXRjaCgpKQpAQCAtNjYsMjMgKzY0LDEwIEBAIGNsYXNzIFdlYktp dFB5RmFjdG9yeShGYWN0b3J5KToKIAogCiBjbGFzcyBCdWlsZEZhY3RvcnkoRmFjdG9yeSk6Ci0g ICAgZGVmIF9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1cmF0aW9uPU5vbmUsIGFyY2hp dGVjdHVyZXM9Tm9uZSwgYWRkaXRpb25hbEFyZ3VtZW50cz1Ob25lLCB0cmlnZ2Vycz1Ob25lLCAq Kmt3YXJncyk6Ci0gICAgICAgIEZhY3RvcnkuX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZp Z3VyYXRpb24sIGFyY2hpdGVjdHVyZXMsIEZhbHNlLCBhZGRpdGlvbmFsQXJndW1lbnRzKQorICAg IGRlZiBfX2luaXRfXyhzZWxmLCBwbGF0Zm9ybSwgY29uZmlndXJhdGlvbj1Ob25lLCBhcmNoaXRl Y3R1cmVzPU5vbmUsIHRyaWdnZXJzPU5vbmUsIGFkZGl0aW9uYWxBcmd1bWVudHM9Tm9uZSwgKipr d2FyZ3MpOgorICAgICAgICBGYWN0b3J5Ll9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1 cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCBGYWxzZSwgdHJpZ2dlcnMsIGFkZGl0aW9uYWxBcmd1bWVu dHMpCiAgICAgICAgIHNlbGYuYWRkU3RlcChLaWxsT2xkUHJvY2Vzc2VzKCkpCiAgICAgICAgIHNl bGYuYWRkU3RlcChDb21waWxlV2ViS2l0KCkpCi0gICAgICAgIGlmIHRyaWdnZXJzOgotICAgICAg ICAgICAgc2VsZi5hZGRTdGVwKHRyaWdnZXIuVHJpZ2dlcihzY2hlZHVsZXJOYW1lcz10cmlnZ2Vy cywgc2V0X3Byb3BlcnRpZXM9c2VsZi5wcm9wZXJ0aWVzVG9QYXNzVG9UcmlnZ2VycygpIG9yIHt9 KSkKLQotICAgIGRlZiBwcm9wZXJ0aWVzVG9QYXNzVG9UcmlnZ2VycyhzZWxmKToKLSAgICAgICAg cmV0dXJuIHsKLSAgICAgICAgICAgICJwYXRjaF9pZCI6IFByb3BlcnR5KCJwYXRjaF9pZCIpLAot ICAgICAgICAgICAgImJ1Z19pZCI6IFByb3BlcnR5KCJidWdfaWQiKSwKLSAgICAgICAgICAgICJj b25maWd1cmF0aW9uIjogUHJvcGVydHkoImNvbmZpZ3VyYXRpb24iKSwKLSAgICAgICAgICAgICJw bGF0Zm9ybSI6IFByb3BlcnR5KCJwbGF0Zm9ybSIpLAotICAgICAgICAgICAgImZ1bGxQbGF0Zm9y bSI6IFByb3BlcnR5KCJmdWxsUGxhdGZvcm0iKSwKLSAgICAgICAgICAgICJhcmNoaXRlY3R1cmUi OiBQcm9wZXJ0eSgiYXJjaGl0ZWN0dXJlIiksCi0gICAgICAgICAgICAib3duZXIiOiBQcm9wZXJ0 eSgib3duZXIiKSwKLSAgICAgICAgfQogCiAKIGNsYXNzIFRlc3RGYWN0b3J5KEZhY3RvcnkpOgpJ bmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNp b24gMjQ0NTE3KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5 CSh3b3JraW5nIGNvcHkpCkBAIC0yMyw3ICsyMyw3IEBACiBmcm9tIGJ1aWxkYm90LnBsdWdpbnMg aW1wb3J0IHN0ZXBzLCB1dGlsCiBmcm9tIGJ1aWxkYm90LnByb2Nlc3MgaW1wb3J0IGJ1aWxkc3Rl cCwgbG9nb2JzZXJ2ZXIsIHByb3BlcnRpZXMKIGZyb20gYnVpbGRib3QucHJvY2Vzcy5yZXN1bHRz IGltcG9ydCBSZXN1bHRzLCBTVUNDRVNTLCBGQUlMVVJFLCBXQVJOSU5HUywgU0tJUFBFRCwgRVhD RVBUSU9OLCBSRVRSWQotZnJvbSBidWlsZGJvdC5zdGVwcyBpbXBvcnQgbWFzdGVyLCBzaGVsbCwg dHJhbnNmZXIKK2Zyb20gYnVpbGRib3Quc3RlcHMgaW1wb3J0IG1hc3Rlciwgc2hlbGwsIHRyYW5z ZmVyLCB0cmlnZ2VyCiBmcm9tIGJ1aWxkYm90LnN0ZXBzLnNvdXJjZSBpbXBvcnQgZ2l0CiBmcm9t IGJ1aWxkYm90LnN0ZXBzLndvcmtlciBpbXBvcnQgQ29tcG9zaXRlU3RlcE1peGluCiBmcm9tIHR3 aXN0ZWQuaW50ZXJuZXQgaW1wb3J0IGRlZmVyCkBAIC00Myw3ICs0Myw3IEBAIGNsYXNzIENvbmZp Z3VyZUJ1aWxkKGJ1aWxkc3RlcC5CdWlsZFN0ZXAKICAgICBkZXNjcmlwdGlvbiA9IFsiY29uZmln dXJpbmcgYnVpbGQiXQogICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsiQ29uZmlndXJlZCBidWlsZCJd CiAKLSAgICBkZWYgX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb24sIGFyY2hp dGVjdHVyZXMsIGJ1aWxkT25seSwgYWRkaXRpb25hbEFyZ3VtZW50cyk6CisgICAgZGVmIF9faW5p dF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCBidWlsZE9u bHksIHRyaWdnZXJzLCBhZGRpdGlvbmFsQXJndW1lbnRzKToKICAgICAgICAgc3VwZXIoQ29uZmln dXJlQnVpbGQsIHNlbGYpLl9faW5pdF9fKCkKICAgICAgICAgc2VsZi5wbGF0Zm9ybSA9IHBsYXRm b3JtCiAgICAgICAgIGlmIHBsYXRmb3JtICE9ICdqc2Mtb25seSc6CkBAIC01Miw2ICs1Miw3IEBA IGNsYXNzIENvbmZpZ3VyZUJ1aWxkKGJ1aWxkc3RlcC5CdWlsZFN0ZXAKICAgICAgICAgc2VsZi5j b25maWd1cmF0aW9uID0gY29uZmlndXJhdGlvbgogICAgICAgICBzZWxmLmFyY2hpdGVjdHVyZSA9 ICIgIi5qb2luKGFyY2hpdGVjdHVyZXMpIGlmIGFyY2hpdGVjdHVyZXMgZWxzZSBOb25lCiAgICAg ICAgIHNlbGYuYnVpbGRPbmx5ID0gYnVpbGRPbmx5CisgICAgICAgIHNlbGYudHJpZ2dlcnMgPSB0 cmlnZ2VycwogICAgICAgICBzZWxmLmFkZGl0aW9uYWxBcmd1bWVudHMgPSBhZGRpdGlvbmFsQXJn dW1lbnRzCiAKICAgICBkZWYgc3RhcnQoc2VsZik6CkBAIC02NSw2ICs2Niw4IEBAIGNsYXNzIENv bmZpZ3VyZUJ1aWxkKGJ1aWxkc3RlcC5CdWlsZFN0ZXAKICAgICAgICAgICAgIHNlbGYuc2V0UHJv cGVydHkoJ2FyY2hpdGVjdHVyZScsIHNlbGYuYXJjaGl0ZWN0dXJlLCAnY29uZmlnLmpzb24nKQog ICAgICAgICBpZiBzZWxmLmJ1aWxkT25seToKICAgICAgICAgICAgIHNlbGYuc2V0UHJvcGVydHko ImJ1aWxkT25seSIsIHNlbGYuYnVpbGRPbmx5LCAnY29uZmlnLmpzb24nKQorICAgICAgICBpZiBz ZWxmLnRyaWdnZXJzOgorICAgICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgndHJpZ2dlcnMnLCBz ZWxmLnRyaWdnZXJzLCAnY29uZmlnLmpzb24nKQogICAgICAgICBpZiBzZWxmLmFkZGl0aW9uYWxB cmd1bWVudHM6CiAgICAgICAgICAgICBzZWxmLnNldFByb3BlcnR5KCJhZGRpdGlvbmFsQXJndW1l bnRzIiwgc2VsZi5hZGRpdGlvbmFsQXJndW1lbnRzLCAnY29uZmlnLmpzb24nKQogCkBAIC0zODMs NiArMzg2LDIzIEBAIGNsYXNzIFVuQXBwbHlQYXRjaElmUmVxdWlyZWQoQ2xlYW5Xb3JraW4KICAg ICAgICAgcmV0dXJuIG5vdCBzZWxmLmRvU3RlcElmKHN0ZXApCiAKIAorY2xhc3MgVHJpZ2dlcih0 cmlnZ2VyLlRyaWdnZXIpOgorICAgIGRlZiBfX2luaXRfXyhzZWxmLCBzY2hlZHVsZXJOYW1lcywg Kiprd2FyZ3MpOgorICAgICAgICBzZXRfcHJvcGVydGllcyA9IHNlbGYucHJvcGVydGllc1RvUGFz c1RvVHJpZ2dlcnMoKSBvciB7fQorICAgICAgICBzdXBlcihUcmlnZ2VyLCBzZWxmKS5fX2luaXRf XyhzY2hlZHVsZXJOYW1lcz1zY2hlZHVsZXJOYW1lcywgc2V0X3Byb3BlcnRpZXM9c2V0X3Byb3Bl cnRpZXMsICoqa3dhcmdzKQorCisgICAgZGVmIHByb3BlcnRpZXNUb1Bhc3NUb1RyaWdnZXJzKHNl bGYpOgorICAgICAgICByZXR1cm4geworICAgICAgICAgICAgJ3BhdGNoX2lkJzogcHJvcGVydGll cy5Qcm9wZXJ0eSgncGF0Y2hfaWQnKSwKKyAgICAgICAgICAgICdidWdfaWQnOiBwcm9wZXJ0aWVz LlByb3BlcnR5KCdidWdfaWQnKSwKKyAgICAgICAgICAgICdjb25maWd1cmF0aW9uJzogcHJvcGVy dGllcy5Qcm9wZXJ0eSgnY29uZmlndXJhdGlvbicpLAorICAgICAgICAgICAgJ3BsYXRmb3JtJzog cHJvcGVydGllcy5Qcm9wZXJ0eSgncGxhdGZvcm0nKSwKKyAgICAgICAgICAgICdmdWxsUGxhdGZv cm0nOiBwcm9wZXJ0aWVzLlByb3BlcnR5KCdmdWxsUGxhdGZvcm0nKSwKKyAgICAgICAgICAgICdh cmNoaXRlY3R1cmUnOiBwcm9wZXJ0aWVzLlByb3BlcnR5KCdhcmNoaXRlY3R1cmUnKSwKKyAgICAg ICAgICAgICdvd25lcic6IHByb3BlcnRpZXMuUHJvcGVydHkoJ293bmVyJyksCisgICAgICAgIH0K KworCiBjbGFzcyBUZXN0V2l0aEZhaWx1cmVDb3VudChzaGVsbC5UZXN0KToKICAgICBmYWlsZWRU ZXN0c0Zvcm1hdFN0cmluZyA9ICIlZCB0ZXN0JXMgZmFpbGVkIgogICAgIGZhaWxlZFRlc3RDb3Vu dCA9IDAKQEAgLTY3NCw2ICs2OTQsMTQgQEAgY2xhc3MgVXBsb2FkQnVpbHRQcm9kdWN0KHRyYW5z ZmVyLkZpbGVVcAogICAgICAgICBrd2FyZ3NbJ2Jsb2Nrc2l6ZSddID0gMTAyNCAqIDI1NgogICAg ICAgICB0cmFuc2Zlci5GaWxlVXBsb2FkLl9faW5pdF9fKHNlbGYsICoqa3dhcmdzKQogCisgICAg ZGVmIGZpbmlzaGVkKHNlbGYsIHJlc3VsdHMpOgorICAgICAgICBpZiByZXN1bHRzID09IFNVQ0NF U1M6CisgICAgICAgICAgICB0cmlnZ2VycyA9IHNlbGYuZ2V0UHJvcGVydHkoJ3RyaWdnZXJzJywg Tm9uZSkKKyAgICAgICAgICAgIGlmIHRyaWdnZXJzOgorICAgICAgICAgICAgICAgIHNlbGYuYnVp bGQuYWRkU3RlcHNBZnRlckN1cnJlbnRTdGVwKFtUcmlnZ2VyKHNjaGVkdWxlck5hbWVzPXRyaWdn ZXJzKV0pCisKKyAgICAgICAgcmV0dXJuIHN1cGVyKFVwbG9hZEJ1aWx0UHJvZHVjdCwgc2VsZiku ZmluaXNoZWQocmVzdWx0cykKKwogCiBjbGFzcyBEb3dubG9hZEJ1aWx0UHJvZHVjdChzaGVsbC5T aGVsbENvbW1hbmQpOgogICAgIGNvbW1hbmQgPSBbJ3B5dGhvbicsICdUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9kb3dubG9hZC1idWlsdC1wcm9kdWN0JywK