19718 2008-06-22 18:58:55 -0700 Named anonymous functions are slow accessing global variables 2008-07-25 20:53:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy webkit-unassigned oldest_to_newest 84104 0 timothy 2008-06-22 18:58:55 -0700 A named anonymous function that accesses a global or closure scope variable is slower than a non-named anonymous function. See the attached test case. This is a regression since SquirrelFish. 84105 1 21876 timothy 2008-06-22 18:59:28 -0700 Created attachment 21876 Testcase 84174 2 ggaren 2008-06-23 12:49:51 -0700 Can you give more data on the SquirrelFish regression: * Is access to a global from a named anonymous function slower in SF than it was before SF? * How big (%) is the regression? The cause of the relative slowness is that, according to the spec, a named anonymous function should have a vanilla (i.e. unoptimized) object inserted into its scope chain, with one property: the function's name. We can / should improve this situation, but that's how things are implemented today (and how they've always been implemented). 84178 3 timothy 2008-06-23 13:16:54 -0700 It is not a regression, since SquirrelFish is faster than Safari 3.1. But there is now a difference in speed between named anonymous functions and non-named anonymous function that didn't exist in Safari 3.1. 86991 4 oliver 2008-07-25 20:53:50 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/GNUmakefile.am M JavaScriptCore/JavaScriptCore.pri M JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj M JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M JavaScriptCore/VM/CodeGenerator.cpp M JavaScriptCore/VM/CodeGenerator.h M JavaScriptCore/kjs/AllInOneFile.cpp A JavaScriptCore/kjs/JSStaticScopeObject.cpp A JavaScriptCore/kjs/JSStaticScopeObject.h M JavaScriptCore/kjs/nodes.cpp M LayoutTests/ChangeLog M LayoutTests/fast/js/const-expected.txt M LayoutTests/fast/js/resources/const.js Committed r35368 21876 2008-06-22 18:59:28 -0700 2008-06-22 18:59:28 -0700 Testcase Test.html text/html 393 timothy PHNjcmlwdD4KCnZhciBqID0gMTsKCnZhciBnID0gZnVuY3Rpb24gaCgpIHsKCXZhciB0aW1lU3Rh bXAgPSBuZXcgRGF0ZSgpOwoJZm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwMDA7ICsraSkKCQlqKys7 CglhbGVydCgiZzogIiArIChuZXcgRGF0ZSgpIC0gdGltZVN0YW1wKSk7Cn0KCnZhciBnMSA9IGZ1 bmN0aW9uKCkgewoJdmFyIHRpbWVTdGFtcCA9IG5ldyBEYXRlKCk7Cglmb3IgKHZhciBpID0gMDsg aSA8IDEwMDAwMDsgKytpKQoJCWorKzsKCWFsZXJ0KCJnMTogIiArIChuZXcgRGF0ZSgpIC0gdGlt ZVN0YW1wKSk7Cn0KCmcoKTsKZzEoKTsKCjwvc2NyaXB0PgoKZygpIHNob3VsZCBiZSBhcyBmYXN0 IGFzIGcxKCkuIEJ1dCBnKCkgdXNlcyBhIG5hbWVkIGFub255bW91cyBmdW5jdGlvbi4K