197169 2019-04-22 11:19:20 -0700 Deprecate WKContextCreateWithInjectedBundlePath 2019-04-29 21:44:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez commit-queue thorton webkit-bug-importer youennf oldest_to_newest 1529310 0 achristensen 2019-04-22 11:19:20 -0700 Deprecate WKContextCreateWithInjectedBundlePath 1529312 1 367955 achristensen 2019-04-22 11:20:58 -0700 Created attachment 367955 Patch 1529403 2 367955 youennf 2019-04-22 14:47:48 -0700 Comment on attachment 367955 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367955&action=review > Source/WebKit/UIProcess/API/C/WKContext.h:110 > +WK_EXPORT WKContextRef WKContextCreateWithInjectedBundlePath(WKStringRef path) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKContextCreateWithConfiguration); Should we also remove our internal use of WKContextCreateWithInjectedBundlePath in API tests? 1529405 3 achristensen 2019-04-22 14:50:27 -0700 Good catch. I'll do that, too. 1529458 4 367994 achristensen 2019-04-22 16:32:04 -0700 Created attachment 367994 Patch 1529476 5 367994 commit-queue 2019-04-22 17:15:09 -0700 Comment on attachment 367994 Patch Clearing flags on attachment: 367994 Committed r244529: <https://trac.webkit.org/changeset/244529> 1529477 6 commit-queue 2019-04-22 17:15:11 -0700 All reviewed patches have been landed. Closing bug. 1529478 7 webkit-bug-importer 2019-04-22 17:16:14 -0700 <rdar://problem/50113767> 1531426 8 achristensen 2019-04-29 21:44:24 -0700 See rdar://problem/50323967 367955 2019-04-22 11:20:58 -0700 2019-04-22 16:32:03 -0700 Patch bug-197169-20190422112058.patch text/plain 1460 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQ1MDMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA0LTIyICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRGVwcmVjYXRlIFdL Q29udGV4dENyZWF0ZVdpdGhJbmplY3RlZEJ1bmRsZVBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzE2OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5o OgorCiAyMDE5LTA0LTIyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgRGVsYXllZCBXZWJQcm9jZXNzTGF1bmNoIG1heSBicmVhayB0aGUgX3JlbGF0ZWRXZWJWaWV3 IFNQSQpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmgJKHJl dmlzaW9uIDI0NDQ5OSkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4 dC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDcsNyArMTA3LDcgQEAgdHlwZWRlZiB1aW50MzJfdCBX S1N0YXRpc3RpY3NPcHRpb25zOwogV0tfRVhQT1JUIFdLVHlwZUlEIFdLQ29udGV4dEdldFR5cGVJ RCgpOwogCiBXS19FWFBPUlQgV0tDb250ZXh0UmVmIFdLQ29udGV4dENyZWF0ZSgpIFdLX0NfQVBJ X0RFUFJFQ0FURURfV0lUSF9SRVBMQUNFTUVOVChXS0NvbnRleHRDcmVhdGVXaXRoQ29uZmlndXJh dGlvbik7Ci1XS19FWFBPUlQgV0tDb250ZXh0UmVmIFdLQ29udGV4dENyZWF0ZVdpdGhJbmplY3Rl ZEJ1bmRsZVBhdGgoV0tTdHJpbmdSZWYgcGF0aCk7CitXS19FWFBPUlQgV0tDb250ZXh0UmVmIFdL Q29udGV4dENyZWF0ZVdpdGhJbmplY3RlZEJ1bmRsZVBhdGgoV0tTdHJpbmdSZWYgcGF0aCkgV0tf Q19BUElfREVQUkVDQVRFRF9XSVRIX1JFUExBQ0VNRU5UKFdLQ29udGV4dENyZWF0ZVdpdGhDb25m aWd1cmF0aW9uKTsKIFdLX0VYUE9SVCBXS0NvbnRleHRSZWYgV0tDb250ZXh0Q3JlYXRlV2l0aENv bmZpZ3VyYXRpb24oV0tDb250ZXh0Q29uZmlndXJhdGlvblJlZiBjb25maWd1cmF0aW9uKTsKIAog V0tfRVhQT1JUIHZvaWQgV0tDb250ZXh0U2V0Q2xpZW50KFdLQ29udGV4dFJlZiBjb250ZXh0LCBj b25zdCBXS0NvbnRleHRDbGllbnRCYXNlKiBjbGllbnQpOwo= 367994 2019-04-22 16:32:04 -0700 2019-04-22 17:15:09 -0700 Patch bug-197169-20190422163204.patch text/plain 3442 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQ1MjEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA0LTIyICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRGVwcmVjYXRlIFdL Q29udGV4dENyZWF0ZVdpdGhJbmplY3RlZEJ1bmRsZVBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzE2OQorCisgICAgICAgIFJldmlld2VkIGJ5 IFlvdWVubiBGYWJsZXQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0Lmg6 CisKIDIwMTktMDQtMjIgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9y Zz4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyMzA2ODEpIERvIG5vdCB1c2Ugc3RvcmVkIGNyZWRl bnRpYWxzIGlmIFdLQnVuZGxlUGFnZVJlc291cmNlTG9hZENsaWVudC5zaG91bGRVc2VDcmVkZW50 aWFsU3RvcmFnZSByZXR1cm5zIGZhbHNlCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvQy9XS0NvbnRleHQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvQy9XS0NvbnRleHQuaAkocmV2aXNpb24gMjQ0NTIxKQorKysgU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL0MvV0tDb250ZXh0LmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNyw3ICsxMDcsNyBA QCB0eXBlZGVmIHVpbnQzMl90IFdLU3RhdGlzdGljc09wdGlvbnM7CiBXS19FWFBPUlQgV0tUeXBl SUQgV0tDb250ZXh0R2V0VHlwZUlEKCk7CiAKIFdLX0VYUE9SVCBXS0NvbnRleHRSZWYgV0tDb250 ZXh0Q3JlYXRlKCkgV0tfQ19BUElfREVQUkVDQVRFRF9XSVRIX1JFUExBQ0VNRU5UKFdLQ29udGV4 dENyZWF0ZVdpdGhDb25maWd1cmF0aW9uKTsKLVdLX0VYUE9SVCBXS0NvbnRleHRSZWYgV0tDb250 ZXh0Q3JlYXRlV2l0aEluamVjdGVkQnVuZGxlUGF0aChXS1N0cmluZ1JlZiBwYXRoKTsKK1dLX0VY UE9SVCBXS0NvbnRleHRSZWYgV0tDb250ZXh0Q3JlYXRlV2l0aEluamVjdGVkQnVuZGxlUGF0aChX S1N0cmluZ1JlZiBwYXRoKSBXS19DX0FQSV9ERVBSRUNBVEVEX1dJVEhfUkVQTEFDRU1FTlQoV0tD b250ZXh0Q3JlYXRlV2l0aENvbmZpZ3VyYXRpb24pOwogV0tfRVhQT1JUIFdLQ29udGV4dFJlZiBX S0NvbnRleHRDcmVhdGVXaXRoQ29uZmlndXJhdGlvbihXS0NvbnRleHRDb25maWd1cmF0aW9uUmVm IGNvbmZpZ3VyYXRpb24pOwogCiBXS19FWFBPUlQgdm9pZCBXS0NvbnRleHRTZXRDbGllbnQoV0tD b250ZXh0UmVmIGNvbnRleHQsIGNvbnN0IFdLQ29udGV4dENsaWVudEJhc2UqIGNsaWVudCk7Cklu ZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZp c2lvbiAyNDQ1MjIpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNCBAQAorMjAxOS0wNC0yMiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJr aXQub3JnPgorCisgICAgICAgIERlcHJlY2F0ZSBXS0NvbnRleHRDcmVhdGVXaXRoSW5qZWN0ZWRC dW5kbGVQYXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTcxNjkKKworICAgICAgICBSZXZpZXdlZCBieSBZb3Vlbm4gRmFibGV0LgorCisgICAgICAg ICogVGVzdFdlYktpdEFQSS9QbGF0Zm9ybVV0aWxpdGllcy5jcHA6CisgICAgICAgIChUZXN0V2Vi S2l0QVBJOjpVdGlsOjpjcmVhdGVDb250ZXh0V2l0aEluamVjdGVkQnVuZGxlKToKKyAgICAgICAg VXNlIFdLQ29udGV4dENyZWF0ZVdpdGhDb25maWd1cmF0aW9uIGluc3RlYWQgb2YgV0tDb250ZXh0 Q3JlYXRlV2l0aEluamVjdGVkQnVuZGxlUGF0aCBhZnRlciBoYXZpbmcgc2V0IGl0cyBpbmplY3Rl ZCBidW5kbGUgcGF0aC4KKwogMjAxOS0wNC0yMiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3Rl bnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjIzMDY4MSkgRG8gbm90IHVz ZSBzdG9yZWQgY3JlZGVudGlhbHMgaWYgV0tCdW5kbGVQYWdlUmVzb3VyY2VMb2FkQ2xpZW50LnNo b3VsZFVzZUNyZWRlbnRpYWxTdG9yYWdlIHJldHVybnMgZmFsc2UKSW5kZXg6IFRvb2xzL1Rlc3RX ZWJLaXRBUEkvUGxhdGZvcm1VdGlsaXRpZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RX ZWJLaXRBUEkvUGxhdGZvcm1VdGlsaXRpZXMuY3BwCShyZXZpc2lvbiAyNDQ1MjEpCisrKyBUb29s cy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtVXRpbGl0aWVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjYsNiArMjYsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlBsYXRmb3JtVXRp bGl0aWVzLmgiCiAKKyNpbmNsdWRlIDxXZWJLaXQvV0tDb250ZXh0Q29uZmlndXJhdGlvblJlZi5o PgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KIAogbmFtZXNwYWNlIFRlc3RXZWJLaXRB UEkgewpAQCAtMzYsOSArMzcsOSBAQCBuYW1lc3BhY2UgVXRpbCB7CiBXS0NvbnRleHRSZWYgY3Jl YXRlQ29udGV4dFdpdGhJbmplY3RlZEJ1bmRsZSgpCiB7CiAgICAgV0tSZXRhaW5QdHI8V0tTdHJp bmdSZWY+IGluamVjdGVkQnVuZGxlUGF0aCA9IGFkb3B0V0soY3JlYXRlSW5qZWN0ZWRCdW5kbGVQ YXRoKCkpOwotICAgIFdLQ29udGV4dFJlZiBjb250ZXh0ID0gV0tDb250ZXh0Q3JlYXRlV2l0aElu amVjdGVkQnVuZGxlUGF0aChpbmplY3RlZEJ1bmRsZVBhdGguZ2V0KCkpOwotCi0gICAgcmV0dXJu IGNvbnRleHQ7CisgICAgYXV0byBjb25maWd1cmF0aW9uID0gYWRvcHRXSyhXS0NvbnRleHRDb25m aWd1cmF0aW9uQ3JlYXRlKCkpOworICAgIFdLQ29udGV4dENvbmZpZ3VyYXRpb25TZXRJbmplY3Rl ZEJ1bmRsZVBhdGgoY29uZmlndXJhdGlvbi5nZXQoKSwgaW5qZWN0ZWRCdW5kbGVQYXRoLmdldCgp KTsKKyAgICByZXR1cm4gV0tDb250ZXh0Q3JlYXRlV2l0aENvbmZpZ3VyYXRpb24oY29uZmlndXJh dGlvbi5nZXQoKSk7CiB9CiAKIFdLRGljdGlvbmFyeVJlZiBjcmVhdGVJbml0aWFsaXphdGlvbkRp Y3Rpb25hcnlGb3JJbmplY3RlZEJ1bmRsZVRlc3QoY29uc3Qgc3RkOjpzdHJpbmcmIHRlc3ROYW1l LCBXS1R5cGVSZWYgdXNlckRhdGEpCg==