197163 2019-04-22 09:53:29 -0700 [GLib] Remove unused MainThreadSharedTimer RunLoopSourcePriority value 2019-07-31 08:41:07 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 zan zan benjamin cdumez cgarcia cmarcelo dbates ews-watchlist oldest_to_newest 1529276 0 zan 2019-04-22 09:53:29 -0700 [GLib] Remove unused MainThreadSharedTimer RunLoopSourcePriority value 1529277 1 367946 zan 2019-04-22 09:54:40 -0700 Created attachment 367946 Patch 1529549 2 367946 cgarcia 2019-04-23 03:15:13 -0700 Comment on attachment 367946 Patch I think this is actually a typo in Source/WTF/wtf/generic/MainThreadGeneric.cpp, it should use MainThreadSharedTimer instead of MainThreadDispatcherTimer. It doesn't matter because we use the same priority but we might change it in the future. MainThreadDispatcherTimer is the priority for timers used to send tasks to the main thread run loop like callOnMainThread(). 1533338 3 367946 zan 2019-05-06 00:44:32 -0700 Comment on attachment 367946 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367946&action=review > Source/WTF/wtf/glib/RunLoopSourcePriority.h:-58 > - // WebCore timers. > - MainThreadSharedTimer = 100, Per this comment, MainThreadSharedTimer priority should be used in the WebCore::MainThreadSharedTimer class. 1533342 4 zan 2019-05-06 00:49:03 -0700 Continued in bug #197606. 367946 2019-04-22 09:54:40 -0700 2019-07-31 08:41:07 -0700 Patch bug-197163-20190422185439.patch text/plain 1579 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDExOGUyYjE0NDM3OWExNjNhMWU5ZDg5 ZWI1MjA1NjFmMTI2NTNlYzEuLjA0NDlhZWJiMDE1ZWMzMmI3ZmIyZGQzNTdiM2Y2MGQ5MjRkNjVi NWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDQtMjIgIFphbiBEb2JlcnNlayAgPHpkb2Jl cnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHTGliXSBSZW1vdmUgdW51c2VkIE1haW5UaHJl YWRTaGFyZWRUaW1lciBSdW5Mb29wU291cmNlUHJpb3JpdHkgdmFsdWUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzE2MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL2dsaWIvUnVuTG9vcFNvdXJj ZVByaW9yaXR5Lmg6IFRoZSBNYWluVGhyZWFkU2hhcmVkVGltZXIgcHJpb3JpdHkKKyAgICAgICAg dmFsdWUgY2FuIGJlIHJlbW92ZWQgYXMgaXQncyBub3QgdXNlZCBhbnl3aGVyZS4KKwogMjAxOS0w NC0yMSAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dU Rl0gR2VuZXJpYyBtZW1vcnlGb290cHJpbnQoKSBpbXBsZW1lbnRhdGlvbiBzaG91bGQgdXNlIGJt YWxsb2Mgb24gTGludXgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL2dsaWIvUnVuTG9vcFNv dXJjZVByaW9yaXR5LmggYi9Tb3VyY2UvV1RGL3d0Zi9nbGliL1J1bkxvb3BTb3VyY2VQcmlvcml0 eS5oCmluZGV4IDcxMjdhNGU3NTlkOGM4MDA3ZWQxMWRiNmFiNjE4M2QxNTk1N2ZmMDMuLjI2YmFi NWZjYzNjNzQ5NTU5Y2YyYzA0NjA4NzcyNzIyMjk0OGQxMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X VEYvd3RmL2dsaWIvUnVuTG9vcFNvdXJjZVByaW9yaXR5LmgKKysrIGIvU291cmNlL1dURi93dGYv Z2xpYi9SdW5Mb29wU291cmNlUHJpb3JpdHkuaApAQCAtNTQsOSArNTQsNiBAQCBlbnVtIFJ1bkxv b3BTb3VyY2VQcmlvcml0eSB7CiAgICAgLy8gTWVtb3J5IHByZXNzdXJlIG1vbml0b3IuCiAgICAg TWVtb3J5UHJlc3N1cmVIYW5kbGVyVGltZXIgPSAtMTAwLAogCi0gICAgLy8gV2ViQ29yZSB0aW1l cnMuCi0gICAgTWFpblRocmVhZFNoYXJlZFRpbWVyID0gMTAwLAotCiAgICAgLy8gVXNlZCBmb3Ig dGltZXJzIHRoYXQgZGlzY2FyZCByZXNvdXJjZXMgbGlrZSBiYWNraW5nIHN0b3JlLCBidWZmZXJz LCBldGMuCiAgICAgUmVsZWFzZVVudXNlZFJlc291cmNlc1RpbWVyID0gMjAwLAogCkBAIC05Myw3 ICs5MCw2IEBAIGVudW0gUnVuTG9vcFNvdXJjZVByaW9yaXR5IHsKICAgICBNZW1vcnlQcmVzc3Vy ZUhhbmRsZXJUaW1lciA9IC04MCwKIAogICAgIEphdmFzY3JpcHRUaW1lciA9IC02MCwKLSAgICBN YWluVGhyZWFkU2hhcmVkVGltZXIgPSAtNjAsCiAKICAgICBMYXllckZsdXNoVGltZXIgPSAtNzAs CiAgICAgRGlzcGxheVJlZnJlc2hNb25pdG9yVGltZXIgPSAtNzAsCg==