197156 2019-04-22 03:57:42 -0700 [GTK] MiniBrowser: also set the passed bg-color when receiving arguments 2019-04-24 00:55:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196912 Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply ews-watchlist lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1529216 0 cgarcia 2019-04-22 03:57:42 -0700 The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs support was added. 1529218 1 367935 cgarcia 2019-04-22 04:07:07 -0700 Created attachment 367935 Patch 1529219 2 ews-watchlist 2019-04-22 04:08:55 -0700 Attachment 367935 did not pass style-queue: ERROR: Tools/MiniBrowser/gtk/BrowserTab.h:57: browser_tab_set_background_color is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/MiniBrowser/gtk/BrowserTab.c:607: browser_tab_set_background_color is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1529252 3 mcatanzaro 2019-04-22 08:58:39 -0700 Please add these files to the style checker whitelist. 1529920 4 cgarcia 2019-04-24 00:54:04 -0700 Committed r244583: <https://trac.webkit.org/changeset/244583> 1529921 5 webkit-bug-importer 2019-04-24 00:55:18 -0700 <rdar://problem/50159645> 367935 2019-04-22 04:07:07 -0700 2019-04-22 08:59:47 -0700 Patch mb-bg-color.diff text/plain 5796 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkYTg3 ZjVlYmIyZC4uYzA3ZTEyZWQxZmMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxOS0wNC0yMiAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gTWluaUJyb3dz ZXI6IGFsc28gc2V0IHRoZSBwYXNzZWQgYmctY29sb3Igd2hlbiByZWNlaXZpbmcgYXJndW1lbnRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcxNTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYmFj a2dyb3VuZCBjb2xvciBpcyBvbmx5IHNldCB3aGVuIE1pbmlCcm93c2VyIGlzIGxhdW5jaGVkIHdp dGhvdXQgYXJndW1lbnRzLiBUaGlzIHJlZ3Jlc3NlZCB3aGVuIHRhYnMKKyAgICAgICAgc3VwcG9y dCB3YXMgYWRkZWQuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9ndGsvQnJvd3NlclRhYi5jOgor ICAgICAgICAoYnJvd3Nlcl90YWJfc2V0X2JhY2tncm91bmRfY29sb3IpOiBTZXQgdGhlIHBhc3Nl ZCBpbiBjb2xvciBhcyB3ZWIgdmlldyBiYWNrZ3JvdW5kIGNvbG9yLgorICAgICAgICAqIE1pbmlC cm93c2VyL2d0ay9Ccm93c2VyVGFiLmg6CisgICAgICAgICogTWluaUJyb3dzZXIvZ3RrL0Jyb3dz ZXJXaW5kb3cuYzoKKyAgICAgICAgKGJyb3dzZXJfd2luZG93X2luaXQpOiBJbml0aWFsaXplIGJh Y2tncm91bmRDb2xvci4KKyAgICAgICAgKGJyb3dzZXJfd2luZG93X2FwcGVuZF92aWV3KTogQ2Fs bCBicm93c2VyX3RhYl9zZXRfYmFja2dyb3VuZF9jb2xvcigpLgorICAgICAgICAoYnJvd3Nlcl93 aW5kb3dfc2V0X2JhY2tncm91bmRfY29sb3IpOiBTYXZlIHRoZSBwYXNzZWQgaW4gY29sb3IuIFRo aXMgZnVuY3Rpb24gc2hvdWxkIG5vdyBiZSBjYWxsZWQgYmVmb3JlIHRhYnMKKyAgICAgICAgYXJl IGFkZGVkLgorICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9tYWluLmM6CisgICAgICAgIChtYWlu KTogQ2FsbCBicm93c2VyX3dpbmRvd19zZXRfYmFja2dyb3VuZF9jb2xvcigpIGJlZm9yZSBjcmVh dGluZyB0aGUgdGFicy4KKwogMjAxOS0wNC0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0FUS10gSW1wbGVtZW50IEF0a0NvbXBvbmVudElm YWNlIHNjcm9sbF90byBtZXRob2RzCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsv QnJvd3NlclRhYi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJUYWIuYwppbmRleCA0 ZWZjNjMzMTE0Yy4uMjllY2FlOWViZmUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0 ay9Ccm93c2VyVGFiLmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJUYWIuYwpA QCAtNjAzLDMgKzYwMywxNiBAQCB2b2lkIGJyb3dzZXJfdGFiX2xlYXZlX2Z1bGxzY3JlZW4oQnJv d3NlclRhYiAqdGFiKQogICAgICAgICBndGtfd2luZG93X3NldF9mb2N1cyh3aW5kb3csIGZvY3Vz V2lkZ2V0KTsKICAgICB9CiB9CisKK3ZvaWQgYnJvd3Nlcl90YWJfc2V0X2JhY2tncm91bmRfY29s b3IoQnJvd3NlclRhYiAqdGFiLCBHZGtSR0JBICpyZ2JhKQoreworICAgIGdfcmV0dXJuX2lmX2Zh aWwoQlJPV1NFUl9JU19UQUIodGFiKSk7CisgICAgZ19yZXR1cm5faWZfZmFpbChyZ2JhKTsKKwor ICAgIEdka1JHQkEgdmlld1JHQkE7CisgICAgd2Via2l0X3dlYl92aWV3X2dldF9iYWNrZ3JvdW5k X2NvbG9yKHRhYi0+d2ViVmlldywgJnZpZXdSR0JBKTsKKyAgICBpZiAoZ2RrX3JnYmFfZXF1YWwo cmdiYSwgJnZpZXdSR0JBKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgd2Via2l0X3dlYl92aWV3 X3NldF9iYWNrZ3JvdW5kX2NvbG9yKHRhYi0+d2ViVmlldywgcmdiYSk7Cit9CmRpZmYgLS1naXQg YS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlclRhYi5oIGIvVG9vbHMvTWluaUJyb3dzZXIv Z3RrL0Jyb3dzZXJUYWIuaAppbmRleCA5ZDU3Mjc1OTE3Zi4uZDQ1NTczNzQxNWMgMTAwNjQ0Ci0t LSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyVGFiLmgKKysrIGIvVG9vbHMvTWluaUJy b3dzZXIvZ3RrL0Jyb3dzZXJUYWIuaApAQCAtNTQsNiArNTQsNyBAQCB2b2lkIGJyb3dzZXJfdGFi X3N0b3Bfc2VhcmNoKEJyb3dzZXJUYWIqKTsKIHZvaWQgYnJvd3Nlcl90YWJfYWRkX2FjY2VsZXJh dG9ycyhCcm93c2VyVGFiKiwgR3RrQWNjZWxHcm91cCopOwogdm9pZCBicm93c2VyX3RhYl9lbnRl cl9mdWxsc2NyZWVuKEJyb3dzZXJUYWIqKTsKIHZvaWQgYnJvd3Nlcl90YWJfbGVhdmVfZnVsbHNj cmVlbihCcm93c2VyVGFiKik7Cit2b2lkIGJyb3dzZXJfdGFiX3NldF9iYWNrZ3JvdW5kX2NvbG9y KEJyb3dzZXJUYWIqLCBHZGtSR0JBKik7CiAKIEdfRU5EX0RFQ0xTCiAKZGlmZiAtLWdpdCBhL1Rv b2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMgYi9Ub29scy9NaW5pQnJvd3Nlci9n dGsvQnJvd3NlcldpbmRvdy5jCmluZGV4IGQ1NTk4MzUxZGUyLi40Y2RhNWVkYTAzYiAxMDA2NDQK LS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYworKysgYi9Ub29scy9N aW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCkBAIC02NSw2ICs2NSw3IEBAIHN0cnVjdCBf QnJvd3NlcldpbmRvdyB7CiAgICAgR3RrV2luZG93ICpwYXJlbnRXaW5kb3c7CiAgICAgZ3VpbnQg cmVzZXRFbnRyeVByb2dyZXNzVGltZW91dElkOwogICAgIGdjaGFyICpzZXNzaW9uRmlsZTsKKyAg ICBHZGtSR0JBIGJhY2tncm91bmRDb2xvcjsKIH07CiAKIHN0cnVjdCBfQnJvd3NlcldpbmRvd0Ns YXNzIHsKQEAgLTkxNyw2ICs5MTgsOSBAQCBzdGF0aWMgdm9pZCBicm93c2VyX3dpbmRvd19pbml0 KEJyb3dzZXJXaW5kb3cgKndpbmRvdykKIHsKICAgICB3aW5kb3dMaXN0ID0gZ19saXN0X2FwcGVu ZCh3aW5kb3dMaXN0LCB3aW5kb3cpOwogCisgICAgd2luZG93LT5iYWNrZ3JvdW5kQ29sb3IucmVk ID0gd2luZG93LT5iYWNrZ3JvdW5kQ29sb3IuZ3JlZW4gPSB3aW5kb3ctPmJhY2tncm91bmRDb2xv ci5ibHVlID0gMjU1OworICAgIHdpbmRvdy0+YmFja2dyb3VuZENvbG9yLmFscGhhID0gMTsKKwog ICAgIGd0a193aW5kb3dfc2V0X3RpdGxlKEdUS19XSU5ET1cod2luZG93KSwgZGVmYXVsdFdpbmRv d1RpdGxlKTsKICAgICBndGtfd2luZG93X3NldF9kZWZhdWx0X3NpemUoR1RLX1dJTkRPVyh3aW5k b3cpLCA4MDAsIDYwMCk7CiAKQEAgLTExNTUsNiArMTE1OSw4IEBAIHZvaWQgYnJvd3Nlcl93aW5k b3dfYXBwZW5kX3ZpZXcoQnJvd3NlcldpbmRvdyAqd2luZG93LCBXZWJLaXRXZWJWaWV3ICp3ZWJW aWV3KQogICAgIH0KIAogICAgIEd0a1dpZGdldCAqdGFiID0gYnJvd3Nlcl90YWJfbmV3KHdlYlZp ZXcpOworICAgIGlmIChndGtfd2lkZ2V0X2dldF9hcHBfcGFpbnRhYmxlKEdUS19XSURHRVQod2lu ZG93KSkpCisgICAgICAgIGJyb3dzZXJfdGFiX3NldF9iYWNrZ3JvdW5kX2NvbG9yKEJST1dTRVJf VEFCKHRhYiksICZ3aW5kb3ctPmJhY2tncm91bmRDb2xvcik7CiAgICAgYnJvd3Nlcl90YWJfYWRk X2FjY2VsZXJhdG9ycyhCUk9XU0VSX1RBQih0YWIpLCB3aW5kb3ctPmFjY2VsR3JvdXApOwogICAg IGd0a19ub3RlYm9va19hcHBlbmRfcGFnZShHVEtfTk9URUJPT0sod2luZG93LT5ub3RlYm9vayks IHRhYiwgYnJvd3Nlcl90YWJfZ2V0X3RpdGxlX3dpZGdldChCUk9XU0VSX1RBQih0YWIpKSk7CiAg ICAgZ3RrX2NvbnRhaW5lcl9jaGlsZF9zZXQoR1RLX0NPTlRBSU5FUih3aW5kb3ctPm5vdGVib29r KSwgdGFiLCAidGFiLWV4cGFuZCIsIFRSVUUsIE5VTEwpOwpAQCAtMTIwMywyMCArMTIwOSwxOSBA QCB2b2lkIGJyb3dzZXJfd2luZG93X3NldF9iYWNrZ3JvdW5kX2NvbG9yKEJyb3dzZXJXaW5kb3cg KndpbmRvdywgR2RrUkdCQSAqcmdiYSkKICAgICBnX3JldHVybl9pZl9mYWlsKEJST1dTRVJfSVNf V0lORE9XKHdpbmRvdykpOwogICAgIGdfcmV0dXJuX2lmX2ZhaWwocmdiYSk7CiAKLSAgICBXZWJL aXRXZWJWaWV3ICp3ZWJWaWV3ID0gYnJvd3Nlcl90YWJfZ2V0X3dlYl92aWV3KHdpbmRvdy0+YWN0 aXZlVGFiKTsKLSAgICBHZGtSR0JBIHZpZXdSR0JBOwotICAgIHdlYmtpdF93ZWJfdmlld19nZXRf YmFja2dyb3VuZF9jb2xvcih3ZWJWaWV3LCAmdmlld1JHQkEpOwotICAgIGlmIChnZGtfcmdiYV9l cXVhbChyZ2JhLCAmdmlld1JHQkEpKQorICAgIGdfYXNzZXJ0KCF3aW5kb3ctPmFjdGl2ZVRhYik7 CisKKyAgICBpZiAoZ2RrX3JnYmFfZXF1YWwocmdiYSwgJndpbmRvdy0+YmFja2dyb3VuZENvbG9y KSkKICAgICAgICAgcmV0dXJuOwogCisgICAgd2luZG93LT5iYWNrZ3JvdW5kQ29sb3IgPSAqcmdi YTsKKwogICAgIEdka1Zpc3VhbCAqcmdiYVZpc3VhbCA9IGdka19zY3JlZW5fZ2V0X3JnYmFfdmlz dWFsKGd0a193aW5kb3dfZ2V0X3NjcmVlbihHVEtfV0lORE9XKHdpbmRvdykpKTsKICAgICBpZiAo IXJnYmFWaXN1YWwpCiAgICAgICAgIHJldHVybjsKIAogICAgIGd0a193aWRnZXRfc2V0X3Zpc3Vh bChHVEtfV0lER0VUKHdpbmRvdyksIHJnYmFWaXN1YWwpOwogICAgIGd0a193aWRnZXRfc2V0X2Fw cF9wYWludGFibGUoR1RLX1dJREdFVCh3aW5kb3cpLCBUUlVFKTsKLQotICAgIHdlYmtpdF93ZWJf dmlld19zZXRfYmFja2dyb3VuZF9jb2xvcih3ZWJWaWV3LCByZ2JhKTsKIH0KIAogV2ViS2l0V2Vi VmlldyAqYnJvd3Nlcl93aW5kb3dfZ2V0X29yX2NyZWF0ZV93ZWJfdmlld19mb3JfYXV0b21hdGlv bih2b2lkKQpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL21haW4uYyBiL1Rvb2xz L01pbmlCcm93c2VyL2d0ay9tYWluLmMKaW5kZXggMTMzMjg0ZmYxNWEuLmE5YTNjMWVmZGYzIDEw MDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlC cm93c2VyL2d0ay9tYWluLmMKQEAgLTU4OSw2ICs1ODksOSBAQCBpbnQgbWFpbihpbnQgYXJnYywg Y2hhciAqYXJndltdKQogICAgIGVsc2UgaWYgKGdlb21ldHJ5KQogICAgICAgICBndGtfd2luZG93 X3BhcnNlX2dlb21ldHJ5KEdUS19XSU5ET1cobWFpbldpbmRvdyksIGdlb21ldHJ5KTsKIAorICAg IGlmIChiYWNrZ3JvdW5kQ29sb3IpCisgICAgICAgIGJyb3dzZXJfd2luZG93X3NldF9iYWNrZ3Jv dW5kX2NvbG9yKG1haW5XaW5kb3csIGJhY2tncm91bmRDb2xvcik7CisKICAgICBHdGtXaWRnZXQg KmZpcnN0VGFiID0gTlVMTDsKICAgICBpZiAodXJpQXJndW1lbnRzKSB7CiAgICAgICAgIGludCBp OwpAQCAtNjA1LDkgKzYwOCw2IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAg ICAgICAgIFdlYktpdFdlYlZpZXcgKndlYlZpZXcgPSBjcmVhdGVCcm93c2VyVGFiKG1haW5XaW5k b3csIHdlYmtpdFNldHRpbmdzLCB1c2VyQ29udGVudE1hbmFnZXIpOwogICAgICAgICBmaXJzdFRh YiA9IEdUS19XSURHRVQod2ViVmlldyk7CiAKLSAgICAgICAgaWYgKGJhY2tncm91bmRDb2xvcikK LSAgICAgICAgICAgIGJyb3dzZXJfd2luZG93X3NldF9iYWNrZ3JvdW5kX2NvbG9yKG1haW5XaW5k b3csIGJhY2tncm91bmRDb2xvcik7Ci0KICAgICAgICAgaWYgKCFlZGl0b3JNb2RlKSB7CiAgICAg ICAgICAgICBpZiAoc2Vzc2lvbkZpbGUpCiAgICAgICAgICAgICAgICAgYnJvd3Nlcl93aW5kb3df bG9hZF9zZXNzaW9uKG1haW5XaW5kb3csIHNlc3Npb25GaWxlKTsK