197153 2019-04-22 02:45:10 -0700 [JSC] useJIT should subsume useRegExpJIT 2019-05-10 09:18:40 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki achristensen ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1529201 0 ysuzuki 2019-04-22 02:45:10 -0700 [JSC] useJIT should subsume useRegExpJIT 1529202 1 367930 ysuzuki 2019-04-22 02:45:56 -0700 Created attachment 367930 Patch 1529205 2 ews-watchlist 2019-04-22 02:48:21 -0700 Attachment 367930 did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/RegExp.cpp:261: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/runtime/RegExp.cpp:319: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1529320 3 ysuzuki 2019-04-22 11:30:37 -0700 Committed r244505: <https://trac.webkit.org/changeset/244505> 1529321 4 webkit-bug-importer 2019-04-22 11:31:41 -0700 <rdar://problem/50100848> 1535018 5 ysuzuki 2019-05-10 09:18:40 -0700 This improved some memory footprint in useJIT=false environment since, perviously, even if useJIT=false is specified, we still have useRegExpJIT=false, and we attempt to initialize ExecutableAllocator and being rejected by entitlements. Now we do not do that. 367930 2019-04-22 02:45:56 -0700 2019-04-22 09:54:20 -0700 Patch bug-197153-20190422024555.patch text/plain 5696 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl MTFhNzcwZGJlYzZlYjI0NTkyOTEzYzIyMzUwNTQ1NjY2NjlkNmY2Li5mZmMxNmUyOTZjNDY3MmQ4 MGZiYTZkMTI1ZTcxNmNjMjUzMDVkZmEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxOS0wNC0yMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIHVzZUpJVCBzaG91bGQgc3Vic3VtZSB1c2VSZWdFeHBKSVQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzE1MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHVzZUpJVCBzaG91 bGQgc3Vic3VtZSB1c2VSZWdFeHBKSVQuIFdlIHNob3VsZCBpbW1lZGlhdGVseSBkaXNhYmxlIEpJ VCBmZWF0dXJlIGlmIHVzZUpJVCA9IGZhbHNlLAorICAgICAgICBldmVuIGlmIHVzZVJlZ0V4cEpJ VCBpcyB0cnVlLgorCisgICAgICAgICogZGZnL0RGR0NhcGFiaWxpdGllcy5jcHA6CisgICAgICAg IChKU0M6OkRGRzo6aXNTdXBwb3J0ZWQpOgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5jcHA6 CisgICAgICAgIChKU0M6OnJlY29tcHV0ZURlcGVuZGVudE9wdGlvbnMpOgorICAgICAgICAqIHJ1 bnRpbWUvUmVnRXhwLmNwcDoKKyAgICAgICAgKEpTQzo6UmVnRXhwOjpjb21waWxlKToKKyAgICAg ICAgKEpTQzo6UmVnRXhwOjpjb21waWxlTWF0Y2hPbmx5KToKKyAgICAgICAgKiBydW50aW1lL1ZN LmNwcDoKKyAgICAgICAgKEpTQzo6ZW5hYmxlQXNzZW1ibGVyKToKKyAgICAgICAgKEpTQzo6Vk06 OmNhblVzZVJlZ0V4cEpJVCk6IERlbGV0ZWQuCisgICAgICAgICogcnVudGltZS9WTS5oOgorCiAy MDE5LTA0LTIwICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgc3VwcHJlc3Mgd2FybmluZ3MgaW4gbm9uIERhcndpbiBlbnZpcm9ubWVudHMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ2FwYWJpbGl0aWVzLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ2FwYWJpbGl0aWVzLmNwcAppbmRleCBm NDViMzhlZWRiZmUwNjAwZTU2NWU0ZDMwMjY3YmI4ZTE4MGFhZGIxLi4yZDJkMmFiYzJkMGFhNWY2 ODI1YzFiMGUzMzFkM2RkNzJkZDdjNzA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0NhcGFiaWxpdGllcy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdDYXBhYmlsaXRpZXMuY3BwCkBAIC0zOCw4ICszOCw3IEBAIG5hbWVzcGFjZSBKU0MgeyBu YW1lc3BhY2UgREZHIHsKIAogYm9vbCBpc1N1cHBvcnRlZCgpCiB7Ci0gICAgcmV0dXJuIE9wdGlv bnM6OnVzZURGR0pJVCgpCi0gICAgICAgICYmIE1hY3JvQXNzZW1ibGVyOjpzdXBwb3J0c0Zsb2F0 aW5nUG9pbnQoKTsKKyAgICByZXR1cm4gVk06OmNhblVzZUpJVCgpICYmIE9wdGlvbnM6OnVzZURG R0pJVCgpICYmIE1hY3JvQXNzZW1ibGVyOjpzdXBwb3J0c0Zsb2F0aW5nUG9pbnQoKTsKIH0KIAog Ym9vbCBpc1N1cHBvcnRlZEZvcklubGluaW5nKENvZGVCbG9jayogY29kZUJsb2NrKQpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmNwcAppbmRleCA2MDllZmFiMDFhYmJhM2Jh MjkxYjQxMTgzMGI0OWQxMzg3OGEyODUzLi5jNjVjNmRiZDM1OTIwMDBiNjE3ZmJkY2Y4MzU5MmZm MWI1YzcwMTVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRp b25zLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmNwcApA QCAtMzkyLDE2ICszOTIsMTggQEAgc3RhdGljIHZvaWQgcmVjb21wdXRlRGVwZW5kZW50T3B0aW9u cygpCiAjaWYgIUVOQUJMRShKSVQpCiAgICAgT3B0aW9uczo6dXNlTExJbnQoKSA9IHRydWU7CiAg ICAgT3B0aW9uczo6dXNlSklUKCkgPSBmYWxzZTsKKyAgICBPcHRpb25zOjp1c2VCYXNlbGluZUpJ VCgpID0gZmFsc2U7CiAgICAgT3B0aW9uczo6dXNlREZHSklUKCkgPSBmYWxzZTsKICAgICBPcHRp b25zOjp1c2VGVExKSVQoKSA9IGZhbHNlOwogICAgIE9wdGlvbnM6OnVzZURPTUpJVCgpID0gZmFs c2U7Ci0jZW5kaWYKLSNpZiAhRU5BQkxFKFlBUlJfSklUKQogICAgIE9wdGlvbnM6OnVzZVJlZ0V4 cEpJVCgpID0gZmFsc2U7CiAjZW5kaWYKICNpZiAhRU5BQkxFKENPTkNVUlJFTlRfSlMpCiAgICAg T3B0aW9uczo6dXNlQ29uY3VycmVudEpJVCgpID0gZmFsc2U7CiAjZW5kaWYKKyNpZiAhRU5BQkxF KFlBUlJfSklUKQorICAgIE9wdGlvbnM6OnVzZVJlZ0V4cEpJVCgpID0gZmFsc2U7CisjZW5kaWYK ICNpZiAhRU5BQkxFKERGR19KSVQpCiAgICAgT3B0aW9uczo6dXNlREZHSklUKCkgPSBmYWxzZTsK ICAgICBPcHRpb25zOjp1c2VGVExKSVQoKSA9IGZhbHNlOwpAQCAtNDEzLDEyICs0MTUsNiBAQCBz dGF0aWMgdm9pZCByZWNvbXB1dGVEZXBlbmRlbnRPcHRpb25zKCkKICNpZiAhQ1BVKFg4Nl82NCkg JiYgIUNQVShBUk02NCkKICAgICBPcHRpb25zOjp1c2VDb25jdXJyZW50R0MoKSA9IGZhbHNlOwog I2VuZGlmCi0gICAgCi0jaWYgRU5BQkxFKEpJVCkgJiYgQ1BVKFg4NikKLSAgICAvLyBEaXNhYmxl IEpJVCBvbiBJQS0zMiBpZiBTU0UyIGlzIG5vdCBwcmVzZW50Ci0gICAgaWYgKCFNYWNyb0Fzc2Vt Ymxlclg4Njo6c3VwcG9ydHNGbG9hdGluZ1BvaW50KCkpCi0gICAgICAgIE9wdGlvbnM6OnVzZUpJ VCgpID0gZmFsc2U7Ci0jZW5kaWYKIAogICAgIGlmICghT3B0aW9uczo6dXNlSklUKCkpIHsKICAg ICAgICAgT3B0aW9uczo6dXNlU2lnaWxsQ3Jhc2hBbmFseXplcigpID0gZmFsc2U7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHAuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwLmNwcAppbmRleCA4NDM1MjRmYjg4MzM0MTBhODY2 YjA3YTMyNGZlNjU3OGRmODQzYTE3Li5mMzEzZDRlY2I1M2M4MWJmMTZkYWNkZTVmZjdmZjA3YTJi NDVkYzdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHAu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cC5jcHAKQEAgLTI1 OCw3ICsyNTgsNyBAQCB2b2lkIFJlZ0V4cDo6Y29tcGlsZShWTSogdm0sIFlhcnI6OllhcnJDaGFy U2l6ZSBjaGFyU2l6ZSkKICAgICB9CiAKICNpZiBFTkFCTEUoWUFSUl9KSVQpCi0gICAgaWYgKCFw YXR0ZXJuLmNvbnRhaW5zVW5zaWduZWRMZW5ndGhQYXR0ZXJuKCkgJiYgVk06OmNhblVzZVJlZ0V4 cEpJVCgpCisgICAgaWYgKCFwYXR0ZXJuLmNvbnRhaW5zVW5zaWduZWRMZW5ndGhQYXR0ZXJuKCkg JiYgVk06OmNhblVzZUpJVCgpICYmIE9wdGlvbnM6OnVzZVJlZ0V4cEpJVCgpCiAjaWYgIUVOQUJM RShZQVJSX0pJVF9CQUNLUkVGRVJFTkNFUykKICAgICAgICAgJiYgIXBhdHRlcm4ubV9jb250YWlu c0JhY2tyZWZlcmVuY2VzCiAjZW5kaWYKQEAgLTMxNiw3ICszMTYsNyBAQCB2b2lkIFJlZ0V4cDo6 Y29tcGlsZU1hdGNoT25seShWTSogdm0sIFlhcnI6OllhcnJDaGFyU2l6ZSBjaGFyU2l6ZSkKICAg ICB9CiAKICNpZiBFTkFCTEUoWUFSUl9KSVQpCi0gICAgaWYgKCFwYXR0ZXJuLmNvbnRhaW5zVW5z aWduZWRMZW5ndGhQYXR0ZXJuKCkgJiYgVk06OmNhblVzZVJlZ0V4cEpJVCgpCisgICAgaWYgKCFw YXR0ZXJuLmNvbnRhaW5zVW5zaWduZWRMZW5ndGhQYXR0ZXJuKCkgJiYgVk06OmNhblVzZUpJVCgp ICYmIE9wdGlvbnM6OnVzZVJlZ0V4cEpJVCgpCiAjaWYgIUVOQUJMRShZQVJSX0pJVF9CQUNLUkVG RVJFTkNFUykKICAgICAgICAgJiYgIXBhdHRlcm4ubV9jb250YWluc0JhY2tyZWZlcmVuY2VzCiAj ZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAppbmRleCAyZWM4NGQ1NzJiMWZm MWU4MjU3MWQ3ZjVlNTc0NmQ0MDhmNGE1ZjM2Li4xMmE3NjhlMDVjZTNjNWUxMzc4NTUxNTMxNWJh Y2NhY2VkMGRlZjExIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9W TS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCkBAIC0xOTAs NyArMTkwLDcgQEAgQXRvbWljPHVuc2lnbmVkPiBWTTo6c19udW1iZXJPZklEczsKICNpZiBFTkFC TEUoQVNTRU1CTEVSKQogc3RhdGljIGJvb2wgZW5hYmxlQXNzZW1ibGVyKCkKIHsKLSAgICBpZiAo IU9wdGlvbnM6OnVzZUpJVCgpICYmICFPcHRpb25zOjp1c2VSZWdFeHBKSVQoKSkKKyAgICBpZiAo IU9wdGlvbnM6OnVzZUpJVCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBjaGFyKiBj YW5Vc2VKSVRTdHJpbmcgPSBnZXRlbnYoIkphdmFTY3JpcHRDb3JlVXNlSklUIik7CkBAIC0yMzMs MjAgKzIzMyw2IEBAIHZvaWQgVk06OmNvbXB1dGVDYW5Vc2VKSVQoKQogI2VuZGlmCiB9CiAKLWJv b2wgVk06OmNhblVzZVJlZ0V4cEpJVCgpCi17Ci0jaWYgRU5BQkxFKFlBUlJfSklUKQotICAgIHN0 YXRpYyBzdGQ6Om9uY2VfZmxhZyBvbmNlS2V5OwotICAgIHN0YXRpYyBib29sIGVuYWJsZWQgPSBm YWxzZTsKLSAgICBzdGQ6OmNhbGxfb25jZShvbmNlS2V5LCBbXSB7Ci0gICAgICAgIGVuYWJsZWQg PSBWTTo6Y2FuVXNlQXNzZW1ibGVyKCkgJiYgT3B0aW9uczo6dXNlUmVnRXhwSklUKCk7Ci0gICAg fSk7Ci0gICAgcmV0dXJuIGVuYWJsZWQ7Ci0jZWxzZQotICAgIHJldHVybiBmYWxzZTsgLy8gaW50 ZXJwcmV0ZXIgb25seQotI2VuZGlmCi19Ci0KIGJvb2wgVk06OmlzSW5NaW5pTW9kZSgpCiB7CiAg ICAgcmV0dXJuICFjYW5Vc2VKSVQoKSB8fCBPcHRpb25zOjpmb3JjZU1pbmlWTU1vZGUoKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmggYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCmluZGV4IGUwZmU1ZmE0NmRmYTNkNDAxMDkyOTBiMTMz ZWM4YWUyZGRiMzI2MDQuLmI5ODVkNDdlYTRkOTVlZGRkYzljMGNmMzY2ODk2NTMzNzZmN2QxZGYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmgKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uaApAQCAtNjMzLDcgKzYzMyw2IEBAIGNsYXNz IFZNIDogcHVibGljIFRocmVhZFNhZmVSZWZDb3VudGVkPFZNPiwgcHVibGljIERvdWJseUxpbmtl ZExpc3ROb2RlPFZNPiB7CiAgICAgfTsKIAogICAgIHN0YXRpYyBKU19FWFBPUlRfUFJJVkFURSBi b29sIGNhblVzZUFzc2VtYmxlcigpOwotICAgIHN0YXRpYyBKU19FWFBPUlRfUFJJVkFURSBib29s IGNhblVzZVJlZ0V4cEpJVCgpOwogICAgIHN0YXRpYyBKU19FWFBPUlRfUFJJVkFURSBib29sIGlz SW5NaW5pTW9kZSgpOwogCiAgICAgc3RhdGljIHZvaWQgY29tcHV0ZUNhblVzZUpJVCgpOwo=