<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>197151</bug_id>
          
          <creation_ts>2019-04-21 17:16:06 -0700</creation_ts>
          <short_desc>WHLSLPrepare.cpp always recompiles, even if nothing was changed</short_desc>
          <delta_ts>2019-05-13 07:00:04 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGPU</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>197159</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Darin Adler">darin</reporter>
          <assigned_to name="Darin Adler">darin</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>jonlee</cc>
    
    <cc>krollin</cc>
    
    <cc>mitz</cc>
    
    <cc>mmaxfield</cc>
    
    <cc>sroberts</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1529170</commentid>
    <comment_count>0</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-04-21 17:16:06 -0700</bug_when>
    <thetext>WHLSLPrepare.cpp always recompiles, even if nothing was changed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529171</commentid>
    <comment_count>1</comment_count>
      <attachid>367920</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-04-21 17:17:59 -0700</bug_when>
    <thetext>Created attachment 367920
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529172</commentid>
    <comment_count>2</comment_count>
      <attachid>367921</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-04-21 17:20:19 -0700</bug_when>
    <thetext>Created attachment 367921
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529173</commentid>
    <comment_count>3</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-04-21 17:23:23 -0700</bug_when>
    <thetext>One small thing I don’t understand is why generate-xcfilelists did not remove the reference to WHLSLStandardLibrary.cpp even after I removed all other references to that filename from the source tree.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529174</commentid>
    <comment_count>4</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-04-21 17:24:07 -0700</bug_when>
    <thetext>Committed r244495: &lt;https://trac.webkit.org/changeset/244495&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529175</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-04-21 17:25:24 -0700</bug_when>
    <thetext>&lt;rdar://problem/50083499&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529244</commentid>
    <comment_count>6</comment_count>
    <who name="Shawn Roberts">sroberts</who>
    <bug_when>2019-04-22 08:41:49 -0700</bug_when>
    <thetext>Changes in https://trac.webkit.org/changeset/244495 are causing build failures on Mac and iOS Release and Debug queues.

https://build.webkit.org/builders/Apple%20Mojave%20Release%20%28Build%29/builds/5103/steps/compile-webkit/logs/stdio

perl JavaScriptCorePrivateHeaders/xxd.pl XMLViewer_js ./XMLViewer.min.js XMLViewerJS.h
Can&apos;t modify anonymous list ([]) in scalar assignment at JavaScriptCorePrivateHeaders/xxd.pl line 3, near &quot;};&quot;
Execution of JavaScriptCorePrivateHeaders/xxd.pl aborted due to compilation errors.
make: *** [XMLViewerJS.h] Error 255
perl JavaScriptCorePrivateHeaders/xxd.pl CommandLineAPIModuleSource_js ./CommandLineAPIModuleSource.min.js CommandLineAPIModuleSource.h
Can&apos;t modify anonymous list ([]) in scalar assignment at JavaScriptCorePrivateHeaders/xxd.pl line 3, near &quot;};&quot;
Execution of JavaScriptCorePrivateHeaders/xxd.pl aborted due to compilation errors.
make: *** [CommandLineAPIModuleSource.h] Error 255</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529246</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-04-22 08:47:11 -0700</bug_when>
    <thetext>Re-opened since this is blocked by bug 197159</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529334</commentid>
    <comment_count>8</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-04-22 12:34:11 -0700</bug_when>
    <thetext>I have no idea how this change caused those problems. Does anyone know?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529369</commentid>
    <comment_count>9</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-04-22 13:56:53 -0700</bug_when>
    <thetext>Myles, at some point when you are free after doing higher priority work, would you be willing to help me with this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529621</commentid>
    <comment_count>10</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-04-23 09:20:15 -0700</bug_when>
    <thetext>I am still getting this error in xxd.pl in my build here on my Mac even though my source tree does not have the changes from this patch; no time to investigate and fix it right now. Are we sure about cause/effect here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529622</commentid>
    <comment_count>11</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-04-23 09:20:57 -0700</bug_when>
    <thetext>Oh wait, maybe I do have the changes; I’ll be able to debug this locally now. No worries, no rush.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1533294</commentid>
    <comment_count>12</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-05-05 14:57:17 -0700</bug_when>
    <thetext>I can no longer reproduce this error in xxd.pl so I don’t know how to make progress on this. Can someone help me reproduce the problem? I’d love to fix this makefile mistake because it’s really annoying to do extra compiling every time I build!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1535446</commentid>
    <comment_count>13</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-05-12 10:41:49 -0700</bug_when>
    <thetext>This bug is really annoying me — I’d love to land the change some day, but I need help reproducing the build failure that meant Shawn had to roll it out last time. Especially mysterious given the changes don’t seem to be ones that could affect those other invocations of xxd.pl</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1535486</commentid>
    <comment_count>14</comment_count>
    <who name="Keith Rollin">krollin</who>
    <bug_when>2019-05-12 15:19:48 -0700</bug_when>
    <thetext>(In reply to Darin Adler from comment #3)
&gt; One small thing I don’t understand is why generate-xcfilelists did not
&gt; remove the reference to WHLSLStandardLibrary.cpp even after I removed all
&gt; other references to that filename from the source tree.

xcfilelists need to represent all platforms and configurations, and must be a super-set of the files used for all those build combinations. However, when updating the xcfilelists during build time, we can only update the xcfilelists with respect to that current build. This means that the xcfilelist contents generated during the build might be a subset of what&apos;s required for all build combinations. Since it&apos;s a subset, there might be files in the resulting xcfilelist that we could characterize as &quot;left over&quot;. And there&apos;s no way to know if those files are obsolete and can be removed, or if they are needed by a different build combination. Therefore, during the incremental xcfilelist updates, we can&apos;t safely delete any files.

There&apos;s some discussion of this at &lt;https://confluence.sd.apple.com/pages/viewpage.action?pageId=783873680&gt; under Known Issues.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1535514</commentid>
    <comment_count>15</comment_count>
      <attachid>367921</attachid>
    <who name="Keith Rollin">krollin</who>
    <bug_when>2019-05-12 20:50:53 -0700</bug_when>
    <thetext>Comment on attachment 367921
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367921&amp;action=review

&gt; Source/WebCore/DerivedSources.make:1639
&gt; +	$(PERL) $(JavaScriptCore_SCRIPTS_DIR)/xxd.pl WHLSLStandardLibrary $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt $&lt;

Is this an equivalent replacement? You&apos;re replacing &quot;WHLSLStandardLibrary.h&quot; with &quot;$&lt;&quot;. But $&lt; is the first pre-requisite, which is the xxd.pl tool. I think you want $@ instead of $&lt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1535601</commentid>
    <comment_count>16</comment_count>
      <attachid>367921</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-05-13 06:57:14 -0700</bug_when>
    <thetext>Comment on attachment 367921
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367921&amp;action=review

&gt;&gt; Source/WebCore/DerivedSources.make:1639
&gt;&gt; +	$(PERL) $(JavaScriptCore_SCRIPTS_DIR)/xxd.pl WHLSLStandardLibrary $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt $&lt;
&gt; 
&gt; Is this an equivalent replacement? You&apos;re replacing &quot;WHLSLStandardLibrary.h&quot; with &quot;$&lt;&quot;. But $&lt; is the first pre-requisite, which is the xxd.pl tool. I think you want $@ instead of $&lt;.

Yes, I want $@, that’s the bug. I was overwriting the tool!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1535602</commentid>
    <comment_count>17</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-05-13 06:57:40 -0700</bug_when>
    <thetext>Thank you Keith!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1535604</commentid>
    <comment_count>18</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-05-13 07:00:04 -0700</bug_when>
    <thetext>Committed r245233: &lt;https://trac.webkit.org/changeset/245233&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>367920</attachid>
            <date>2019-04-21 17:17:59 -0700</date>
            <delta_ts>2019-04-21 17:20:16 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-197151-20190421171755.patch</filename>
            <type>text/plain</type>
            <size>4439</size>
            <attacher name="Darin Adler">darin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTJkNDU0Zjg5MTkzZWRi
N2UxYjdlZjBlZmZhMjY2YzM0MjEyN2VjZS4uNGU1YTRjNzJjY2ZiNDVkOWEzNmMyN2FiNTk4ZDNm
MmE3YWZmOGE4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA0LTIxICBEYXJp
biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBXSExTTFByZXBhcmUuY3BwIGFs
d2F5cyByZWNvbXBpbGVzLCBldmVuIGlmIG5vdGhpbmcgd2FzIGNoYW5nZWQKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzE1MQorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRGVyaXZlZFNvdXJjZXMtaW5w
dXQueGNmaWxlbGlzdDogU2NyaXB0IHVwZGF0ZWQgdGhpcyBhdXRvbWF0aWNhbGx5IGFmdGVyCisg
ICAgICAgIERlcml2ZWRTb3VyY2VzLm1ha2Ugd2FzIGNvcnJlY3RlZC4KKyAgICAgICAgKiBEZXJp
dmVkU291cmNlcy1vdXRwdXQueGNmaWxlbGlzdDogRGl0dG8sIGFsdGhvdWdoIEkgaGFkIHRvIG1h
bnVhbGx5IHJlbW92ZQorICAgICAgICBvbmUgYm9ndXMgbGVmdG92ZXIgcmVmZXJlbmNlIHRvIFdI
TFNMU3RhbmRhcmRMaWJyYXJ5LmguCisKKyAgICAgICAgKiBEZXJpdmVkU291cmNlcy5tYWtlOiBV
cGRhdGVkIHRoZSBydWxlIHRoYXQgYnVpbGRzIFdIU0xTdGFuZGFyZExpYnJhcnkuaCB0bworICAg
ICAgICBubyBsb25nZXIgcmVmZXIgdG8gbm9uZXhpc3RlbnQgV0hMU0xTdGFuZGFyZExpYnJhcnku
Y3BwLiBCZWNhdXNlIHRoZSBkZXBlbmRlbmN5CisgICAgICAgIHdhcyBvbiBhIGZpbGUgdGhhdCB3
YXMgbmV2ZXIgY3JlYXRlZCwgdGhlIHJ1bGUgdG8gcmVnZW5lcmF0ZSBXSFNMU3RhbmRhcmRMaWJy
YXJ5LmgKKyAgICAgICAgd2FzIHJ1bm5pbmcgb24gZXZlcnkgYnVpbGQsIGluc3RlYWQgb2Ygb25s
eSB3aGVuIG9uZSBvZiB0aGUgZGVwZW5kZW5jaWVzIGNoYW5nZWQuCisKIDIwMTktMDQtMjAgIFNh
aWQgQWJvdS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAo
cjI0MzEzNyk6IFNWR1ZpZXdFbGVtZW50LnZpZXdUYXJnZXQgc2hvdWxkIG5vdCByZXR1cm4gYSBu
ZXcgb2JqZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy1pbnB1
dC54Y2ZpbGVsaXN0IGIvU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMtaW5wdXQueGNmaWxl
bGlzdAppbmRleCA2YjI0YTk0MTMyZTVlZjE1ZjVhNDZhZDc4NGM0NDcyMDEwYTkzNjgxLi43NjYw
NTRmYjU5ODNlZmE4ZGRiZGQ4NTczYzM0MjRmMjliOGI0NTEyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9EZXJpdmVkU291cmNlcy1pbnB1dC54Y2ZpbGVsaXN0CisrKyBiL1NvdXJjZS9XZWJD
b3JlL0Rlcml2ZWRTb3VyY2VzLWlucHV0LnhjZmlsZWxpc3QKQEAgLTE1LDYgKzE1LDcgQEAgJChK
QVZBU0NSSVBUQ09SRV9QUklWQVRFX0hFQURFUlNfRElSKS9nZW5lcmF0ZS1qcy1idWlsdGlucy5w
eQogJChKQVZBU0NSSVBUQ09SRV9QUklWQVRFX0hFQURFUlNfRElSKS9sYXp5d3JpdGVyLnB5CiAk
KEpBVkFTQ1JJUFRDT1JFX1BSSVZBVEVfSEVBREVSU19ESVIpL21ha2UtanMtZmlsZS1hcnJheXMu
cHkKICQoSkFWQVNDUklQVENPUkVfUFJJVkFURV9IRUFERVJTX0RJUikvd2tidWlsdGlucy5weQor
JChKQVZBU0NSSVBUQ09SRV9QUklWQVRFX0hFQURFUlNfRElSKS94eGQucGwKICQoUFJPSkVDVF9E
SVIpL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnCiAkKFBST0pFQ1RfRElS
KS9EZXJpdmVkU291cmNlcy5tYWtlCiAkKFBST0pFQ1RfRElSKS9Nb2R1bGVzL2FpcnBsYXkvV2Vi
S2l0UGxheWJhY2tUYXJnZXRBdmFpbGFiaWxpdHlFdmVudC5pZGwKQEAgLTM0MSw2ICszNDIsNyBA
QCAkKFBST0pFQ1RfRElSKS9Nb2R1bGVzL3dlYmdwdS9HUFVUZXh0dXJlRm9ybWF0LmlkbAogJChQ
Uk9KRUNUX0RJUikvTW9kdWxlcy93ZWJncHUvR1BVVGV4dHVyZVVzYWdlLmlkbAogJChQUk9KRUNU
X0RJUikvTW9kdWxlcy93ZWJncHUvR1BVVmVydGV4QXR0cmlidXRlRGVzY3JpcHRvci5pZGwKICQo
UFJPSkVDVF9ESVIpL01vZHVsZXMvd2ViZ3B1L0dQVVZlcnRleElucHV0RGVzY3JpcHRvci5pZGwK
KyQoUFJPSkVDVF9ESVIpL01vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMU3RhbmRhcmRMaWJyYXJ5
LnR4dAogJChQUk9KRUNUX0RJUikvTW9kdWxlcy93ZWJncHUvV2ViR1BVLmlkbAogJChQUk9KRUNU
X0RJUikvTW9kdWxlcy93ZWJncHUvV2ViR1BVQWRhcHRlci5pZGwKICQoUFJPSkVDVF9ESVIpL01v
ZHVsZXMvd2ViZ3B1L1dlYkdQVUJpbmRHcm91cC5pZGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL0Rlcml2ZWRTb3VyY2VzLW91dHB1dC54Y2ZpbGVsaXN0IGIvU291cmNlL1dlYkNvcmUvRGVy
aXZlZFNvdXJjZXMtb3V0cHV0LnhjZmlsZWxpc3QKaW5kZXggMjZiNjVmZmE5NjkyNjg2OTY3ZDQ0
MDVhODNjNTFmMTliNjI3YjdiNi4uZWFmN2QyZWM4YTljYTkxN2E5NDM5YzU3MTI1MTI3MzY4MTc5
NzIyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMtb3V0cHV0Lnhj
ZmlsZWxpc3QKKysrIGIvU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMtb3V0cHV0LnhjZmls
ZWxpc3QKQEAgLTIwODQsNyArMjA4NCw3IEBAICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVk
U291cmNlcy9XZWJDb3JlL1RvdWNoTGlzdC5pZGwKICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJp
dmVkU291cmNlcy9XZWJDb3JlL1VzZXJBZ2VudFNjcmlwdHMuaAogJChCVUlMVF9QUk9EVUNUU19E
SVIpL0Rlcml2ZWRTb3VyY2VzL1dlYkNvcmUvVXNlckFnZW50U2NyaXB0c0RhdGEuY3BwCiAkKEJV
SUxUX1BST0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9Vc2VyQWdlbnRTdHlsZVNo
ZWV0cy5oCi0kKEJVSUxUX1BST0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9XSExT
TFN0YW5kYXJkTGlicmFyeS5jcHAKKyQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNl
cy9XZWJDb3JlL1dITFNMU3RhbmRhcmRMaWJyYXJ5LmgKICQoQlVJTFRfUFJPRFVDVFNfRElSKS9E
ZXJpdmVkU291cmNlcy9XZWJDb3JlL1dlYkNvcmVKU0J1aWx0aW5JbnRlcm5hbHMuY3BwCiAkKEJV
SUxUX1BST0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9XZWJDb3JlSlNCdWlsdGlu
SW50ZXJuYWxzLmgKICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJDb3Jl
L1dlYkNvcmVKU0J1aWx0aW5zLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvRGVyaXZl
ZFNvdXJjZXMubWFrZSBiL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UKaW5kZXgg
MDMzZTY0YjNlYTcxYWJhZjcxNzc1NzNjODhhMDQzMzM0ZmRiY2IzMS4uNzFhZmI2YWJjZWM2ZjEx
OTZjMDgxYTk2ZDhhYmZhM2U3YzVkZDBjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvRGVy
aXZlZFNvdXJjZXMubWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5tYWtl
CkBAIC0xNjMzLDEwICsxNjMzLDEwIEBAICQoR0VORVJBVEVfU0VUVElOR1NfUEFUVEVSTlMpIDog
JChXZWJDb3JlKS9TY3JpcHRzL0dlbmVyYXRlU2V0dGluZ3MucmIgJChHRU5FUkFUCiAKICMgV0hM
U0wgU3RhbmRhcmQgTGlicmFyeQogCi1hbGwgOiBXSExTTFN0YW5kYXJkTGlicmFyeS5jcHAKK2Fs
bCA6IFdITFNMU3RhbmRhcmRMaWJyYXJ5LmgKIAotV0hMU0xTdGFuZGFyZExpYnJhcnkuY3BwIDog
JChKYXZhU2NyaXB0Q29yZV9TQ1JJUFRTX0RJUikveHhkLnBsICQoV2ViQ29yZSkvTW9kdWxlcy93
ZWJncHUvV0hMU0wvV0hMU0xTdGFuZGFyZExpYnJhcnkudHh0Ci0JJChQRVJMKSAkKEphdmFTY3Jp
cHRDb3JlX1NDUklQVFNfRElSKS94eGQucGwgV0hMU0xTdGFuZGFyZExpYnJhcnkgJChXZWJDb3Jl
KS9Nb2R1bGVzL3dlYmdwdS9XSExTTC9XSExTTFN0YW5kYXJkTGlicmFyeS50eHQgV0hMU0xTdGFu
ZGFyZExpYnJhcnkuaAorV0hMU0xTdGFuZGFyZExpYnJhcnkuaCA6ICQoSmF2YVNjcmlwdENvcmVf
U0NSSVBUU19ESVIpL3h4ZC5wbCAkKFdlYkNvcmUpL01vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNM
U3RhbmRhcmRMaWJyYXJ5LnR4dAorCSQoUEVSTCkgJChKYXZhU2NyaXB0Q29yZV9TQ1JJUFRTX0RJ
UikveHhkLnBsIFdITFNMU3RhbmRhcmRMaWJyYXJ5ICQoV2ViQ29yZSkvTW9kdWxlcy93ZWJncHUv
V0hMU0wvV0hMU0xTdGFuZGFyZExpYnJhcnkudHh0ICQ8CiAKICMgLS0tLS0tLS0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>367921</attachid>
            <date>2019-04-21 17:20:19 -0700</date>
            <delta_ts>2019-04-21 17:23:05 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-197151-20190421172015.patch</filename>
            <type>text/plain</type>
            <size>4441</size>
            <attacher name="Darin Adler">darin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTJkNDU0Zjg5MTkzZWRi
N2UxYjdlZjBlZmZhMjY2YzM0MjEyN2VjZS4uMzA1MzNiOWY2NDYxODQ5NTZjNDU4MDUzZWNiN2Vk
NTUwZDUzMWU2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA0LTIxICBEYXJp
biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBXSExTTFByZXBhcmUuY3BwIGFs
d2F5cyByZWNvbXBpbGVzLCBldmVuIGlmIG5vdGhpbmcgd2FzIGNoYW5nZWQKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzE1MQorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRGVyaXZlZFNvdXJjZXMtaW5w
dXQueGNmaWxlbGlzdDogU2NyaXB0IHVwZGF0ZWQgdGhpcyBhdXRvbWF0aWNhbGx5IGFmdGVyCisg
ICAgICAgIERlcml2ZWRTb3VyY2VzLm1ha2Ugd2FzIGNvcnJlY3RlZC4KKyAgICAgICAgKiBEZXJp
dmVkU291cmNlcy1vdXRwdXQueGNmaWxlbGlzdDogRGl0dG8sIGFsdGhvdWdoIEkgaGFkIHRvIG1h
bnVhbGx5IHJlbW92ZQorICAgICAgICBvbmUgYm9ndXMgbGVmdG92ZXIgcmVmZXJlbmNlIHRvIFdI
TFNMU3RhbmRhcmRMaWJyYXJ5LmNwcC4KKworICAgICAgICAqIERlcml2ZWRTb3VyY2VzLm1ha2U6
IFVwZGF0ZWQgdGhlIHJ1bGUgdGhhdCBidWlsZHMgV0hTTFN0YW5kYXJkTGlicmFyeS5oIHRvCisg
ICAgICAgIG5vIGxvbmdlciByZWZlciB0byBub25leGlzdGVudCBXSExTTFN0YW5kYXJkTGlicmFy
eS5jcHAuIEJlY2F1c2UgdGhlIGRlcGVuZGVuY3kKKyAgICAgICAgd2FzIG9uIGEgZmlsZSB0aGF0
IHdhcyBuZXZlciBjcmVhdGVkLCB0aGUgcnVsZSB0byByZWdlbmVyYXRlIFdIU0xTdGFuZGFyZExp
YnJhcnkuaAorICAgICAgICB3YXMgcnVubmluZyBvbiBldmVyeSBidWlsZCwgaW5zdGVhZCBvZiBv
bmx5IHdoZW4gb25lIG9mIHRoZSBkZXBlbmRlbmNpZXMgY2hhbmdlZC4KKwogMjAxOS0wNC0yMCAg
U2FpZCBBYm91LUhhbGxhd2EgIDxzYWlkQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O
IChyMjQzMTM3KTogU1ZHVmlld0VsZW1lbnQudmlld1RhcmdldCBzaG91bGQgbm90IHJldHVybiBh
IG5ldyBvYmplY3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLWlu
cHV0LnhjZmlsZWxpc3QgYi9Tb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy1pbnB1dC54Y2Zp
bGVsaXN0CmluZGV4IDZiMjRhOTQxMzJlNWVmMTVmNWE0NmFkNzg0YzQ0NzIwMTBhOTM2ODEuLjc2
NjA1NGZiNTk4M2VmYThkZGJkZDg1NzNjMzQyNGYyOWI4YjQ1MTIgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLWlucHV0LnhjZmlsZWxpc3QKKysrIGIvU291cmNlL1dl
YkNvcmUvRGVyaXZlZFNvdXJjZXMtaW5wdXQueGNmaWxlbGlzdApAQCAtMTUsNiArMTUsNyBAQCAk
KEpBVkFTQ1JJUFRDT1JFX1BSSVZBVEVfSEVBREVSU19ESVIpL2dlbmVyYXRlLWpzLWJ1aWx0aW5z
LnB5CiAkKEpBVkFTQ1JJUFRDT1JFX1BSSVZBVEVfSEVBREVSU19ESVIpL2xhenl3cml0ZXIucHkK
ICQoSkFWQVNDUklQVENPUkVfUFJJVkFURV9IRUFERVJTX0RJUikvbWFrZS1qcy1maWxlLWFycmF5
cy5weQogJChKQVZBU0NSSVBUQ09SRV9QUklWQVRFX0hFQURFUlNfRElSKS93a2J1aWx0aW5zLnB5
CiskKEpBVkFTQ1JJUFRDT1JFX1BSSVZBVEVfSEVBREVSU19ESVIpL3h4ZC5wbAogJChQUk9KRUNU
X0RJUikvQ29uZmlndXJhdGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25maWcKICQoUFJPSkVDVF9E
SVIpL0Rlcml2ZWRTb3VyY2VzLm1ha2UKICQoUFJPSkVDVF9ESVIpL01vZHVsZXMvYWlycGxheS9X
ZWJLaXRQbGF5YmFja1RhcmdldEF2YWlsYWJpbGl0eUV2ZW50LmlkbApAQCAtMzQxLDYgKzM0Miw3
IEBAICQoUFJPSkVDVF9ESVIpL01vZHVsZXMvd2ViZ3B1L0dQVVRleHR1cmVGb3JtYXQuaWRsCiAk
KFBST0pFQ1RfRElSKS9Nb2R1bGVzL3dlYmdwdS9HUFVUZXh0dXJlVXNhZ2UuaWRsCiAkKFBST0pF
Q1RfRElSKS9Nb2R1bGVzL3dlYmdwdS9HUFVWZXJ0ZXhBdHRyaWJ1dGVEZXNjcmlwdG9yLmlkbAog
JChQUk9KRUNUX0RJUikvTW9kdWxlcy93ZWJncHUvR1BVVmVydGV4SW5wdXREZXNjcmlwdG9yLmlk
bAorJChQUk9KRUNUX0RJUikvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xTdGFuZGFyZExpYnJh
cnkudHh0CiAkKFBST0pFQ1RfRElSKS9Nb2R1bGVzL3dlYmdwdS9XZWJHUFUuaWRsCiAkKFBST0pF
Q1RfRElSKS9Nb2R1bGVzL3dlYmdwdS9XZWJHUFVBZGFwdGVyLmlkbAogJChQUk9KRUNUX0RJUikv
TW9kdWxlcy93ZWJncHUvV2ViR1BVQmluZEdyb3VwLmlkbApkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvRGVyaXZlZFNvdXJjZXMtb3V0cHV0LnhjZmlsZWxpc3QgYi9Tb3VyY2UvV2ViQ29yZS9E
ZXJpdmVkU291cmNlcy1vdXRwdXQueGNmaWxlbGlzdAppbmRleCAyNmI2NWZmYTk2OTI2ODY5Njdk
NDQwNWE4M2M1MWYxOWI2MjdiN2I2Li5lYWY3ZDJlYzhhOWNhOTE3YTk0MzljNTcxMjUxMjczNjgx
Nzk3MjI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy1vdXRwdXQu
eGNmaWxlbGlzdAorKysgYi9Tb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy1vdXRwdXQueGNm
aWxlbGlzdApAQCAtMjA4NCw3ICsyMDg0LDcgQEAgJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2
ZWRTb3VyY2VzL1dlYkNvcmUvVG91Y2hMaXN0LmlkbAogJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rl
cml2ZWRTb3VyY2VzL1dlYkNvcmUvVXNlckFnZW50U2NyaXB0cy5oCiAkKEJVSUxUX1BST0RVQ1RT
X0RJUikvRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9Vc2VyQWdlbnRTY3JpcHRzRGF0YS5jcHAKICQo
QlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJDb3JlL1VzZXJBZ2VudFN0eWxl
U2hlZXRzLmgKLSQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJDb3JlL1dI
TFNMU3RhbmRhcmRMaWJyYXJ5LmNwcAorJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3Vy
Y2VzL1dlYkNvcmUvV0hMU0xTdGFuZGFyZExpYnJhcnkuaAogJChCVUlMVF9QUk9EVUNUU19ESVIp
L0Rlcml2ZWRTb3VyY2VzL1dlYkNvcmUvV2ViQ29yZUpTQnVpbHRpbkludGVybmFscy5jcHAKICQo
QlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJDb3JlL1dlYkNvcmVKU0J1aWx0
aW5JbnRlcm5hbHMuaAogJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYkNv
cmUvV2ViQ29yZUpTQnVpbHRpbnMuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9EZXJp
dmVkU291cmNlcy5tYWtlIGIvU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMubWFrZQppbmRl
eCAwMzNlNjRiM2VhNzFhYmFmNzE3NzU3M2M4OGEwNDMzMzRmZGJjYjMxLi43MWFmYjZhYmNlYzZm
MTE5NmMwODFhOTZkOGFiZmEzZTdjNWRkMGNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9E
ZXJpdmVkU291cmNlcy5tYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1h
a2UKQEAgLTE2MzMsMTAgKzE2MzMsMTAgQEAgJChHRU5FUkFURV9TRVRUSU5HU19QQVRURVJOUykg
OiAkKFdlYkNvcmUpL1NjcmlwdHMvR2VuZXJhdGVTZXR0aW5ncy5yYiAkKEdFTkVSQVQKIAogIyBX
SExTTCBTdGFuZGFyZCBMaWJyYXJ5CiAKLWFsbCA6IFdITFNMU3RhbmRhcmRMaWJyYXJ5LmNwcAor
YWxsIDogV0hMU0xTdGFuZGFyZExpYnJhcnkuaAogCi1XSExTTFN0YW5kYXJkTGlicmFyeS5jcHAg
OiAkKEphdmFTY3JpcHRDb3JlX1NDUklQVFNfRElSKS94eGQucGwgJChXZWJDb3JlKS9Nb2R1bGVz
L3dlYmdwdS9XSExTTC9XSExTTFN0YW5kYXJkTGlicmFyeS50eHQKLQkkKFBFUkwpICQoSmF2YVNj
cmlwdENvcmVfU0NSSVBUU19ESVIpL3h4ZC5wbCBXSExTTFN0YW5kYXJkTGlicmFyeSAkKFdlYkNv
cmUpL01vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMU3RhbmRhcmRMaWJyYXJ5LnR4dCBXSExTTFN0
YW5kYXJkTGlicmFyeS5oCitXSExTTFN0YW5kYXJkTGlicmFyeS5oIDogJChKYXZhU2NyaXB0Q29y
ZV9TQ1JJUFRTX0RJUikveHhkLnBsICQoV2ViQ29yZSkvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hM
U0xTdGFuZGFyZExpYnJhcnkudHh0CisJJChQRVJMKSAkKEphdmFTY3JpcHRDb3JlX1NDUklQVFNf
RElSKS94eGQucGwgV0hMU0xTdGFuZGFyZExpYnJhcnkgJChXZWJDb3JlKS9Nb2R1bGVzL3dlYmdw
dS9XSExTTC9XSExTTFN0YW5kYXJkTGlicmFyeS50eHQgJDwKIAogIyAtLS0tLS0tLQogCg==
</data>
<flag name="review"
          id="384243"
          type_id="1"
          status="+"
          setter="mitz"
    />
          </attachment>
      

    </bug>

</bugzilla>