197140 2019-04-20 09:24:32 -0700 Update text for old EWS submit button 2019-04-20 11:45:18 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu lforschler webkit-bug-importer oldest_to_newest 1529082 0 aakash_jain 2019-04-20 09:24:32 -0700 The text for new EWS submit button is 'Submit to new EWS'. To be consistent, and less confusing for new developers, the text for old EWS submit button should be 'Submit to old EWS'. 1529083 1 367890 aakash_jain 2019-04-20 09:25:08 -0700 Created attachment 367890 Patch 1529086 2 367890 ap 2019-04-20 10:22:18 -0700 Comment on attachment 367890 Patch Has there been feedback suggesting this? I’m not sure if old/new is an important distinction for WebKit developers - what seems important to me is which tests are triggered by which button. It may be ok to treat this temporary state where we have two as transitional, and not over-optimize it. Longer term, this button name should be tweaked to be more clear on two things: 1. It doesn’t need to be pressed if the attachment is a patch for review. 2. What EWS even is in the first place. 1529092 3 aakash_jain 2019-04-20 11:08:38 -0700 > Has there been feedback suggesting this? Nope. It was a just a quick fix, as I was working on this code. > I’m not sure if old/new is an important distinction for WebKit developers - what seems important to me is which tests are triggered by which button. > > It may be ok to treat this temporary state where we have two as transitional, and not over-optimize it. Yeah. > Longer term, this button name should be tweaked to be more clear on two things: > > 1. It doesn’t need to be pressed if the attachment is a patch for review. https://bugs.webkit.org/show_bug.cgi?id=197138 would make this button appear less frequently in such cases. Maybe in future we can make bugzilla send push events to EWS, so that this button doesn't appear at all. > 2. What EWS even is in the first place. Agree. 1529104 4 367890 commit-queue 2019-04-20 11:44:59 -0700 Comment on attachment 367890 Patch Clearing flags on attachment: 367890 Committed r244487: <https://trac.webkit.org/changeset/244487> 1529105 5 commit-queue 2019-04-20 11:45:01 -0700 All reviewed patches have been landed. Closing bug. 1529106 6 webkit-bug-importer 2019-04-20 11:45:18 -0700 <rdar://problem/50074153> 367890 2019-04-20 09:25:08 -0700 2019-04-20 11:44:59 -0700 Patch bug-197140-20190420122507.patch text/plain 1256 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDQ4MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTA0LTIwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBVcGRhdGUgdGV4dCBmb3Igb2xkIEVXUyBzdWJtaXQgYnV0dG9uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcxNDAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFF1ZXVlU3RhdHVz U2VydmVyL3RlbXBsYXRlcy9zdGF0dXNidWJibGUuaHRtbDoKKwogMjAxOS0wNC0xOSAgS2VpdGgg TWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc2NyaXB0IHRv IG1lcmdlIHJ1bl9iZW5jaG1hcmsganNvbnMKSW5kZXg6IFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVy L3RlbXBsYXRlcy9zdGF0dXNidWJibGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9RdWV1ZVN0 YXR1c1NlcnZlci90ZW1wbGF0ZXMvc3RhdHVzYnViYmxlLmh0bWwJKHJldmlzaW9uIDI0NDQ4MykK KysrIFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL3RlbXBsYXRlcy9zdGF0dXNidWJibGUuaHRtbAko d29ya2luZyBjb3B5KQpAQCAtOTQsNyArOTQsNyBAQCB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigi bWVzc2FnZSIsIGZ1bmN0CiAgIDxmb3JtIG5hbWU9InN1Ym1pdF90b19ld3MiIG1ldGhvZD0iUE9T VCIgYWN0aW9uPSIvc3VibWl0LXRvLWV3cyI+CiAgICAgPGlucHV0IHR5cGU9ImhpZGRlbiIgbmFt ZT0iYXR0YWNobWVudF9pZCIgdmFsdWU9Int7IGF0dGFjaG1lbnRfaWQgfX0iPgogICAgIDxpbnB1 dCB0eXBlPSJoaWRkZW4iIG5hbWU9Im5leHRfYWN0aW9uIiB2YWx1ZT0icmV0dXJuX3RvX2J1YmJs ZXMiPgotICAgIDxpbnB1dCBjbGFzcz0ic3RhdHVzIiB0eXBlPSJzdWJtaXQiIHZhbHVlPSJTdWJt aXQgZm9yIEVXUyBhbmFseXNpcyI+CisgICAgPGlucHV0IGNsYXNzPSJzdGF0dXMiIHR5cGU9InN1 Ym1pdCIgdmFsdWU9IlN1Ym1pdCB0byBvbGQgRVdTIj4KICAgPC9mb3JtPgogeyUgZW5kaWYgJX0K IAo=