<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>197137</bug_id>
          
          <creation_ts>2019-04-20 01:30:11 -0700</creation_ts>
          <short_desc>REGRESSION (r243137): SVGViewElement.viewTarget should not return a new object</short_desc>
          <delta_ts>2019-04-22 11:18:08 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>SVG</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Said Abou-Hallawa">sabouhallawa</reporter>
          <assigned_to name="Said Abou-Hallawa">sabouhallawa</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1529061</commentid>
    <comment_count>0</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2019-04-20 01:30:11 -0700</bug_when>
    <thetext>Open the attached test case. The following assertion fires:

0x0000000762c6d4c0 in ::WTFCrash() at /Volumes/Data/WebKit/OpenSource/Source/WTF/wtf/Assertions.cpp:305
0x0000000749defb5b in WTFCrashWithInfo(int, char const*, char const*, int) at /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/Assertions.h:566
0x000000074b159905 in std::__1::enable_if&lt;std::is_same&lt;WebCore::SVGStringList, WebCore::SVGStringList&gt;::value, WebCore::JSDOMWrapperConverterTraits&lt;WebCore::SVGStringList&gt;::WrapperClass*&gt;::type WebCore::createWrapper&lt;WebCore::SVGStringList, WebCore::SVGStringList&gt;(WebCore::JSDOMGlobalObject*, WTF::Ref&lt;WebCore::SVGStringList, WTF::DumbPtrTraits&lt;WebCore::SVGStringList&gt; &gt;&amp;&amp;) at /Volumes/Data/WebKit/OpenSource/Source/WebCore/bindings/js/JSDOMWrapperCache.h:185
0x000000074b1597ec in WebCore::toJSNewlyCreated(JSC::ExecState*, WebCore::JSDOMGlobalObject*, WTF::Ref&lt;WebCore::SVGStringList, WTF::DumbPtrTraits&lt;WebCore::SVGStringList&gt; &gt;&amp;&amp;) at /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/DerivedSources/WebCore/JSSVGStringList.cpp:381
0x000000074b194500 in JSC::JSValue WebCore::JSConverter&lt;WebCore::IDLInterface&lt;WebCore::SVGStringList&gt; &gt;::convertNewlyCreated&lt;WTF::Ref&lt;WebCore::SVGStringList, WTF::DumbPtrTraits&lt;WebCore::SVGStringList&gt; &gt; &gt;(JSC::ExecState&amp;, WebCore::JSDOMGlobalObject&amp;, WTF::Ref&lt;WebCore::SVGStringList, WTF::DumbPtrTraits&lt;WebCore::SVGStringList&gt; &gt;&amp;&amp;) at /Volumes/Data/WebKit/OpenSource/Source/WebCore/bindings/js/JSDOMConvertInterface.h:87
0x000000074b1944a0 in JSC::JSValue WebCore::toJSNewlyCreated&lt;WebCore::IDLInterface&lt;WebCore::SVGStringList&gt;, WTF::Ref&lt;WebCore::SVGStringList, WTF::DumbPtrTraits&lt;WebCore::SVGStringList&gt; &gt; &gt;(JSC::ExecState&amp;, WebCore::JSDOMGlobalObject&amp;, WTF::Ref&lt;WebCore::SVGStringList, WTF::DumbPtrTraits&lt;WebCore::SVGStringList&gt; &gt;&amp;&amp;) at /Volumes/Data/WebKit/OpenSource/Source/WebCore/bindings/js/JSDOMConvertBase.h:162
0x000000074b194414 in std::__1::enable_if&lt;!(IsExceptionOr&lt;WTF::Ref&lt;WebCore::SVGStringList, WTF::DumbPtrTraits&lt;WebCore::SVGStringList&gt; &gt; &gt;::value), JSC::JSValue&gt;::type WebCore::toJSNewlyCreated&lt;WebCore::IDLInterface&lt;WebCore::SVGStringList&gt;, WTF::Ref&lt;WebCore::SVGStringList, WTF::DumbPtrTraits&lt;WebCore::SVGStringList&gt; &gt; &gt;(JSC::ExecState&amp;, WebCore::JSDOMGlobalObject&amp;, JSC::ThrowScope&amp;, WTF::Ref&lt;WebCore::SVGStringList, WTF::DumbPtrTraits&lt;WebCore::SVGStringList&gt; &gt;&amp;&amp;) at /Volumes/Data/WebKit/OpenSource/Source/WebCore/bindings/js/JSDOMConvertBase.h:207
0x000000074b1942d3 in WebCore::jsSVGViewElementViewTargetGetter(JSC::ExecState&amp;, WebCore::JSSVGViewElement&amp;, JSC::ThrowScope&amp;) at /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/DerivedSources/WebCore/JSSVGViewElement.cpp:198
0x000000074b186750 in long long WebCore::IDLAttribute&lt;WebCore::JSSVGViewElement&gt;::get&lt;&amp;(WebCore::jsSVGViewElementViewTargetGetter(JSC::ExecState&amp;, WebCore::JSSVGViewElement&amp;, JSC::ThrowScope&amp;)), (WebCore::CastedThisErrorBehavior)3&gt;(JSC::ExecState&amp;, long long, char const*) at /Volumes/Data/WebKit/OpenSource/Source/WebCore/bindings/js/JSDOMAttribute.h:69
0x000000074b186638 in WebCore::jsSVGViewElementViewTarget(JSC::ExecState*, long long, JSC::PropertyName) at /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/DerivedSources/WebCore/JSSVGViewElement.cpp:204

r243137 removes the tear off objects of SVGStringList. Since the SVGElements now owns Ref pointers to the SVG properties, there is no need to create wrappers for these properties anymore. Therefore all the DOM objects accessing the same property should wrap the same Ref pointer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529062</commentid>
    <comment_count>1</comment_count>
      <attachid>367882</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2019-04-20 01:39:34 -0700</bug_when>
    <thetext>Created attachment 367882
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529063</commentid>
    <comment_count>2</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2019-04-20 01:42:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/50065198&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529067</commentid>
    <comment_count>3</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2019-04-20 01:48:07 -0700</bug_when>
    <thetext>Notes:

1. The new layout test, in the patch https://bugs.webkit.org/attachment.cgi?id=367882&amp;action=review, does not pass with the tear off objects implementation. The attribute was not synchronized after changing the SVGStringList.

2. SVGViewElement.viewTarget was removed from SVG 2; see https://www.w3.org/TR/SVG2/linking.html#InterfaceSVGViewElement.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529117</commentid>
    <comment_count>4</comment_count>
      <attachid>367882</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-04-20 17:03:50 -0700</bug_when>
    <thetext>Comment on attachment 367882
Patch

Clearing flags on attachment: 367882

Committed r244491: &lt;https://trac.webkit.org/changeset/244491&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529118</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-04-20 17:03:52 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529119</commentid>
    <comment_count>6</comment_count>
      <attachid>367882</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-04-20 17:06:41 -0700</bug_when>
    <thetext>Comment on attachment 367882
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367882&amp;action=review

&gt; Source/WebCore/svg/SVGViewElement.idl:27
&gt; -    [NewObject] readonly attribute SVGStringList viewTarget;
&gt; +    readonly attribute SVGStringList viewTarget;

Wait, had one thought. Should this be using [SameObject] now?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529176</commentid>
    <comment_count>7</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2019-04-21 18:15:37 -0700</bug_when>
    <thetext>Reopen to upload a followup patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529177</commentid>
    <comment_count>8</comment_count>
      <attachid>367922</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2019-04-21 18:17:33 -0700</bug_when>
    <thetext>Created attachment 367922
Followup patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529309</commentid>
    <comment_count>9</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2019-04-22 11:18:08 -0700</bug_when>
    <thetext>Committed r244503: &lt;https://trac.webkit.org/changeset/244503&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>367882</attachid>
            <date>2019-04-20 01:39:34 -0700</date>
            <delta_ts>2019-04-20 17:03:50 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-197137-20190420013933.patch</filename>
            <type>text/plain</type>
            <size>4864</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmViMGUwYjc1MDI2OTI4
N2I1NjdhZjdkZGYzMTY4ZDRjNmNkMmJiYi4uYTJmMDNhNTlkNTZlNWJjNWM4ZjI3ZDY1NDA1NDgz
OTM0Y2VlMDg5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA0LTIwICBTYWlk
IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIy
NDMxMzcpOiBTVkdWaWV3RWxlbWVudC52aWV3VGFyZ2V0IHNob3VsZCBub3QgcmV0dXJuIGEgbmV3
IG9iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTk3MTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
QWxsIHRoZSBET00gb2JqZWN0cyBhY2Nlc3NpbmcgdGhlIHZpZXdUYXJnZXQgb2YgdGhlIHNhbWUg
U1ZHVmlld0VsZW1lbnQgCisgICAgICAgIHNob3VsZCBob2xkIGEgUmVmIHBvaW50ZXIgdG8gdGhl
IHNhbWUgU1ZHU3RyaW5nTGlzdCBwcm9wZXJ0eS4KKworICAgICAgICBUZXN0OiBzdmcvZG9tL1NW
R1ZpZXdFbGVtZW50LXZpZXdUYXJnZXQuaHRtbAorCisgICAgICAgICogc3ZnL1NWR1ZpZXdFbGVt
ZW50LmlkbDoKKwogMjAxOS0wNC0xOSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+
CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxpbmVzOiBDUFU6IGVuc3VyZSB0aGF0IHRy
YWNraW5nIHN0b3BzIHdoZW4gZGlzY29ubmVjdGluZyBXZWIgSW5zcGVjdG9yCmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVmlld0VsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUv
c3ZnL1NWR1ZpZXdFbGVtZW50LmlkbAppbmRleCBkNzE3NjQ3ODljYzQ0NmM2N2RmMmQ4MmU4ODBk
MmRlZTNlNjUyZjk5Li5jY2RlY2ViNzg5YmZjNjYxOWM2MDI2NjQyNTNjOGU3NTI0ZGUxN2MzIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVmlld0VsZW1lbnQuaWRsCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL3N2Zy9TVkdWaWV3RWxlbWVudC5pZGwKQEAgLTI0LDcgKzI0LDcgQEAKICAq
LwogCiBpbnRlcmZhY2UgU1ZHVmlld0VsZW1lbnQgOiBTVkdFbGVtZW50IHsKLSAgICBbTmV3T2Jq
ZWN0XSByZWFkb25seSBhdHRyaWJ1dGUgU1ZHU3RyaW5nTGlzdCB2aWV3VGFyZ2V0OworICAgIHJl
YWRvbmx5IGF0dHJpYnV0ZSBTVkdTdHJpbmdMaXN0IHZpZXdUYXJnZXQ7CiB9OwogCiBTVkdWaWV3
RWxlbWVudCBpbXBsZW1lbnRzIFNWR0V4dGVybmFsUmVzb3VyY2VzUmVxdWlyZWQ7CmRpZmYgLS1n
aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg
MTI4MTkwN2U1MjY1NTkyMDQzZDMzMGE0N2EzOGFiM2Q2YmNiZGM4MS4uYzNhMGE1MjkzZjJjYjZk
YzQyM2Q2ZjhjZmRiOTczZTAzMWM4N2IwYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl
TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA0
LTIwICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JF
U1NJT04gKHIyNDMxMzcpOiBTVkdWaWV3RWxlbWVudC52aWV3VGFyZ2V0IHNob3VsZCBub3QgcmV0
dXJuIGEgbmV3IG9iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTk3MTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgKiBzdmcvZG9tL1NWR1ZpZXdFbGVtZW50LXZpZXdUYXJnZXQtZXhwZWN0ZWQudHh0
OiBBZGRlZC4KKyAgICAgICAgKiBzdmcvZG9tL1NWR1ZpZXdFbGVtZW50LXZpZXdUYXJnZXQuaHRt
bDogQWRkZWQuCisKIDIwMTktMDQtMTkgIE1lZ2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFw
cGxlLmNvbT4KIAogICAgICAgICBGaXggTG9uZyBQcmVzcyBJbWFnZSBUZXN0CmRpZmYgLS1naXQg
YS9MYXlvdXRUZXN0cy9zdmcvZG9tL1NWR1ZpZXdFbGVtZW50LXZpZXdUYXJnZXQtZXhwZWN0ZWQu
dHh0IGIvTGF5b3V0VGVzdHMvc3ZnL2RvbS9TVkdWaWV3RWxlbWVudC12aWV3VGFyZ2V0LWV4cGVj
dGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwLi45MTZjZTI5NTcwYjlkYTc4NjQ3ODU3OTkwM2U2MGZhYjA3OTdm
ZDhlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2RvbS9TVkdWaWV3RWxlbWVu
dC12aWV3VGFyZ2V0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIzIEBACitUaGlzIHRlc3QgY2hl
Y2tzIHRoZSBTVkdTdHJpbmdMaXN0IEFQSSAtIHV0aWxpemluZyB0aGUgdmlld1RhcmdldCBwcm9w
ZXJ0eSBvZiBTVkdWaWV3RWxlbWVudAorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp
ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKwor
CitDaGVjayBpbml0aWFsIHZpZXdUYXJnZXQgdmFsdWUKK1BBU1Mgdmlld0VsZW1lbnQudmlld1Rh
cmdldC50b1N0cmluZygpIGlzICJbb2JqZWN0IFNWR1N0cmluZ0xpc3RdIgorUEFTUyB2aWV3RWxl
bWVudC52aWV3VGFyZ2V0Lm51bWJlck9mSXRlbXMgaXMgMQorUEFTUyB2aWV3RWxlbWVudC52aWV3
VGFyZ2V0LmdldEl0ZW0oMCkgaXMgInJlY3QtdmlldyIKKworQ2hlY2sgdGhlIHVuaXF1ZW5lc3Mg
b2Ygdmlld1RhcmdldCBwZXIgU1ZHVmlld0VsZW1lbnQKK1BBU1Mgdmlld0VsZW1lbnQudmlld1Rh
cmdldCBpcyB2aWV3VGFyZ2V0CitQQVNTIHZpZXdUYXJnZXQuZ2V0SXRlbSgwKSBpcyAicmVjdC12
aWV3IgorCitDaGVjayBtb2RpZnlpbmcgdmlld1RhcmdldAorUEFTUyB2aWV3VGFyZ2V0LnJlcGxh
Y2VJdGVtKCdjaXJjbGUtdmlldycsIDApIGlzICJjaXJjbGUtdmlldyIKK1BBU1Mgdmlld0VsZW1l
bnQudmlld1RhcmdldC5nZXRJdGVtKDApIGlzICJjaXJjbGUtdmlldyIKK1BBU1Mgdmlld0VsZW1l
bnQuZ2V0QXR0cmlidXRlKCd2aWV3VGFyZ2V0JykgaXMgImNpcmNsZS12aWV3IgorUEFTUyBzdWNj
ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xh
eW91dFRlc3RzL3N2Zy9kb20vU1ZHVmlld0VsZW1lbnQtdmlld1RhcmdldC5odG1sIGIvTGF5b3V0
VGVzdHMvc3ZnL2RvbS9TVkdWaWV3RWxlbWVudC12aWV3VGFyZ2V0Lmh0bWwKbmV3IGZpbGUgbW9k
ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u
MDMzMzUyOTY5NDYzMGQ5YTg4YjEwYWIyYTA5Y2M3MmNmMzExOTg1OAotLS0gL2Rldi9udWxsCisr
KyBiL0xheW91dFRlc3RzL3N2Zy9kb20vU1ZHVmlld0VsZW1lbnQtdmlld1RhcmdldC5odG1sCkBA
IC0wLDAgKzEsMzYgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3Vy
Y2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRl
c2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CitkZXNj
cmlwdGlvbigiVGhpcyB0ZXN0IGNoZWNrcyB0aGUgU1ZHU3RyaW5nTGlzdCBBUEkgLSB1dGlsaXpp
bmcgdGhlIHZpZXdUYXJnZXQgcHJvcGVydHkgb2YgU1ZHVmlld0VsZW1lbnQiKTsKKwordmFyIHZp
ZXdFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudE5TKCJodHRwOi8vd3d3LnczLm9yZy8y
MDAwL3N2ZyIsICJ2aWV3Iik7Cit2aWV3RWxlbWVudC5zZXRBdHRyaWJ1dGUoInZpZXdUYXJnZXQi
LCAicmVjdC12aWV3Iik7CisKK2RlYnVnKCIiKTsKK2RlYnVnKCJDaGVjayBpbml0aWFsIHZpZXdU
YXJnZXQgdmFsdWUiKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygidmlld0VsZW1lbnQudmlld1Rh
cmdldC50b1N0cmluZygpIiwgIltvYmplY3QgU1ZHU3RyaW5nTGlzdF0iKTsKK3Nob3VsZEJlKCJ2
aWV3RWxlbWVudC52aWV3VGFyZ2V0Lm51bWJlck9mSXRlbXMiLCAiMSIpOworc2hvdWxkQmVFcXVh
bFRvU3RyaW5nKCJ2aWV3RWxlbWVudC52aWV3VGFyZ2V0LmdldEl0ZW0oMCkiLCAicmVjdC12aWV3
Iik7CisKK3ZhciB2aWV3VGFyZ2V0ID0gdmlld0VsZW1lbnQudmlld1RhcmdldDsKK2RlYnVnKCIi
KTsKK2RlYnVnKCJDaGVjayB0aGUgdW5pcXVlbmVzcyBvZiB2aWV3VGFyZ2V0IHBlciBTVkdWaWV3
RWxlbWVudCIpOworc2hvdWxkQmUoInZpZXdFbGVtZW50LnZpZXdUYXJnZXQiLCAidmlld1Rhcmdl
dCIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJ2aWV3VGFyZ2V0LmdldEl0ZW0oMCkiLCAicmVj
dC12aWV3Iik7CisKK2RlYnVnKCIiKTsKK2RlYnVnKCJDaGVjayBtb2RpZnlpbmcgdmlld1Rhcmdl
dCIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJ2aWV3VGFyZ2V0LnJlcGxhY2VJdGVtKCdjaXJj
bGUtdmlldycsIDApIiwgImNpcmNsZS12aWV3Iik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoInZp
ZXdFbGVtZW50LnZpZXdUYXJnZXQuZ2V0SXRlbSgwKSIsICJjaXJjbGUtdmlldyIpOworc2hvdWxk
QmVFcXVhbFRvU3RyaW5nKCJ2aWV3RWxlbWVudC5nZXRBdHRyaWJ1dGUoJ3ZpZXdUYXJnZXQnKSIs
ICJjaXJjbGUtdmlldyIpOworCitzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+
Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+
Cis8L2JvZHk+Cis8L2h0bWw+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>367922</attachid>
            <date>2019-04-21 18:17:33 -0700</date>
            <delta_ts>2019-04-22 10:41:57 -0700</delta_ts>
            <desc>Followup patch</desc>
            <filename>bug-197137-20190421181733.patch</filename>
            <type>text/plain</type>
            <size>2299</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQ5ZmIxYjVlYzc0OWI2
ZTVjN2U3ZDMzNjc4MWJkODFkMTMxZGQ0My4uNzNlMGRmODZiOTE2NjViYWJjM2M0YWMwNWQxZDIy
M2NiZWZlN2ZmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA0LTIxICBTYWlk
IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIE1hcmsgU1ZHU3RyaW5n
TGlzdCBwcm9wZXJ0aWVzICdbU2FtZU9iamVjdF0nIGluIHRoZSBJREwgZmlsZXMKKyAgICAgICAg
Rm9sbG93dXAgdG8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzEz
NworCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgIFRoZSBTVkcg
ZWxlbWVudHMgZG8gbm90IGNyZWF0ZSB0ZWFyLW9mZiB3cmFwcGVycyBmb3IgU1ZHU3RyaWdMaXN0
IERPTQorICAgICAgICBvYmplY3RzIGFueW1vcmUuIEluc3RlYWQgdGhleSByZXR1cm4gUmVmIHBv
aW50ZXJzIHRvIHRoZSBzYW1lIFJlZkNvdW50ZWQKKyAgICAgICAgb2JqZWN0cy4gU28gdGhleSBz
aG91bGQgYmUgbWFya2VkICdbU2FtZU9iamVjdF0nIGluIHRoZWlyIElETCBmaWxlcy4KKworICAg
ICAgICAqIHN2Zy9TVkdUZXN0cy5pZGw6CisgICAgICAgICogc3ZnL1NWR1ZpZXdFbGVtZW50Lmlk
bDoKKwogMjAxOS0wNC0yMSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAg
ICAgV0hMU0xQcmVwYXJlLmNwcCBhbHdheXMgcmVjb21waWxlcywgZXZlbiBpZiBub3RoaW5nIHdh
cyBjaGFuZ2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVGVzdHMuaWRsIGIv
U291cmNlL1dlYkNvcmUvc3ZnL1NWR1Rlc3RzLmlkbAppbmRleCAzYjdhOWM3ODgwOTU4MmI4Zjdk
NTEzZDc4NTRmYjBjMDFkMTBjMjAzLi4zYzkwZmU1N2U1MGE4YWY5MDdlZjhhNTIyYzI5NmUzZTVh
N2IxNTJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVGVzdHMuaWRsCisrKyBi
L1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUZXN0cy5pZGwKQEAgLTI4LDkgKzI4LDkgQEAKICAgICBO
b0ludGVyZmFjZU9iamVjdCwKICAgICBTdXBwcmVzc1RvSlNPYmplY3QsCiBdIGludGVyZmFjZSBT
VkdUZXN0cyB7Ci0gICAgcmVhZG9ubHkgYXR0cmlidXRlIFNWR1N0cmluZ0xpc3QgcmVxdWlyZWRG
ZWF0dXJlczsKLSAgICByZWFkb25seSBhdHRyaWJ1dGUgU1ZHU3RyaW5nTGlzdCByZXF1aXJlZEV4
dGVuc2lvbnM7Ci0gICAgcmVhZG9ubHkgYXR0cmlidXRlIFNWR1N0cmluZ0xpc3Qgc3lzdGVtTGFu
Z3VhZ2U7CisgICAgW1NhbWVPYmplY3RdIHJlYWRvbmx5IGF0dHJpYnV0ZSBTVkdTdHJpbmdMaXN0
IHJlcXVpcmVkRmVhdHVyZXM7CisgICAgW1NhbWVPYmplY3RdIHJlYWRvbmx5IGF0dHJpYnV0ZSBT
VkdTdHJpbmdMaXN0IHJlcXVpcmVkRXh0ZW5zaW9uczsKKyAgICBbU2FtZU9iamVjdF0gcmVhZG9u
bHkgYXR0cmlidXRlIFNWR1N0cmluZ0xpc3Qgc3lzdGVtTGFuZ3VhZ2U7CiAKICAgICAvLyBGSVhN
RTogVXNpbmcgInVuZGVmaW5lZCIgYXMgZGVmYXVsdCBwYXJhbWV0ZXIgdmFsdWUgaXMgd3Jvbmcu
CiAgICAgYm9vbGVhbiBoYXNFeHRlbnNpb24ob3B0aW9uYWwgRE9NU3RyaW5nIGV4dGVuc2lvbiA9
ICJ1bmRlZmluZWQiKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdWaWV3RWxl
bWVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVmlld0VsZW1lbnQuaWRsCmluZGV4IGNj
ZGVjZWI3ODliZmM2NjE5YzYwMjY2NDI1M2M4ZTc1MjRkZTE3YzMuLjVmN2FiYTMyMjZjNzRlOTI3
OTVhZmU0NzlhZTQ0MmJmYzkwNTM2NGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9T
VkdWaWV3RWxlbWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1ZpZXdFbGVtZW50
LmlkbApAQCAtMjQsNyArMjQsNyBAQAogICovCiAKIGludGVyZmFjZSBTVkdWaWV3RWxlbWVudCA6
IFNWR0VsZW1lbnQgewotICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBTVkdTdHJpbmdMaXN0IHZpZXdU
YXJnZXQ7CisgICAgW1NhbWVPYmplY3RdIHJlYWRvbmx5IGF0dHJpYnV0ZSBTVkdTdHJpbmdMaXN0
IHZpZXdUYXJnZXQ7CiB9OwogCiBTVkdWaWV3RWxlbWVudCBpbXBsZW1lbnRzIFNWR0V4dGVybmFs
UmVzb3VyY2VzUmVxdWlyZWQ7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>