197118 2019-04-19 14:34:24 -0700 AbstractValue can represent more than int52 2019-04-19 17:37:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1528874 0 saam 2019-04-19 14:34:24 -0700 ... 1528875 1 saam 2019-04-19 14:35:10 -0700 <rdar://problem/49969960> 1528880 2 367829 saam 2019-04-19 14:40:54 -0700 Created attachment 367829 patch 1528890 3 367829 msaboff 2019-04-19 14:52:33 -0700 Comment on attachment 367829 patch r=me 1528971 4 367829 saam 2019-04-19 17:15:07 -0700 Comment on attachment 367829 patch Thanks for the review. 1528989 5 367829 commit-queue 2019-04-19 17:37:49 -0700 Comment on attachment 367829 patch Clearing flags on attachment: 367829 Committed r244480: <https://trac.webkit.org/changeset/244480> 1528990 6 commit-queue 2019-04-19 17:37:50 -0700 All reviewed patches have been landed. Closing bug. 367829 2019-04-19 14:40:54 -0700 2019-04-19 17:37:49 -0700 patch a-backup.diff text/plain 6644 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDQ0NjkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTE5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIEFic3RyYWN0VmFsdWUgY2FuIHJlcHJlc2VudCBtb3JlIHRoYW4gaW50 NTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzEx OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk5Njk5NjA+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvYWJzdHJhY3QtdmFsdWUtY2Fu LWluY2x1ZGUtaW50NTIuanM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKyAgICAgICAgKGluZGV4 LmluZGV4LjguaW5kZXguNjAuaW5kZXguNjUuaW5kZXguMTIzNC5pbmRleC4xMjM0LnBhcnNlSW50 LnN0cmluZ19hcHBlYXJlZF9oZXJlLlN0cmluZy5mcm9tQ2hhckNvZGUpOgorCiAyMDE5LTA0LTE4 ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dURl0gU3Ry aW5nQnVpbGRlciBzaG91bGQgc2V0IGNvcnJlY3QgbV9pczhCaXQgZmxhZyB3aGVuIG1lcmdpbmcK SW5kZXg6IEpTVGVzdHMvc3RyZXNzL2Fic3RyYWN0LXZhbHVlLWNhbi1pbmNsdWRlLWludDUyLmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2Fic3RyYWN0LXZhbHVlLWNhbi1pbmNsdWRl LWludDUyLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2Fic3RyYWN0LXZhbHVl LWNhbi1pbmNsdWRlLWludDUyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjcgQEAKKy8v QCBydW5EZWZhdWx0KCItLXVzZVJhbmRvbWl6aW5nRnV6emVyQWdlbnQ9MSIsICItLWppdFBvbGlj eVNjYWxlPTAiLCAiLS11c2VDb25jdXJyZW50SklUPTAiLCAiLS11c2VDb25jdXJyZW50R0M9MCIp CisKK2Z1bmN0aW9uIGZvbyhuKSB7CisgICAgd2hpbGUgKG4pIHsKKyAgICAgICAgbiA+Pj49IDE7 CisgICAgfQorICAgIHJldHVybiAnJ1swXTsKK30KK3ZhciBpbmRleFA7Cit2YXIgaW5kZXhPID0g MDsKK2ZvciAodmFyIGluZGV4ID0gMDsgaW5kZXggPD0gMTAwOyBpbmRleCsrKSB7CisgICAgaWYg KGluZGV4IDwgOCB8fCBpbmRleCA+IDYwICYmIGluZGV4IDw9IDY1IHx8IGluZGV4ID4gMTIzNCAm JiBpbmRleCA8IDEyMzQpIHsKKyAgICAgICAgbGV0IHggPSBmb28oaW5kZXgpOworICAgICAgICBp ZiAocGFyc2VJbnQoJzFaJyArIFN0cmluZy5mcm9tQ2hhckNvZGUoaW5kZXgpLCAzNikgIT09IDcx KSB7CisgICAgICAgICAgICBpZiAoaW5kZXhPID09PSAwKSB7CisgICAgICAgICAgICAgICAgaW5k ZXhPID0gMDsKKyAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgaWYgKGluZGV4 IC0gaW5kZXhQKSB7CisgICAgICAgICAgICAgICAgICAgIHZhciBoZXhQID0gZm9vKGluZGV4UCk7 CisgICAgICAgICAgICAgICAgICAgIGluZGV4IC0gaW5kZXgKKyAgICAgICAgICAgICAgICAgICAg aW5kZXggPSBpbmRleDsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisgICAgICAg ICAgICBpbmRleFAgPSBpbmRleDsKKyAgICAgICAgfQorICAgIH0KK30KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ0NDU2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQ0IEBACisyMDE5LTA0LTE5ICBT YWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIEFic3RyYWN0VmFsdWUg Y2FuIHJlcHJlc2VudCBtb3JlIHRoYW4gaW50NTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzExOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk5 Njk5NjA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TGV0J3MgYW5hbHl6ZSB0aGlzIGNvbnRyb2wgZmxvdyBkaWFtb25kOgorICAgICAgICAKKyAgICAg ICAgIzAKKyAgICAgICAgYnJhbmNoICMxLCAjMgorICAgICAgICAKKyAgICAgICAgIzE6CisgICAg ICAgIFB1dFN0YWNrKEpTVmFsdWUsIGxvYzQyKQorICAgICAgICBKdW1wICMzCisgICAgICAgIAor ICAgICAgICAjMjoKKyAgICAgICAgUHV0U3RhY2soSW50NTIsIGxvYzQyKQorICAgICAgICBKdW1w ICMzCisgICAgICAgIAorICAgICAgICAjMzoKKyAgICAgICAgLi4uCisgICAgICAgIAorICAgICAg ICBPdXIgYWJzdHJhY3QgdmFsdWUgZm9yIGxvYzQyIGF0IHRoZSBoZWFkIG9mICMzIHdpbGwgY29u dGFpbiBhbiBhYnN0cmFjdAorICAgICAgICB2YWx1ZSB0aGF0IHVzIHRoZSB1bmlvbiBvZiBJbnQ1 MiB3aXRoIG90aGVyIHRoaW5ncy4gT2J2aW91c2x5IGluIHRoZQorICAgICAgICBhYm92ZSBwcm9n cmFtLCBhIEdldFN0YWNrIGZvciBsb2M0MiB3b3VsZCBiZSBpbmF2bGlkLCBzaW5jZSBpdCBtaWdo dAorICAgICAgICBiZSBsb2FkaW5nIGVpdGhlciBKU1ZhbHVlIG9yIEludDUyLiBIb3dldmVyLCB0 aGUgYWJzdHJhY3QgaW50ZXJwcmV0ZXIKKyAgICAgICAganVzdCB0cmFja3Mgd2hhdCB0aGUgdmFs dWUgY291bGQgYmUsIGFuZCBpdCBjb3VsZCBiZSBJbnQ1MiBvciBKU1ZhbHVlLgorICAgICAgICAK KyAgICAgICAgV2hlbiBJIGRpZCB0aGUgSW50NTIgcmVmYWN0b3JpbmcsIEkgZXhwZWN0ZWQgc3Vj aCB0aGluZ3MgdG8gbmV2ZXIgaGFwcGVuLAorICAgICAgICBidXQgaXQgdHVybnMgb3V0IGl0IGRv ZXMuIFdlIHNob3VsZCBqdXN0IGFsbG93IGZvciB0aGlzIGluc3RlYWQgb2YgYXNzZXJ0aW5nCisg ICAgICAgIGFnYWluc3QgaXQgc2luY2UgaXQncyB2YWxpZCBJUiB0byBkbyB0aGUgYWJvdmUuCisK KyAgICAgICAgKiBieXRlY29kZS9TcGVjdWxhdGVkVHlwZS5jcHA6CisgICAgICAgIChKU0M6OmR1 bXBTcGVjdWxhdGlvbik6CisgICAgICAgICogZGZnL0RGR0Fic3RyYWN0VmFsdWUuY3BwOgorICAg ICAgICAoSlNDOjpERkc6OkFic3RyYWN0VmFsdWU6OmNoZWNrQ29uc2lzdGVuY3kgY29uc3QpOgor ICAgICAgICAqIGRmZy9ERkdBYnN0cmFjdFZhbHVlLmg6CisgICAgICAgIChKU0M6OkRGRzo6QWJz dHJhY3RWYWx1ZTo6dmFsaWRhdGVUeXBlQWNjZXB0aW5nQm94ZWRJbnQ1MiBjb25zdCk6CisKIDIw MTktMDQtMTggIFNhYW0gYmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVt b3ZlIHVzZUNvbmN1cnJlbnRCYXJyaWVycyBvcHRpb24KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ieXRlY29kZS9TcGVjdWxhdGVkVHlwZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2J5dGVjb2RlL1NwZWN1bGF0ZWRUeXBlLmNwcAkocmV2aXNpb24gMjQ0NDU2 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1NwZWN1bGF0ZWRUeXBlLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjQ4LDEzICsyNDgsNyBAQCB2b2lkIGR1bXBTcGVjdWxhdGlvbihQ cmludFN0cmVhbSYgb3V0U3RyCiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGlzVG9wID0gZmFs c2U7CiAgICAgfQotICAgIAotICAgIGlmICh2YWx1ZSAmIFNwZWNJbnQzMkFzSW50NTIpCi0gICAg ICAgIHN0ck91dC5wcmludCgiSW50MzJBc0ludDUyIik7CiAKLSAgICBpZiAodmFsdWUgJiBTcGVj Tm9uSW50MzJBc0ludDUyKQotICAgICAgICBzdHJPdXQucHJpbnQoIk5vbkludDMyQXNJbnQ1MiIp OwotICAgICAgICAKICAgICBpZiAoKHZhbHVlICYgU3BlY0J5dGVjb2RlRG91YmxlKSA9PSBTcGVj Qnl0ZWNvZGVEb3VibGUpCiAgICAgICAgIHN0ck91dC5wcmludCgiQnl0ZWNvZGVEb3VibGUiKTsK ICAgICBlbHNlIHsKQEAgLTI4NywxMyArMjgxLDMxIEBAIHZvaWQgZHVtcFNwZWN1bGF0aW9uKFBy aW50U3RyZWFtJiBvdXRTdHIKICAgICBlbHNlCiAgICAgICAgIGlzVG9wID0gZmFsc2U7CiAgICAg Ci0gICAgaWYgKGlzVG9wKQorICAgIGlmICh2YWx1ZSAmIFNwZWNFbXB0eSkKKyAgICAgICAgc3Ry T3V0LnByaW50KCJFbXB0eSIpOworICAgIGVsc2UKKyAgICAgICAgaXNUb3AgPSBmYWxzZTsKKwor ICAgIGlmICh2YWx1ZSAmIFNwZWNJbnQ1MkFueSkgeworICAgICAgICBpZiAoKHZhbHVlICYgU3Bl Y0ludDUyQW55KSA9PSBTcGVjSW50NTJBbnkpCisgICAgICAgICAgICBzdHJPdXQucHJpbnQoIklu dDUyQW55Iik7CisgICAgICAgIGVsc2UgaWYgKHZhbHVlICYgU3BlY0ludDMyQXNJbnQ1MikKKyAg ICAgICAgICAgIHN0ck91dC5wcmludCgiSW50MzJBc0ludDUyIik7CisgICAgICAgIGVsc2UgaWYg KHZhbHVlICYgU3BlY05vbkludDMyQXNJbnQ1MikKKyAgICAgICAgICAgIHN0ck91dC5wcmludCgi Tm9uSW50MzJBc0ludDUyIik7CisgICAgfSBlbHNlCisgICAgICAgIGlzVG9wID0gZmFsc2U7Cisg ICAgCisgICAgaWYgKHZhbHVlID09IFNwZWNCeXRlY29kZVRvcCkKKyAgICAgICAgb3V0LnByaW50 KCJCeXRlY29kZVRvcCIpOworICAgIGVsc2UgaWYgKHZhbHVlID09IFNwZWNIZWFwVG9wKQorICAg ICAgICBvdXQucHJpbnQoIkhlYXBUb3AiKTsKKyAgICBlbHNlIGlmICh2YWx1ZSA9PSBTcGVjRnVs bFRvcCkKKyAgICAgICAgb3V0LnByaW50KCJGdWxsVG9wIik7CisgICAgZWxzZSBpZiAoaXNUb3Ap CiAgICAgICAgIG91dC5wcmludCgiVG9wIik7CiAgICAgZWxzZQogICAgICAgICBvdXQucHJpbnQo c3RyU3RyZWFtLnRvQ1N0cmluZygpKTsKLSAgICAKLSAgICBpZiAodmFsdWUgJiBTcGVjRW1wdHkp Ci0gICAgICAgIG91dC5wcmludCgiRW1wdHkiKTsKIH0KIAogLy8gV2UgZG9uJ3QgZXhwb3NlIHRo aXMgYmVjYXVzZSB3ZSBkb24ndCB3YW50IGFueW9uZSByZWx5aW5nIG9uIHRoZSBmYWN0IHRoYXQg dGhpcyBtZXRob2QgY3VycmVudGx5CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0Fic3RyYWN0VmFsdWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQWJzdHJhY3RWYWx1ZS5jcHAJKHJldmlzaW9uIDI0NDQ1NikKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RWYWx1ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1 MiwxMSArNDUyLDYgQEAgdm9pZCBBYnN0cmFjdFZhbHVlOjpjaGVja0NvbnNpc3RlbmN5KCkgYwog ICAgIGlmIChpc0NsZWFyKCkpCiAgICAgICAgIFJFTEVBU0VfQVNTRVJUKCFtX3ZhbHVlKTsKICAg ICAKLSAgICBpZiAobV90eXBlICYgU3BlY0ludDUyQW55KSB7Ci0gICAgICAgIGlmIChtX3R5cGUg IT0gU3BlY0Z1bGxUb3ApCi0gICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChpc0FueUludDUyU3Bl Y3VsYXRpb24obV90eXBlKSk7Ci0gICAgfQotCiAgICAgaWYgKCEhbV92YWx1ZSkKICAgICAgICAg UkVMRUFTRV9BU1NFUlQodmFsaWRhdGVUeXBlQWNjZXB0aW5nQm94ZWRJbnQ1MihtX3ZhbHVlKSk7 CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RWYWx1ZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RWYWx1ZS5o CShyZXZpc2lvbiAyNDQ0NTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3Ry YWN0VmFsdWUuaAkod29ya2luZyBjb3B5KQpAQCAtNTI2LDExICs1MjYsOCBAQCBwcml2YXRlOgog ICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIAogICAgICAgICBpZiAobV90eXBlICYg U3BlY0ludDUyQW55KSB7Ci0gICAgICAgICAgICBBU1NFUlQoIShtX3R5cGUgJiB+U3BlY0ludDUy QW55KSk7Ci0KLSAgICAgICAgICAgIGlmIChtZXJnZVNwZWN1bGF0aW9ucyhtX3R5cGUsIGludDUy QXdhcmVTcGVjdWxhdGlvbkZyb21WYWx1ZSh2YWx1ZSkpICE9IG1fdHlwZSkKLSAgICAgICAgICAg ICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgICAg IGlmIChtZXJnZVNwZWN1bGF0aW9ucyhtX3R5cGUsIGludDUyQXdhcmVTcGVjdWxhdGlvbkZyb21W YWx1ZSh2YWx1ZSkpID09IG1fdHlwZSkKKyAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICAgICAgfQogCiAgICAgICAgIGlmIChtZXJnZVNwZWN1bGF0aW9ucyhtX3R5cGUsIHNwZWN1bGF0 aW9uRnJvbVZhbHVlKHZhbHVlKSkgIT0gbV90eXBlKQo=