197117 2019-04-19 14:28:09 -0700 Add more _WKElementActionTypes and provide API to create with custom types 2019-04-19 15:25:10 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino thorton webkit-bug-importer oldest_to_newest 1528869 0 dino 2019-04-19 14:28:09 -0700 Add more _WKElementActionTypes and provide API to create with custom types 1528870 1 webkit-bug-importer 2019-04-19 14:28:36 -0700 <rdar://problem/50059548> 1528873 2 367828 dino 2019-04-19 14:34:10 -0700 Created attachment 367828 Patch 1528882 3 367831 dino 2019-04-19 14:42:42 -0700 Created attachment 367831 Patch 1528884 4 367831 thorton 2019-04-19 14:44:16 -0700 Comment on attachment 367831 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367831&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h:45 > + _WKElementActionTypeShare WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(10.0)), This one shouldn't be TBA > Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h:55 > -+ (instancetype)elementActionWithType:(_WKElementActionType)type customTitle:(NSString *)title; > ++ (instancetype)elementActionWithType:(_WKElementActionType)type title:(NSString *)title actionHandler:(WKElementActionHandler)actionHandler; Are you sure there are no clients of the old SPI‽ Also, this needs availability. 1528897 5 367835 dino 2019-04-19 14:57:41 -0700 Created attachment 367835 Patch 1528915 6 dino 2019-04-19 15:25:10 -0700 Committed r244472: <https://trac.webkit.org/changeset/244472> 367828 2019-04-19 14:34:10 -0700 2019-04-19 14:42:41 -0700 Patch bug-197117-20190419143409.patch text/plain 4450 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJiNjgxNGRkZmIxZDJjZTA1 NGVhMGNhMzJmMTQwMmExNWU4OWQyMWUuLjFhZTJkZWQzNDc2OTJkY2RmYTQ2NGIwMTE3MDVhMmJl ZTNhN2I4NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTktMDQtMTkgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBtb3JlIF9XS0VsZW1lbnRBY3Rp b25UeXBlcyBhbmQgcHJvdmlkZSBBUEkgdG8gY3JlYXRlIHdpdGggY3VzdG9tIHR5cGVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcxMTcKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzUwMDU5NTQ4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlIHdlcmUgbWlzc2luZyBhIGZldyBvYnZpb3VzIHR5cGVz IHRoYXQgYXJlIHdlbGwta25vd24KKyAgICAgICAgYnJvd3NlciBhY3Rpb25zLCBhbmQvb3Igc2hv dWxkIGJlIHZpc2libGUgaW4gc2hhcmUgc2hlZXRzLgorICAgICAgICBBbHNvLCBjbGVhbiB1cCB0 aGUgQVBJIGZvciBjb25zdHJ1Y3RpbmcgbmV3IHR5cGVzLgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLmg6IEFkZCBuZXcgdHlwZXMgZm9yIG9wZW5pbmcK KyAgICAgICAgaW4gbmV3IHRhYnMsIHdpbmRvd3MgYW5kIGRvd25sb2FkaW5nLgorICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFjdGlvbi5tbToKKyAgICAgICAgKCtbX1dL RWxlbWVudEFjdGlvbiBlbGVtZW50QWN0aW9uV2l0aFR5cGU6dGl0bGU6YWN0aW9uSGFuZGxlcjpd KTogTmV3IGNvbnN0cnVjdG9yCisgICAgICAgIHdpdGggdHlwZSwgdGl0bGUgYW5kIGFjdGlvbi4K KyAgICAgICAgKCtbX1dLRWxlbWVudEFjdGlvbiBlbGVtZW50QWN0aW9uV2l0aFR5cGU6XSk6IENh bGwgbmV3IG1ldGhvZC4KKyAgICAgICAgKCtbX1dLRWxlbWVudEFjdGlvbiBlbGVtZW50QWN0aW9u V2l0aFR5cGU6Y3VzdG9tVGl0bGU6XSk6IERlbGV0ZWQuIFRoaXMKKyAgICAgICAgd2FzIG9ubHkg YmVpbmcgdXNlZCBpbnRlcm5hbGx5LCBzbyBJIGNvbWJpbmVkIGl0IHdpdGggdGhlIG5ldyBtZXRo b2QuCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06 CisKIDIwMTktMDQtMTggIFNoYXduIFJvYmVydHMgIDxzcm9iZXJ0c0BhcHBsZS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCBtYW51YWwgcm9sbG91dCBvZiByMjQ0MjQ4IGFuZCByMjQ0NDA5CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFj dGlvbi5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRBY3Rp b24uaAppbmRleCA5ZjU0Y2Q3NDU5MDMyYjMzMjhhMDcwYjcxZjQ4ZjAxMThlMzFiY2IwLi40MDEx ZjQwMGVmMDdhMGMxZDQ1NWNiNzRiZjM0ZmI0YzRhNDZkMWQxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFjdGlvbi5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLmgKQEAgLTQxLDYg KzQxLDkgQEAgdHlwZWRlZiBOU19FTlVNKE5TSW50ZWdlciwgX1dLRWxlbWVudEFjdGlvblR5cGUp IHsKICAgICBfV0tFbGVtZW50QWN0aW9uVHlwZUFkZFRvUmVhZGluZ0xpc3QsCiAgICAgX1dLRWxl bWVudEFjdGlvblR5cGVPcGVuSW5EZWZhdWx0QnJvd3NlciBXS19BUElfQVZBSUxBQkxFKGlvcyg5 XzApKSwKICAgICBfV0tFbGVtZW50QWN0aW9uVHlwZU9wZW5JbkV4dGVybmFsQXBwbGljYXRpb24g V0tfQVBJX0FWQUlMQUJMRShpb3MoOV8wKSksCisgICAgX1dLRWxlbWVudEFjdGlvblR5cGVPcGVu SW5OZXdUYWIgV0tfQVBJX0FWQUlMQUJMRShpb3MoV0tfSU9TX1RCQSkpLAorICAgIF9XS0VsZW1l bnRBY3Rpb25UeXBlT3BlbkluTmV3V2luZG93IFdLX0FQSV9BVkFJTEFCTEUoaW9zKFdLX0lPU19U QkEpKSwKKyAgICBfV0tFbGVtZW50QWN0aW9uVHlwZURvd25sb2FkIFdLX0FQSV9BVkFJTEFCTEUo aW9zKFdLX0lPU19UQkEpKSwKICNlbmRpZgogICAgIF9XS0VsZW1lbnRBY3Rpb25UeXBlU2hhcmUg V0tfQVBJX0FWQUlMQUJMRShpb3MoMTAuMCkpLAogfSBXS19BUElfQVZBSUxBQkxFKG1hY29zKDEw LjEwKSwgaW9zKDguMCkpOwpAQCAtNDksNyArNTIsNyBAQCBXS19DTEFTU19BVkFJTEFCTEUobWFj b3MoMTAuMTApLCBpb3MoOC4wKSkKIEBpbnRlcmZhY2UgX1dLRWxlbWVudEFjdGlvbiA6IE5TT2Jq ZWN0CiAKICsgKGluc3RhbmNldHlwZSllbGVtZW50QWN0aW9uV2l0aFR5cGU6KF9XS0VsZW1lbnRB Y3Rpb25UeXBlKXR5cGU7Ci0rIChpbnN0YW5jZXR5cGUpZWxlbWVudEFjdGlvbldpdGhUeXBlOihf V0tFbGVtZW50QWN0aW9uVHlwZSl0eXBlIGN1c3RvbVRpdGxlOihOU1N0cmluZyAqKXRpdGxlOwor KyAoaW5zdGFuY2V0eXBlKWVsZW1lbnRBY3Rpb25XaXRoVHlwZTooX1dLRWxlbWVudEFjdGlvblR5 cGUpdHlwZSB0aXRsZTooTlNTdHJpbmcgKil0aXRsZSBhY3Rpb25IYW5kbGVyOihXS0VsZW1lbnRB Y3Rpb25IYW5kbGVyKWFjdGlvbkhhbmRsZXI7CiAKICsgKGluc3RhbmNldHlwZSllbGVtZW50QWN0 aW9uV2l0aFRpdGxlOihOU1N0cmluZyAqKXRpdGxlIGFjdGlvbkhhbmRsZXI6KFdLRWxlbWVudEFj dGlvbkhhbmRsZXIpaGFuZGxlcjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL0NvY29hL19XS0VsZW1lbnRBY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQ29jb2EvX1dLRWxlbWVudEFjdGlvbi5tbQppbmRleCAxZWQ3NTRjNjhkYTNjZmY4MDI5 NzQzZDgzMDY0NWZjYzBlODg0YjQ2Li5lZTk4MzMzMTMxNTM2NGRlZGYxNTQ0YzE3MDQ0NDFiNTIx YmM3MmE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dL RWxlbWVudEFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev X1dLRWxlbWVudEFjdGlvbi5tbQpAQCAtODksNiArODksMTEgQEAgc3RhdGljIHZvaWQgYWRkVG9S ZWFkaW5nTGlzdChOU1VSTCAqdGFyZ2V0VVJMLCBOU1N0cmluZyAqdGl0bGUpCiB9CiAjZW5kaWYK IAorKyAoaW5zdGFuY2V0eXBlKWVsZW1lbnRBY3Rpb25XaXRoVHlwZTooX1dLRWxlbWVudEFjdGlv blR5cGUpdHlwZSB0aXRsZTooTlNTdHJpbmcgKil0aXRsZSBhY3Rpb25IYW5kbGVyOihXS0VsZW1l bnRBY3Rpb25IYW5kbGVyKWFjdGlvbkhhbmRsZXIKK3sKKyAgICByZXR1cm4gW19XS0VsZW1lbnRB Y3Rpb24gX2VsZW1lbnRBY3Rpb25XaXRoVHlwZTp0eXBlIHRpdGxlOnRpdGxlIGFjdGlvbkhhbmRs ZXI6YWN0aW9uSGFuZGxlcl07Cit9CisKICsgKGluc3RhbmNldHlwZSlfZWxlbWVudEFjdGlvbldp dGhUeXBlOihfV0tFbGVtZW50QWN0aW9uVHlwZSl0eXBlIHRpdGxlOihOU1N0cmluZyAqKXRpdGxl IGFjdGlvbkhhbmRsZXI6KFdLRWxlbWVudEFjdGlvbkhhbmRsZXIpYWN0aW9uSGFuZGxlcgogewog ICAgIFdLRWxlbWVudEFjdGlvbkhhbmRsZXJJbnRlcm5hbCBoYW5kbGVyID0gXihXS0FjdGlvblNo ZWV0QXNzaXN0YW50ICosIF9XS0FjdGl2YXRlZEVsZW1lbnRJbmZvICphY3Rpb25JbmZvKSB7IGFj dGlvbkhhbmRsZXIoYWN0aW9uSW5mbyk7IH07CkBAIC0xNDUsMTQgKzE1MCw5IEBAIHN0YXRpYyB2 b2lkIGFkZFRvUmVhZGluZ0xpc3QoTlNVUkwgKnRhcmdldFVSTCwgTlNTdHJpbmcgKnRpdGxlKQog ICAgIHJldHVybiBbc2VsZiBfZWxlbWVudEFjdGlvbldpdGhUeXBlOnR5cGUgY3VzdG9tVGl0bGU6 bmlsIGFzc2lzdGFudDphc3Npc3RhbnRdOwogfQogCi0rIChpbnN0YW5jZXR5cGUpZWxlbWVudEFj dGlvbldpdGhUeXBlOihfV0tFbGVtZW50QWN0aW9uVHlwZSl0eXBlIGN1c3RvbVRpdGxlOihOU1N0 cmluZyAqKWN1c3RvbVRpdGxlCi17Ci0gICAgcmV0dXJuIFtzZWxmIF9lbGVtZW50QWN0aW9uV2l0 aFR5cGU6dHlwZSBjdXN0b21UaXRsZTpjdXN0b21UaXRsZSBhc3Npc3RhbnQ6bmlsXTsKLX0KLQog KyAoaW5zdGFuY2V0eXBlKWVsZW1lbnRBY3Rpb25XaXRoVHlwZTooX1dLRWxlbWVudEFjdGlvblR5 cGUpdHlwZQogewotICAgIHJldHVybiBbc2VsZiBlbGVtZW50QWN0aW9uV2l0aFR5cGU6dHlwZSBj dXN0b21UaXRsZTpuaWxdOworICAgIHJldHVybiBbc2VsZiBlbGVtZW50QWN0aW9uV2l0aFR5cGU6 dHlwZSB0aXRsZTpuaWwgYWN0aW9uSGFuZGxlcjpuaWxdOwogfQogCiAtIChOU1N0cmluZyAqKXRp dGxlCg== 367831 2019-04-19 14:42:42 -0700 2019-04-19 14:57:40 -0700 Patch bug-197117-20190419144241.patch text/plain 4530 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJiNjgxNGRkZmIxZDJjZTA1 NGVhMGNhMzJmMTQwMmExNWU4OWQyMWUuLjFhZTJkZWQzNDc2OTJkY2RmYTQ2NGIwMTE3MDVhMmJl ZTNhN2I4NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTktMDQtMTkgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBtb3JlIF9XS0VsZW1lbnRBY3Rp b25UeXBlcyBhbmQgcHJvdmlkZSBBUEkgdG8gY3JlYXRlIHdpdGggY3VzdG9tIHR5cGVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcxMTcKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzUwMDU5NTQ4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlIHdlcmUgbWlzc2luZyBhIGZldyBvYnZpb3VzIHR5cGVz IHRoYXQgYXJlIHdlbGwta25vd24KKyAgICAgICAgYnJvd3NlciBhY3Rpb25zLCBhbmQvb3Igc2hv dWxkIGJlIHZpc2libGUgaW4gc2hhcmUgc2hlZXRzLgorICAgICAgICBBbHNvLCBjbGVhbiB1cCB0 aGUgQVBJIGZvciBjb25zdHJ1Y3RpbmcgbmV3IHR5cGVzLgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLmg6IEFkZCBuZXcgdHlwZXMgZm9yIG9wZW5pbmcK KyAgICAgICAgaW4gbmV3IHRhYnMsIHdpbmRvd3MgYW5kIGRvd25sb2FkaW5nLgorICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFjdGlvbi5tbToKKyAgICAgICAgKCtbX1dL RWxlbWVudEFjdGlvbiBlbGVtZW50QWN0aW9uV2l0aFR5cGU6dGl0bGU6YWN0aW9uSGFuZGxlcjpd KTogTmV3IGNvbnN0cnVjdG9yCisgICAgICAgIHdpdGggdHlwZSwgdGl0bGUgYW5kIGFjdGlvbi4K KyAgICAgICAgKCtbX1dLRWxlbWVudEFjdGlvbiBlbGVtZW50QWN0aW9uV2l0aFR5cGU6XSk6IENh bGwgbmV3IG1ldGhvZC4KKyAgICAgICAgKCtbX1dLRWxlbWVudEFjdGlvbiBlbGVtZW50QWN0aW9u V2l0aFR5cGU6Y3VzdG9tVGl0bGU6XSk6IERlbGV0ZWQuIFRoaXMKKyAgICAgICAgd2FzIG9ubHkg YmVpbmcgdXNlZCBpbnRlcm5hbGx5LCBzbyBJIGNvbWJpbmVkIGl0IHdpdGggdGhlIG5ldyBtZXRo b2QuCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06 CisKIDIwMTktMDQtMTggIFNoYXduIFJvYmVydHMgIDxzcm9iZXJ0c0BhcHBsZS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCBtYW51YWwgcm9sbG91dCBvZiByMjQ0MjQ4IGFuZCByMjQ0NDA5CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFj dGlvbi5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRBY3Rp b24uaAppbmRleCA5ZjU0Y2Q3NDU5MDMyYjMzMjhhMDcwYjcxZjQ4ZjAxMThlMzFiY2IwLi42MDg1 ZDBiNmVjN2MwZjI1NjcyZGQ0ZTg4NzUyMTE4MjAzMDhiZjgyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFjdGlvbi5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLmgKQEAgLTQyLDE0 ICs0MiwxNyBAQCB0eXBlZGVmIE5TX0VOVU0oTlNJbnRlZ2VyLCBfV0tFbGVtZW50QWN0aW9uVHlw ZSkgewogICAgIF9XS0VsZW1lbnRBY3Rpb25UeXBlT3BlbkluRGVmYXVsdEJyb3dzZXIgV0tfQVBJ X0FWQUlMQUJMRShpb3MoOV8wKSksCiAgICAgX1dLRWxlbWVudEFjdGlvblR5cGVPcGVuSW5FeHRl cm5hbEFwcGxpY2F0aW9uIFdLX0FQSV9BVkFJTEFCTEUoaW9zKDlfMCkpLAogI2VuZGlmCi0gICAg X1dLRWxlbWVudEFjdGlvblR5cGVTaGFyZSBXS19BUElfQVZBSUxBQkxFKGlvcygxMC4wKSksCisg ICAgX1dLRWxlbWVudEFjdGlvblR5cGVTaGFyZSBXS19BUElfQVZBSUxBQkxFKG1hY29zKFdLX01B Q19UQkEpLCBpb3MoMTAuMCkpLAorICAgIF9XS0VsZW1lbnRBY3Rpb25UeXBlT3BlbkluTmV3VGFi IFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSksCisg ICAgX1dLRWxlbWVudEFjdGlvblR5cGVPcGVuSW5OZXdXaW5kb3cgV0tfQVBJX0FWQUlMQUJMRSht YWNvcyhXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKSwKKyAgICBfV0tFbGVtZW50QWN0aW9u VHlwZURvd25sb2FkIFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19J T1NfVEJBKSksCiB9IFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoMTAuMTApLCBpb3MoOC4wKSk7CiAK IFdLX0NMQVNTX0FWQUlMQUJMRShtYWNvcygxMC4xMCksIGlvcyg4LjApKQogQGludGVyZmFjZSBf V0tFbGVtZW50QWN0aW9uIDogTlNPYmplY3QKIAogKyAoaW5zdGFuY2V0eXBlKWVsZW1lbnRBY3Rp b25XaXRoVHlwZTooX1dLRWxlbWVudEFjdGlvblR5cGUpdHlwZTsKLSsgKGluc3RhbmNldHlwZSll bGVtZW50QWN0aW9uV2l0aFR5cGU6KF9XS0VsZW1lbnRBY3Rpb25UeXBlKXR5cGUgY3VzdG9tVGl0 bGU6KE5TU3RyaW5nICopdGl0bGU7CisrIChpbnN0YW5jZXR5cGUpZWxlbWVudEFjdGlvbldpdGhU eXBlOihfV0tFbGVtZW50QWN0aW9uVHlwZSl0eXBlIHRpdGxlOihOU1N0cmluZyAqKXRpdGxlIGFj dGlvbkhhbmRsZXI6KFdLRWxlbWVudEFjdGlvbkhhbmRsZXIpYWN0aW9uSGFuZGxlcjsKIAogKyAo aW5zdGFuY2V0eXBlKWVsZW1lbnRBY3Rpb25XaXRoVGl0bGU6KE5TU3RyaW5nICopdGl0bGUgYWN0 aW9uSGFuZGxlcjooV0tFbGVtZW50QWN0aW9uSGFuZGxlciloYW5kbGVyOwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFjdGlvbi5tbSBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tCmlu ZGV4IDFlZDc1NGM2OGRhM2NmZjgwMjk3NDNkODMwNjQ1ZmNjMGU4ODRiNDYuLmVlOTgzMzMxMzE1 MzY0ZGVkZjE1NDRjMTcwNDQ0MWI1MjFiYzcyYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tCkBAIC04OSw2ICs4OSwx MSBAQCBzdGF0aWMgdm9pZCBhZGRUb1JlYWRpbmdMaXN0KE5TVVJMICp0YXJnZXRVUkwsIE5TU3Ry aW5nICp0aXRsZSkKIH0KICNlbmRpZgogCisrIChpbnN0YW5jZXR5cGUpZWxlbWVudEFjdGlvbldp dGhUeXBlOihfV0tFbGVtZW50QWN0aW9uVHlwZSl0eXBlIHRpdGxlOihOU1N0cmluZyAqKXRpdGxl IGFjdGlvbkhhbmRsZXI6KFdLRWxlbWVudEFjdGlvbkhhbmRsZXIpYWN0aW9uSGFuZGxlcgorewor ICAgIHJldHVybiBbX1dLRWxlbWVudEFjdGlvbiBfZWxlbWVudEFjdGlvbldpdGhUeXBlOnR5cGUg dGl0bGU6dGl0bGUgYWN0aW9uSGFuZGxlcjphY3Rpb25IYW5kbGVyXTsKK30KKwogKyAoaW5zdGFu Y2V0eXBlKV9lbGVtZW50QWN0aW9uV2l0aFR5cGU6KF9XS0VsZW1lbnRBY3Rpb25UeXBlKXR5cGUg dGl0bGU6KE5TU3RyaW5nICopdGl0bGUgYWN0aW9uSGFuZGxlcjooV0tFbGVtZW50QWN0aW9uSGFu ZGxlcilhY3Rpb25IYW5kbGVyCiB7CiAgICAgV0tFbGVtZW50QWN0aW9uSGFuZGxlckludGVybmFs IGhhbmRsZXIgPSBeKFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQgKiwgX1dLQWN0aXZhdGVkRWxlbWVu dEluZm8gKmFjdGlvbkluZm8pIHsgYWN0aW9uSGFuZGxlcihhY3Rpb25JbmZvKTsgfTsKQEAgLTE0 NSwxNCArMTUwLDkgQEAgc3RhdGljIHZvaWQgYWRkVG9SZWFkaW5nTGlzdChOU1VSTCAqdGFyZ2V0 VVJMLCBOU1N0cmluZyAqdGl0bGUpCiAgICAgcmV0dXJuIFtzZWxmIF9lbGVtZW50QWN0aW9uV2l0 aFR5cGU6dHlwZSBjdXN0b21UaXRsZTpuaWwgYXNzaXN0YW50OmFzc2lzdGFudF07CiB9CiAKLSsg KGluc3RhbmNldHlwZSllbGVtZW50QWN0aW9uV2l0aFR5cGU6KF9XS0VsZW1lbnRBY3Rpb25UeXBl KXR5cGUgY3VzdG9tVGl0bGU6KE5TU3RyaW5nICopY3VzdG9tVGl0bGUKLXsKLSAgICByZXR1cm4g W3NlbGYgX2VsZW1lbnRBY3Rpb25XaXRoVHlwZTp0eXBlIGN1c3RvbVRpdGxlOmN1c3RvbVRpdGxl IGFzc2lzdGFudDpuaWxdOwotfQotCiArIChpbnN0YW5jZXR5cGUpZWxlbWVudEFjdGlvbldpdGhU eXBlOihfV0tFbGVtZW50QWN0aW9uVHlwZSl0eXBlCiB7Ci0gICAgcmV0dXJuIFtzZWxmIGVsZW1l bnRBY3Rpb25XaXRoVHlwZTp0eXBlIGN1c3RvbVRpdGxlOm5pbF07CisgICAgcmV0dXJuIFtzZWxm IGVsZW1lbnRBY3Rpb25XaXRoVHlwZTp0eXBlIHRpdGxlOm5pbCBhY3Rpb25IYW5kbGVyOm5pbF07 CiB9CiAKIC0gKE5TU3RyaW5nICopdGl0bGUK 367835 2019-04-19 14:57:41 -0700 2019-04-19 14:58:30 -0700 Patch bug-197117-20190419145740.patch text/plain 3855 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJiNjgxNGRkZmIxZDJjZTA1 NGVhMGNhMzJmMTQwMmExNWU4OWQyMWUuLmQ5OWQ2NGM3MDFjOGY3NGVkZDc3MDYzOTg0ZTdlMWEz YmY0YzdiMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTktMDQtMTkgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBtb3JlIF9XS0VsZW1lbnRBY3Rp b25UeXBlcyBhbmQgcHJvdmlkZSBBUEkgdG8gY3JlYXRlIHdpdGggY3VzdG9tIHR5cGVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcxMTcKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzUwMDU5NTQ4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlIHdlcmUgbWlzc2luZyBhIGZldyBvYnZpb3VzIHR5cGVz IHRoYXQgYXJlIHdlbGwta25vd24KKyAgICAgICAgYnJvd3NlciBhY3Rpb25zLCBhbmQvb3Igc2hv dWxkIGJlIHZpc2libGUgaW4gc2hhcmUgc2hlZXRzLgorICAgICAgICBBbHNvLCBjbGVhbiB1cCB0 aGUgQVBJIGZvciBjb25zdHJ1Y3RpbmcgbmV3IHR5cGVzLgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLmg6IEFkZCBuZXcgdHlwZXMgZm9yIG9wZW5pbmcK KyAgICAgICAgaW4gbmV3IHRhYnMsIHdpbmRvd3MgYW5kIGRvd25sb2FkaW5nLgorICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFjdGlvbi5tbToKKyAgICAgICAgKCtbX1dL RWxlbWVudEFjdGlvbiBlbGVtZW50QWN0aW9uV2l0aFR5cGU6dGl0bGU6YWN0aW9uSGFuZGxlcjpd KTogTmV3IGNvbnN0cnVjdG9yCisgICAgICAgIHdpdGggdHlwZSwgdGl0bGUgYW5kIGFjdGlvbi4K KyAgICAgICAgKCtbX1dLRWxlbWVudEFjdGlvbiBlbGVtZW50QWN0aW9uV2l0aFR5cGU6XSk6IENh bGwgbmV3IG1ldGhvZC4KKwogMjAxOS0wNC0xOCAgU2hhd24gUm9iZXJ0cyAgPHNyb2JlcnRzQGFw cGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIG1hbnVhbCByb2xsb3V0IG9mIHIyNDQyNDgg YW5kIHIyNDQ0MDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9fV0tFbGVtZW50QWN0aW9uLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev X1dLRWxlbWVudEFjdGlvbi5oCmluZGV4IDlmNTRjZDc0NTkwMzJiMzMyOGEwNzBiNzFmNDhmMDEx OGUzMWJjYjAuLjE1ODg1ZWFjNzA5Y2ZkZjYwODQyNWY2OTdjMTk5OWFkYzFjMmY1NWMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9u LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRBY3Rp b24uaApAQCAtNDIsMTUgKzQyLDE4IEBAIHR5cGVkZWYgTlNfRU5VTShOU0ludGVnZXIsIF9XS0Vs ZW1lbnRBY3Rpb25UeXBlKSB7CiAgICAgX1dLRWxlbWVudEFjdGlvblR5cGVPcGVuSW5EZWZhdWx0 QnJvd3NlciBXS19BUElfQVZBSUxBQkxFKGlvcyg5XzApKSwKICAgICBfV0tFbGVtZW50QWN0aW9u VHlwZU9wZW5JbkV4dGVybmFsQXBwbGljYXRpb24gV0tfQVBJX0FWQUlMQUJMRShpb3MoOV8wKSks CiAjZW5kaWYKLSAgICBfV0tFbGVtZW50QWN0aW9uVHlwZVNoYXJlIFdLX0FQSV9BVkFJTEFCTEUo aW9zKDEwLjApKSwKKyAgICBfV0tFbGVtZW50QWN0aW9uVHlwZVNoYXJlIFdLX0FQSV9BVkFJTEFC TEUobWFjb3MoMTAuMTIpLCBpb3MoMTAuMCkpLAorICAgIF9XS0VsZW1lbnRBY3Rpb25UeXBlT3Bl bkluTmV3VGFiIFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1Nf VEJBKSksCisgICAgX1dLRWxlbWVudEFjdGlvblR5cGVPcGVuSW5OZXdXaW5kb3cgV0tfQVBJX0FW QUlMQUJMRShtYWNvcyhXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKSwKKyAgICBfV0tFbGVt ZW50QWN0aW9uVHlwZURvd25sb2FkIFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoV0tfTUFDX1RCQSks IGlvcyhXS19JT1NfVEJBKSksCiB9IFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoMTAuMTApLCBpb3Mo OC4wKSk7CiAKIFdLX0NMQVNTX0FWQUlMQUJMRShtYWNvcygxMC4xMCksIGlvcyg4LjApKQogQGlu dGVyZmFjZSBfV0tFbGVtZW50QWN0aW9uIDogTlNPYmplY3QKIAogKyAoaW5zdGFuY2V0eXBlKWVs ZW1lbnRBY3Rpb25XaXRoVHlwZTooX1dLRWxlbWVudEFjdGlvblR5cGUpdHlwZTsKKysgKGluc3Rh bmNldHlwZSllbGVtZW50QWN0aW9uV2l0aFR5cGU6KF9XS0VsZW1lbnRBY3Rpb25UeXBlKXR5cGUg dGl0bGU6KE5TU3RyaW5nICopdGl0bGUgYWN0aW9uSGFuZGxlcjooV0tFbGVtZW50QWN0aW9uSGFu ZGxlcilhY3Rpb25IYW5kbGVyIFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoV0tfTUFDX1RCQSksIGlv cyhXS19JT1NfVEJBKSk7CiArIChpbnN0YW5jZXR5cGUpZWxlbWVudEFjdGlvbldpdGhUeXBlOihf V0tFbGVtZW50QWN0aW9uVHlwZSl0eXBlIGN1c3RvbVRpdGxlOihOU1N0cmluZyAqKXRpdGxlOwot CiArIChpbnN0YW5jZXR5cGUpZWxlbWVudEFjdGlvbldpdGhUaXRsZTooTlNTdHJpbmcgKil0aXRs ZSBhY3Rpb25IYW5kbGVyOihXS0VsZW1lbnRBY3Rpb25IYW5kbGVyKWhhbmRsZXI7CiAKIC0gKHZv aWQpcnVuQWN0aW9uV2l0aEVsZW1lbnRJbmZvOihfV0tBY3RpdmF0ZWRFbGVtZW50SW5mbyAqKWlu Zm8gV0tfQVBJX0FWQUlMQUJMRShpb3MoOV8wKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tCmluZGV4IDFlZDc1NGM2OGRh M2NmZjgwMjk3NDNkODMwNjQ1ZmNjMGU4ODRiNDYuLjgwNjhlZTU0ZWE5Yjc4ZDQ1ODdlNWJmNGNi Yzk2M2U3MTFkNDYxZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9D b2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tCkBAIC04OSw2ICs4OSwxMSBAQCBzdGF0aWMgdm9p ZCBhZGRUb1JlYWRpbmdMaXN0KE5TVVJMICp0YXJnZXRVUkwsIE5TU3RyaW5nICp0aXRsZSkKIH0K ICNlbmRpZgogCisrIChpbnN0YW5jZXR5cGUpZWxlbWVudEFjdGlvbldpdGhUeXBlOihfV0tFbGVt ZW50QWN0aW9uVHlwZSl0eXBlIHRpdGxlOihOU1N0cmluZyAqKXRpdGxlIGFjdGlvbkhhbmRsZXI6 KFdLRWxlbWVudEFjdGlvbkhhbmRsZXIpYWN0aW9uSGFuZGxlcgoreworICAgIHJldHVybiBbX1dL RWxlbWVudEFjdGlvbiBfZWxlbWVudEFjdGlvbldpdGhUeXBlOnR5cGUgdGl0bGU6dGl0bGUgYWN0 aW9uSGFuZGxlcjphY3Rpb25IYW5kbGVyXTsKK30KKwogKyAoaW5zdGFuY2V0eXBlKV9lbGVtZW50 QWN0aW9uV2l0aFR5cGU6KF9XS0VsZW1lbnRBY3Rpb25UeXBlKXR5cGUgdGl0bGU6KE5TU3RyaW5n ICopdGl0bGUgYWN0aW9uSGFuZGxlcjooV0tFbGVtZW50QWN0aW9uSGFuZGxlcilhY3Rpb25IYW5k bGVyCiB7CiAgICAgV0tFbGVtZW50QWN0aW9uSGFuZGxlckludGVybmFsIGhhbmRsZXIgPSBeKFdL QWN0aW9uU2hlZXRBc3Npc3RhbnQgKiwgX1dLQWN0aXZhdGVkRWxlbWVudEluZm8gKmFjdGlvbklu Zm8pIHsgYWN0aW9uSGFuZGxlcihhY3Rpb25JbmZvKTsgfTsK