197115 2019-04-19 14:02:31 -0700 Web Inspector: Timelines: CPU: ensure that tracking stops when disconnecting Web Inspector 2019-04-19 17:33:27 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1528854 0 hi 2019-04-19 14:02:31 -0700 It may be possible to UAF the `InspectorCPUProfilerAgent`, since it adds itself (via a C++ lambda) as an observer to another object. If the inspector disconnects while actively recording, we currently don't remove that. 1528855 1 hi 2019-04-19 14:02:42 -0700 <rdar://problem/49877875> 1528856 2 367823 hi 2019-04-19 14:03:33 -0700 Created attachment 367823 Patch 1528940 3 367823 joepeck 2019-04-19 16:24:24 -0700 Comment on attachment 367823 Patch r=me. Are there any other agents that could benefit from this? 1528943 4 hi 2019-04-19 16:27:15 -0700 (In reply to Joseph Pecoraro from comment #3) > r=me. Are there any other agents that could benefit from this? I checked the other timelines agents, and all of them either weren't susceptible or already had a "fix" for this issue. 1528983 5 367823 commit-queue 2019-04-19 17:33:26 -0700 Comment on attachment 367823 Patch Clearing flags on attachment: 367823 Committed r244478: <https://trac.webkit.org/changeset/244478> 1528984 6 commit-queue 2019-04-19 17:33:27 -0700 All reviewed patches have been landed. Closing bug. 367823 2019-04-19 14:03:33 -0700 2019-04-19 17:33:26 -0700 Patch bug-197115-20190419140333.patch text/plain 1514 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkZjZmYzczOGUyMjY5M2E0ODczZDM3Yzg3MmE3MjQ5ZDE3MzA2MTIzLi4z ZDhjZDlkY2IyN2QyZWNkZmExMWY4NmQzNzA4ZDgzZmM4NTFiOTE5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTktMDQtMTkgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRpbWVsaW5lczogQ1BVOiBlbnN1cmUgdGhhdCB0 cmFja2luZyBzdG9wcyB3aGVuIGRpc2Nvbm5lY3RpbmcgV2ViIEluc3BlY3RvcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3MTE1CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS80OTg3Nzg3NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ1BVUHJvZmlsZXJB Z2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDUFVQcm9maWxlckFnZW50Ojp3 aWxsRGVzdHJveUZyb250ZW5kQW5kQmFja2VuZCk6CisKIDIwMTktMDQtMTkgIFdlbnNvbiBIc2ll aCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gQWRkIHF1aXJrcyB0 byBkaXNhYmxlIGF1dG9jb3JyZWN0aW9uIGFuZCBhdXRvY2FwaXRhbGl6YXRpb24gaW4gaGlkZGVu IGVkaXRhYmxlIGFyZWFzIG9uIHNvbWUgd2Vic2l0ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ1BVUHJvZmlsZXJBZ2VudC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckNQVVByb2ZpbGVyQWdlbnQuY3Bw CmluZGV4IDZhMjk3MmQ2ODg1MTZkY2YyODYxYjNlMTVhNTQxNmFjMDIxZmI0ZjIuLmNmOTRjYTgw OTZmZjU3MWQ3NGQ3NzNiMWYwMDI3NTA1NGMwY2UxZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ1BVUHJvZmlsZXJBZ2VudC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JDUFVQcm9maWxlckFnZW50 LmNwcApAQCAtNTEsNiArNTEsOSBAQCB2b2lkIEluc3BlY3RvckNQVVByb2ZpbGVyQWdlbnQ6OmRp ZENyZWF0ZUZyb250ZW5kQW5kQmFja2VuZChGcm9udGVuZFJvdXRlciosIEJhYwogCiB2b2lkIElu c3BlY3RvckNQVVByb2ZpbGVyQWdlbnQ6OndpbGxEZXN0cm95RnJvbnRlbmRBbmRCYWNrZW5kKERp c2Nvbm5lY3RSZWFzb24pCiB7CisgICAgRXJyb3JTdHJpbmcgaWdub3JlZDsKKyAgICBzdG9wVHJh Y2tpbmcoaWdub3JlZCk7CisKICAgICBtX2luc3RydW1lbnRpbmdBZ2VudHMuc2V0SW5zcGVjdG9y Q1BVUHJvZmlsZXJBZ2VudChudWxscHRyKTsKIH0KIAo=