197087 2019-04-18 18:43:03 -0700 narrowing errors with clang-8.0 2023-09-08 15:38:33 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Linux NEW P2 Normal --- 1 raj.khem webkit-unassigned ahmad.saleem792 fujii oldest_to_newest 1528673 0 raj.khem 2019-04-18 18:43:03 -0700 Following error is reported by clang on arm In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-5037b3e8-3.cpp:2: /mnt/a/yoe/build/tmp/work/cortexa7t2hf-neon-vfpv4-yoe-linux-gnueabi/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/WebCore/contentextensions/NFAToDFA.cpp:352:43: error: non-constant-expression cannot be narrowed from type 'char' to 'signed char' in initializer list [-Wc++11-narrowing] dfa.transitionRanges.append({ range.first, range.last }); ^~~~~~~~~~~ /mnt/a/yoe/build/tmp/work/cortexa7t2hf-neon-vfpv4-yoe-linux-gnueabi/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/WebCore/contentextensions/NFAToDFA.cpp:352:43: note: insert an explicit cast to silence this issue dfa.transitionRanges.append({ range.first, range.last }); ^~~~~~~~~~~ static_cast<signed char>( ) /mnt/a/yoe/build/tmp/work/cortexa7t2hf-neon-vfpv4-yoe-linux-gnueabi/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/WebCore/contentextensions/NFAToDFA.cpp:352:56: error: non-constant-expression cannot be narrowed from type 'char' to 'signed char' in initializer list [-Wc++11-narrowing] dfa.transitionRanges.append({ range.first, range.last }); ^~~~~~~~~~ /mnt/a/yoe/build/tmp/work/cortexa7t2hf-neon-vfpv4-yoe-linux-gnueabi/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/WebCore/contentextensions/NFAToDFA.cpp:352:56: note: insert an explicit cast to silence this issue dfa.transitionRanges.append({ range.first, range.last }); ^~~~~~~~~~ static_cast<signed char>( ) 2 errors generated. 1528674 1 367781 raj.khem 2019-04-18 18:44:05 -0700 Created attachment 367781 proposed fix 1528715 2 fujii 2019-04-18 23:28:47 -0700 Did you read this? https://webkit.org/contributing-code/ 1976542 3 ahmad.saleem792 2023-09-08 15:38:33 -0700 https://github.com/WebKit/WebKit/blob/256590954964b0f4ead4ad3aa3289bb97bc1f5c4/Source/WebCore/contentextensions/NFAToDFA.cpp#L349 ^ Do we need this or we do even have clang 8 supported or we moved to newer version and don't need this? 367781 2019-04-18 18:44:05 -0700 2019-04-18 18:44:05 -0700 proposed fix narrowing.patch text/plain 1209 raj.khem LS0tIGEvU291cmNlL1dlYkNvcmUvY29udGVudGV4dGVuc2lvbnMvREZBQ29tYmluZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2NvbnRlbnRleHRlbnNpb25zL0RGQUNvbWJpbmVyLmNwcApAQCAt MzcsNyArMzcsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBuYW1lc3BhY2UgQ29udGVudEV4dGVu c2lvbnMgewogCiBjbGFzcyBERkFNZXJnZXIgewotICAgIHR5cGVkZWYgTXV0YWJsZVJhbmdlTGlz dDxjaGFyLCB1aW50NjRfdCwgMTI4PiBDb21iaW5lZFRyYW5zaXRpb25zTXV0YWJsZVJhbmdlTGlz dDsKKyAgICB0eXBlZGVmIE11dGFibGVSYW5nZUxpc3Q8c2lnbmVkIGNoYXIsIHVpbnQ2NF90LCAx Mjg+IENvbWJpbmVkVHJhbnNpdGlvbnNNdXRhYmxlUmFuZ2VMaXN0OwogCiAgICAgZW51bSBjbGFz cyBXaGljaERGQSB7CiAgICAgICAgIEEsCi0tLSBhL1NvdXJjZS9XZWJDb3JlL2NvbnRlbnRleHRl bnNpb25zL05GQVRvREZBLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jb250ZW50ZXh0ZW5zaW9u cy9ORkFUb0RGQS5jcHAKQEAgLTQxLDkgKzQxLDkgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBu YW1lc3BhY2UgQ29udGVudEV4dGVuc2lvbnMgewogCi10eXBlZGVmIE11dGFibGVSYW5nZTxjaGFy LCBORkFOb2RlSW5kZXhTZXQ+IE5GQU5vZGVSYW5nZTsKLXR5cGVkZWYgTXV0YWJsZVJhbmdlTGlz dDxjaGFyLCBORkFOb2RlSW5kZXhTZXQ+IE5GQU5vZGVSYW5nZUxpc3Q7Ci10eXBlZGVmIE11dGFi bGVSYW5nZUxpc3Q8Y2hhciwgTkZBTm9kZUluZGV4U2V0LCAxMjg+IFByZWFsbG9jYXRlZE5GQU5v ZGVSYW5nZUxpc3Q7Cit0eXBlZGVmIE11dGFibGVSYW5nZTxzaWduZWQgY2hhciwgTkZBTm9kZUlu ZGV4U2V0PiBORkFOb2RlUmFuZ2U7Cit0eXBlZGVmIE11dGFibGVSYW5nZUxpc3Q8c2lnbmVkIGNo YXIsIE5GQU5vZGVJbmRleFNldD4gTkZBTm9kZVJhbmdlTGlzdDsKK3R5cGVkZWYgTXV0YWJsZVJh bmdlTGlzdDxzaWduZWQgY2hhciwgTkZBTm9kZUluZGV4U2V0LCAxMjg+IFByZWFsbG9jYXRlZE5G QU5vZGVSYW5nZUxpc3Q7CiB0eXBlZGVmIFZlY3Rvcjx1aW50MzJfdCwgMCwgQ29udGVudEV4dGVu c2lvbnNPdmVyZmxvd0hhbmRsZXI+IFVuaXF1ZU5vZGVMaXN0OwogdHlwZWRlZiBWZWN0b3I8VW5p cXVlTm9kZUxpc3QsIDAsIENvbnRlbnRFeHRlbnNpb25zT3ZlcmZsb3dIYW5kbGVyPiBORkFOb2Rl Q2xvc3VyZXM7CiAK