<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>197086</bug_id>
          
          <creation_ts>2019-04-18 18:19:55 -0700</creation_ts>
          <short_desc>Layout of YouTube videos is wrong in fullscreen after the first time</short_desc>
          <delta_ts>2019-05-02 16:21:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>macOS 10.14</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Remy Demarest">rdemarest</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>jasminedemeesterdhd</cc>
    
    <cc>jer.noble</cc>
    
    <cc>rdemarest</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>thorton</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1528670</commentid>
    <comment_count>0</comment_count>
    <who name="Remy Demarest">rdemarest</who>
    <bug_when>2019-04-18 18:19:55 -0700</bug_when>
    <thetext>View layout is wrong after entering fullscreen mode from the video using WebKit API.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1528671</commentid>
    <comment_count>1</comment_count>
    <who name="Remy Demarest">rdemarest</who>
    <bug_when>2019-04-18 18:21:10 -0700</bug_when>
    <thetext>&lt;rdar://problem/47733671&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1528672</commentid>
    <comment_count>2</comment_count>
      <attachid>367780</attachid>
    <who name="Remy Demarest">rdemarest</who>
    <bug_when>2019-04-18 18:34:46 -0700</bug_when>
    <thetext>Created attachment 367780
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1528685</commentid>
    <comment_count>3</comment_count>
      <attachid>367784</attachid>
    <who name="Remy Demarest">rdemarest</who>
    <bug_when>2019-04-18 19:35:55 -0700</bug_when>
    <thetext>Created attachment 367784
Fix compilation error and ensure the titlebar shows in fullscreen</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529150</commentid>
    <comment_count>5</comment_count>
      <attachid>367784</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-04-21 12:37:00 -0700</bug_when>
    <thetext>Comment on attachment 367784
Fix compilation error and ensure the titlebar shows in fullscreen

View in context: https://bugs.webkit.org/attachment.cgi?id=367784&amp;action=review

Have you tested this on the older versions of macOS that we need to support? Presumably the WebCoreFullScreenWindow changes affect Legacy WebKit as well; that’s why the class is in WebCore, not WebKit. How did you test Legacy WebKit?

&gt; Source/WebCore/ChangeLog:11
&gt; +        which ends up breaking the layout. Having that window use a style that incldues a

typo &quot;incldues&quot;

&gt; Source/WebKit/ChangeLog:11
&gt; +        which ends up breaking the layout. Having that window use a style that incldues a

typo &quot;incldues&quot;

&gt; Source/WebKit/ChangeLog:15
&gt; +        Declare a secret SPI to be used in WKFullScreenWindowController.

&quot;an SPI&quot;, not &quot;a secret SPI&quot;

&gt; Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2613
&gt; +    return [[[WebCoreFullScreenWindow alloc] initWithContentRect:[[NSScreen mainScreen] frame] styleMask:(NSWindowStyleMaskTitled | NSWindowStyleMaskUnifiedTitleAndToolbar | NSWindowStyleMaskFullSizeContentView | NSWindowStyleMaskResizable) backing:NSBackingStoreBuffered defer:NO] autorelease];

Not new, but it’s messy to have this tricky technique split across multiple files. Would be nice if more of this could be in WKFullScreenWindowController. Maybe we should add a method +[WKFulScreenWindowController createWindow] that contains this code.

I’d like to see a comment explaining why we don’t use a borderless window so future programmers don’t need to look back at change log history to figure out why.

&gt; Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:130
&gt; +    window.titlebarAlphaValue = 0;

I think this needs a why comment. Not clear what we are doing with titlebar alpha here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529196</commentid>
    <comment_count>6</comment_count>
    <who name="Remy Demarest">rdemarest</who>
    <bug_when>2019-04-22 01:24:18 -0700</bug_when>
    <thetext>&gt;Have you tested this on the older versions of macOS that we need to support? Presumably the WebCoreFullScreenWindow changes affect Legacy WebKit as well; that’s why the class is in WebCore, not WebKit. How did you test Legacy WebKit?

The changes I made in WebCore have no influence on the behavior of the window without the changes to the style mask that are applied by WebKit. -canBecomeMain returns NO when the window has no titlebar and -constrainFrameRect:toScreen: just returns the frameRect as well. So I did not think I needed to test this particular case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529243</commentid>
    <comment_count>7</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-04-22 08:39:02 -0700</bug_when>
    <thetext>That answers the second question, with &quot;I assume it has no effect so didn’t test&quot;. I suggest finding a way to test to confirm your assumption.

What about the first question: Have you tested this on the older versions of macOS that we need to support?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529370</commentid>
    <comment_count>8</comment_count>
    <who name="Remy Demarest">rdemarest</who>
    <bug_when>2019-04-22 13:58:06 -0700</bug_when>
    <thetext>I tested WebKitLegacy using MiniBrowser and confirmed there were no changes between the two versions with and without my fix.

I&apos;m still trying to get WebKit to build on Mojave so I can test it there.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529471</commentid>
    <comment_count>9</comment_count>
      <attachid>367997</attachid>
    <who name="Remy Demarest">rdemarest</who>
    <bug_when>2019-04-22 16:57:23 -0700</bug_when>
    <thetext>Created attachment 367997
Patch including feedback changes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529625</commentid>
    <comment_count>10</comment_count>
      <attachid>367997</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-04-23 09:25:36 -0700</bug_when>
    <thetext>Comment on attachment 367997
Patch including feedback changes

Clearing flags on attachment: 367997

Committed r244545: &lt;https://trac.webkit.org/changeset/244545&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529626</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-04-23 09:25:38 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>367780</attachid>
            <date>2019-04-18 18:34:46 -0700</date>
            <delta_ts>2019-04-18 19:35:55 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>YouTubeLayoutFix.patch</filename>
            <type>text/plain</type>
            <size>6666</size>
            <attacher name="Remy Demarest">rdemarest</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAxNDI4NjYyMzUyYi4uYmJiMDQyMmFiOWIgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyNiBAQAorMjAxOS0wNC0xOCAgUmVteSBEZW1hcmVzdCAgPHJkZW1hcmVzdEBhcHBsZS5j
b20+CisKKyAgICAgICAgRml4IGxheW91dCBpc3N1ZXMgb2NjdXJpbmcgd2hlbiBlbnRlcmluZyBm
dWxsIHNjcmVlbiBtb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTk3MDg2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzczMzY3MT4uCisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpc3N1ZSBp
cyB0aGUgcmVzdWx0IG9mIGNoYW5naW5nIHRoZSBzdHlsZSBtYXNrIG9mIHRoZSB3aW5kb3cgYWZ0
ZXIgZW50ZXJpbmcKKyAgICAgICAgZnVsbCBzY3JlZW4gbW9kZS4gU2FmYXJpIGFkZHMgYW4gaW52
aXNpYmxlIHRvb2xiYXIgdG8gZGlzcGxheSB0aGUgVVJMIG9mIHRoZSBwYWdlCisgICAgICAgIHdo
aWNoIGVuZHMgdXAgYnJlYWtpbmcgdGhlIGxheW91dC4gSGF2aW5nIHRoYXQgd2luZG93IHVzZSBh
IHN0eWxlIHRoYXQgaW5jbGR1ZXMgYQorICAgICAgICB0aXRsZWJhciBmaXhlcyB0aGUgYnVnLgor
CisgICAgICAgICogcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2luZG93Lm1tOgorICAg
ICAgICAoLVtXZWJDb3JlRnVsbFNjcmVlbldpbmRvdyBpbml0V2l0aENvbnRlbnRSZWN0OnN0eWxl
TWFzazpiYWNraW5nOmRlZmVyOl0pOiBNYWtlIHRoZQorICAgICAgICB0aXRsZWJhciBpbnZpc2li
bGUgdG8gbWF0Y2ggdGhlIG9sZCBiZWhhdmlvci4KKyAgICAgICAgKC1bV2ViQ29yZUZ1bGxTY3Jl
ZW5XaW5kb3cgY29uc3RyYWluRnJhbWVSZWN0OnRvU2NyZWVuOl0pOiBFbnN1cmUgdGhhdCB0aGUg
d2luZG93CisgICAgICAgIGNhbiBmaWxsIHRoZSBlbnRpcmUgc2NyZWVuIGluY2x1ZGluZyB0aGUg
dW5kZXJsYXBwaW5nIHRoZSBtZW51IGJhciwgc28gdGhhdCB0aGUKKyAgICAgICAgd2luZG93IGRv
ZXMgbm90IHJlc2l6ZSB3aGVuIHRoZSBhbmltYXRpb24gaXMgZG9uZS4KKyAgICAgICAgKC1bV2Vi
Q29yZUZ1bGxTY3JlZW5XaW5kb3cgY2FuQmVjb21lTWFpbldpbmRvd10pOiBCb3JkZXJsZXNzIHdp
bmRvd3MgY2Fubm90IGJlY29tZQorICAgICAgICBtYWluIGJ5IGRlZmF1bHQsIGFkZGluZyB0aGUg
dGl0bGViYXIgYWxsb3dzIGl0IHRvIGJlY29tZSBtYWluLCBwcmV2ZW50IHRoaXMgZnJvbQorICAg
ICAgICBoYXBwZW5pbmcgYXQgYWxsIHRvIHByZXNlcnZlIHRoZSBleGlzdGluZyBiZWhhdmlvci4K
KwogMjAxOS0wNC0xOCAgU2hhd24gUm9iZXJ0cyAgPHNyb2JlcnRzQGFwcGxlLmNvbT4KIAogICAg
ICAgICBVbnJldmlld2VkIG1hbnVhbCByb2xsb3V0IG9mIHIyNDQyNDggYW5kIHIyNDQ0MDkKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVsbFNjcmVlbldp
bmRvdy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVsbFNjcmVlbldp
bmRvdy5tbQppbmRleCBhYTQ1MDFjMWE2OS4uMzNmNjg4ZjYyOWIgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVsbFNjcmVlbldpbmRvdy5tbQorKysgYi9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZUZ1bGxTY3JlZW5XaW5kb3cubW0KQEAg
LTI5LDYgKzI5LDggQEAKIAogI2ltcG9ydCAiV2ViQ29yZUZ1bGxTY3JlZW5XaW5kb3cuaCIKIAor
I2ltcG9ydCA8QXBwS2l0L05TV2luZG93X1ByaXZhdGUuaD4KKwogLy8gRklYTUU6IFRoaXMgaXNu
J3QgcmVhbGx5IGFuIE5TV2luZG93Q29udHJvbGxlciBtZXRob2QgLSBpdCdzIGEgbWV0aG9kIHRo
YXQKIC8vIHRoZSBOU1dpbmRvd0NvbnRyb2xsZXIgc3ViY2xhc3MgdGhhdCdzIHVzaW5nIFdlYkNv
cmVGdWxsU2NyZWVuV2luZG93IG5lZWRzIHRvIGltcGxlbWVudC4KIC8vIEl0IHNob3VsZCBwcm9i
YWJseSBiZSBhIHByb3RvY29sIG1ldGhvZC4KQEAgLTQ5LDEwICs1MSwyMiBAQCAtIChpZClpbml0
V2l0aENvbnRlbnRSZWN0OihOU1JlY3QpY29udGVudFJlY3Qgc3R5bGVNYXNrOihOU1VJbnRlZ2Vy
KWFTdHlsZSBiYWNraQogICAgIFtzZWxmIHNldEFjY2VwdHNNb3VzZU1vdmVkRXZlbnRzOllFU107
CiAgICAgW3NlbGYgc2V0UmVsZWFzZWRXaGVuQ2xvc2VkOk5PXTsKICAgICBbc2VsZiBzZXRIYXNT
aGFkb3c6Tk9dOworICAgIFtzZWxmIHNldFRpdGxlYmFyQWxwaGFWYWx1ZTowXTsKIAogICAgIHJl
dHVybiBzZWxmOwogfQogCistIChOU1JlY3QpY29uc3RyYWluRnJhbWVSZWN0OihOU1JlY3QpZnJh
bWVSZWN0IHRvU2NyZWVuOihOU1NjcmVlbiAqKXNjcmVlbgoreworICAgIFVOVVNFRF9QQVJBTShz
Y3JlZW4pOworICAgIHJldHVybiBmcmFtZVJlY3Q7Cit9CisKKy0gKEJPT0wpY2FuQmVjb21lTWFp
bldpbmRvdworeworICAgIHJldHVybiBOTzsKK30KKwogLSAoQk9PTCljYW5CZWNvbWVLZXlXaW5k
b3cKIHsKICAgICByZXR1cm4gWUVTOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VM
b2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCAyYjY4MTRkZGZiMS4uMzEwYzVjNTcw
ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDQtMTggIFJlbXkgRGVtYXJlc3Qg
IDxyZGVtYXJlc3RAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBsYXlvdXQgaXNzdWVzIG9jY3Vy
aW5nIHdoZW4gZW50ZXJpbmcgZnVsbCBzY3JlZW4gbW9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzA4NgorICAgICAgICA8cmRhcjovL3Byb2Js
ZW0vNDc3MzM2NzE+LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIFRoaXMgaXNzdWUgaXMgdGhlIHJlc3VsdCBvZiBjaGFuZ2luZyB0aGUgc3R5bGUgbWFz
ayBvZiB0aGUgd2luZG93IGFmdGVyIGVudGVyaW5nCisgICAgICAgIGZ1bGwgc2NyZWVuIG1vZGUu
IFNhZmFyaSBhZGRzIGFuIGludmlzaWJsZSB0b29sYmFyIHRvIGRpc3BsYXkgdGhlIFVSTCBvZiB0
aGUgcGFnZQorICAgICAgICB3aGljaCBlbmRzIHVwIGJyZWFraW5nIHRoZSBsYXlvdXQuIEhhdmlu
ZyB0aGF0IHdpbmRvdyB1c2UgYSBzdHlsZSB0aGF0IGluY2xkdWVzIGEKKyAgICAgICAgdGl0bGVi
YXIgZml4ZXMgdGhlIGJ1Zy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1w
bC5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmZ1bGxTY3JlZW5XaW5kb3cpOiBT
aG93IHRpdGxlYmFyIGFuZCBlbnN1cmUgdGhlIGNvbnRlbnQgdmlldworICAgICAgICB1bmRlcmxh
cHMgdGhlIHRpdGxlYmFyLgorCiAyMDE5LTA0LTE4ICBTaGF3biBSb2JlcnRzICA8c3JvYmVydHNA
YXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgbWFudWFsIHJvbGxvdXQgb2YgcjI0NDI0
OCBhbmQgcjI0NDQwOQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2Ev
V2ViVmlld0ltcGwubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1w
bC5tbQppbmRleCA0YzkwMTRhM2RjYy4uYjBlMTVlYjQ3ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv
VUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tCkBAIC0yNjEwLDcgKzI2MTAsNyBAQCBOU1Zp
ZXcgKldlYlZpZXdJbXBsOjpmdWxsU2NyZWVuUGxhY2Vob2xkZXJWaWV3KCkKIE5TV2luZG93ICpX
ZWJWaWV3SW1wbDo6ZnVsbFNjcmVlbldpbmRvdygpCiB7CiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5f
QVBJKQotICAgIHJldHVybiBbW1tXZWJDb3JlRnVsbFNjcmVlbldpbmRvdyBhbGxvY10gaW5pdFdp
dGhDb250ZW50UmVjdDpbW05TU2NyZWVuIG1haW5TY3JlZW5dIGZyYW1lXSBzdHlsZU1hc2s6KE5T
V2luZG93U3R5bGVNYXNrQm9yZGVybGVzcyB8IE5TV2luZG93U3R5bGVNYXNrUmVzaXphYmxlKSBi
YWNraW5nOk5TQmFja2luZ1N0b3JlQnVmZmVyZWQgZGVmZXI6Tk9dIGF1dG9yZWxlYXNlXTsKKyAg
ICByZXR1cm4gW1tbV2ViQ29yZUZ1bGxTY3JlZW5XaW5kb3cgYWxsb2NdIGluaXRXaXRoQ29udGVu
dFJlY3Q6W1tOU1NjcmVlbiBtYWluU2NyZWVuXSBmcmFtZV0gc3R5bGVNYXNrOihOU1dpbmRvd1N0
eWxlTWFza1RpdGxlZCB8IE5TV2luZG93U3R5bGVNYXNrVW5pZmllZFRpdGxlQW5kVG9vbGJhciB8
IE5TV2luZG93U3R5bGVNYXNrRnVsbFNpemVDb250ZW50VmlldyB8IE5TV2luZG93U3R5bGVNYXNr
UmVzaXphYmxlKSBiYWNraW5nOk5TQmFja2luZ1N0b3JlQnVmZmVyZWQgZGVmZXI6Tk9dIGF1dG9y
ZWxlYXNlXTsKICNlbHNlCiAgICAgcmV0dXJuIG5pbDsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMv
Q2hhbmdlTG9nCmluZGV4IGQwOGEyNGNmZTViLi5mMDUwNjRmMDdlMSAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kv
bWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA0LTE4ICBSZW15IERlbWFyZXN0
ICA8cmRlbWFyZXN0QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggbGF5b3V0IGlzc3VlcyBvY2N1
cmluZyB3aGVuIGVudGVyaW5nIGZ1bGwgc2NyZWVuIG1vZGUuCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcwODYKKyAgICAgICAgPHJkYXI6Ly9wcm9i
bGVtLzQ3NzMzNjcxPi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBUaGlzIGlzc3VlIGlzIHRoZSByZXN1bHQgb2YgY2hhbmdpbmcgdGhlIHN0eWxlIG1h
c2sgb2YgdGhlIHdpbmRvdyBhZnRlciBlbnRlcmluZworICAgICAgICBmdWxsIHNjcmVlbiBtb2Rl
LiBTYWZhcmkgYWRkcyBhbiBpbnZpc2libGUgdG9vbGJhciB0byBkaXNwbGF5IHRoZSBVUkwgb2Yg
dGhlIHBhZ2UKKyAgICAgICAgd2hpY2ggZW5kcyB1cCBicmVha2luZyB0aGUgbGF5b3V0LiBIYXZp
bmcgdGhhdCB3aW5kb3cgdXNlIGEgc3R5bGUgdGhhdCBpbmNsZHVlcyBhCisgICAgICAgIHRpdGxl
YmFyIGZpeGVzIHRoZSBidWcuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkZ1bGxTY3JlZW5Db250
cm9sbGVyLm1tOgorICAgICAgICAoLVtXZWJGdWxsU2NyZWVuQ29udHJvbGxlciBpbml0XSk6IFNo
b3cgdGl0bGViYXIgYW5kIGVuc3VyZSB0aGUgY29udGVudCB2aWV3CisgICAgICAgIHVuZGVybGFw
cyB0aGUgdGl0bGViYXIuCisKIDIwMTktMDQtMTcgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBw
bGUuY29tPgogCiAgICAgICAgIExpbmsgY2xpY2tzIGluIFBERnMgc2hvdWxkbid0IHNlbmQgcmVm
ZXJyZXIgaGVhZGVycy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZp
ZXcvV2ViRnVsbFNjcmVlbkNvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9X
ZWJWaWV3L1dlYkZ1bGxTY3JlZW5Db250cm9sbGVyLm1tCmluZGV4IDg5YmZhNzBjMTkxLi45MzRh
NWM1ODkzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJG
dWxsU2NyZWVuQ29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJW
aWV3L1dlYkZ1bGxTY3JlZW5Db250cm9sbGVyLm1tCkBAIC04MSw3ICs4MSw3IEBAIEBpbXBsZW1l
bnRhdGlvbiBXZWJGdWxsU2NyZWVuQ29udHJvbGxlcgogLSAoaWQpaW5pdAogewogICAgIC8vIERv
IG5vdCBkZWZlciB3aW5kb3cgY3JlYXRpb24sIHRvIG1ha2Ugc3VyZSAtd2luZG93TnVtYmVyIGlz
IGNyZWF0ZWQgKG5lZWRlZCBieSBXZWJXaW5kb3dTY2FsZUFuaW1hdGlvbikuCi0gICAgTlNXaW5k
b3cgKndpbmRvdyA9IFtbV2ViQ29yZUZ1bGxTY3JlZW5XaW5kb3cgYWxsb2NdIGluaXRXaXRoQ29u
dGVudFJlY3Q6TlNaZXJvUmVjdCBzdHlsZU1hc2s6TlNXaW5kb3dTdHlsZU1hc2tDbG9zYWJsZSBi
YWNraW5nOk5TQmFja2luZ1N0b3JlQnVmZmVyZWQgZGVmZXI6Tk9dOworICAgIE5TV2luZG93ICp3
aW5kb3cgPSBbW1dlYkNvcmVGdWxsU2NyZWVuV2luZG93IGFsbG9jXSBpbml0V2l0aENvbnRlbnRS
ZWN0Ok5TWmVyb1JlY3Qgc3R5bGVNYXNrOk5TV2luZG93U3R5bGVNYXNrVGl0bGVkIHwgTlNXaW5k
b3dTdHlsZU1hc2tVbmlmaWVkVGl0bGVBbmRUb29sYmFyIHwgTlNXaW5kb3dTdHlsZU1hc2tGdWxs
U2l6ZUNvbnRlbnRWaWV3IHwgTlNXaW5kb3dTdHlsZU1hc2tDbG9zYWJsZSBiYWNraW5nOk5TQmFj
a2luZ1N0b3JlQnVmZmVyZWQgZGVmZXI6Tk9dOwogICAgIHNlbGYgPSBbc3VwZXIgaW5pdFdpdGhX
aW5kb3c6d2luZG93XTsKICAgICBbd2luZG93IHJlbGVhc2VdOwogICAgIGlmICghc2VsZikK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>367784</attachid>
            <date>2019-04-18 19:35:55 -0700</date>
            <delta_ts>2019-04-22 16:57:23 -0700</delta_ts>
            <desc>Fix compilation error and ensure the titlebar shows in fullscreen</desc>
            <filename>YouTubeLayoutFix.patch</filename>
            <type>text/plain</type>
            <size>6668</size>
            <attacher name="Remy Demarest">rdemarest</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAxNDI4NjYyMzUyYi4uM2FmNzRiZDBhYTAgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyNCBAQAorMjAxOS0wNC0xOCAgUmVteSBEZW1hcmVzdCAgPHJkZW1hcmVzdEBhcHBsZS5j
b20+CisKKyAgICAgICAgRml4IGxheW91dCBpc3N1ZXMgb2NjdXJpbmcgd2hlbiBlbnRlcmluZyBm
dWxsIHNjcmVlbiBtb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTk3MDg2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzczMzY3MT4uCisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpc3N1ZSBp
cyB0aGUgcmVzdWx0IG9mIGNoYW5naW5nIHRoZSBzdHlsZSBtYXNrIG9mIHRoZSB3aW5kb3cgYWZ0
ZXIgZW50ZXJpbmcKKyAgICAgICAgZnVsbCBzY3JlZW4gbW9kZS4gU2FmYXJpIGFkZHMgYW4gaW52
aXNpYmxlIHRvb2xiYXIgdG8gZGlzcGxheSB0aGUgVVJMIG9mIHRoZSBwYWdlCisgICAgICAgIHdo
aWNoIGVuZHMgdXAgYnJlYWtpbmcgdGhlIGxheW91dC4gSGF2aW5nIHRoYXQgd2luZG93IHVzZSBh
IHN0eWxlIHRoYXQgaW5jbGR1ZXMgYQorICAgICAgICB0aXRsZWJhciBmaXhlcyB0aGUgYnVnLgor
CisgICAgICAgICogcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2luZG93Lm1tOgorICAg
ICAgICAoLVtXZWJDb3JlRnVsbFNjcmVlbldpbmRvdyBjb25zdHJhaW5GcmFtZVJlY3Q6dG9TY3Jl
ZW46XSk6IEVuc3VyZSB0aGF0IHRoZSB3aW5kb3cKKyAgICAgICAgY2FuIGZpbGwgdGhlIGVudGly
ZSBzY3JlZW4gaW5jbHVkaW5nIHRoZSB1bmRlcmxhcHBpbmcgdGhlIG1lbnUgYmFyLCBzbyB0aGF0
IHRoZQorICAgICAgICB3aW5kb3cgZG9lcyBub3QgcmVzaXplIHdoZW4gdGhlIGFuaW1hdGlvbiBp
cyBkb25lLgorICAgICAgICAoLVtXZWJDb3JlRnVsbFNjcmVlbldpbmRvdyBjYW5CZWNvbWVNYWlu
V2luZG93XSk6IEJvcmRlcmxlc3Mgd2luZG93cyBjYW5ub3QgYmVjb21lCisgICAgICAgIG1haW4g
YnkgZGVmYXVsdCwgYWRkaW5nIHRoZSB0aXRsZWJhciBhbGxvd3MgaXQgdG8gYmVjb21lIG1haW4s
IHByZXZlbnQgdGhpcyBmcm9tCisgICAgICAgIGhhcHBlbmluZyBhdCBhbGwgdG8gcHJlc2VydmUg
dGhlIGV4aXN0aW5nIGJlaGF2aW9yLgorCiAyMDE5LTA0LTE4ICBTaGF3biBSb2JlcnRzICA8c3Jv
YmVydHNAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgbWFudWFsIHJvbGxvdXQgb2Yg
cjI0NDI0OCBhbmQgcjI0NDQwOQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
bWFjL1dlYkNvcmVGdWxsU2NyZWVuV2luZG93Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
bWFjL1dlYkNvcmVGdWxsU2NyZWVuV2luZG93Lm1tCmluZGV4IGFhNDUwMWMxYTY5Li5hYTY4ZTAx
M2ZiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxs
U2NyZWVuV2luZG93Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3Jl
RnVsbFNjcmVlbldpbmRvdy5tbQpAQCAtNTMsNiArNTMsMTcgQEAgLSAoaWQpaW5pdFdpdGhDb250
ZW50UmVjdDooTlNSZWN0KWNvbnRlbnRSZWN0IHN0eWxlTWFzazooTlNVSW50ZWdlcilhU3R5bGUg
YmFja2kKICAgICByZXR1cm4gc2VsZjsKIH0KIAorLSAoTlNSZWN0KWNvbnN0cmFpbkZyYW1lUmVj
dDooTlNSZWN0KWZyYW1lUmVjdCB0b1NjcmVlbjooTlNTY3JlZW4gKilzY3JlZW4KK3sKKyAgICBV
TlVTRURfUEFSQU0oc2NyZWVuKTsKKyAgICByZXR1cm4gZnJhbWVSZWN0OworfQorCistIChCT09M
KWNhbkJlY29tZU1haW5XaW5kb3cKK3sKKyAgICByZXR1cm4gTk87Cit9CisKIC0gKEJPT0wpY2Fu
QmVjb21lS2V5V2luZG93CiB7CiAgICAgcmV0dXJuIFlFUzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggMmI2ODE0ZGRm
YjEuLjY3ZDAxMTI4NjM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysg
Yi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE5LTA0LTE4ICBS
ZW15IERlbWFyZXN0ICA8cmRlbWFyZXN0QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggbGF5b3V0
IGlzc3VlcyBvY2N1cmluZyB3aGVuIGVudGVyaW5nIGZ1bGwgc2NyZWVuIG1vZGUuCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcwODYKKyAgICAgICAg
PHJkYXI6Ly9wcm9ibGVtLzQ3NzMzNjcxPi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzc3VlIGlzIHRoZSByZXN1bHQgb2YgY2hhbmdpbmcg
dGhlIHN0eWxlIG1hc2sgb2YgdGhlIHdpbmRvdyBhZnRlciBlbnRlcmluZworICAgICAgICBmdWxs
IHNjcmVlbiBtb2RlLiBTYWZhcmkgYWRkcyBhbiBpbnZpc2libGUgdG9vbGJhciB0byBkaXNwbGF5
IHRoZSBVUkwgb2YgdGhlIHBhZ2UKKyAgICAgICAgd2hpY2ggZW5kcyB1cCBicmVha2luZyB0aGUg
bGF5b3V0LiBIYXZpbmcgdGhhdCB3aW5kb3cgdXNlIGEgc3R5bGUgdGhhdCBpbmNsZHVlcyBhCisg
ICAgICAgIHRpdGxlYmFyIGZpeGVzIHRoZSBidWcuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9zcGkv
bWFjL0FwcEtpdFNQSS5oOgorICAgICAgICBEZWNsYXJlIGEgc2VjcmV0IFNQSSB0byBiZSB1c2Vk
IGluIFdLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv
Q29jb2EvV2ViVmlld0ltcGwubW06CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpmdWxs
U2NyZWVuV2luZG93KTogTWFrZSB0aGUgZnVsbCBzY3JlZW4gd2luZG93IHNob3cgYSB0aXRsZWJh
cgorICAgICAgICBhbmQgbWFrZSB0aGUgY29udGVudCB2aWV3IHVuZGVybGFwIHRoZSB0aXRsZWJh
ciB0byBtYXRjaCB0aGUgY3VycmVudCBiZWhhdmlvci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9t
YWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tGdWxsU2Ny
ZWVuV2luZG93Q29udHJvbGxlciBpbml0V2l0aFdpbmRvdzp3ZWJWaWV3OnBhZ2U6XSk6IEhpZGUg
dGhlIHRpdGxlYmFyCisgICAgICAgIGJlZm9yZSBiZWdpbm5pbmcgdGhlIGFuaW1hdGlvbiB0byBm
dWxsIHNjcmVlbi4KKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBmaW5p
c2hlZEVudGVyRnVsbFNjcmVlbkFuaW1hdGlvbjpdKTogU2hvdyB0aGUgdGl0bGUKKyAgICAgICAg
YmFyIHdoZW4gaW4gZnVsbCBzY3JlZW4gaW5zdGVhZCBvZiBhIGJsYW5rIGJhci4KKyAgICAgICAg
KC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBmaW5pc2hlZEV4aXRGdWxsU2NyZWVuQW5p
bWF0aW9uOl0pOiBIaWRlIHRoZSB0aXRsZQorICAgICAgICBiYXIgdG8gcmVzdG9yZSB0aGUgaW5p
dGlhbCBzZXR0aW5nLgorCiAyMDE5LTA0LTE4ICBTaGF3biBSb2JlcnRzICA8c3JvYmVydHNAYXBw
bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgbWFudWFsIHJvbGxvdXQgb2YgcjI0NDI0OCBh
bmQgcjI0NDQwOQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvbWFjL0Fw
cEtpdFNQSS5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvbWFjL0FwcEtpdFNQSS5oCmlu
ZGV4IGZhNmFiMzE5MzE2Li5hMmY5MjFlMzQ4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9Q
bGF0Zm9ybS9zcGkvbWFjL0FwcEtpdFNQSS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0v
c3BpL21hYy9BcHBLaXRTUEkuaApAQCAtNDcsNiArNDcsMTAgQEAKIC0gKHZvaWQpc2V0SW5zcGVj
dG9yQmFyOihOU0luc3BlY3RvckJhciAqKWJhcjsKIEBlbmQKIAorQGludGVyZmFjZSBOU1dpbmRv
dyAoRnVsbFNjcmVlblN1cHBvcnQpCitAcHJvcGVydHkgQ0dGbG9hdCB0aXRsZWJhckFscGhhVmFs
dWU7CitAZW5kCisKICNlbmRpZgogCiBAaW50ZXJmYWNlIE5TSW5zcGVjdG9yQmFyIChJUEkpCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbSBi
L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tCmluZGV4IDRjOTAx
NGEzZGNjLi5iMGUxNWViNDdmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv
Q29jb2EvV2ViVmlld0ltcGwubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2Ev
V2ViVmlld0ltcGwubW0KQEAgLTI2MTAsNyArMjYxMCw3IEBAIE5TVmlldyAqV2ViVmlld0ltcGw6
OmZ1bGxTY3JlZW5QbGFjZWhvbGRlclZpZXcoKQogTlNXaW5kb3cgKldlYlZpZXdJbXBsOjpmdWxs
U2NyZWVuV2luZG93KCkKIHsKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCi0gICAgcmV0dXJu
IFtbW1dlYkNvcmVGdWxsU2NyZWVuV2luZG93IGFsbG9jXSBpbml0V2l0aENvbnRlbnRSZWN0Oltb
TlNTY3JlZW4gbWFpblNjcmVlbl0gZnJhbWVdIHN0eWxlTWFzazooTlNXaW5kb3dTdHlsZU1hc2tC
b3JkZXJsZXNzIHwgTlNXaW5kb3dTdHlsZU1hc2tSZXNpemFibGUpIGJhY2tpbmc6TlNCYWNraW5n
U3RvcmVCdWZmZXJlZCBkZWZlcjpOT10gYXV0b3JlbGVhc2VdOworICAgIHJldHVybiBbW1tXZWJD
b3JlRnVsbFNjcmVlbldpbmRvdyBhbGxvY10gaW5pdFdpdGhDb250ZW50UmVjdDpbW05TU2NyZWVu
IG1haW5TY3JlZW5dIGZyYW1lXSBzdHlsZU1hc2s6KE5TV2luZG93U3R5bGVNYXNrVGl0bGVkIHwg
TlNXaW5kb3dTdHlsZU1hc2tVbmlmaWVkVGl0bGVBbmRUb29sYmFyIHwgTlNXaW5kb3dTdHlsZU1h
c2tGdWxsU2l6ZUNvbnRlbnRWaWV3IHwgTlNXaW5kb3dTdHlsZU1hc2tSZXNpemFibGUpIGJhY2tp
bmc6TlNCYWNraW5nU3RvcmVCdWZmZXJlZCBkZWZlcjpOT10gYXV0b3JlbGVhc2VdOwogI2Vsc2UK
ICAgICByZXR1cm4gbmlsOwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv
Y2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQv
VUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCmluZGV4IGU1ZDQx
MTk3NWZhLi4wNDVkYjM1MmRhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv
bWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdC9V
SVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0KQEAgLTI5LDYgKzI5
LDcgQEAKIAogI2ltcG9ydCAiV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5oIgogCisjaW1w
b3J0ICJBcHBLaXRTUEkuaCIKICNpbXBvcnQgIkxheWVyVHJlZUNvbnRleHQuaCIKICNpbXBvcnQg
IlZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94eS5oIgogI2ltcG9ydCAiV0tBUElDYXN0LmgiCkBA
IC0xMjYsNiArMTI3LDggQEAgLSAoaWQpaW5pdFdpdGhXaW5kb3c6KE5TV2luZG93ICopd2luZG93
IHdlYlZpZXc6KE5TVmlldyAqKXdlYlZpZXcgcGFnZTooV2ViS2l0OjoKICAgICBbd2luZG93IHNl
dERlbGVnYXRlOnNlbGZdOwogICAgIFt3aW5kb3cgc2V0Q29sbGVjdGlvbkJlaGF2aW9yOihbd2lu
ZG93IGNvbGxlY3Rpb25CZWhhdmlvcl0gfCBOU1dpbmRvd0NvbGxlY3Rpb25CZWhhdmlvckZ1bGxT
Y3JlZW5QcmltYXJ5KV07CiAKKyAgICB3aW5kb3cudGl0bGViYXJBbHBoYVZhbHVlID0gMDsKKwog
ICAgIE5TVmlldyAqY29udGVudFZpZXcgPSBbd2luZG93IGNvbnRlbnRWaWV3XTsKICAgICBjb250
ZW50Vmlldy5oaWRkZW4gPSBZRVM7CiAgICAgY29udGVudFZpZXcuYXV0b3Jlc2l6ZXNTdWJ2aWV3
cyA9IFlFUzsKQEAgLTM0MSw2ICszNDQsNyBAQCAtICh2b2lkKWZpbmlzaGVkRW50ZXJGdWxsU2Ny
ZWVuQW5pbWF0aW9uOihib29sKWNvbXBsZXRlZAogICAgICAgICBOU1NpemUgbWluQ29udGVudFNp
emUgPSBzZWxmLndpbmRvdy5jb250ZW50TWluU2l6ZTsKICAgICAgICAgbWluQ29udGVudFNpemUu
d2lkdGggPSBtaW5WaWRlb1dpZHRoOwogICAgICAgICBzZWxmLndpbmRvdy5jb250ZW50TWluU2l6
ZSA9IG1pbkNvbnRlbnRTaXplOworICAgICAgICBzZWxmLndpbmRvdy50aXRsZWJhckFscGhhVmFs
dWUgPSAxOwogICAgIH0gZWxzZSB7CiAgICAgICAgIC8vIFRyYW5zaXRpb24gdG8gZnVsbHNjcmVl
biBmYWlsZWQuIENsZWFuIHVwLgogICAgICAgICBfZnVsbFNjcmVlblN0YXRlID0gTm90SW5GdWxs
U2NyZWVuOwpAQCAtNDc1LDYgKzQ3OSw4IEBAIC0gKHZvaWQpZmluaXNoZWRFeGl0RnVsbFNjcmVl
bkFuaW1hdGlvbjooYm9vbCljb21wbGV0ZWQKICAgICAgICAgcmV0dXJuOwogICAgIF9mdWxsU2Ny
ZWVuU3RhdGUgPSBOb3RJbkZ1bGxTY3JlZW47CiAKKyAgICBzZWxmLndpbmRvdy50aXRsZWJhckFs
cGhhVmFsdWUgPSAwOworCiAgICAgTlNSZXNwb25kZXIgKmZpcnN0UmVzcG9uZGVyID0gW1tzZWxm
IHdpbmRvd10gZmlyc3RSZXNwb25kZXJdOwogCiAgICAgW0NBVHJhbnNhY3Rpb24gYmVnaW5dOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>367997</attachid>
            <date>2019-04-22 16:57:23 -0700</date>
            <delta_ts>2019-04-23 09:25:36 -0700</delta_ts>
            <desc>Patch including feedback changes</desc>
            <filename>PatchFixes.patch</filename>
            <type>text/plain</type>
            <size>7023</size>
            <attacher name="Remy Demarest">rdemarest</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA0YTgyMTc2MjBhMi4uOWZiODIxNTAwYjMgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyNCBAQAorMjAxOS0wNC0xOCAgUmVteSBEZW1hcmVzdCAgPHJkZW1hcmVzdEBhcHBsZS5j
b20+CisKKyAgICAgICAgRml4IGxheW91dCBpc3N1ZXMgb2NjdXJpbmcgd2hlbiBlbnRlcmluZyBm
dWxsIHNjcmVlbiBtb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTk3MDg2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzczMzY3MT4uCisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpc3N1ZSBp
cyB0aGUgcmVzdWx0IG9mIGNoYW5naW5nIHRoZSBzdHlsZSBtYXNrIG9mIHRoZSB3aW5kb3cgYWZ0
ZXIgZW50ZXJpbmcKKyAgICAgICAgZnVsbCBzY3JlZW4gbW9kZS4gU2FmYXJpIGFkZHMgYW4gaW52
aXNpYmxlIHRvb2xiYXIgdG8gZGlzcGxheSB0aGUgVVJMIG9mIHRoZSBwYWdlCisgICAgICAgIHdo
aWNoIGVuZHMgdXAgYnJlYWtpbmcgdGhlIGxheW91dC4gSGF2aW5nIHRoYXQgd2luZG93IHVzZSBh
IHN0eWxlIHRoYXQgaW5jbHVkZXMgYQorICAgICAgICB0aXRsZWJhciBmaXhlcyB0aGUgYnVnLgor
CisgICAgICAgICogcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2luZG93Lm1tOgorICAg
ICAgICAoLVtXZWJDb3JlRnVsbFNjcmVlbldpbmRvdyBjb25zdHJhaW5GcmFtZVJlY3Q6dG9TY3Jl
ZW46XSk6IEVuc3VyZSB0aGF0IHRoZSB3aW5kb3cKKyAgICAgICAgY2FuIGZpbGwgdGhlIGVudGly
ZSBzY3JlZW4gaW5jbHVkaW5nIHRoZSB1bmRlcmxhcHBpbmcgdGhlIG1lbnUgYmFyLCBzbyB0aGF0
IHRoZQorICAgICAgICB3aW5kb3cgZG9lcyBub3QgcmVzaXplIHdoZW4gdGhlIGFuaW1hdGlvbiBp
cyBkb25lLgorICAgICAgICAoLVtXZWJDb3JlRnVsbFNjcmVlbldpbmRvdyBjYW5CZWNvbWVNYWlu
V2luZG93XSk6IEJvcmRlcmxlc3Mgd2luZG93cyBjYW5ub3QgYmVjb21lCisgICAgICAgIG1haW4g
YnkgZGVmYXVsdCwgYWRkaW5nIHRoZSB0aXRsZWJhciBhbGxvd3MgaXQgdG8gYmVjb21lIG1haW4s
IHByZXZlbnQgdGhpcyBmcm9tCisgICAgICAgIGhhcHBlbmluZyBhdCBhbGwgdG8gcHJlc2VydmUg
dGhlIGV4aXN0aW5nIGJlaGF2aW9yLgorCiAyMDE5LTA0LTIyICBTaW1vbiBGcmFzZXIgIDxzaW1v
bi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEludHJvZHVjZSB0aGUgY29uY2VwdCBvZiAi
b3Bwb3J0dW5pc3RpYyIgc3RhY2tpbmcgY29udGV4dHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVsbFNjcmVlbldpbmRvdy5tbSBiL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVsbFNjcmVlbldpbmRvdy5tbQppbmRleCBhYTQ1MDFj
MWE2OS4uYWE2OGUwMTNmYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21h
Yy9XZWJDb3JlRnVsbFNjcmVlbldpbmRvdy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9tYWMvV2ViQ29yZUZ1bGxTY3JlZW5XaW5kb3cubW0KQEAgLTUzLDYgKzUzLDE3IEBAIC0gKGlk
KWluaXRXaXRoQ29udGVudFJlY3Q6KE5TUmVjdCljb250ZW50UmVjdCBzdHlsZU1hc2s6KE5TVUlu
dGVnZXIpYVN0eWxlIGJhY2tpCiAgICAgcmV0dXJuIHNlbGY7CiB9CiAKKy0gKE5TUmVjdCljb25z
dHJhaW5GcmFtZVJlY3Q6KE5TUmVjdClmcmFtZVJlY3QgdG9TY3JlZW46KE5TU2NyZWVuICopc2Ny
ZWVuCit7CisgICAgVU5VU0VEX1BBUkFNKHNjcmVlbik7CisgICAgcmV0dXJuIGZyYW1lUmVjdDsK
K30KKworLSAoQk9PTCljYW5CZWNvbWVNYWluV2luZG93Cit7CisgICAgcmV0dXJuIE5POworfQor
CiAtIChCT09MKWNhbkJlY29tZUtleVdpbmRvdwogewogICAgIHJldHVybiBZRVM7CmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmlu
ZGV4IGYxMTk3ZDMyN2YyLi41NzNlMTEwZjkxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9D
aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMiBAQAor
MjAxOS0wNC0xOCAgUmVteSBEZW1hcmVzdCAgPHJkZW1hcmVzdEBhcHBsZS5jb20+CisKKyAgICAg
ICAgRml4IGxheW91dCBpc3N1ZXMgb2NjdXJpbmcgd2hlbiBlbnRlcmluZyBmdWxsIHNjcmVlbiBt
b2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3
MDg2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzczMzY3MT4uCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpc3N1ZSBpcyB0aGUgcmVzdWx0
IG9mIGNoYW5naW5nIHRoZSBzdHlsZSBtYXNrIG9mIHRoZSB3aW5kb3cgYWZ0ZXIgZW50ZXJpbmcK
KyAgICAgICAgZnVsbCBzY3JlZW4gbW9kZS4gU2FmYXJpIGFkZHMgYW4gaW52aXNpYmxlIHRvb2xi
YXIgdG8gZGlzcGxheSB0aGUgVVJMIG9mIHRoZSBwYWdlCisgICAgICAgIHdoaWNoIGVuZHMgdXAg
YnJlYWtpbmcgdGhlIGxheW91dC4gSGF2aW5nIHRoYXQgd2luZG93IHVzZSBhIHN0eWxlIHRoYXQg
aW5jbHVkZXMgYQorICAgICAgICB0aXRsZWJhciBmaXhlcyB0aGUgYnVnLgorCisgICAgICAgICog
UGxhdGZvcm0vc3BpL21hYy9BcHBLaXRTUEkuaDoKKyAgICAgICAgRGVjbGFyZSBhbiBTUEkgdG8g
YmUgdXNlZCBpbiBXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLgorCisgICAgICAgICogVUlQ
cm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1w
bDo6ZnVsbFNjcmVlbldpbmRvdyk6IE1ha2UgdGhlIGZ1bGwgc2NyZWVuIHdpbmRvdyBzaG93IGEg
dGl0bGViYXIKKyAgICAgICAgYW5kIG1ha2UgdGhlIGNvbnRlbnQgdmlldyB1bmRlcmxhcCB0aGUg
dGl0bGViYXIgdG8gbWF0Y2ggdGhlIGN1cnJlbnQgYmVoYXZpb3IuCisgICAgICAgIFJlbW92ZSBO
U1dpbmRvd1N0eWxlTWFza0JvcmRlcmxlc3Mgd2hpY2ggaGFzIG5vIGVmZmVjdHMgc2luY2UgaXQg
aXMgZXF1YWwgdG8gemVyby4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVu
V2luZG93Q29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJv
bGxlciBpbml0V2l0aFdpbmRvdzp3ZWJWaWV3OnBhZ2U6XSk6IEhpZGUgdGhlIHRpdGxlYmFyCisg
ICAgICAgIGJlZm9yZSBiZWdpbm5pbmcgdGhlIGFuaW1hdGlvbiB0byBmdWxsIHNjcmVlbi4KKyAg
ICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBmaW5pc2hlZEVudGVyRnVsbFNj
cmVlbkFuaW1hdGlvbjpdKTogU2hvdyB0aGUgdGl0bGUKKyAgICAgICAgYmFyIHdoZW4gaW4gZnVs
bCBzY3JlZW4gaW5zdGVhZCBvZiBhIGJsYW5rIGJhci4KKyAgICAgICAgKC1bV0tGdWxsU2NyZWVu
V2luZG93Q29udHJvbGxlciBmaW5pc2hlZEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uOl0pOiBIaWRl
IHRoZSB0aXRsZQorICAgICAgICBiYXIgdG8gcmVzdG9yZSB0aGUgaW5pdGlhbCBzZXR0aW5nLgor
CiAyMDE5LTA0LTIyICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAg
ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDQ0MzcuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViS2l0L1BsYXRmb3JtL3NwaS9tYWMvQXBwS2l0U1BJLmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRm
b3JtL3NwaS9tYWMvQXBwS2l0U1BJLmgKaW5kZXggZmE2YWIzMTkzMTYuLmEyZjkyMWUzNDgwIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9tYWMvQXBwS2l0U1BJLmgKKysr
IGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvbWFjL0FwcEtpdFNQSS5oCkBAIC00Nyw2ICs0
NywxMCBAQAogLSAodm9pZClzZXRJbnNwZWN0b3JCYXI6KE5TSW5zcGVjdG9yQmFyICopYmFyOwog
QGVuZAogCitAaW50ZXJmYWNlIE5TV2luZG93IChGdWxsU2NyZWVuU3VwcG9ydCkKK0Bwcm9wZXJ0
eSBDR0Zsb2F0IHRpdGxlYmFyQWxwaGFWYWx1ZTsKK0BlbmQKKwogI2VuZGlmCiAKIEBpbnRlcmZh
Y2UgTlNJbnNwZWN0b3JCYXIgKElQSSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j
ZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2Ev
V2ViVmlld0ltcGwubW0KaW5kZXggNGM5MDE0YTNkY2MuLmIwZTE1ZWI0N2YzIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQorKysgYi9Tb3Vy
Y2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQpAQCAtMjYxMCw3ICsyNjEw
LDcgQEAgTlNWaWV3ICpXZWJWaWV3SW1wbDo6ZnVsbFNjcmVlblBsYWNlaG9sZGVyVmlldygpCiBO
U1dpbmRvdyAqV2ViVmlld0ltcGw6OmZ1bGxTY3JlZW5XaW5kb3coKQogewogI2lmIEVOQUJMRShG
VUxMU0NSRUVOX0FQSSkKLSAgICByZXR1cm4gW1tbV2ViQ29yZUZ1bGxTY3JlZW5XaW5kb3cgYWxs
b2NdIGluaXRXaXRoQ29udGVudFJlY3Q6W1tOU1NjcmVlbiBtYWluU2NyZWVuXSBmcmFtZV0gc3R5
bGVNYXNrOihOU1dpbmRvd1N0eWxlTWFza0JvcmRlcmxlc3MgfCBOU1dpbmRvd1N0eWxlTWFza1Jl
c2l6YWJsZSkgYmFja2luZzpOU0JhY2tpbmdTdG9yZUJ1ZmZlcmVkIGRlZmVyOk5PXSBhdXRvcmVs
ZWFzZV07CisgICAgcmV0dXJuIFtbW1dlYkNvcmVGdWxsU2NyZWVuV2luZG93IGFsbG9jXSBpbml0
V2l0aENvbnRlbnRSZWN0OltbTlNTY3JlZW4gbWFpblNjcmVlbl0gZnJhbWVdIHN0eWxlTWFzazoo
TlNXaW5kb3dTdHlsZU1hc2tUaXRsZWQgfCBOU1dpbmRvd1N0eWxlTWFza1VuaWZpZWRUaXRsZUFu
ZFRvb2xiYXIgfCBOU1dpbmRvd1N0eWxlTWFza0Z1bGxTaXplQ29udGVudFZpZXcgfCBOU1dpbmRv
d1N0eWxlTWFza1Jlc2l6YWJsZSkgYmFja2luZzpOU0JhY2tpbmdTdG9yZUJ1ZmZlcmVkIGRlZmVy
Ok5PXSBhdXRvcmVsZWFzZV07CiAjZWxzZQogICAgIHJldHVybiBuaWw7CiAjZW5kaWYKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250
cm9sbGVyLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRv
d0NvbnRyb2xsZXIubW0KaW5kZXggZTVkNDExOTc1ZmEuLjY4YjZjZjYwZjY2IDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxl
ci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93
Q29udHJvbGxlci5tbQpAQCAtMjksNiArMjksNyBAQAogCiAjaW1wb3J0ICJXS0Z1bGxTY3JlZW5X
aW5kb3dDb250cm9sbGVyLmgiCiAKKyNpbXBvcnQgIkFwcEtpdFNQSS5oIgogI2ltcG9ydCAiTGF5
ZXJUcmVlQ29udGV4dC5oIgogI2ltcG9ydCAiVmlkZW9GdWxsc2NyZWVuTWFuYWdlclByb3h5Lmgi
CiAjaW1wb3J0ICJXS0FQSUNhc3QuaCIKQEAgLTEyNiw2ICsxMjcsOSBAQCAtIChpZClpbml0V2l0
aFdpbmRvdzooTlNXaW5kb3cgKil3aW5kb3cgd2ViVmlldzooTlNWaWV3ICopd2ViVmlldyBwYWdl
OihXZWJLaXQ6OgogICAgIFt3aW5kb3cgc2V0RGVsZWdhdGU6c2VsZl07CiAgICAgW3dpbmRvdyBz
ZXRDb2xsZWN0aW9uQmVoYXZpb3I6KFt3aW5kb3cgY29sbGVjdGlvbkJlaGF2aW9yXSB8IE5TV2lu
ZG93Q29sbGVjdGlvbkJlaGF2aW9yRnVsbFNjcmVlblByaW1hcnkpXTsKIAorICAgIC8vIEhpZGUg
dGhlIHRpdGxlYmFyIGR1cmluZyB0aGUgYW5pbWF0aW9uIHRvIGZ1bGwgc2NyZWVuIHNvIHRoYXQg
b25seSB0aGUgV0tXZWJWaWV3IGNvbnRlbnQgaXMgdmlzaWJsZS4KKyAgICB3aW5kb3cudGl0bGVi
YXJBbHBoYVZhbHVlID0gMDsKKwogICAgIE5TVmlldyAqY29udGVudFZpZXcgPSBbd2luZG93IGNv
bnRlbnRWaWV3XTsKICAgICBjb250ZW50Vmlldy5oaWRkZW4gPSBZRVM7CiAgICAgY29udGVudFZp
ZXcuYXV0b3Jlc2l6ZXNTdWJ2aWV3cyA9IFlFUzsKQEAgLTM0MSw2ICszNDUsOSBAQCAtICh2b2lk
KWZpbmlzaGVkRW50ZXJGdWxsU2NyZWVuQW5pbWF0aW9uOihib29sKWNvbXBsZXRlZAogICAgICAg
ICBOU1NpemUgbWluQ29udGVudFNpemUgPSBzZWxmLndpbmRvdy5jb250ZW50TWluU2l6ZTsKICAg
ICAgICAgbWluQ29udGVudFNpemUud2lkdGggPSBtaW5WaWRlb1dpZHRoOwogICAgICAgICBzZWxm
LndpbmRvdy5jb250ZW50TWluU2l6ZSA9IG1pbkNvbnRlbnRTaXplOworCisgICAgICAgIC8vIEFs
d2F5cyBzaG93IHRoZSB0aXRsZWJhciBpbiBmdWxsIHNjcmVlbiBtb2RlLgorICAgICAgICBzZWxm
LndpbmRvdy50aXRsZWJhckFscGhhVmFsdWUgPSAxOwogICAgIH0gZWxzZSB7CiAgICAgICAgIC8v
IFRyYW5zaXRpb24gdG8gZnVsbHNjcmVlbiBmYWlsZWQuIENsZWFuIHVwLgogICAgICAgICBfZnVs
bFNjcmVlblN0YXRlID0gTm90SW5GdWxsU2NyZWVuOwpAQCAtNDc1LDYgKzQ4Miw5IEBAIC0gKHZv
aWQpZmluaXNoZWRFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbjooYm9vbCljb21wbGV0ZWQKICAgICAg
ICAgcmV0dXJuOwogICAgIF9mdWxsU2NyZWVuU3RhdGUgPSBOb3RJbkZ1bGxTY3JlZW47CiAKKyAg
ICAvLyBIaWRlIHRoZSB0aXRsZWJhciBhdCB0aGUgZW5kIG9mIHRoZSBhbmltYXRpb24gc28gdGhh
dCBpdCBjYW4gc2xpZGUgYXdheSB3aXRob3V0IHR1cm5pbmcgYmxhbmsuCisgICAgc2VsZi53aW5k
b3cudGl0bGViYXJBbHBoYVZhbHVlID0gMDsKKwogICAgIE5TUmVzcG9uZGVyICpmaXJzdFJlc3Bv
bmRlciA9IFtbc2VsZiB3aW5kb3ddIGZpcnN0UmVzcG9uZGVyXTsKIAogICAgIFtDQVRyYW5zYWN0
aW9uIGJlZ2luXTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>