197066 2019-04-18 11:52:22 -0700 Remove useConcurrentBarriers option 2019-04-18 13:45:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1528524 0 saam 2019-04-18 11:52:22 -0700 ... 1528525 1 367741 saam 2019-04-18 11:55:36 -0700 Created attachment 367741 patch 1528526 2 367741 msaboff 2019-04-18 11:58:05 -0700 Comment on attachment 367741 patch r=me 1528527 3 ysuzuki 2019-04-18 11:59:44 -0700 r=me too. Now, we always use FencedStoreBarrier. So I think we can drop StoreBarrier code :) 1528528 4 ysuzuki 2019-04-18 12:00:09 -0700 (In reply to Yusuke Suzuki from comment #3) > r=me too. Now, we always use FencedStoreBarrier. So I think we can drop > StoreBarrier code :) Ah, no, ignore it. 1528529 5 saam 2019-04-18 12:08:48 -0700 (In reply to Yusuke Suzuki from comment #3) > r=me too. Now, we always use FencedStoreBarrier. So I think we can drop > StoreBarrier code :) I originally thought that too but came to the same conclusion you did. 1528559 6 367741 commit-queue 2019-04-18 13:44:53 -0700 Comment on attachment 367741 patch Clearing flags on attachment: 367741 Committed r244433: <https://trac.webkit.org/changeset/244433> 1528560 7 commit-queue 2019-04-18 13:44:55 -0700 All reviewed patches have been landed. Closing bug. 1528562 8 webkit-bug-importer 2019-04-18 13:45:22 -0700 <rdar://problem/50026980> 367741 2019-04-18 11:55:36 -0700 2019-04-18 13:44:53 -0700 patch c-backup.diff text/plain 3563 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ0NDMwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE5LTA0LTE4ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFJlbW92ZSB1c2VDb25jdXJyZW50QmFycmllcnMgb3B0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcwNjYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzbid0IGEgaGVscGZ1bCBvcHRpb24g YXMgaXQgd2lsbCBsZWFkIHVzIHRvIGNyYXNoIHdoZW4gdXNpbmcgdGhlCisgICAgICAgIGNvbmN1 cnJlbnQgR0MuCisKKyAgICAgICAgKiBkZmcvREZHU3RvcmVCYXJyaWVyQ2x1c3RlcmluZ1BoYXNl LmNwcDoKKyAgICAgICAgKiBkZmcvREZHU3RvcmVCYXJyaWVySW5zZXJ0aW9uUGhhc2UuY3BwOgor ICAgICAgICAqIGppdC9Bc3NlbWJseUhlbHBlcnMuaDoKKyAgICAgICAgKEpTQzo6QXNzZW1ibHlI ZWxwZXJzOjpiYXJyaWVyU3RvcmVMb2FkRmVuY2UpOgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9u cy5oOgorCiAyMDE5LTA0LTE3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbW92ZSBkZXByZWNhdGVkIEpTU2NyaXB0IFNQSQpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdTdG9yZUJhcnJpZXJDbHVzdGVyaW5nUGhhc2UuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3RvcmVCYXJyaWVyQ2x1c3Rlcmlu Z1BoYXNlLmNwcAkocmV2aXNpb24gMjQ0NDMwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdTdG9yZUJhcnJpZXJDbHVzdGVyaW5nUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NDAsNyArMTQwLDcgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICBDb2RlT3JpZ2luIHNlbWFu dGljT3JpZ2luID0gaXRlci0+c2VtYW50aWNPcmlnaW47CiAgICAgICAgICAgICAgICAgCiAgICAg ICAgICAgICAgICAgTm9kZVR5cGUgdHlwZTsKLSAgICAgICAgICAgICAgICBpZiAoT3B0aW9uczo6 dXNlQ29uY3VycmVudEJhcnJpZXJzKCkgJiYgaXRlciA9PSBtX25lZWRlZEJhcnJpZXJzLmJlZ2lu KCkpCisgICAgICAgICAgICAgICAgaWYgKGl0ZXIgPT0gbV9uZWVkZWRCYXJyaWVycy5iZWdpbigp KQogICAgICAgICAgICAgICAgICAgICB0eXBlID0gRmVuY2VkU3RvcmVCYXJyaWVyOwogICAgICAg ICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAgdHlwZSA9IFN0b3JlQmFycmllcjsK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3RvcmVCYXJyaWVySW5zZXJ0aW9u UGhhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3Rv cmVCYXJyaWVySW5zZXJ0aW9uUGhhc2UuY3BwCShyZXZpc2lvbiAyNDQ0MzApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR1N0b3JlQmFycmllckluc2VydGlvblBoYXNlLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDc4LDEzICs0NzgsNyBAQCBwcml2YXRlOgogICAgICAgICBpZiAoY2xv YmJlcnNFeGl0U3RhdGUobV9ncmFwaCwgbV9ub2RlKSkKICAgICAgICAgICAgIG9yaWdpbiA9IG9y aWdpbi53aXRoSW52YWxpZEV4aXQoKTsKICAgICAgICAgCi0gICAgICAgIE5vZGVUeXBlIHR5cGU7 Ci0gICAgICAgIGlmIChPcHRpb25zOjp1c2VDb25jdXJyZW50QmFycmllcnMoKSkKLSAgICAgICAg ICAgIHR5cGUgPSBGZW5jZWRTdG9yZUJhcnJpZXI7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAg IHR5cGUgPSBTdG9yZUJhcnJpZXI7Ci0gICAgICAgIAotICAgICAgICBtX2luc2VydGlvblNldC5p bnNlcnROb2RlKG5vZGVJbmRleCwgU3BlY05vbmUsIHR5cGUsIG9yaWdpbiwgYmFzZSk7CisgICAg ICAgIG1faW5zZXJ0aW9uU2V0Lmluc2VydE5vZGUobm9kZUluZGV4LCBTcGVjTm9uZSwgRmVuY2Vk U3RvcmVCYXJyaWVyLCBvcmlnaW4sIGJhc2UpOwogICAgIH0KICAgICAKICAgICBib29sIHJlYWxs eUluc2VydEJhcnJpZXJzKCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQXNzZW1i bHlIZWxwZXJzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9Bc3Nl bWJseUhlbHBlcnMuaAkocmV2aXNpb24gMjQ0NDMwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9Bc3NlbWJseUhlbHBlcnMuaAkod29ya2luZyBjb3B5KQpAQCAtMTU0MSw4ICsxNTQxLDYg QEAgcHVibGljOgogICAgIAogICAgIHZvaWQgYmFycmllclN0b3JlTG9hZEZlbmNlKFZNJiB2bSkK ICAgICB7Ci0gICAgICAgIGlmICghT3B0aW9uczo6dXNlQ29uY3VycmVudEJhcnJpZXJzKCkpCi0g ICAgICAgICAgICByZXR1cm47CiAgICAgICAgIEp1bXAgb2sgPSBqdW1wSWZNdXRhdG9yRmVuY2VO b3ROZWVkZWQodm0pOwogICAgICAgICBtZW1vcnlGZW5jZSgpOwogICAgICAgICBvay5saW5rKHRo aXMpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaAkocmV2aXNp b24gMjQ0NDMwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oCSh3 b3JraW5nIGNvcHkpCkBAIC0yMTksNyArMjE5LDYgQEAgY29uc3RleHByIGJvb2wgZW5hYmxlV2Vi QXNzZW1ibHlTdHJlYW1pbgogICAgIHYoYm9vbCwgdGVzdFRoZUZUTCwgZmFsc2UsIE5vcm1hbCwg bnVsbHB0cikgXAogICAgIHYoYm9vbCwgdmVyYm9zZVNhbml0aXplU3RhY2ssIGZhbHNlLCBOb3Jt YWwsIG51bGxwdHIpIFwKICAgICB2KGJvb2wsIHVzZUdlbmVyYXRpb25hbEdDLCB0cnVlLCBOb3Jt YWwsIG51bGxwdHIpIFwKLSAgICB2KGJvb2wsIHVzZUNvbmN1cnJlbnRCYXJyaWVycywgdHJ1ZSwg Tm9ybWFsLCBudWxscHRyKSBcCiAgICAgdihib29sLCB1c2VDb25jdXJyZW50R0MsIHRydWUsIE5v cm1hbCwgbnVsbHB0cikgXAogICAgIHYoYm9vbCwgY29sbGVjdENvbnRpbnVvdXNseSwgZmFsc2Us IE5vcm1hbCwgbnVsbHB0cikgXAogICAgIHYoZG91YmxlLCBjb2xsZWN0Q29udGludW91c2x5UGVy aW9kTVMsIDEsIE5vcm1hbCwgbnVsbHB0cikgXAo=