197065 2019-04-18 11:15:52 -0700 [Mac WK2] REGRESSION (r244182) editing/execCommand/change-list-type.html is a flaky failure 2019-04-22 19:39:21 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=177484 https://bugs.webkit.org/show_bug.cgi?id=196985 InRadar P2 Normal --- 1 sroberts rniwa lforschler rniwa sabouhallawa simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1528516 0 sroberts 2019-04-18 11:15:52 -0700 The following layout test is flaky on Mac WK2 Release editing/execCommand/change-list-type.html Probable cause: Test started to become flaky on the dashboard around r244328. Found through local testing that changes in https://trac.webkit.org/changeset/244182/webkit caused this test to become flaky. Testing with prior revisions pass 100% Reproduced with: run-webkit-tests editing/execCommand/change-list-type.html --iterations 100 -f Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2FexecCommand%2Fchange-list-type.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/editing/execCommand/change-list-type-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/editing/execCommand/change-list-type-actual.txt @@ -354,7 +354,64 @@ | "one" | " " -| <ol> +| <ul> +| class="list" +| style="color: red" +| " + " +| <li> +| id="two" +| "two" +| " + " +| <li> +| id="three" +| "three<#selection-caret>" +| " + " +| " + " +| <li> +| id="four" +| "four" +| " + " +| <pre> +| " " +| <ol> +| class="list" +| " + " +| <li> +| id="five" +| "five" +| " + " +| <li> +| id="six" +| "six" +| " + " +| " + " +| " + " +| " + " + +After making the outer list unordered: +| " + " +| <ul> +| class="list" +| " + " +| <li> +| id="one" +| "one" +| " + " +| <ul> | class="list" | style="color: red" | " @@ -384,25 +441,25 @@ " | <li> | id="five" -| "<#selection-anchor>five" -| " - " -| <li> -| id="six" -| "six<#selection-focus>" -| " - " -| " - " -| " - " -| " - " - -After making the outer list unordered: -| " - " -| <ul> +| "five" +| " + " +| <li> +| id="six" +| "six" +| " + " +| " + <#selection-caret>" +| " + " +| " + " + +After making the outer list ordered again: +| " + " +| <ol> | class="list" | " " @@ -411,64 +468,7 @@ | "one" | " " -| <ol> -| class="list" -| style="color: red" -| " - " -| <li> -| id="two" -| "two" -| " - " -| <li> -| id="three" -| "three" -| " - " -| " - " -| <li> -| id="four" -| "four" -| " - " -| <pre> -| " " -| <ol> -| class="list" -| " - " -| <li> -| id="five" -| "five" -| " - " -| <li> -| id="six" -| "six" -| " - " -| " - <#selection-caret>" -| " - " -| " - " - -After making the outer list ordered again: -| " - " -| <ol> -| class="list" -| " - " -| <li> -| id="one" -| "one" -| " - " -| <ol> +| <ul> | class="list" | style="color: red" | " 1528519 1 webkit-bug-importer 2019-04-18 11:18:29 -0700 <rdar://problem/50021964> 1528822 2 wenson_hsieh 2019-04-19 12:36:35 -0700 This test just needs the same tweak as r244461. 1528826 3 367815 rniwa 2019-04-19 12:51:42 -0700 Created attachment 367815 Fixes the test 1528828 4 rniwa 2019-04-19 12:56:00 -0700 Committed r244462: <https://trac.webkit.org/changeset/244462> 1528836 5 367815 simon.fraser 2019-04-19 13:18:16 -0700 Comment on attachment 367815 Fixes the test View in context: https://bugs.webkit.org/attachment.cgi?id=367815&action=review > LayoutTests/editing/execCommand/change-list-type.html:74 > + testRunner.runUIScript(`(function() { uiController.uiScriptComplete(); })()`, resolve); Wouldn't doAfterPresentationUpdate() have been better? 1528839 6 wenson_hsieh 2019-04-19 13:26:31 -0700 (In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 367815 [details] > Fixes the test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367815&action=review > > > LayoutTests/editing/execCommand/change-list-type.html:74 > > + testRunner.runUIScript(`(function() { uiController.uiScriptComplete(); })()`, resolve); > > Wouldn't doAfterPresentationUpdate() have been better? I wouldn't think this needs to wait for the next layer tree flush; it simply needs to ensure that the current runloop in the UI process has finished. 1529507 7 rniwa 2019-04-22 19:39:21 -0700 Looks like the flakiness is gone! 367815 2019-04-19 12:51:42 -0700 2019-04-19 12:52:04 -0700 Fixes the test bug-197065-20190419125141.patch text/plain 1772 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI0NDQ2MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA0LTE5ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFtNYWMgV0syXSBSRUdSRVNTSU9OIChyMjQ0MTgy KSBlZGl0aW5nL2V4ZWNDb21tYW5kL2NoYW5nZS1saXN0LXR5cGUuaHRtbCBpcyBhIGZsYWt5IGZh aWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 NzA2NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTAwMjE5NjQ+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGlrZSByMjQ0NDYxLCB0aGlzIHRlc3Qg d2FzIGVycm9ybm9zdWx5IGFzc3VtaW5nIHRoYXQgckFGIHdvdWxkIGJlIGVub3VnaCB0byBjbG9z ZSB0aGUgdW5kbyBncm91cAorICAgICAgICBpbiB0aGUgVUkgcHJvY2Vzcy4gRml4ZWQgdGhlIHRl c3QgYnkgZXhwbGljaXRseSB3YWl0aW5nIGZvciB0aGUgcnVubG9vcCBpbiB0aGUgdWkgcHJvY2Vz cyB0byBydW4KKyAgICAgICAgYnkgZXhlY3V0aW5nIGEgVUkgc2NyaXB0LgorCisgICAgICAgICog ZWRpdGluZy9leGVjQ29tbWFuZC9jaGFuZ2UtbGlzdC10eXBlLmh0bWw6CisKIDIwMTktMDQtMTkg IFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTjog KHIyNDQxODIpIExheW91dCBUZXN0IGVkaXRpbmcvZXhlY0NvbW1hbmQvaW5zZXJ0LW5lc3RlZC1s aXN0cy5odG1sIGlzIGZsYWt5CkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5k L2NoYW5nZS1saXN0LXR5cGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5n L2V4ZWNDb21tYW5kL2NoYW5nZS1saXN0LXR5cGUuaHRtbAkocmV2aXNpb24gMjQ0NDYwKQorKysg TGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9jaGFuZ2UtbGlzdC10eXBlLmh0bWwJKHdv cmtpbmcgY29weSkKQEAgLTY5LDYgKzY5LDEzIEBACiAgICAgICAgIGludGVybmFscy5jaGFuZ2VT ZWxlY3Rpb25MaXN0VHlwZSgpOwogICAgICAgICBNYXJrdXAuZHVtcCgidG9wIiwgIkFmdGVyIGNo YW5naW5nIHRoZSBmaXJzdCBzdWJsaXN0IGJhY2sgdG8gb3JkZXJlZCIpOwogCisgICAgICAgIGF3 YWl0IG5ldyBQcm9taXNlKChyZXNvbHZlKSA9PiB7CisgICAgICAgICAgICBpZiAod2luZG93LnRl c3RSdW5uZXIpCisgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5ydW5VSVNjcmlwdChgKGZ1bmN0 aW9uKCkgeyB1aUNvbnRyb2xsZXIudWlTY3JpcHRDb21wbGV0ZSgpOyB9KSgpYCwgcmVzb2x2ZSk7 CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgc2V0VGltZW91dChyZXNvbHZlLCA1 MDApOworICAgICAgICB9KTsKKwogICAgICAgICBhd2FpdCBuZXcgUHJvbWlzZShyZXF1ZXN0QW5p bWF0aW9uRnJhbWUpOwogICAgICAgICBnZXRTZWxlY3Rpb24oKS5zZXRCYXNlQW5kRXh0ZW50KGZp dmUsIDAsIHNpeCwgMSk7CiAgICAgICAgIGludGVybmFscy5jaGFuZ2VTZWxlY3Rpb25MaXN0VHlw ZSgpOwo=