197051 2019-04-17 23:01:28 -0700 Web Inspector: REGRESSION (r244155): pressing down expands folders in trees 2019-04-18 14:20:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 192711 1 hi hi commit-queue hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1528402 0 hi 2019-04-17 23:01:28 -0700 # STEPS TO REPRODUCE: 1. inspect any page 2. go to the Elements tab 3. select the <body> 4. press down => the <body> expands and the first child is selected (instead of the next sibling of <body> being selected) 1528403 1 webkit-bug-importer 2019-04-17 23:04:22 -0700 <rdar://problem/50006414> 1528564 2 367748 hi 2019-04-18 13:46:48 -0700 Created attachment 367748 Patch 1528588 3 367748 commit-queue 2019-04-18 14:20:14 -0700 Comment on attachment 367748 Patch Clearing flags on attachment: 367748 Committed r244435: <https://trac.webkit.org/changeset/244435> 1528589 4 commit-queue 2019-04-18 14:20:16 -0700 All reviewed patches have been landed. Closing bug. 367748 2019-04-18 13:46:48 -0700 2019-04-18 14:20:14 -0700 Patch bug-197051-20190418134647.patch text/plain 3605 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGUwMzE2ZmE4NGU5ZTVmMTZlNjVkOTMyZDc4YmMw NzFlZmM3NWFiOWEuLmE4MTZjMGJhNTAwY2QzYWU3NjM5MDZjYmM0NjczYWY2NTE4NDZiODcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA0LTE4ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OIChyMjQ0MTU1KTogcHJlc3NpbmcgZG93biBleHBhbmRzIGZvbGRlcnMgaW4gdHJl ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzA1 MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTAwMDY0MTQ+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVP dXRsaW5lLmpzOgorICAgICAgICAoV0kuVHJlZU91dGxpbmUucHJvdG90eXBlLnNlbGVjdGlvbkNv bnRyb2xsZXJQcmV2aW91c1NlbGVjdGFibGVJdGVtKToKKyAgICAgICAgKFdJLlRyZWVPdXRsaW5l LnByb3RvdHlwZS5zZWxlY3Rpb25Db250cm9sbGVyTmV4dFNlbGVjdGFibGVJdGVtKToKKyAgICAg ICAgU2tpcCBoaWRkZW4gaXRlbXMgd2hlbiB0cmF2ZXJzaW5nIHRoZSB0cmVlLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlT3V0bGluZS5qczoKKyAgICAgICAgKFdJLkRP TVRyZWVPdXRsaW5lLnByb3RvdHlwZS5vbmRlbGV0ZSk6CisgICAgICAgIFJldmVhbCBhbGwgaXRl bXMgYWJvdXQgdG8gYmUgZGVsZXRlZCBzbyB0aGF0IHRoZSBhYm92ZSBjaGFuZ2Ugd29uJ3Qgc2tp cCBhbnkgc2libGluZ3MuCisKIDIwMTktMDQtMTggIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENhbnZhczogZW5hYmxlIFdlYkdMMiBm b3IgaW5zcGVjdG9yIHBhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVPdXRsaW5lLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZU91dGxpbmUuanMKaW5kZXggNjdkNTQ0MTlhZWE3 YTBlZGI2YWQ0YzViYjc2ZGQ4MmMzN2I0ZmFmYi4uN2EwOTEzOTBjYzM4ZWIxZjc2OTFmMDcwYzAy NjlhZDRhZTZjMzhjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvRE9NVHJlZU91dGxpbmUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZU91dGxpbmUuanMKQEAgLTMxMyw2ICszMTMsMTIg QEAgV0kuRE9NVHJlZU91dGxpbmUgPSBjbGFzcyBET01UcmVlT3V0bGluZSBleHRlbmRzIFdJLlRy ZWVPdXRsaW5lCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICAgICAgdGhpcy5fdHJl ZUVsZW1lbnRzVG9SZW1vdmUgPSB0aGlzLnNlbGVjdGVkVHJlZUVsZW1lbnRzOworCisgICAgICAg IC8vIFJldmVhbCBhbGwgb2YgdGhlIGVsZW1lbnRzIGJlaW5nIGRlbGV0ZWQgc28gdGhhdCBpZiB0 aGUgbm9kZSBpcyBoaWRkZW4gKGUuZy4gdGhlIHBhcmVudAorICAgICAgICAvLyBpcyBjb2xsYXBz ZWQpLCB3ZSBjYW4gc2VsZWN0IGl0cyBzaWJsaW5ncyBpbnN0ZWFkIG9mIHRoZSBwYXJlbnQgaXRz ZWxmLgorICAgICAgICBmb3IgKGxldCB0cmVlRWxlbWVudCBvZiB0aGlzLl90cmVlRWxlbWVudHNU b1JlbW92ZSkKKyAgICAgICAgICAgIHRyZWVFbGVtZW50LnJldmVhbCgpOworCiAgICAgICAgIHRo aXMuX3NlbGVjdGlvbkNvbnRyb2xsZXIucmVtb3ZlU2VsZWN0ZWRJdGVtcygpOwogCiAgICAgICAg IGxldCBsZXZlbE1hcCA9IG5ldyBNYXA7CkBAIC0zMzUsMTIgKzM0MSwxMiBAQCBXSS5ET01UcmVl T3V0bGluZSA9IGNsYXNzIERPTVRyZWVPdXRsaW5lIGV4dGVuZHMgV0kuVHJlZU91dGxpbmUKIAog ICAgICAgICAvLyBUcmFjayByZW1vdmVkIGVsZW1lbnRzLCBzaW5jZSB0aGUgb3BlbmluZyBhbmQg Y2xvc2luZyB0YWdzIGZvciB0aGUKICAgICAgICAgLy8gc2FtZSBXSS5ET01Ob2RlIGNhbiBib3Ro IGJlIHNlbGVjdGVkLgotICAgICAgICBsZXQgcmVtb3ZlZFRyZWVFbGVtZW50cyA9IG5ldyBTZXQ7 CisgICAgICAgIGxldCByZW1vdmVkRE9NTm9kZXMgPSBuZXcgU2V0OwogCiAgICAgICAgIGZvciAo bGV0IHRyZWVFbGVtZW50IG9mIHRoaXMuX3RyZWVFbGVtZW50c1RvUmVtb3ZlKSB7Ci0gICAgICAg ICAgICBpZiAocmVtb3ZlZFRyZWVFbGVtZW50cy5oYXModHJlZUVsZW1lbnQpKQorICAgICAgICAg ICAgaWYgKHJlbW92ZWRET01Ob2Rlcy5oYXModHJlZUVsZW1lbnQucmVwcmVzZW50ZWRPYmplY3Qp KQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICAgICAgcmVtb3ZlZFRyZWVFbGVt ZW50cy5hZGQodHJlZUVsZW1lbnQpCisgICAgICAgICAgICByZW1vdmVkRE9NTm9kZXMuYWRkKHRy ZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0KTsKICAgICAgICAgICAgIHRyZWVFbGVtZW50LnJl bW92ZSgpOwogICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvVHJlZU91dGxpbmUuanMKaW5kZXggNDQ5YzY2ZjY2ZmUyNGQ2 NTk3OGIwYjBiMTViM2JhZDMxZDdjYTI2Yi4uNjZlY2Q1MmJiOGYzMzkxY2MzNzMyZjA4MDAxYmVk NmM0ZjQyZWM0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVHJlZU91dGxpbmUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVHJlZU91dGxpbmUuanMKQEAgLTg1NSw3ICs4NTUsNyBAQCBXSS5UcmVl T3V0bGluZSA9IGNsYXNzIFRyZWVPdXRsaW5lIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgIGlm ICghdHJlZUVsZW1lbnQpCiAgICAgICAgICAgICByZXR1cm4gbnVsbDsKIAotICAgICAgICBjb25z dCBza2lwVW5yZXZlYWxlZCA9IGZhbHNlOworICAgICAgICBjb25zdCBza2lwVW5yZXZlYWxlZCA9 IHRydWU7CiAgICAgICAgIGNvbnN0IHN0YXlXaXRoaW4gPSBudWxsOwogICAgICAgICBjb25zdCBk b250UG9wdWxhdGUgPSB0cnVlOwogCkBAIC04NzQsNyArODc0LDcgQEAgV0kuVHJlZU91dGxpbmUg PSBjbGFzcyBUcmVlT3V0bGluZSBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICBpZiAoIXRyZWVF bGVtZW50KQogICAgICAgICAgICAgcmV0dXJuIG51bGw7CiAKLSAgICAgICAgY29uc3Qgc2tpcFVu cmV2ZWFsZWQgPSBmYWxzZTsKKyAgICAgICAgY29uc3Qgc2tpcFVucmV2ZWFsZWQgPSB0cnVlOwog ICAgICAgICBjb25zdCBzdGF5V2l0aGluID0gbnVsbDsKICAgICAgICAgY29uc3QgZG9udFBvcHVs YXRlID0gdHJ1ZTsKIAo=