197047 2019-04-17 19:02:17 -0700 Update UIKit when a cut causes a selection change 2019-04-19 20:06:55 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner bdakin commit-queue darin thorton wenson_hsieh oldest_to_newest 1528372 0 megan_gardner 2019-04-17 19:02:17 -0700 Update UIKIt when a cut causes a selection change 1528373 1 367711 megan_gardner 2019-04-17 19:05:28 -0700 Created attachment 367711 Patch 1528377 2 megan_gardner 2019-04-17 19:14:33 -0700 <rdar://problem/36311563> 1528378 3 wenson_hsieh 2019-04-17 19:38:41 -0700 This looks reasonable! A couple of brief comments: - I think we want the same logic in -pasteForWebView:. There's the reverse of this bug, where if a user (1) copies something, (2) makes a ranged selection, and then (3) pastes, one would expect the undo/redo buttons to show up, but the copy/paste/cut buttons are still there, probably because we don't tell UIKit that the selection changes. I *think* this would also be fixed by applying your fix to the paste case. But if you prefer, we can do this as a followup. - I believe writing an API test for this shouldn't be *too* bad. I've recently written some tests in KeyboardInputTestsIOS.mm that focus editable fields and check the state of UIBarButtonItemGroups. You might be able to use these tests as a template. 1528593 4 megan_gardner 2019-04-18 14:26:48 -0700 After several hours of trying, a test has been determined to be unfeasible. I'll fix the copy bug in a followup. 1528606 5 367711 commit-queue 2019-04-18 14:57:53 -0700 Comment on attachment 367711 Patch Clearing flags on attachment: 367711 Committed r244438: <https://trac.webkit.org/changeset/244438> 1528608 6 commit-queue 2019-04-18 14:57:55 -0700 All reviewed patches have been landed. Closing bug. 1528853 7 darin 2019-04-19 14:01:55 -0700 What about when the webpage itself calls execCommand("Cut")? Do we eventually need a different solution to make sure that case is also correctly handled? 1529015 8 wenson_hsieh 2019-04-19 20:06:55 -0700 (In reply to Darin Adler from comment #7) > What about when the webpage itself calls execCommand("Cut")? Do we > eventually need a different solution to make sure that case is also > correctly handled? Yes, I think we need a different solution for that to work (which may obviate the need for this change). In fact, there's a FIXME for it elsewhere in this file: (WKContentViewInteraction.mm:5656) // FIXME: We need to figure out what to do if the selection is changed by Javascript. We may, for example, want to consider having UIKit re-validate its input assistant items after executing an editing command. 367711 2019-04-17 19:05:28 -0700 2019-04-18 14:57:53 -0700 Patch bug-197047-20190417190527.patch text/plain 1469 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ1M2UwZWY2YjgzMmM5MjE5 MmRmMzhiZDgyZTA1ODQ0NjEwNDRjNDQuLjg0YjFhMWQzMGJkYjIyOTAxNmNkOGY1ZDc0NTRmZGEw MWRiNDlhMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDQtMTcgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBVcGRhdGUgVUlLaXQg d2hlbiBhIGN1dCBjYXVzZXMgYSBzZWxlY3Rpb24gY2hhbmdlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcwNDcKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzM2MzExNTYzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdlIG5lZWQgdG8gbGV0IFVJS2l0IGtub3cgd2hlbiBhIGN1dCBjYXVzZXMgYSBzZWxl Y3Rpb24gY2hhbmdlIChhbHdheXMpLAorICAgICAgICBzbyB0aGF0IGlzIGNhbiBhcHByb3ByaWF0 ZWx5IHVwZGF0ZSB0aGUgYnV0dG9uIG9uIHRoZSBrZXlib2FyZCBiYXIuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tD b250ZW50VmlldyBjdXRGb3JXZWJWaWV3Ol0pOgorCiAyMDE5LTA0LTExICBXZW5zb24gSHNpZWgg IDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IHRoZSBNZWRpYVNvdXJj ZSBBUEkgdG8gYmUgZW5hYmxlZCB2aWEgd2Vic2l0ZSBwb2xpY3kKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4 IDg0ZTczMWZjNDJkMzY5NzVkMDc5NDNhYWM5MTQwZjIwMmIwZjA5MDEuLmMxMDQwNWYwM2FjYWFm NTllZWI3MjhmNzY1ODMxNGVmM2U3MTkzNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtMzAxNSw3ICsz MDE1LDcgQEAgLSAodm9pZCljb3B5Rm9yV2ViVmlldzooaWQpc2VuZGVyCiAKIC0gKHZvaWQpY3V0 Rm9yV2ViVmlldzooaWQpc2VuZGVyCiB7Ci0gICAgX3BhZ2UtPmV4ZWN1dGVFZGl0Q29tbWFuZCgi Y3V0Il9zKTsKKyAgICBbc2VsZiBleGVjdXRlRWRpdENvbW1hbmRXaXRoQ2FsbGJhY2s6QCJjdXQi XTsKIH0KIAogLSAodm9pZClwYXN0ZUZvcldlYlZpZXc6KGlkKXNlbmRlcgo=