197043 2019-04-17 16:59:21 -0700 Adopt different scroll view flashing SPI 2019-04-17 17:42:43 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton benjamin cdumez cmarcelo commit-queue dbates ews-watchlist ggaren webkit-bug-importer wenson_hsieh oldest_to_newest 1528343 0 thorton 2019-04-17 16:59:21 -0700 Adopt different scroll view flashing SPI 1528344 1 367699 thorton 2019-04-17 16:59:32 -0700 Created attachment 367699 Patch 1528345 2 thorton 2019-04-17 16:59:34 -0700 <rdar://problem/49996476> 1528348 3 367699 ggaren 2019-04-17 17:02:44 -0700 Comment on attachment 367699 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367699&action=review r=me > Source/WebKit/Platform/spi/ios/UIKitSPI.h:347 > +- (void)_flashScrollIndicatorsPersistingPreviousFlashes; Should we #if this too? 1528349 4 thorton 2019-04-17 17:03:28 -0700 (In reply to Geoffrey Garen from comment #3) > Comment on attachment 367699 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367699&action=review > > r=me > > > Source/WebKit/Platform/spi/ios/UIKitSPI.h:347 > > +- (void)_flashScrollIndicatorsPersistingPreviousFlashes; > > Should we #if this too? 🤷‍♂️ 1528354 5 367699 commit-queue 2019-04-17 17:42:41 -0700 Comment on attachment 367699 Patch Clearing flags on attachment: 367699 Committed r244414: <https://trac.webkit.org/changeset/244414> 1528355 6 commit-queue 2019-04-17 17:42:43 -0700 All reviewed patches have been landed. Closing bug. 367699 2019-04-17 16:59:32 -0700 2019-04-17 17:42:41 -0700 Patch bug-197043-20190417165932.patch text/plain 3813 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDk5MDEwOGExYmI4NDBlNjc0YTRmZTMw YTk2YjU5ZjhhYTM2OGEzNmUuLmM5M2Q2MTcxNGFmYzQxYTYyMTVlMzAxOTFlODQ1YTIxY2E5Njli YjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDQtMTcgIFRpbSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRvcHQgZGlmZmVyZW50IHNjcm9sbCB2aWV3 IGZsYXNoaW5nIFNQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk3MDQzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTk5NjQ3Nj4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5o OgorCiAyMDE5LTA0LTE3ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIEVuYWJsZSBIQVZFX0FWRk9VTkRBVElPTl9WSURFT19PVVRQVVQgb24gUExBVEZPUk0oSU9T TUFDKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0 L0NoYW5nZUxvZwppbmRleCA4ODljZWUwODFkNWNiMjFjNWZlMjk1NTQ3NmEzZjExNGMzYzkxOGQw Li45ZDFhMTQzOWFjYjg3OGM5ZmYzNmRhZmVjOGNkYWM5MmMyOTVmMjc4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDE5LTA0LTE3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBw bGUuY29tPgorCisgICAgICAgIEFkb3B0IGRpZmZlcmVudCBzY3JvbGwgdmlldyBmbGFzaGluZyBT UEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzA0 MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk5OTY0NzY+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJ Lmg6CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3Iu bW06CisgICAgICAgICgtW1dLS2V5Ym9hcmRTY3JvbGxWaWV3QW5pbWF0b3Igc2Nyb2xsVG9Db250 ZW50T2Zmc2V0OmFuaW1hdGVkOl0pOgorCiAyMDE5LTA0LTE3ICBUaW0gSG9ydG9uICA8dGltb3Ro eV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNDE5ODgpOiBTd2l0 Y2hpbmcgdGFicyBpcyBzbG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5o IGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCBhYTFjNWE0Mjg4MzZiOTM4ZDAxYjIw NGU5NzU0NzMyMDRlNzBlNThhLi5jYmNmZjk1MjAxMWE2ZWU0NDZiMGZlNzE0OWZjNDQ2MDUzYTJk ZDNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9X VEYvd3RmL1BsYXRmb3JtLmgKQEAgLTE1MTksNiArMTUxOSwxMCBAQAogI2RlZmluZSBIQVZFX0FM TE9XU19TRU5TSVRJVkVfTE9HR0lORyAxCiAjZW5kaWYKIAorI2lmIChQTEFURk9STShJT1MpICYm IF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEzMDAwMCkgfHwgKFBMQVRGT1JN KFdBVENIT1MpICYmIF9fV0FUQ0hfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gNjAwMDApIHx8 IChQTEFURk9STShBUFBMRVRWKSAmJiBfX1RWX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEz MDAwMCkKKyNkZWZpbmUgSEFWRV9VSV9TQ1JPTExfVklFV19JTkRJQ0FUT1JfRkxBU0hJTkdfU1BJ IDEKKyNlbmRpZgorCiAjaWYgKFBMQVRGT1JNKElPUykgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9N SU5fUkVRVUlSRUQgPj0gMTMwMDAwKQogI2RlZmluZSBIQVZFX1JPVVRFX1NIQVJJTkdfUE9MSUNZ X0xPTkdfRk9STV9WSURFTyAxCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxh dGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9z L1VJS2l0U1BJLmgKaW5kZXggMDBkNDIyMjdjYjZjYjRhY2IxMjgzMzkxNDRiYWUzZWUwMWIxMjlh ZC4uZDg2N2ZhMWU4NmMwYmFjNTdhZDA5ODUzYzZiNjcxZjY0MDcyZjJlNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKKysrIGIvU291cmNlL1dl YktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKQEAgLTM0NCw2ICszNDQsNyBAQCB0eXBl ZGVmIE5TX0VOVU0oTlNJbnRlZ2VyLCBVSVNjcm9sbFZpZXdJbmRpY2F0b3JJbnNldEFkanVzdG1l bnRCZWhhdmlvcikgewogLSAodm9pZClfem9vbVRvQ2VudGVyOihDR1BvaW50KWNlbnRlciBzY2Fs ZTooQ0dGbG9hdClzY2FsZSBkdXJhdGlvbjooQ0ZUaW1lSW50ZXJ2YWwpZHVyYXRpb247CiAtIChk b3VibGUpX2hvcml6b250YWxWZWxvY2l0eTsKIC0gKGRvdWJsZSlfdmVydGljYWxWZWxvY2l0eTsK Ky0gKHZvaWQpX2ZsYXNoU2Nyb2xsSW5kaWNhdG9yc1BlcnNpc3RpbmdQcmV2aW91c0ZsYXNoZXM7 CiBAcHJvcGVydHkgKG5vbmF0b21pYywgZ2V0dGVyPWlzWm9vbUVuYWJsZWQpIEJPT0wgem9vbUVu YWJsZWQ7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHksIGdldHRlcj1faXNBbmltYXRp bmdab29tKSBCT09MIGlzQW5pbWF0aW5nWm9vbTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFk b25seSwgZ2V0dGVyPV9pc0FuaW1hdGluZ1Njcm9sbCkgQk9PTCBpc0FuaW1hdGluZ1Njcm9sbDsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0tleWJvYXJkU2Nyb2xs aW5nQW5pbWF0b3IubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tLZXlib2FyZFNj cm9sbGluZ0FuaW1hdG9yLm1tCmluZGV4IDJhNDJjNzFlYzQxODk5MDZmMWM5ZDliNTk0OGQxY2Q5 MzczNjkyOWQuLmJjYTk4MmUwZTU0MmJjMTM5OTZhNGRhODlhMDIxNjhmNTdmZmVjNzggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0tleWJvYXJkU2Nyb2xsaW5nQW5p bWF0b3IubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLS2V5Ym9hcmRTY3Jv bGxpbmdBbmltYXRvci5tbQpAQCAtNTkzLDcgKzU5MywxMSBAQCAtICh2b2lkKXNjcm9sbFRvQ29u dGVudE9mZnNldDooV2ViQ29yZTo6RmxvYXRQb2ludCljb250ZW50T2Zmc2V0RGVsdGEgYW5pbWF0 ZWQ6KAogICAgIGlmIChfZGVsZWdhdGVSZXNwb25kc1RvV2lsbFNjcm9sbCkKICAgICAgICAgW19k ZWxlZ2F0ZSBrZXlib2FyZFNjcm9sbFZpZXdBbmltYXRvcldpbGxTY3JvbGw6c2VsZl07CiAgICAg W3Njcm9sbFZpZXcgc2V0Q29udGVudE9mZnNldDpjb250ZW50T2Zmc2V0RGVsdGEgYW5pbWF0ZWQ6 YW5pbWF0ZWRdOworI2lmIEhBVkUoVUlfU0NST0xMX1ZJRVdfSU5ESUNBVE9SX0ZMQVNISU5HX1NQ SSkKKyAgICBbc2Nyb2xsVmlldyBfZmxhc2hTY3JvbGxJbmRpY2F0b3JzUGVyc2lzdGluZ1ByZXZp b3VzRmxhc2hlc107CisjZWxzZQogICAgIFtzY3JvbGxWaWV3IF9mbGFzaFNjcm9sbEluZGljYXRv cnNQZXJzaXN0aW5nUHJldmlvdXNGbGFzaGVzOllFU107CisjZW5kaWYKIH0KIAogLSAodm9pZClz Y3JvbGxXaXRoU2Nyb2xsVG9FeHRlbnRBbmltYXRpb25UbzooQ0dQb2ludClvZmZzZXQK