197040 2019-04-17 16:36:32 -0700 [Mac iOS WK2] Layout Test http/wpt/cache-storage/cache-quota-after-restart.any.html is a flaky failure 2019-04-25 08:50:25 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sroberts youennf achristensen cdumez cgarcia commit-queue ews-watchlist koivisto lforschler webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1528330 0 sroberts 2019-04-17 16:36:32 -0700 The following layout test is failing on Mac WK2, iOS Simulator WK2 Release and Debug http/wpt/cache-storage/cache-quota-after-restart.any.html Probable cause: test was added in https://trac.webkit.org/changeset/243276/webkit and has been a flaky failure since added. iOS Simulator Release fails the most, but has been seen on other queues as well. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fcache-storage%2Fcache-quota-after-restart.any.html Diff: --- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/http/wpt/cache-storage/cache-quota-after-restart.any-expected.txt +++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/http/wpt/cache-storage/cache-quota-after-restart.any-actual.txt @@ -1,7 +1,8 @@ -CONSOLE MESSAGE: Cache API operation failed: Quota exceeded CONSOLE MESSAGE: Cache API operation failed: Quota exceeded +Harness Error (TIMEOUT), message = null + PASS Increasing quota -PASS After network process restart, verify quota is computed according space being used -PASS After network process restart, verify quota is computed according space being used and does not increase +TIMEOUT After network process restart, verify quota is computed according space being used Test timed out +NOTRUN After network process restart, verify quota is computed according space being used and does not increase 1528331 1 webkit-bug-importer 2019-04-17 16:37:06 -0700 <rdar://problem/49997641> 1529769 2 youennf 2019-04-23 14:42:24 -0700 There are two issues there: - Test on iOS might be very slow so we should mark it this way in TestExpectations. - Sometimes, disk writing fails. Doing some logging in NetworkCache::Storage, it seems that between the time we call Storage::dispatchWriteOperation and create the folder where to write using FileSystem::makeAllDirectories and the actual write operation in IOChannel::write, the folder get deleted. Sometimes the call to FileSystem::makeAllDirectories fails as well. Doing some logging, I do not see any calls to remove these folders from another thread. 1530113 3 youennf 2019-04-24 13:13:09 -0700 As spotted by Antti, the synchronize mechanism is probably the one deleting the folder that has just been created. This probably happens as write and synchronize share the same background queue and the queue is concurrent. 1530116 4 368167 youennf 2019-04-24 13:23:03 -0700 Created attachment 368167 Patch 1530380 5 368167 commit-queue 2019-04-25 08:50:24 -0700 Comment on attachment 368167 Patch Clearing flags on attachment: 368167 Committed r244645: <https://trac.webkit.org/changeset/244645> 1530381 6 commit-queue 2019-04-25 08:50:25 -0700 All reviewed patches have been landed. Closing bug. 368167 2019-04-24 13:23:03 -0700 2019-04-25 08:50:24 -0700 Patch bug-197040-20190424132302.patch text/plain 2222 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRlNzI0Y2RmMDkwZjcyY2Vh MzIxYjk0NDlhNDRlYmQwNzI3NTc4NWEuLjM3MDNmOGZjMjkzMzAyOTg5NzMwMGM0ZmM2MTFhMTU0 YzA3ZjM2ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDQtMjQgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWMgaU9TIFdLMl0gTGF5b3V0 IFRlc3QgaHR0cC93cHQvY2FjaGUtc3RvcmFnZS9jYWNoZS1xdW90YS1hZnRlci1yZXN0YXJ0LmFu eS5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk3MDQwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTk5NzY0 MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWxh eSB3cml0ZSBvcGVyYXRpb25zIGluIGNhc2Ugc3luY2hyb25pemUgaXMgb25nb2luZy4KKyAgICAg ICAgVGhpcyBpcyByZXN0cmljdGVkIHRvIEF2b2lkUmFuZG9tbmVzcyBtb2RlIHdoaWNoIGlzIGFs d2F5cyB1c2VkIGJ5IENhY2hlQVBJCisgICAgICAgIGFuZCBpcyBhbHNvIHVzZWQgYnkgbmV0d29y ayBjYWNoZSBmb3IgbGF5b3V0IHRlc3RzLgorCisgICAgICAgIFRlc3RlZCBieSBjYWNoZS1xdW90 YS1hZnRlci1yZXN0YXJ0LmFueS5odG1sIG5vIGxvbmdlciBleGhpYml0aW5nIHdyaXRlIGRpc2sg ZXJyb3JzLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3Rv cmFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtDYWNoZTo6U3RvcmFnZTo6c3luY2hy b25pemUpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OlN0b3JhZ2U6OnN0b3JlKToK KwogMjAxOS0wNC0yMyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAg ICAgVXNlIG5vcm1hbCBsb2FkaW5nIHBhdGggZm9yIHBpbmcgbG9hZHMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFnZS5jcHAg Yi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3JhZ2Uu Y3BwCmluZGV4IDEzOGNiYjBkZTZhMmUzNmZhOWZmMmFiYzk3MzNkZTJjZDUwYjRjNTEuLjU4YmUy Y2ExZjlmYjQyMWIxZjU4OTQzZmM5ZmRjZDgwYTQxMDYxYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFnZS5jcHAKKysrIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdlLmNw cApAQCAtMzQ5LDYgKzM0OSw4IEBAIHZvaWQgU3RvcmFnZTo6c3luY2hyb25pemUoKQogICAgICAg ICAgICAgbV9ibG9iRmlsdGVyID0gV1RGTW92ZShibG9iRmlsdGVyKTsKICAgICAgICAgICAgIG1f YXBwcm94aW1hdGVSZWNvcmRzU2l6ZSA9IHJlY29yZHNTaXplOwogICAgICAgICAgICAgbV9zeW5j aHJvbml6YXRpb25JblByb2dyZXNzID0gZmFsc2U7CisgICAgICAgICAgICBpZiAobV9tb2RlID09 IE1vZGU6OkF2b2lkUmFuZG9tbmVzcykKKyAgICAgICAgICAgICAgICBkaXNwYXRjaFBlbmRpbmdX cml0ZU9wZXJhdGlvbnMoKTsKICAgICAgICAgfSk7CiAKICAgICB9KTsKQEAgLTg5Nyw3ICs4OTks NyBAQCB2b2lkIFN0b3JhZ2U6OnN0b3JlKGNvbnN0IFJlY29yZCYgcmVjb3JkLCBNYXBwZWRCb2R5 SGFuZGxlciYmIG1hcHBlZEJvZHlIYW5kbGVyLAogICAgIGFkZFRvUmVjb3JkRmlsdGVyKHJlY29y ZC5rZXkpOwogCiAgICAgYm9vbCBpc0luaXRpYWxXcml0ZSA9IG1fcGVuZGluZ1dyaXRlT3BlcmF0 aW9ucy5zaXplKCkgPT0gMTsKLSAgICBpZiAoIWlzSW5pdGlhbFdyaXRlKQorICAgIGlmICghaXNJ bml0aWFsV3JpdGUgfHwgKG1fc3luY2hyb25pemF0aW9uSW5Qcm9ncmVzcyAmJiBtX21vZGUgPT0g TW9kZTo6QXZvaWRSYW5kb21uZXNzKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV93cml0ZU9w ZXJhdGlvbkRpc3BhdGNoVGltZXIuc3RhcnRPbmVTaG90KG1faW5pdGlhbFdyaXRlRGVsYXkpOwo=