197028 2019-04-17 11:30:01 -0700 [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing 2019-04-17 18:02:59 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sroberts thorton commit-queue jlewis3 ryanhaddad simon.fraser thorton tsavell webkit-bug-importer wenson_hsieh oldest_to_newest 1528192 0 sroberts 2019-04-17 11:30:01 -0700 New API test TestWebKitAPI.WebKit.OverrideViewportArguments added in https://trac.webkit.org/changeset/244151 is failing on iOS Simulator Debug https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20%28Tests%29/builds/3239/steps/run-api-tests/logs/stdio Is failing every run on the bots, is a flaky failure when run locally. TestWebKitAPI.WebKit.OverrideViewportArguments 2019-04-10 17:41:45.743 TestWebKitAPI[3470:6770579] -[WKWebView _overrideViewportWithArguments:]: Error parsing viewport argument: Viewport argument key "garbage" not recognized and ignored. LEAK: 1 WebProcessPool LEAK: 1 WebPageProxy /Volumes/Data/slave/ios-simulator-12-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:54 Expected equality of these values: 1. Which is: 1 [webView scrollView].zoomScale Which is: 0.25 1528195 1 webkit-bug-importer 2019-04-17 11:33:50 -0700 <rdar://problem/49985290> 1528352 2 367702 thorton 2019-04-17 17:22:16 -0700 Created attachment 367702 Patch 1528360 3 367702 commit-queue 2019-04-17 18:02:58 -0700 Comment on attachment 367702 Patch Clearing flags on attachment: 367702 Committed r244415: <https://trac.webkit.org/changeset/244415> 1528361 4 commit-queue 2019-04-17 18:02:59 -0700 All reviewed patches have been landed. Closing bug. 367702 2019-04-17 17:22:16 -0700 2019-04-17 18:02:58 -0700 Patch bug-197028-20190417172216.patch text/plain 3868 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MzkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWRlMTA1NDUyZmNmOWIwY2FlMGUxODk2MzNiN2YxNWQ2 YzZkYmZjNC4uNjdjNWZmYTJiYTkzMmM4Njg4Nzc4ZjE0N2JhNzlkZDJlNDkwNTQ3NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE5LTA0LTE3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgor CisgICAgICAgIFtpT1MgU2ltIERlYnVnXSBSRUdSRVNTSU9OIChyMjQ0MTUxKSBUZXN0V2ViS2l0 QVBJLldlYktpdC5PdmVycmlkZVZpZXdwb3J0QXJndW1lbnRzIGlzIGZhaWxpbmcgKDE5NzAyOCkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzAyOAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk5ODUyOTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL092ZXJyaWRlVmlld3BvcnRBcmd1bWVudHMubW06CisgICAgICAgIChURVNUKToKKyAgICAg ICAgTGliZXJhbCBhcHBsaWNhdGlvbiBvZiB3YWl0Rm9yTmV4dFByZXNlbnRhdGlvblVwZGF0ZSB3 b3JrcyBhcm91bmQgYSByYWNlCisgICAgICAgIHdoZXJlIGlmIHRoZSBwYWdlIHJhcGlkbHkgY2hh bmdlcyBpdHMgdmlld3BvcnQgYXJndW1lbnRzIChvciBhbiBBUEkgY2xpZW50CisgICAgICAgIHJh cGlkbHkgY2hhbmdlcyBpdHMgdmlld3BvcnQgYXJndW1lbnRzKSwgd2UnZCBnZXQgc3R1Y2sgdGhp bmtpbmcgdGhhdCB0aGUKKyAgICAgICAgdXNlciBoYWQgaW50ZW50aW9uYWxseSB6b29tZWQgdGhl IHBhZ2UsIGFuZCBzdG9wIHJlc2V0dGluZyB0aGUgaW5pdGlhbCBzY2FsZS4KKyAgICAgICAgVGhp cyBkZXNlcnZlcyBhIHNlcGFyYXRlIGJ1ZywgYnV0IG5vIG5lZWQgdG8ga2VlcCB0aGUgdGVzdCBm YWlsaW5nIHdoaWxlCisgICAgICAgIHdlIHRoaW5rIGFib3V0IGl0LgorCiAyMDE5LTA0LTE3ICBB bGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgV0tS ZXRhaW5QdHIncyBhZG9wdGlvbiBjb25zdHJ1Y3RvciBzaG91bGQgYmUgcHJpdmF0ZQpkaWZmIC0t Z2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9PdmVycmlkZVZpZXdw b3J0QXJndW1lbnRzLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9P dmVycmlkZVZpZXdwb3J0QXJndW1lbnRzLm1tCmluZGV4IDdlMTBmYWRiNzg2ODY3NTlhNjU1ODlh MGUzODAxYmY4OGU4NWJlNDUuLmE5NzZlYmFlZDU3Y2RjNWEwYWZjZTQ3ZjFjM2MxMzQ0ZDMwMTM0 YzIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvT3Zl cnJpZGVWaWV3cG9ydEFyZ3VtZW50cy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdENvY29hL092ZXJyaWRlVmlld3BvcnRBcmd1bWVudHMubW0KQEAgLTQyLDM1ICs0Miwz OCBAQCBURVNUKFdlYktpdCwgT3ZlcnJpZGVWaWV3cG9ydEFyZ3VtZW50cykKICAgICAgICAgcmV0 dXJuIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJkb2N1bWVudC5ib2R5 LmNsaWVudFdpZHRoIl07CiAgICAgfTsKIAorICAgIGF1dG8gc2V0Vmlld3BvcnQgPSBeKE5TRGlj dGlvbmFyeSAqdmlld3BvcnQpIHsKKyAgICAgICAgW3dlYlZpZXcgX292ZXJyaWRlVmlld3BvcnRX aXRoQXJndW1lbnRzOnZpZXdwb3J0XTsKKyAgICAgICAgW3dlYlZpZXcgd2FpdEZvck5leHRQcmVz ZW50YXRpb25VcGRhdGVdOworICAgIH07CisKICAgICBbd2ViVmlldyBzeW5jaHJvbm91c2x5TG9h ZEhUTUxTdHJpbmc6QCI8bWV0YSBuYW1lPSd2aWV3cG9ydCcgY29udGVudD0naW5pdGlhbC1zY2Fs ZT0xJz48ZGl2IGlkPSdkaXZXaXRoVmlld3BvcnRVbml0cycgc3R5bGU9J3dpZHRoOiAxMDB2dzsn PjwvZGl2PiJdOwogICAgIEVYUEVDVF9XS19TVFJFUSgiMjAiLCBib2R5V2lkdGgoKSk7CiAKLSAg ICBbd2ViVmlldyBfb3ZlcnJpZGVWaWV3cG9ydFdpdGhBcmd1bWVudHM6QHsgQCJ3aWR0aCIgOiBA IjEwMDAiIH1dOworICAgIHNldFZpZXdwb3J0KEB7IEAid2lkdGgiIDogQCIxMDAwIiB9KTsKICAg ICBFWFBFQ1RfV0tfU1RSRVEoIjEwMDAiLCBib2R5V2lkdGgoKSk7CiAKLSAgICBbd2ViVmlldyBf b3ZlcnJpZGVWaWV3cG9ydFdpdGhBcmd1bWVudHM6QHsgQCJ3aWR0aCIgOiBAIjEwMDAiLCBAImlu aXRpYWwtc2NhbGUiOiBAIjEiIH1dOwotICAgIFt3ZWJWaWV3IHdhaXRGb3JOZXh0UHJlc2VudGF0 aW9uVXBkYXRlXTsKKyAgICBzZXRWaWV3cG9ydChAeyBAIndpZHRoIiA6IEAiMTAwMCIsIEAiaW5p dGlhbC1zY2FsZSI6IEAiMSIgfSk7CiAgICAgRVhQRUNUX1dLX1NUUkVRKCIxMDAwIiwgYm9keVdp ZHRoKCkpOwogICAgIEVYUEVDVF9FUSgxLiwgW3dlYlZpZXcgc2Nyb2xsVmlld10uem9vbVNjYWxl KTsKIAotICAgIFt3ZWJWaWV3IF9vdmVycmlkZVZpZXdwb3J0V2l0aEFyZ3VtZW50czpAeyBAIndp ZHRoIiA6IEAiMTAwMCIsIEAiaW5pdGlhbC1zY2FsZSI6IEAiNSIgfV07Ci0gICAgW3dlYlZpZXcg d2FpdEZvck5leHRQcmVzZW50YXRpb25VcGRhdGVdOworICAgIHNldFZpZXdwb3J0KEB7IEAid2lk dGgiIDogQCIxMDAwIiwgQCJpbml0aWFsLXNjYWxlIjogQCI1IiB9KTsKICAgICBFWFBFQ1RfV0tf U1RSRVEoIjEwMDAiLCBib2R5V2lkdGgoKSk7CiAgICAgRVhQRUNUX0VRKDUuLCBbd2ViVmlldyBz Y3JvbGxWaWV3XS56b29tU2NhbGUpOwogCi0gICAgW3dlYlZpZXcgX292ZXJyaWRlVmlld3BvcnRX aXRoQXJndW1lbnRzOm5pbF07CisgICAgc2V0Vmlld3BvcnQobmlsKTsKICAgICBFWFBFQ1RfV0tf U1RSRVEoIjIwIiwgYm9keVdpZHRoKCkpOwogCiAgICAgW3dlYlZpZXcgc3luY2hyb25vdXNseUxv YWRIVE1MU3RyaW5nOkAiPG1ldGEgbmFtZT0ndmlld3BvcnQnIGNvbnRlbnQ9J3dpZHRoPTEwJz48 ZGl2IGlkPSdkaXZXaXRoVmlld3BvcnRVbml0cycgc3R5bGU9J3dpZHRoOiAxMDB2dzsnPjwvZGl2 PiJdOwogICAgIEVYUEVDVF9XS19TVFJFUSgiMTAiLCBib2R5V2lkdGgoKSk7CiAKLSAgICBbd2Vi VmlldyBfb3ZlcnJpZGVWaWV3cG9ydFdpdGhBcmd1bWVudHM6QHsgQCJ3aWR0aCIgOiBAIjEwMDAi LCBAImluaXRpYWwtc2NhbGUiOiBAIjEiIH1dOworICAgIHNldFZpZXdwb3J0KEB7IEAid2lkdGgi IDogQCIxMDAwIiwgQCJpbml0aWFsLXNjYWxlIjogQCIxIiB9KTsKICAgICBFWFBFQ1RfV0tfU1RS RVEoIjEwMDAiLCBib2R5V2lkdGgoKSk7CiAKLSAgICBbd2ViVmlldyBfb3ZlcnJpZGVWaWV3cG9y dFdpdGhBcmd1bWVudHM6QHsgQCJ3aWR0aCIgOiBAImRldmljZS13aWR0aCIsIEAiaW5pdGlhbC1z Y2FsZSI6IEAiMSIgfV07CisgICAgc2V0Vmlld3BvcnQoQHsgQCJ3aWR0aCIgOiBAImRldmljZS13 aWR0aCIsIEAiaW5pdGlhbC1zY2FsZSI6IEAiMSIgfSk7CiAgICAgRVhQRUNUX1dLX1NUUkVRKCIy MCIsIGJvZHlXaWR0aCgpKTsKIAotICAgIFt3ZWJWaWV3IF9vdmVycmlkZVZpZXdwb3J0V2l0aEFy Z3VtZW50czpAeyBAIndpZHRoIiA6IEAiNTAwIiwgQCJpbml0aWFsLXNjYWxlIjogQCIxIiwgQCJn YXJiYWdlIjogQCJub25zZW5zZSIgfV07CisgICAgc2V0Vmlld3BvcnQoQHsgQCJ3aWR0aCIgOiBA IjUwMCIsIEAiaW5pdGlhbC1zY2FsZSI6IEAiMSIsIEAiZ2FyYmFnZSI6IEAibm9uc2Vuc2UiIH0p OwogICAgIEVYUEVDVF9XS19TVFJFUSgiNTAwIiwgYm9keVdpZHRoKCkpOwogfQogCg==