197026 2019-04-17 11:13:18 -0700 AX: AccessibilityObject::parentObject() doesn't need to be pure virtual 2019-04-17 12:29:01 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi aboxhall apinheiro bburg cfleizach cgarcia commit-queue dmazzoni ews-watchlist hi jcraig jdiggs joepeck samuel_white timothy webkit-bug-importer oldest_to_newest 1528177 0 hi 2019-04-17 11:13:18 -0700 Rather than expect all subclasses to override `parentObject`, we can provide a stub implementation that does nothing so that we never have to worry about calling a pure virtual function (if we missed a subclass). 1528179 1 hi 2019-04-17 11:13:32 -0700 <rdar://problem/49448209> 1528182 2 webkit-bug-importer 2019-04-17 11:13:50 -0700 <rdar://problem/49984482> 1528185 3 367655 hi 2019-04-17 11:23:15 -0700 Created attachment 367655 Patch 1528187 4 hi 2019-04-17 11:26:52 -0700 <rdar://problem/49448209> 1528189 5 367656 hi 2019-04-17 11:28:01 -0700 Created attachment 367656 Patch 1528217 6 367656 commit-queue 2019-04-17 12:29:00 -0700 Comment on attachment 367656 Patch Clearing flags on attachment: 367656 Committed r244394: <https://trac.webkit.org/changeset/244394> 1528218 7 commit-queue 2019-04-17 12:29:01 -0700 All reviewed patches have been landed. Closing bug. 367655 2019-04-17 11:23:15 -0700 2019-04-17 11:28:01 -0700 Patch bug-197026-20190417112314.patch text/plain 1708 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMGM1MzdlYmU1MmQyN2UyZGY2NmIwZDg4ZjRhYTdiZjM5YWQ3ZmUwLi45 NmY4OGY0MDQ0MmQ0N2ZlYTBjMTZhOWY1ODBlZDllMWYwZWRmZjAxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTktMDQtMTcgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIEFYOiBBY2Nlc3NpYmlsaXR5T2JqZWN0OjpwYXJlbnRPYmplY3QoKSBkb2Vz bid0IG5lZWQgdG8gYmUgcHVyZSB2aXJ0dWFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcwMjYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5OTg0 NDgyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpB Y2Nlc3NpYmlsaXR5T2JqZWN0OjpwYXJlbnRPYmplY3QgY29uc3QpOgorCiAyMDE5LTA0LTE2ICBU aW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBGcmFtZVZpZXcg YmFzZSBiYWNrZ3JvdW5kIGNvbG9yIGFsd2F5cyBzdGFydHMgd2hpdGUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuaCBiL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oCmluZGV4IGQ0Zjc1 NmE3MmExM2UwMjRjYzk2YjdmODQyMmJhMjE0ODYyMTAwNmMuLjg3ZmU5YmM4YzM4YjAyNzJlZTAx YzJlNmRjZTUxNjUxNmQ5YjY1YmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oCkBAIC01OTcsNyArNTk3LDcgQEAgcHVibGljOgog ICAgIHZpcnR1YWwgQWNjZXNzaWJpbGl0eU9iamVjdCogbmV4dFNpYmxpbmcoKSBjb25zdCB7IHJl dHVybiBudWxscHRyOyB9CiAgICAgdmlydHVhbCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBuZXh0U2li bGluZ1VuaWdub3JlZChpbnQgbGltaXQpIGNvbnN0OwogICAgIHZpcnR1YWwgQWNjZXNzaWJpbGl0 eU9iamVjdCogcHJldmlvdXNTaWJsaW5nVW5pZ25vcmVkKGludCBsaW1pdCkgY29uc3Q7Ci0gICAg dmlydHVhbCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBwYXJlbnRPYmplY3QoKSBjb25zdCA9IDA7Cisg ICAgdmlydHVhbCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBwYXJlbnRPYmplY3QoKSBjb25zdCB7IHJl dHVybiBudWxscHRyOyB9CiAgICAgdmlydHVhbCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBwYXJlbnRP YmplY3RVbmlnbm9yZWQoKSBjb25zdDsKICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0SW50ZXJmYWNl KiBwYXJlbnRPYmplY3RJbnRlcmZhY2VVbmlnbm9yZWQoKSBjb25zdCBvdmVycmlkZSB7IHJldHVy biBwYXJlbnRPYmplY3RVbmlnbm9yZWQoKTsgfQogICAgIHZpcnR1YWwgQWNjZXNzaWJpbGl0eU9i amVjdCogcGFyZW50T2JqZWN0SWZFeGlzdHMoKSBjb25zdCB7IHJldHVybiBudWxscHRyOyB9Cg== 367656 2019-04-17 11:28:01 -0700 2019-04-17 12:29:00 -0700 Patch bug-197026.patch text/plain 1708 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMGM1MzdlYmU1MmQyN2UyZGY2NmIwZDg4ZjRhYTdiZjM5YWQ3ZmUwLi45 NmY4OGY0MDQ0MmQ0N2ZlYTBjMTZhOWY1ODBlZDllMWYwZWRmZjAxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTktMDQtMTcgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIEFYOiBBY2Nlc3NpYmlsaXR5T2JqZWN0OjpwYXJlbnRPYmplY3QoKSBkb2Vz bid0IG5lZWQgdG8gYmUgcHVyZSB2aXJ0dWFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcwMjYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5NDQ4 MjA5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpB Y2Nlc3NpYmlsaXR5T2JqZWN0OjpwYXJlbnRPYmplY3QgY29uc3QpOgorCiAyMDE5LTA0LTE2ICBU aW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBGcmFtZVZpZXcg YmFzZSBiYWNrZ3JvdW5kIGNvbG9yIGFsd2F5cyBzdGFydHMgd2hpdGUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuaCBiL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oCmluZGV4IGQ0Zjc1 NmE3MmExM2UwMjRjYzk2YjdmODQyMmJhMjE0ODYyMTAwNmMuLjg3ZmU5YmM4YzM4YjAyNzJlZTAx YzJlNmRjZTUxNjUxNmQ5YjY1YmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oCkBAIC01OTcsNyArNTk3LDcgQEAgcHVibGljOgog ICAgIHZpcnR1YWwgQWNjZXNzaWJpbGl0eU9iamVjdCogbmV4dFNpYmxpbmcoKSBjb25zdCB7IHJl dHVybiBudWxscHRyOyB9CiAgICAgdmlydHVhbCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBuZXh0U2li bGluZ1VuaWdub3JlZChpbnQgbGltaXQpIGNvbnN0OwogICAgIHZpcnR1YWwgQWNjZXNzaWJpbGl0 eU9iamVjdCogcHJldmlvdXNTaWJsaW5nVW5pZ25vcmVkKGludCBsaW1pdCkgY29uc3Q7Ci0gICAg dmlydHVhbCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBwYXJlbnRPYmplY3QoKSBjb25zdCA9IDA7Cisg ICAgdmlydHVhbCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBwYXJlbnRPYmplY3QoKSBjb25zdCB7IHJl dHVybiBudWxscHRyOyB9CiAgICAgdmlydHVhbCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBwYXJlbnRP YmplY3RVbmlnbm9yZWQoKSBjb25zdDsKICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0SW50ZXJmYWNl KiBwYXJlbnRPYmplY3RJbnRlcmZhY2VVbmlnbm9yZWQoKSBjb25zdCBvdmVycmlkZSB7IHJldHVy biBwYXJlbnRPYmplY3RVbmlnbm9yZWQoKTsgfQogICAgIHZpcnR1YWwgQWNjZXNzaWJpbGl0eU9i amVjdCogcGFyZW50T2JqZWN0SWZFeGlzdHMoKSBjb25zdCB7IHJldHVybiBudWxscHRyOyB9Cg==