197021 2019-04-17 10:55:26 -0700 Display name is empty when getting credentials with the WebKit API. 2019-04-19 14:21:28 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham rniwa webkit-bug-importer wilander oldest_to_newest 1528157 0 pvollan 2019-04-17 10:55:26 -0700 When getting credentials with -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:], the display name is empty. 1528159 1 webkit-bug-importer 2019-04-17 10:56:58 -0700 <rdar://problem/49983718> 1528166 2 367651 pvollan 2019-04-17 11:01:35 -0700 Created attachment 367651 Patch 1528827 3 367651 rniwa 2019-04-19 12:54:28 -0700 Comment on attachment 367651 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367651&action=review > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:361 > + if (!displayName) > + continue; It doesn't seem right to skip the entry just because we're missing the display name?? 1528850 4 pvollan 2019-04-19 13:57:04 -0700 (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 367651 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367651&action=review > > > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:361 > > + if (!displayName) > > + continue; > > It doesn't seem right to skip the entry just because we're missing the > display name?? That makes sense. I will update the patch. Thanks for reviewing! 1528868 5 367826 pvollan 2019-04-19 14:21:28 -0700 Created attachment 367826 Patch 367651 2019-04-17 11:01:35 -0700 2019-04-19 14:21:26 -0700 Patch bug-197021-20190417110134.patch text/plain 1941 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQzODYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA0LTE3ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBEaXNwbGF5IG5hbWUgaXMgZW1w dHkgd2hlbiBnZXR0aW5nIGNyZWRlbnRpYWxzIHdpdGggdGhlIFdlYktpdCBBUEkuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcwMjEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGdldHRpbmcgY3Jl ZGVudGlhbHMgd2l0aCAtW1dLV2Vic2l0ZURhdGFTdG9yZSBmZXRjaERhdGFSZWNvcmRzT2ZUeXBl czpjb21wbGV0aW9uSGFuZGxlcjpdLCB0aGUKKyAgICAgICAgZGlzcGxheSBuYW1lIGlzIGVtcHR5 LiBDcmVhdGUgYSBkaXNwbGF5IG5hbWUgd2l0aCB0aGUgbWV0aG9kIFdlYnNpdGVEYXRhUmVjb3Jk OjpkaXNwbGF5TmFtZUZvck9yaWdpbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJzaXRlRGF0 YS9XZWJzaXRlRGF0YVN0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFTdG9y ZTo6ZmV0Y2hEYXRhQW5kQXBwbHkpOgorCiAyMDE5LTA0LTE3ICBDaHJpcyBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtZW1iZXIgZGV2aWNlIG9yaWVudGF0aW9uIHBlcm1p c3Npb24gZm9yIHRoZSBkdXJhdGlvbiBvZiB0aGUgYnJvd3Npbmcgc2Vzc2lvbgpJbmRleDogU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURh dGFTdG9yZS5jcHAJKHJldmlzaW9uIDI0NDM4MikKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTYs OCArMzU2LDE0IEBAIHZvaWQgV2Vic2l0ZURhdGFTdG9yZTo6ZmV0Y2hEYXRhQW5kQXBwbHkKICNl bmRpZgogCiAgICAgICAgICAgICBmb3IgKGF1dG8mIG9yaWdpbiA6IHdlYnNpdGVEYXRhLm9yaWdp bnNXaXRoQ3JlZGVudGlhbHMpIHsKLSAgICAgICAgICAgICAgICBhdXRvJiByZWNvcmQgPSBtX3dl YnNpdGVEYXRhUmVjb3Jkcy5hZGQob3JpZ2luLCBXZWJzaXRlRGF0YVJlY29yZCB7IH0pLml0ZXJh dG9yLT52YWx1ZTsKLSAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAgICBhdXRvIGRpc3Bs YXlOYW1lID0gV2Vic2l0ZURhdGFSZWNvcmQ6OmRpc3BsYXlOYW1lRm9yT3JpZ2luKFNlY3VyaXR5 T3JpZ2luRGF0YTo6ZnJvbVVSTChVUkwoVVJMKCksIG9yaWdpbikpKTsKKyAgICAgICAgICAgICAg ICBpZiAoIWRpc3BsYXlOYW1lKQorICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKKworICAg ICAgICAgICAgICAgIGF1dG8mIHJlY29yZCA9IG1fd2Vic2l0ZURhdGFSZWNvcmRzLmFkZChkaXNw bGF5TmFtZSwgV2Vic2l0ZURhdGFSZWNvcmQgeyB9KS5pdGVyYXRvci0+dmFsdWU7CisgICAgICAg ICAgICAgICAgaWYgKCFyZWNvcmQuZGlzcGxheU5hbWUpCisgICAgICAgICAgICAgICAgICAgIHJl Y29yZC5kaXNwbGF5TmFtZSA9IFdURk1vdmUoZGlzcGxheU5hbWUpOworCiAgICAgICAgICAgICAg ICAgcmVjb3JkLmFkZE9yaWdpbldpdGhDcmVkZW50aWFsKG9yaWdpbik7CiAgICAgICAgICAgICB9 CiAK 367826 2019-04-19 14:21:28 -0700 2019-04-19 14:21:28 -0700 Patch bug-197021-20190419142127.patch text/plain 1893 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQ0NjQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA0LTE5ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBEaXNwbGF5IG5hbWUgaXMgZW1w dHkgd2hlbiBnZXR0aW5nIGNyZWRlbnRpYWxzIHdpdGggdGhlIFdlYktpdCBBUEkuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcwMjEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGdldHRpbmcgY3Jl ZGVudGlhbHMgd2l0aCAtW1dLV2Vic2l0ZURhdGFTdG9yZSBmZXRjaERhdGFSZWNvcmRzT2ZUeXBl czpjb21wbGV0aW9uSGFuZGxlcjpdLCB0aGUKKyAgICAgICAgZGlzcGxheSBuYW1lIGlzIGVtcHR5 LiBDcmVhdGUgYSBkaXNwbGF5IG5hbWUgd2l0aCB0aGUgbWV0aG9kIFdlYnNpdGVEYXRhUmVjb3Jk OjpkaXNwbGF5TmFtZUZvck9yaWdpbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJzaXRlRGF0 YS9XZWJzaXRlRGF0YVN0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFTdG9y ZTo6ZmV0Y2hEYXRhQW5kQXBwbHkpOgorCiAyMDE5LTA0LTE5ICBDaHJpcyBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CiAKICAgICAgICAgTWlub3IgUFNPTiByZWxlYXNlIGxvZ2dpbmcgaW1wcm92 ZW1lbnRzCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRl RGF0YVN0b3JlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJz aXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcAkocmV2aXNpb24gMjQ0NDY0KQorKysgU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTM1Niw4ICszNTYsMTMgQEAgdm9pZCBXZWJzaXRlRGF0YVN0b3JlOjpmZXRj aERhdGFBbmRBcHBseQogI2VuZGlmCiAKICAgICAgICAgICAgIGZvciAoYXV0byYgb3JpZ2luIDog d2Vic2l0ZURhdGEub3JpZ2luc1dpdGhDcmVkZW50aWFscykgewotICAgICAgICAgICAgICAgIGF1 dG8mIHJlY29yZCA9IG1fd2Vic2l0ZURhdGFSZWNvcmRzLmFkZChvcmlnaW4sIFdlYnNpdGVEYXRh UmVjb3JkIHsgfSkuaXRlcmF0b3ItPnZhbHVlOwotICAgICAgICAgICAgICAgIAorICAgICAgICAg ICAgICAgIGF1dG8gZGlzcGxheU5hbWUgPSBXZWJzaXRlRGF0YVJlY29yZDo6ZGlzcGxheU5hbWVG b3JPcmlnaW4oV2ViQ29yZTo6U2VjdXJpdHlPcmlnaW5EYXRhOjpmcm9tVVJMKFVSTChVUkwoKSwg b3JpZ2luKSkpOworICAgICAgICAgICAgICAgIEFTU0VSVCghZGlzcGxheU5hbWUuaXNFbXB0eSgp KTsKKworICAgICAgICAgICAgICAgIGF1dG8mIHJlY29yZCA9IG1fd2Vic2l0ZURhdGFSZWNvcmRz LmFkZChkaXNwbGF5TmFtZSwgV2Vic2l0ZURhdGFSZWNvcmQgeyB9KS5pdGVyYXRvci0+dmFsdWU7 CisgICAgICAgICAgICAgICAgaWYgKCFyZWNvcmQuZGlzcGxheU5hbWUpCisgICAgICAgICAgICAg ICAgICAgIHJlY29yZC5kaXNwbGF5TmFtZSA9IFdURk1vdmUoZGlzcGxheU5hbWUpOworCiAgICAg ICAgICAgICAgICAgcmVjb3JkLmFkZE9yaWdpbldpdGhDcmVkZW50aWFsKG9yaWdpbik7CiAgICAg ICAgICAgICB9CiAK