197013 2019-04-17 08:59:41 -0700 [ews-build] Use singular verb in failure description in case of single api test failure 2019-04-22 11:30:32 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu lforschler webkit-bug-importer oldest_to_newest 1528102 0 aakash_jain 2019-04-17 08:59:41 -0700 When there is only 1 api test failure, currently the failure string reads: 'Found 1 new API Tests failures'. It should be singular for single failure. e.g.: https://ews-build.webkit.org/#/builders/3/builds/670 1528104 1 367633 aakash_jain 2019-04-17 09:10:18 -0700 Created attachment 367633 Patch 1528105 2 367633 lforschler 2019-04-17 09:15:10 -0700 Comment on attachment 367633 Patch I think we have a webkitpy pluralize function. This is pretty lightweight, so so don't expect you to import webkitpy, but I'm curious if the logic you used was similar? 1529230 3 367633 aakash_jain 2019-04-22 06:06:19 -0700 Comment on attachment 367633 Patch > I think we have a webkitpy pluralize function. This is pretty lightweight, > so so don't expect you to import webkitpy, but I'm curious if the logic you > used was similar? The logic is similar. webkitpy method (https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/tool/grammar.py#L41) is little more generic and take care of whether to append 's' vs 'es'. I don't think we need to make a generic function here. 1529317 4 367633 commit-queue 2019-04-22 11:29:45 -0700 Comment on attachment 367633 Patch Clearing flags on attachment: 367633 Committed r244504: <https://trac.webkit.org/changeset/244504> 1529318 5 commit-queue 2019-04-22 11:29:47 -0700 All reviewed patches have been landed. Closing bug. 1529319 6 webkit-bug-importer 2019-04-22 11:30:32 -0700 <rdar://problem/50100796> 367633 2019-04-17 09:10:18 -0700 2019-04-22 11:29:45 -0700 Patch bug-197013-20190417121140.patch text/plain 2183 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDM3NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA0LTE3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBVc2Ugc2luZ3VsYXIgdmVyYiBpbiBmYWlsdXJlIGRl c2NyaXB0aW9uIGluIGNhc2Ugb2Ygc2luZ2xlIGFwaSB0ZXN0IGZhaWx1cmUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzAxMworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoQW5hbHl6ZUFQSVRlc3RzUmVzdWx0cy5hbmFs eXplUmVzdWx0cyk6CisKIDIwMTktMDQtMTYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBh cHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gW1dlYktpdDJdIEFkZCBzdXBwb3J0IGZvciBob25v cmluZyAtW1VJTWVudUl0ZW0gZG9udERpc21pc3NdCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNDQzNzcpCisrKyBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTgwNyw3 ICs4MDcsOCBAQCBjbGFzcyBBbmFseXplQVBJVGVzdHNSZXN1bHRzKGJ1aWxkc3RlcC5CCiAgICAg ICAgICAgICBzZWxmLl9hZGRUb0xvZygnc3RkZXJyJywgJ1xuTmV3IGZhaWx1cmVzOiB7fVxuJy5m b3JtYXQobmV3X2ZhaWx1cmVzKSkKICAgICAgICAgICAgIHNlbGYuZmluaXNoZWQoRkFJTFVSRSkK ICAgICAgICAgICAgIHNlbGYuYnVpbGQucmVzdWx0cyA9IEZBSUxVUkUKLSAgICAgICAgICAgIG1l c3NhZ2UgPSAnRm91bmQge30gbmV3IEFQSSBUZXN0cyBmYWlsdXJlczoge30nLmZvcm1hdChsZW4o bmV3X2ZhaWx1cmVzKSwgbmV3X2ZhaWx1cmVzX3N0cmluZykKKyAgICAgICAgICAgIHBsdXJhbFN1 ZmZpeCA9ICdzJyBpZiBsZW4obmV3X2ZhaWx1cmVzKSA+IDEgZWxzZSAnJworICAgICAgICAgICAg bWVzc2FnZSA9ICdGb3VuZCB7fSBuZXcgQVBJIFRlc3QgZmFpbHVyZXt9OiB7fScuZm9ybWF0KGxl bihuZXdfZmFpbHVyZXMpLCBwbHVyYWxTdWZmaXgsIG5ld19mYWlsdXJlc19zdHJpbmcpCiAgICAg ICAgICAgICBzZWxmLmRlc2NyaXB0aW9uRG9uZSA9IG1lc3NhZ2UKICAgICAgICAgICAgIHNlbGYu YnVpbGQuYnVpbGRGaW5pc2hlZChbbWVzc2FnZV0sIEZBSUxVUkUpCiAgICAgICAgIGVsc2U6CkBA IC04MTUsNyArODE2LDggQEAgY2xhc3MgQW5hbHl6ZUFQSVRlc3RzUmVzdWx0cyhidWlsZHN0ZXAu QgogICAgICAgICAgICAgc2VsZi5maW5pc2hlZChTVUNDRVNTKQogICAgICAgICAgICAgc2VsZi5i dWlsZC5yZXN1bHRzID0gU1VDQ0VTUwogICAgICAgICAgICAgc2VsZi5kZXNjcmlwdGlvbkRvbmUg PSAnUGFzc2VkIEFQSSB0ZXN0cycKLSAgICAgICAgICAgIG1lc3NhZ2UgPSAnRm91bmQge30gcHJl LWV4aXN0aW5nIEFQSSB0ZXN0cyBmYWlsdXJlcycuZm9ybWF0KGxlbihjbGVhbl90cmVlX2ZhaWx1 cmVzKSkKKyAgICAgICAgICAgIHBsdXJhbFN1ZmZpeCA9ICdzJyBpZiBsZW4oY2xlYW5fdHJlZV9m YWlsdXJlcykgPiAxIGVsc2UgJycKKyAgICAgICAgICAgIG1lc3NhZ2UgPSAnRm91bmQge30gcHJl LWV4aXN0aW5nIEFQSSB0ZXN0IGZhaWx1cmV7fScuZm9ybWF0KGxlbihjbGVhbl90cmVlX2ZhaWx1 cmVzKSwgcGx1cmFsU3VmZml4KQogICAgICAgICAgICAgaWYgZmxha3lfZmFpbHVyZXM6CiAgICAg ICAgICAgICAgICAgbWVzc2FnZSArPSAnLiBGbGFreSB0ZXN0czoge30nLmZvcm1hdChmbGFreV9m YWlsdXJlc19zdHJpbmcpCiAgICAgICAgICAgICBzZWxmLmJ1aWxkLmJ1aWxkRmluaXNoZWQoW21l c3NhZ2VdLCBTVUNDRVNTKQo=