197004 2019-04-17 07:02:16 -0700 [Pointer Events WPT] Unskip imported/w3c/web-platform-tests/pointerevents/pointerevent_lostpointercapture_for_disconnected_node.html 2019-04-18 06:32:22 -0700 1 1 1 Unclassified WebKit UI Events WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts cdumez cmarcelo dbates esprehn+autocc ews-watchlist kangil.han koivisto webkit-bug-importer oldest_to_newest 1528072 0 graouts 2019-04-17 07:02:16 -0700 The test at imported/w3c/web-platform-tests/pointerevents/pointerevent_lostpointercapture_for_disconnected_node.html is timing out and is skipped currently. 1528077 1 graouts 2019-04-17 07:07:26 -0700 We don't release pointer capture when a node that has pointer capture is disconnected. 1528424 2 367722 graouts 2019-04-18 02:26:49 -0700 Created attachment 367722 Patch 1528439 3 367722 koivisto 2019-04-18 06:11:56 -0700 Comment on attachment 367722 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367722&action=review > Source/WebCore/page/PointerCaptureController.cpp:133 > + for (auto& keyAndValue : m_activePointerIdsToCapturingData) { I suppose this map is mostly empty/has very few items? > Source/WebCore/page/PointerCaptureController.cpp:147 > + return; > + } I feel for loops read better if the bail out case is a branch, not the body of the loop. 1528442 4 graouts 2019-04-18 06:24:49 -0700 (In reply to Antti Koivisto from comment #3) > Comment on attachment 367722 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367722&action=review > > > Source/WebCore/page/PointerCaptureController.cpp:133 > > + for (auto& keyAndValue : m_activePointerIdsToCapturingData) { > > I suppose this map is mostly empty/has very few items? Yes. On macOS, it will be empty except if the page has explicitly requested pointer capture for the single active pointer. So the map would have at most one item in it on macOS. On iOS, pointer capture is implicit, so that map will have as many items as there are active touches, which most likely will be 1 or 2. > > Source/WebCore/page/PointerCaptureController.cpp:147 > > + return; > > + } > > I feel for loops read better if the bail out case is a branch, not the body > of the loop. Cool, I'll change it. 1528444 5 graouts 2019-04-18 06:31:24 -0700 Committed r244423: <https://trac.webkit.org/changeset/244423> 1528445 6 webkit-bug-importer 2019-04-18 06:32:22 -0700 <rdar://problem/50014329> 367722 2019-04-18 02:26:49 -0700 2019-04-18 06:11:56 -0700 Patch bug-197004-20190418112647.patch text/plain 12020 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzcyNjFiM2E5ZGZmNzIx ODY0NTQ5ZGVhZjAxNTU0OWNiMjc5NWIxNC4uN2M2ZjI2ZTk3ZjU0YzE4ZTEwYTU2ZTU0YjNjMzgz YmY3MDFhNDQyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE5LTA0LTE4ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1BvaW50ZXIgRXZlbnRz IFdQVF0gVW5za2lwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvcG9pbnRlcmV2ZW50 cy9wb2ludGVyZXZlbnRfbG9zdHBvaW50ZXJjYXB0dXJlX2Zvcl9kaXNjb25uZWN0ZWRfbm9kZS5o dG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTcw MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBu ZWVkIHRvIHJlbGVhc2UgcG9pbnRlciBjYXB0dXJlIHdoZW4gYW4gZWxlbWVudCB0aGF0IGhhcyBw b2ludGVyIGNhcHR1cmUgaXMgZGlzY29ubmVjdGVkIGZyb20gdGhlIERPTS4KKworICAgICAgICAq IGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OnJlbW92ZWRGcm9t QW5jZXN0b3IpOiBOb3RpZnkgdGhlIFBvaW50ZXJDYXB0dXJlQ29udHJvbGxlciB0aGF0IGFuIGVs ZW1lbnQgd2FzIGRpc2Nvbm5lY3RlZC4KKyAgICAgICAgKiBkb20vUG9pbnRlckV2ZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlBvaW50ZXJFdmVudDo6Y3JlYXRlKTogQnJvYWRlbiBjcmVhdGVQ b2ludGVyQ2FuY2VsRXZlbnQoKSB0byB0YWtlIGluIGFuIGV2ZW50IHR5cGUgc28gdGhhdCB3ZSBt YXkgdXNlIGl0IHRvIGNyZWF0ZSBhCisgICAgICAgIGxvc3Rwb2ludGVyY2FwdHVyZSBldmVudCBh cyB3ZWxsLgorICAgICAgICAoV2ViQ29yZTo6UG9pbnRlckV2ZW50OjpjcmVhdGVQb2ludGVyQ2Fu Y2VsRXZlbnQpOiBEZWxldGVkLgorICAgICAgICAqIGRvbS9Qb2ludGVyRXZlbnQuaDoKKyAgICAg ICAgKiBwYWdlL1BvaW50ZXJDYXB0dXJlQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpQb2ludGVyQ2FwdHVyZUNvbnRyb2xsZXI6OmVsZW1lbnRXYXNSZW1vdmVkKTogQ2hlY2sgd2hl dGhlciB0aGUgcHJvdmlkZWQgZWxlbWVudCBtYXRjaGVzIG9uZSBvZiB0aGUgdGFyZ2V0IG92ZXJy aWRlcyByZWNvcmRlZAorICAgICAgICBpbiB0aGUgbWFwIG9mIGNhcHR1cmVkIHBvaW50ZXIgSURz LgorICAgICAgICAoV2ViQ29yZTo6UG9pbnRlckNhcHR1cmVDb250cm9sbGVyOjpwb2ludGVyRXZl bnRXYXNEaXNwYXRjaGVkKTogVGhpcyBibG9jayBvZiBjb2RlIHdhcyBhY3R1YWxseSB1c2VsZXNz IGluIHRoaXMgbG9jYXRpb24sIHRoZSBuZXcgY29kZQorICAgICAgICBhZGRlZCBpbiBlbGVtZW50 V2FzUmVtb3ZlZCgpIHBlcmZvcm1zIHRoZSBhY3Rpb25zIHRoYXQgdGhlIHNwZWMgdGV4dCBtYW5k YXRlcy4KKyAgICAgICAgKFdlYkNvcmU6OlBvaW50ZXJDYXB0dXJlQ29udHJvbGxlcjo6Y2FuY2Vs UG9pbnRlcik6IFJlcGxhY2UgdGhlIGNhbGwgdG8gY3JlYXRlUG9pbnRlckNhbmNlbEV2ZW50KCkg d2l0aCBvbmUgdG8gY3JlYXRlKCkuCisgICAgICAgICogcGFnZS9Qb2ludGVyQ2FwdHVyZUNvbnRy b2xsZXIuaDoKKwogMjAxOS0wNC0xNyAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29t PgogCiAgICAgICAgIFtQb2ludGVyIEV2ZW50cyBXUFRdIFVuc2tpcCBpbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL3BvaW50ZXJldmVudHMvcG9pbnRlcmV2ZW50X29uX2V2ZW50X2hhbmRs ZXJzLmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCAxMDhlODI0YTA1NTI4Y2U5NmI1NWU5 NWExZDMzZDEyZmNlYjdmYTQxLi40ZDRiOWRmNGRmNDliNjM0MmRmZDM5YzNjY2U2M2U4MDNkYzkx M2FmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0xOTkwLDYgKzE5OTAsMTAgQEAgdm9pZCBF bGVtZW50OjpyZW1vdmVkRnJvbUFuY2VzdG9yKFJlbW92YWxUeXBlIHJlbW92YWxUeXBlLCBDb250 YWluZXJOb2RlJiBvbGRQYXIKICAgICBpZiAoZG9jdW1lbnQoKS5wYWdlKCkpCiAgICAgICAgIGRv Y3VtZW50KCkucGFnZSgpLT5wb2ludGVyTG9ja0NvbnRyb2xsZXIoKS5lbGVtZW50UmVtb3ZlZCgq dGhpcyk7CiAjZW5kaWYKKyNpZiBFTkFCTEUoUE9JTlRFUl9FVkVOVFMpCisgICAgaWYgKGRvY3Vt ZW50KCkucGFnZSgpICYmIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVzKCku cG9pbnRlckV2ZW50c0VuYWJsZWQoKSkKKyAgICAgICAgZG9jdW1lbnQoKS5wYWdlKCktPnBvaW50 ZXJDYXB0dXJlQ29udHJvbGxlcigpLmVsZW1lbnRXYXNSZW1vdmVkKCp0aGlzKTsKKyNlbmRpZgog CiAgICAgc2V0U2F2ZWRMYXllclNjcm9sbFBvc2l0aW9uKFNjcm9sbFBvc2l0aW9uKCkpOwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vUG9pbnRlckV2ZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Qb2ludGVyRXZlbnQuY3BwCmluZGV4IGE1YjdkMWNlZTg1OTI3ODg0MzI4ZmY3 ZTNjNDdlZTlmZDU2OTAxODkuLmI2NzlhMTNhODExMjkxMTY3YzU4N2ZjMWViYTY5YTBhYjdhY2Jh NGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb2ludGVyRXZlbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9Qb2ludGVyRXZlbnQuY3BwCkBAIC04NCw5ICs4NCw5IEBAIFJl ZlB0cjxQb2ludGVyRXZlbnQ+IFBvaW50ZXJFdmVudDo6Y3JlYXRlKGNvbnN0IE1vdXNlRXZlbnQm IG1vdXNlRXZlbnQpCiAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgUG9pbnRlckV2ZW50KHR5cGUs IGNhbkJ1YmJsZSwgaXNDYW5jZWxhYmxlLCBpc0NvbXBvc2VkLCBtb3VzZUV2ZW50KSk7CiB9CiAK LVJlZjxQb2ludGVyRXZlbnQ+IFBvaW50ZXJFdmVudDo6Y3JlYXRlUG9pbnRlckNhbmNlbEV2ZW50 KFBvaW50ZXJJRCBwb2ludGVySWQsIGNvbnN0IFN0cmluZyYgcG9pbnRlclR5cGUpCitSZWY8UG9p bnRlckV2ZW50PiBQb2ludGVyRXZlbnQ6OmNyZWF0ZShjb25zdCBTdHJpbmcmIHR5cGUsIFBvaW50 ZXJJRCBwb2ludGVySWQsIGNvbnN0IFN0cmluZyYgcG9pbnRlclR5cGUpCiB7Ci0gICAgcmV0dXJu IGFkb3B0UmVmKCpuZXcgUG9pbnRlckV2ZW50KGV2ZW50TmFtZXMoKS5wb2ludGVyY2FuY2VsRXZl bnQsIENhbkJ1YmJsZTo6WWVzLCBJc0NhbmNlbGFibGU6Ok5vLCBJc0NvbXBvc2VkOjpZZXMsIHBv aW50ZXJJZCwgcG9pbnRlclR5cGUpKTsKKyAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBQb2ludGVy RXZlbnQodHlwZSwgQ2FuQnViYmxlOjpZZXMsIElzQ2FuY2VsYWJsZTo6Tm8sIElzQ29tcG9zZWQ6 OlllcywgcG9pbnRlcklkLCBwb2ludGVyVHlwZSkpOwogfQogCiBQb2ludGVyRXZlbnQ6OlBvaW50 ZXJFdmVudCgpID0gZGVmYXVsdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb2lu dGVyRXZlbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb2ludGVyRXZlbnQuaAppbmRleCA1Nzg5 NzZkYTEzNDFmNjE2OWY1YjIwN2ZiN2RhNzc5Yzg3Mjk3ZmI4Li5iMTJhYjJkNzg4ZGQ1YjUyZTFm MjQ4MzNlZGNmYTc5MjM1YjdlMmY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vUG9p bnRlckV2ZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1BvaW50ZXJFdmVudC5oCkBAIC03 Myw3ICs3Myw3IEBAIHB1YmxpYzoKICAgICB9CiAKICAgICBzdGF0aWMgUmVmUHRyPFBvaW50ZXJF dmVudD4gY3JlYXRlKGNvbnN0IE1vdXNlRXZlbnQmKTsKLSAgICBzdGF0aWMgUmVmPFBvaW50ZXJF dmVudD4gY3JlYXRlUG9pbnRlckNhbmNlbEV2ZW50KFBvaW50ZXJJRCwgY29uc3QgU3RyaW5nJiBw b2ludGVyVHlwZSk7CisgICAgc3RhdGljIFJlZjxQb2ludGVyRXZlbnQ+IGNyZWF0ZShjb25zdCBT dHJpbmcmIHR5cGUsIFBvaW50ZXJJRCwgY29uc3QgU3RyaW5nJiBwb2ludGVyVHlwZSk7CiAKICNp ZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKSAmJiBQTEFURk9STShJT1NfRkFNSUxZKQogICAgIHN0YXRp YyBSZWY8UG9pbnRlckV2ZW50PiBjcmVhdGUoY29uc3QgUGxhdGZvcm1Ub3VjaEV2ZW50JiwgdW5z aWduZWQgdG91Y2hJbmRleCwgYm9vbCBpc1ByaW1hcnksIFJlZjxXaW5kb3dQcm94eT4mJik7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BvaW50ZXJDYXB0dXJlQ29udHJvbGxlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BvaW50ZXJDYXB0dXJlQ29udHJvbGxlci5jcHAKaW5k ZXggNzU5NDE3NTkzOGRlZmEwZDNiOTRmMDZlMGE3YjdhYTE1Y2JhMWY0OC4uOTY2MjQxZGFlZTQy OGY0MjU2NDNmODMwNTgxNGQ1M2M5ZjhhNzdlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGFnZS9Qb2ludGVyQ2FwdHVyZUNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvUG9pbnRlckNhcHR1cmVDb250cm9sbGVyLmNwcApAQCAtMTI4LDYgKzEyOCwyNSBAQCB2b2lk IFBvaW50ZXJDYXB0dXJlQ29udHJvbGxlcjo6cG9pbnRlckxvY2tXYXNBcHBsaWVkKCkKICAgICB9 CiB9CiAKK3ZvaWQgUG9pbnRlckNhcHR1cmVDb250cm9sbGVyOjplbGVtZW50V2FzUmVtb3ZlZChF bGVtZW50JiBlbGVtZW50KQoreworICAgIGZvciAoYXV0byYga2V5QW5kVmFsdWUgOiBtX2FjdGl2 ZVBvaW50ZXJJZHNUb0NhcHR1cmluZ0RhdGEpIHsKKyAgICAgICAgYXV0byYgY2FwdHVyaW5nRGF0 YSA9IGtleUFuZFZhbHVlLnZhbHVlOworICAgICAgICBpZiAoY2FwdHVyaW5nRGF0YS5wZW5kaW5n VGFyZ2V0T3ZlcnJpZGUgIT0gJmVsZW1lbnQgJiYgY2FwdHVyaW5nRGF0YS50YXJnZXRPdmVycmlk ZSAhPSAmZWxlbWVudCkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCisgICAgICAgIC8vIGh0dHBz Oi8vdzNjLmdpdGh1Yi5pby9wb2ludGVyZXZlbnRzLyNpbXBsaWNpdC1yZWxlYXNlLW9mLXBvaW50 ZXItY2FwdHVyZQorICAgICAgICAvLyBXaGVuIHRoZSBwb2ludGVyIGNhcHR1cmUgdGFyZ2V0IG92 ZXJyaWRlIGlzIG5vIGxvbmdlciBjb25uZWN0ZWQsIHRoZSBwZW5kaW5nIHBvaW50ZXIgY2FwdHVy ZSB0YXJnZXQgb3ZlcnJpZGUgYW5kIHBvaW50ZXIgY2FwdHVyZSB0YXJnZXQKKyAgICAgICAgLy8g b3ZlcnJpZGUgbm9kZXMgU0hPVUxEIGJlIGNsZWFyZWQgYW5kIGFsc28gYSBQb2ludGVyRXZlbnQg bmFtZWQgbG9zdHBvaW50ZXJjYXB0dXJlIGNvcnJlc3BvbmRpbmcgdG8gdGhlIGNhcHR1cmVkIHBv aW50ZXIgU0hPVUxEIGJlIGZpcmVkCisgICAgICAgIC8vIGF0IHRoZSBkb2N1bWVudC4KKyAgICAg ICAgYXV0byBwb2ludGVySWQgPSBrZXlBbmRWYWx1ZS5rZXk7CisgICAgICAgIGF1dG8gcG9pbnRl clR5cGUgPSBjYXB0dXJpbmdEYXRhLnBvaW50ZXJUeXBlOworICAgICAgICByZWxlYXNlUG9pbnRl ckNhcHR1cmUoJmVsZW1lbnQsIHBvaW50ZXJJZCk7CisgICAgICAgIGVsZW1lbnQuZG9jdW1lbnQo KS5lbnF1ZXVlRG9jdW1lbnRFdmVudChQb2ludGVyRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCku bG9zdHBvaW50ZXJjYXB0dXJlRXZlbnQsIHBvaW50ZXJJZCwgcG9pbnRlclR5cGUpKTsKKyAgICAg ICAgcmV0dXJuOworICAgIH0KK30KKwogdm9pZCBQb2ludGVyQ2FwdHVyZUNvbnRyb2xsZXI6OnRv dWNoRW5kZWRPcldhc0NhbmNlbGxlZEZvcklkZW50aWZpZXIoUG9pbnRlcklEIHBvaW50ZXJJZCkK IHsKICAgICBtX2FjdGl2ZVBvaW50ZXJJZHNUb0NhcHR1cmluZ0RhdGEucmVtb3ZlKHBvaW50ZXJJ ZCk7CkBAIC0yMzEsMTQgKzI1MCw2IEBAIHZvaWQgUG9pbnRlckNhcHR1cmVDb250cm9sbGVyOjpw b2ludGVyRXZlbnRXYXNEaXNwYXRjaGVkKGNvbnN0IFBvaW50ZXJFdmVudCYgZXZlCiAgICAgICAg IC8vIFBvaW50ZXIgQ2FwdHVyZSBzdGVwcyB0byBmaXJlIGxvc3Rwb2ludGVyY2FwdHVyZSBpZiBu ZWNlc3NhcnkuCiAgICAgICAgIGlmIChldmVudC50eXBlKCkgPT0gZXZlbnROYW1lcygpLnBvaW50 ZXJ1cEV2ZW50KQogICAgICAgICAgICAgY2FwdHVyaW5nRGF0YS5wZW5kaW5nVGFyZ2V0T3ZlcnJp ZGUgPSBudWxscHRyOwotCi0gICAgICAgIC8vIFdoZW4gdGhlIHBvaW50ZXIgY2FwdHVyZSB0YXJn ZXQgb3ZlcnJpZGUgaXMgbm8gbG9uZ2VyIGNvbm5lY3RlZCwgdGhlIHBlbmRpbmcgcG9pbnRlciBj YXB0dXJlIHRhcmdldCBvdmVycmlkZSBhbmQgcG9pbnRlcgotICAgICAgICAvLyBjYXB0dXJlIHRh cmdldCBvdmVycmlkZSBub2RlcyBTSE9VTEQgYmUgY2xlYXJlZCBhbmQgYWxzbyBhIFBvaW50ZXJF dmVudCBuYW1lZCBsb3N0cG9pbnRlcmNhcHR1cmUgY29ycmVzcG9uZGluZyB0byB0aGUgY2FwdHVy ZWQKLSAgICAgICAgLy8gcG9pbnRlciBTSE9VTEQgYmUgZmlyZWQgYXQgdGhlIGRvY3VtZW50Lgot ICAgICAgICBpZiAoY2FwdHVyaW5nRGF0YS50YXJnZXRPdmVycmlkZSAmJiAhY2FwdHVyaW5nRGF0 YS50YXJnZXRPdmVycmlkZS0+aXNDb25uZWN0ZWQoKSkgewotICAgICAgICAgICAgY2FwdHVyaW5n RGF0YS5wZW5kaW5nVGFyZ2V0T3ZlcnJpZGUgPSBudWxscHRyOwotICAgICAgICAgICAgY2FwdHVy aW5nRGF0YS50YXJnZXRPdmVycmlkZSA9IG51bGxwdHI7Ci0gICAgICAgIH0KICAgICB9CiAKICAg ICBwcm9jZXNzUGVuZGluZ1BvaW50ZXJDYXB0dXJlKGV2ZW50KTsKQEAgLTI4MSw3ICsyOTIsNyBA QCB2b2lkIFBvaW50ZXJDYXB0dXJlQ29udHJvbGxlcjo6Y2FuY2VsUG9pbnRlcihQb2ludGVySUQg cG9pbnRlcklkLCBjb25zdCBJbnRQb2ludAogICAgIGlmICghdGFyZ2V0KQogICAgICAgICByZXR1 cm47CiAKLSAgICBhdXRvIGV2ZW50ID0gUG9pbnRlckV2ZW50OjpjcmVhdGVQb2ludGVyQ2FuY2Vs RXZlbnQocG9pbnRlcklkLCBjYXB0dXJpbmdEYXRhLnBvaW50ZXJUeXBlKTsKKyAgICBhdXRvIGV2 ZW50ID0gUG9pbnRlckV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLnBvaW50ZXJjYW5jZWxFdmVu dCwgcG9pbnRlcklkLCBjYXB0dXJpbmdEYXRhLnBvaW50ZXJUeXBlKTsKICAgICB0YXJnZXQtPmRp c3BhdGNoRXZlbnQoZXZlbnQpOwogICAgIHByb2Nlc3NQZW5kaW5nUG9pbnRlckNhcHR1cmUoV1RG TW92ZShldmVudCkpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9Qb2ludGVy Q2FwdHVyZUNvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUG9pbnRlckNhcHR1cmVD b250cm9sbGVyLmgKaW5kZXggMTczMzQxZGE0MzliYjU1Njc5Y2UwYjQ3OWFjZDI1YTViN2ZmN2Uz YS4uNDcwOGYwNDk2Y2JkNDFhMTc4M2I5M2JkZGNkY2I2YWFhZGMzNzNiNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9Qb2ludGVyQ2FwdHVyZUNvbnRyb2xsZXIuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL1BvaW50ZXJDYXB0dXJlQ29udHJvbGxlci5oCkBAIC00Niw2ICs0Niw3 IEBAIHB1YmxpYzoKICAgICBib29sIGhhc1BvaW50ZXJDYXB0dXJlKEVsZW1lbnQqLCBQb2ludGVy SUQpOwogCiAgICAgdm9pZCBwb2ludGVyTG9ja1dhc0FwcGxpZWQoKTsKKyAgICB2b2lkIGVsZW1l bnRXYXNSZW1vdmVkKEVsZW1lbnQmKTsKIAogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpICYmIFBM QVRGT1JNKElPU19GQU1JTFkpCiAgICAgc3RkOjpwYWlyPGJvb2wsIGJvb2w+IGRpc3BhdGNoRXZl bnRGb3JUb3VjaEF0SW5kZXgoRXZlbnRUYXJnZXQmLCBjb25zdCBQbGF0Zm9ybVRvdWNoRXZlbnQm LCB1bnNpZ25lZCwgYm9vbCBpc1ByaW1hcnksIFdpbmRvd1Byb3h5Jik7CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggM2Q2ZWFk YWMyNDM5M2U0OGNhMTNkOGNiZWFjY2I4ODYxMjIzZWExMS4uMTAxZWFkNGM2ODVjYWUwOWYxZDcx MGJlM2Q0ZTZhN2Q0N2U5MDA1MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA0LTE4ICBB bnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1BvaW50ZXIgRXZl bnRzIFdQVF0gVW5za2lwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvcG9pbnRlcmV2 ZW50cy9wb2ludGVyZXZlbnRfbG9zdHBvaW50ZXJjYXB0dXJlX2Zvcl9kaXNjb25uZWN0ZWRfbm9k ZS5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTcwMDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE5LTA0LTE3ICBBbnRvaW5lIFF1 aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgW1BvaW50ZXIgRXZlbnRzIFdQVF0g VW5za2lwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvcG9pbnRlcmV2ZW50cy9wb2lu dGVyZXZlbnRfb25fZXZlbnRfaGFuZGxlcnMuaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VM b2cKaW5kZXggMWExYWNhOGZlNjJlMzlkYzUzZmU5YWVmY2QwMmZjYzM5NThiZDIyMS4uMTA0NDJl OGNiZTQ0MWE5NGExNDRjZjdlMmFkZjY0NTNmZTU3ZDNiNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMDQtMTggIEFudG9pbmUgUXVpbnQgIDxn cmFvdXRzQGFwcGxlLmNvbT4KKworICAgICAgICBbUG9pbnRlciBFdmVudHMgV1BUXSBVbnNraXAg aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9wb2ludGVyZXZlbnRzL3BvaW50ZXJldmVu dF9sb3N0cG9pbnRlcmNhcHR1cmVfZm9yX2Rpc2Nvbm5lY3RlZF9ub2RlLmh0bWwKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzAwNAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRl c3RzL3BvaW50ZXJldmVudHMvcG9pbnRlcmV2ZW50X2xvc3Rwb2ludGVyY2FwdHVyZV9mb3JfZGlz Y29ubmVjdGVkX25vZGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAxOS0wNC0xNyAgQW50b2lu ZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIFtQb2ludGVyIEV2ZW50cyBX UFRdIFVuc2tpcCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3BvaW50ZXJldmVudHMv cG9pbnRlcmV2ZW50X29uX2V2ZW50X2hhbmRsZXJzLmh0bWwKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvcG9pbnRlcmV2ZW50cy9wb2ludGVy ZXZlbnRfbG9zdHBvaW50ZXJjYXB0dXJlX2Zvcl9kaXNjb25uZWN0ZWRfbm9kZS1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3BvaW50ZXJl dmVudHMvcG9pbnRlcmV2ZW50X2xvc3Rwb2ludGVyY2FwdHVyZV9mb3JfZGlzY29ubmVjdGVkX25v ZGUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmI3ZmM5NTk2ZTE4YmNmYjAwZmQyNjJiNWVhOWE1 ZDE3NzczMmU1OTUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL3BvaW50ZXJldmVudHMvcG9pbnRlcmV2ZW50X2xvc3Rwb2ludGVy Y2FwdHVyZV9mb3JfZGlzY29ubmVjdGVkX25vZGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTgg QEAKK1BvaW50ZXIgRXZlbnRzIC0gbG9zdHBvaW50ZXJjYXB0dXJlIHdoZW4gY2FwdHVyaW5nIGVs ZW1lbnQgaXMgcmVtb3ZlZAorCitUZXN0IERlc2NyaXB0aW9uOiBUaGlzIHRlc3QgY2hlY2tzIGlm IGxvc3Rwb2ludGVyY2FwdHVyZSBpcyBmaXJlZCBhdCB0aGUgZG9jdW1lbnQgd2hlbiB0aGUgY2Fw dHVyaW5nIG5vZGUgaXMgcmVtb3ZlZCBmcm9tIHRoZSBkb2N1bWVudC4gQ29tcGxldGUgdGhlIGZv bGxvd2luZyBhY3Rpb25zOgorUHJlc3MgYW5kIGhvbGQgbGVmdCBtb3VzZSBidXR0b24gb3ZlciAi U2V0IENhcHR1cmUiIGJ1dHRvbi4gImdvdHBvaW50ZXJjYXB0dXJlIiBzaG91bGQgYmUgbG9nZ2Vk IGluc2lkZSBvZiB0aGUgYmxhY2sgcmVjdGFuZ2xlLgorImxvc3Rwb2ludGVyY2FwdHVyZSIgc2hv dWxkIGJlIGxvZ2dlZCBpbnNpZGUgb2YgdGhlIGJsYWNrIHJlY3RhbmdsZSBhZnRlciBhIHNob3J0 IGRlbGF5LgorCisKKworUG9pbnRlciBFdmVudHMgQ2FwdHVyZSBUZXN0CisKK1RoZSBmb2xsb3dp bmcgcG9pbnRlciB0eXBlcyB3ZXJlIGRldGVjdGVkOiBtb3VzZS4KKworVGhlIGZvbGxvd2luZyBl dmVudHMgd2VyZSBsb2dnZWQ6IGdvdHBvaW50ZXJjYXB0dXJlQHRhcmdldDEsIGxvc3Rwb2ludGVy Y2FwdHVyZUBkb2N1bWVudC4KKworCitQQVNTIGxvc3Rwb2ludGVyY2FwdHVyZSBldmVudCByZWNl aXZlZCAKK1BBU1MgbG9zdHBvaW50ZXJjYXB0dXJlIGlzIGRpc3BhdGNoZWQgb24gdGhlIGRvY3Vt ZW50IAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0 aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDQ4 MTZkYzUzM2ZmZjVlYjA4OWQ0MGEwNGNjODJlOTg1NWM5NmZkYWQuLjczNmRhYzg5ZWFhMDFlYjgx NmY5MGE5YmQxYzU2NjRlNjEwYjBiNGEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0 RXhwZWN0YXRpb25zCkBAIC0xODc5LDcgKzE4NzksNiBAQCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL3BvaW50ZXJldmVudHMvcG9pbnRlcmxvY2svcG9pbnRlcmV2ZW50X3BvaW50ZXJs bwogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9wb2ludGVyZXZlbnRzL3BvaW50ZXJs b2NrL3BvaW50ZXJldmVudF9wb2ludGVybW92ZV9pbl9wb2ludGVybG9jay1tYW51YWwuaHRtbCBb IFNraXAgXQogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9wb2ludGVyZXZlbnRzL3Bv aW50ZXJsb2NrL3BvaW50ZXJldmVudF9wb2ludGVybW92ZV9vbl9jaG9yZGVkX21vdXNlX2J1dHRv bl93aGVuX2xvY2tlZC1tYW51YWwuaHRtbCBbIFNraXAgXQogCi13ZWJraXQub3JnL2IvMTk3MDA0 IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvcG9pbnRlcmV2ZW50cy9wb2ludGVyZXZl bnRfbG9zdHBvaW50ZXJjYXB0dXJlX2Zvcl9kaXNjb25uZWN0ZWRfbm9kZS5odG1sIFsgU2tpcCBd CiB3ZWJraXQub3JnL2IvMTk3MDA1IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvcG9p bnRlcmV2ZW50cy9wb2ludGVyZXZlbnRfbG9zdHBvaW50ZXJjYXB0dXJlX2lzX2ZpcnN0Lmh0bWwg WyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8xOTcwMDggaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9wb2ludGVyZXZlbnRzL3BvaW50ZXJldmVudF9zdXBwcmVzc19jb21wYXRfZXZlbnRzX29u X2RyYWdfbW91c2UuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTk3MDA3IGlt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvcG9pbnRlcmV2ZW50cy9wb2ludGVybG9jay9w b2ludGVyZXZlbnRfY29vcmRpbmF0ZXNfd2hlbl9sb2NrZWQuaHRtbCBbIFNraXAgXQo=