196999 2019-04-16 19:31:14 -0700 [iOSMac] Use UIDocumentPickerViewController for picking files 2019-04-16 21:45:56 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes bdakin cdumez commit-queue ggaren jer.noble thorton timothy webkit-bug-importer wenson_hsieh oldest_to_newest 1527983 0 aestes 2019-04-16 19:31:14 -0700 [iOSMac] Use UIDocumentPickerViewController for picking files 1527984 1 aestes 2019-04-16 19:32:29 -0700 rdar://problem/49961414 1527986 2 367602 aestes 2019-04-16 19:37:13 -0700 Created attachment 367602 Patch 1527989 3 367602 thorton 2019-04-16 19:59:29 -0700 Comment on attachment 367602 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367602&action=review > Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:407 > +#if PLATFORM(IOSMAC) This class need some serious cleanup, but this is OK for now. 1528005 4 367602 commit-queue 2019-04-16 21:45:55 -0700 Comment on attachment 367602 Patch Clearing flags on attachment: 367602 Committed r244371: <https://trac.webkit.org/changeset/244371> 1528006 5 commit-queue 2019-04-16 21:45:56 -0700 All reviewed patches have been landed. Closing bug. 367602 2019-04-16 19:37:13 -0700 2019-04-16 21:45:55 -0700 Patch bug-196999-20190416193713.patch text/plain 4210 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI4N2JkOGRlNTUxZGQ0NzIy MzEwMTBhNGIzZjAzNjBlMzgxNzY2MzEuLmRmNjU4NGViNDNkMDc2Yjk2NGQ5ZTdkNTQxZDIzYzk4 MDY0Nzg0NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDQtMTYgIEFuZHkgRXN0 ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NNYWNdIFVzZSBVSURvY3VtZW50 UGlja2VyVmlld0NvbnRyb2xsZXIgZm9yIHBpY2tpbmcgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Njk5OQorICAgICAgICA8cmRhcjovL3By b2JsZW0vNDk5NjE0MTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tOgorICAg ICAgICAoLVtXS0ZpbGVVcGxvYWRQYW5lbCBfc2hvd0RvY3VtZW50UGlja2VyTWVudV0pOgorICAg ICAgICBDaGFuZ2VkIHRvIHByZXNlbnQgYSBVSURvY3VtZW50UGlja2VyVmlld0NvbnRyb2xsZXIg b24gaU9TTWFjLgorCisgICAgICAgICgtW1dLRmlsZVVwbG9hZFBhbmVsIGRvY3VtZW50UGlja2Vy OmRpZFBpY2tEb2N1bWVudHNBdFVSTHM6XSk6CisgICAgICAgICgtW1dLRmlsZVVwbG9hZFBhbmVs IGRvY3VtZW50UGlja2VyOmRpZFBpY2tEb2N1bWVudEF0VVJMOl0pOgorICAgICAgICBSZXBsYWNl ZCBhIGRlcHJlY2F0ZWQgZGVsZWdhdGUgbWV0aG9kIGltcGxlbWVudGF0aW9uLgorCiAyMDE5LTA0 LTE2ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIGZpeCB0aGUgYnVpbGQgd2l0aCByZWNlbnQgU0RLcy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbQppbmRleCBm NTc4MGQ4Yzg2NjNiYmU5YTI5M2E1YWFlNmUwNmE5MGFmNGQzZWFkLi4yNDY4NjUxMTY3NWM1MTJh MzAxZDdiNmZjYzYyNzM1ZGE5ZGIwNTljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0KKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tCkBAIC00MDQsMTAgKzQwNCwx NyBAQCAtICh2b2lkKV9zaG93RG9jdW1lbnRQaWNrZXJNZW51CiAgICAgQk9PTCBjb250YWluc0lt YWdlTWVkaWFUeXBlID0gIW1lZGlhVHlwZXMuY291bnQgfHwgYXJyYXlDb250YWluc1VUSVRoYXRD b25mb3Jtc1RvKG1lZGlhVHlwZXMsIGtVVFR5cGVJbWFnZSk7CiAgICAgQk9PTCBjb250YWluc1Zp ZGVvTWVkaWFUeXBlID0gIW1lZGlhVHlwZXMuY291bnQgfHwgYXJyYXlDb250YWluc1VUSVRoYXRD b25mb3Jtc1RvKG1lZGlhVHlwZXMsIGtVVFR5cGVNb3ZpZSk7CiAKKyNpZiBQTEFURk9STShJT1NN QUMpCisgICAgLy8gRklYTUUgNDk5NjE1ODk6IFN1cHBvcnQgcGlja2luZyBtZWRpYSB3aXRoIFVJ SW1hZ2VQaWNrZXJDb250cm9sbGVyCisgICAgQk9PTCBzaG91bGRQcmVzZW50RG9jdW1lbnRNZW51 Vmlld0NvbnRyb2xsZXIgPSBOTzsKKyNlbHNlCisgICAgQk9PTCBzaG91bGRQcmVzZW50RG9jdW1l bnRNZW51Vmlld0NvbnRyb2xsZXIgPSBjb250YWluc0ltYWdlTWVkaWFUeXBlIHx8IGNvbnRhaW5z VmlkZW9NZWRpYVR5cGU7CisjZW5kaWYKKwogICAgIE5TQXJyYXkgKmRvY3VtZW50VHlwZXMgPSBt ZWRpYVR5cGVzLmNvdW50ID8gbWVkaWFUeXBlcyA6IEBbKF9fYnJpZGdlIE5TU3RyaW5nICopa1VU VHlwZUl0ZW1dOwotICAgIGlmIChjb250YWluc0ltYWdlTWVkaWFUeXBlIHx8IGNvbnRhaW5zVmlk ZW9NZWRpYVR5cGUpIHsKKyAgICBpZiAoc2hvdWxkUHJlc2VudERvY3VtZW50TWVudVZpZXdDb250 cm9sbGVyKSB7CiAgICAgICAgIC8vIEZJWE1FOiBVSURvY3VtZW50TWVudVZpZXdDb250cm9sbGVy IGlzIGRlcHJlY2F0ZWQsIHdlIHNob3VsZCB1c2UgVUlEb2N1bWVudFBpY2tlclZpZXdDb250cm9s bGVyIGluc3RlYWQuCi0gICAgICAgIC8vIEZJWE1FOiBTdXBwb3J0IG11bHRpcGxlIGZpbGUgc2Vs ZWN0aW9uIHdoZW4gaW1wbGVtZW50ZWQuIDxyZGFyOi8vMTcxNzc5ODE+CisgICAgICAgIC8vIEZJ WE1FIDQ5OTYzNTE0OiBTdXBwb3J0IG11bHRpcGxlIGZpbGUgc2VsZWN0aW9uCiAgICAgICAgIF9k b2N1bWVudE1lbnVDb250cm9sbGVyID0gYWRvcHROUyhbW1VJRG9jdW1lbnRNZW51Vmlld0NvbnRy b2xsZXIgYWxsb2NdIF9pbml0SWdub3JpbmdBcHBsaWNhdGlvbkVudGl0bGVtZW50Rm9ySW1wb3J0 T2ZUeXBlczpkb2N1bWVudFR5cGVzXSk7CiAgICAgICAgIFtfZG9jdW1lbnRNZW51Q29udHJvbGxl ciBzZXREZWxlZ2F0ZTpzZWxmXTsKIApAQCAtNDI2LDcgKzQzMyw3IEBAIC0gKHZvaWQpX3Nob3dE b2N1bWVudFBpY2tlck1lbnUKICAgICAgICAgW3NlbGYgX3ByZXNlbnRNZW51T3B0aW9uRm9yQ3Vy cmVudEludGVyZmFjZUlkaW9tOl9kb2N1bWVudE1lbnVDb250cm9sbGVyLmdldCgpXTsKICAgICB9 IGVsc2UgewogICAgICAgICAvLyBJbWFnZSBhbmQgVmlkZW8gdHlwZXMgYXJlIG5vdCBhY2NlcHRl ZCBzbyBieXBhc3MgdGhlIG1lbnUgYW5kIG9wZW4gdGhlIGZpbGUgcGlja2VyIGRpcmVjdGx5Lgot ICAgICAgICAvLyBGSVhNRTogU3VwcG9ydCBtdWx0aXBsZSBmaWxlIHNlbGVjdGlvbiB3aGVuIGlt cGxlbWVudGVkLiA8cmRhcjovLzE3MTc3OTgxPgorICAgICAgICAvLyBGSVhNRSA0OTk2MzUxNDog U3VwcG9ydCBtdWx0aXBsZSBmaWxlIHNlbGVjdGlvbgogICAgICAgICBfZG9jdW1lbnRQaWNrZXJD b250cm9sbGVyID0gYWRvcHROUyhbW1VJRG9jdW1lbnRQaWNrZXJWaWV3Q29udHJvbGxlciBhbGxv Y10gaW5pdFdpdGhEb2N1bWVudFR5cGVzOmRvY3VtZW50VHlwZXMgaW5Nb2RlOlVJRG9jdW1lbnRQ aWNrZXJNb2RlSW1wb3J0XSk7CiAgICAgICAgIFtfZG9jdW1lbnRQaWNrZXJDb250cm9sbGVyIHNl dERlbGVnYXRlOnNlbGZdOwogICAgICAgICBbc2VsZiBfcHJlc2VudEZ1bGxzY3JlZW5WaWV3Q29u dHJvbGxlcjpfZG9jdW1lbnRQaWNrZXJDb250cm9sbGVyLmdldCgpIGFuaW1hdGVkOllFU107CkBA IC01NDQsMTIgKzU1MSwxMyBAQCAtICh2b2lkKWRvY3VtZW50TWVudVdhc0NhbmNlbGxlZDooVUlE b2N1bWVudE1lbnVWaWV3Q29udHJvbGxlciAqKWRvY3VtZW50TWVudQogCiAjcHJhZ21hIG1hcmsg LSBVSURvY3VtZW50UGlja2VyQ29udHJvbGxlckRlbGVnYXRlIGltcGxlbWVudGF0aW9uCiAKLUlH Tk9SRV9XQVJOSU5HU19CRUdJTigiZGVwcmVjYXRlZC1pbXBsZW1lbnRhdGlvbnMiKQotLSAodm9p ZClkb2N1bWVudFBpY2tlcjooVUlEb2N1bWVudFBpY2tlclZpZXdDb250cm9sbGVyICopZG9jdW1l bnRQaWNrZXIgZGlkUGlja0RvY3VtZW50QXRVUkw6KE5TVVJMICopdXJsCi1JR05PUkVfV0FSTklO R1NfRU5ECistICh2b2lkKWRvY3VtZW50UGlja2VyOihVSURvY3VtZW50UGlja2VyVmlld0NvbnRy b2xsZXIgKiljb250cm9sbGVyIGRpZFBpY2tEb2N1bWVudHNBdFVSTHM6KE5TQXJyYXkgPE5TVVJM ICo+ICopdXJscwogeworICAgIC8vIEZJWE1FIDQ5OTYzNTE0OiBTdXBwb3J0IG11bHRpcGxlIGZp bGUgc2VsZWN0aW9uCisgICAgQVNTRVJUKHVybHMuY291bnQgPT0gMSk7CisgICAgTlNVUkwgKnVy bCA9IHVybHNbMF07CiAgICAgW3NlbGYgX2Rpc21pc3NEaXNwbGF5QW5pbWF0ZWQ6WUVTXTsKLSAg ICBbc2VsZiBfY2hvb3NlRmlsZXM6QFt1cmxdIGRpc3BsYXlTdHJpbmc6dXJsLmxhc3RQYXRoQ29t cG9uZW50IGljb25JbWFnZTppY29uRm9yRmlsZSh1cmwpXTsKKyAgICBbc2VsZiBfY2hvb3NlRmls ZXM6dXJscyBkaXNwbGF5U3RyaW5nOnVybC5sYXN0UGF0aENvbXBvbmVudCBpY29uSW1hZ2U6aWNv bkZvckZpbGUodXJsKV07CiB9CiAKIC0gKHZvaWQpZG9jdW1lbnRQaWNrZXJXYXNDYW5jZWxsZWQ6 KFVJRG9jdW1lbnRQaWNrZXJWaWV3Q29udHJvbGxlciAqKWRvY3VtZW50UGlja2VyCg==