196996 2019-04-16 18:05:11 -0700 Web Inspector: Extension scripts with parse errors do not show up in Web Inspector 2019-04-17 12:59:31 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1527960 0 joepeck 2019-04-16 18:05:11 -0700 Extension scripts with parse errors do not show up in Web Inspector Steps to Reproduce: 1. Create a Safari extension with a script with a syntax error 2. Load a page where the content script loads => Syntax Error in console but no location and no resource content to link to Notes: • There is a Debugger message we ignore, such as: { "method": "Debugger.scriptFailedToParse", "params": { "url": "safari-extension://com.apple.Safari.Test.../script.js", "scriptSource":"…", "startLine": 1, "errorLine": 27, "errorMessage": "Unexpected end of script" } } 1527961 1 joepeck 2019-04-16 18:05:21 -0700 <rdar://problem/47054804> 1527962 2 367597 joepeck 2019-04-16 18:09:21 -0700 Created attachment 367597 [PATCH] Proposed Fix For now this is useful for extension which I don't know how to test... The only thing this might eventually be useful for would be anonymous evals: setTimeout(() => { eval("console.log(1) }}}"); }); Which after the above still won't have a URL so the later parse error won't handle this. --- We could create a console message error here if `url` is null and ignore the `Console.messageAdded` in that case. This seems pretty edge casey at the moment. 1528203 3 367597 hi 2019-04-17 11:50:53 -0700 Comment on attachment 367597 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=367597&action=review r-, missing ChangeLog :( > Source/WebInspectorUI/UserInterface/Models/Script.js:-32 > - console.assert(id); Why was this removed? 1528204 4 367659 joepeck 2019-04-17 11:51:21 -0700 Created attachment 367659 [PATCH] Proposed Fix 1528206 5 367659 hi 2019-04-17 11:52:23 -0700 Comment on attachment 367659 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=367659&action=review rs=me > Source/WebInspectorUI/ChangeLog:20 > + Local scripts provide a null id and id is not required below. Along these lines, I'd remove the `|| null` from `this._range = range || null;` since it's asserted that it's a `WI.TextRange`. 1528236 6 367659 commit-queue 2019-04-17 12:59:30 -0700 Comment on attachment 367659 [PATCH] Proposed Fix Clearing flags on attachment: 367659 Committed r244398: <https://trac.webkit.org/changeset/244398> 1528237 7 commit-queue 2019-04-17 12:59:31 -0700 All reviewed patches have been landed. Closing bug. 367597 2019-04-16 18:09:21 -0700 2019-04-17 11:51:21 -0700 [PATCH] Proposed Fix extension-1.patch text/plain 2502 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xs ZXJzL0RlYnVnZ2VyTWFuYWdlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0NvbnRyb2xsZXJzL0RlYnVnZ2VyTWFuYWdlci5qcwppbmRleCA2OGRmM2FmNGIwYy4uN2Fh ZWViODY4NDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0NvbnRyb2xsZXJzL0RlYnVnZ2VyTWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9EZWJ1Z2dlck1hbmFnZXIuanMKQEAgLTc1OSw2 ICs3NTksMjMgQEAgV0kuRGVidWdnZXJNYW5hZ2VyID0gY2xhc3MgRGVidWdnZXJNYW5hZ2VyIGV4 dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICB0YXJnZXQuYWRkU2NyaXB0KHNjcmlwdCk7CiAg ICAgfQogCisgICAgc2NyaXB0RGlkRmFpbCh0YXJnZXQsIHVybCwgc2NyaXB0U291cmNlKQorICAg IHsKKyAgICAgICAgY29uc3Qgc291cmNlVHlwZSA9IFdJLlNjcmlwdC5Tb3VyY2VUeXBlLlByb2dy YW07CisgICAgICAgIGxldCBzY3JpcHQgPSBuZXcgV0kuTG9jYWxTY3JpcHQodGFyZ2V0LCB1cmws IHNvdXJjZVR5cGUsIHNjcmlwdFNvdXJjZSk7CisKKyAgICAgICAgLy8gSWYgdGhlcmUgaXMgYWxy ZWFkeSBhIHJlc291cmNlIHdlIGRvbid0IG5lZWQgdG8gaGF2ZSB0aGUgc2NyaXB0IGFueW1vcmUs CisgICAgICAgIC8vIHdlIG9ubHkgbmVlZCBhIHNjcmlwdCB0byB1c2UgZm9yIHBhcnNlciBlcnJv ciBsb2NhdGlvbiBsaW5rcy4KKyAgICAgICAgaWYgKHNjcmlwdC5yZXNvdXJjZSkKKyAgICAgICAg ICAgIHJldHVybjsKKworICAgICAgICBsZXQgdGFyZ2V0RGF0YSA9IHRoaXMuZGF0YUZvclRhcmdl dCh0YXJnZXQpOworICAgICAgICB0YXJnZXREYXRhLmFkZFNjcmlwdChzY3JpcHQpOworICAgICAg ICB0YXJnZXQuYWRkU2NyaXB0KHNjcmlwdCk7CisKKyAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50 VG9MaXN0ZW5lcnMoV0kuRGVidWdnZXJNYW5hZ2VyLkV2ZW50LlNjcmlwdEFkZGVkLCB7c2NyaXB0 fSk7CisgICAgfQorCiAgICAgZGlkU2FtcGxlUHJvYmUodGFyZ2V0LCBzYW1wbGUpCiAgICAgewog ICAgICAgICBjb25zb2xlLmFzc2VydCh0aGlzLl9wcm9iZXNCeUlkZW50aWZpZXIuaGFzKHNhbXBs ZS5wcm9iZUlkKSwgIlVua25vd24gcHJvYmUgaWRlbnRpZmllciBzcGVjaWZpZWQgZm9yIHNhbXBs ZTogIiwgc2FtcGxlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL01vZGVscy9TY3JpcHQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Nb2RlbHMvU2NyaXB0LmpzCmluZGV4IDlmYjZkMzYyN2ZhLi44MmEyMTUxZTI4NCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1Njcmlw dC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU2Ny aXB0LmpzCkBAIC0yOSw3ICsyOSw2IEBAIFdJLlNjcmlwdCA9IGNsYXNzIFNjcmlwdCBleHRlbmRz IFdJLlNvdXJjZUNvZGUKICAgICB7CiAgICAgICAgIHN1cGVyKCk7CiAKLSAgICAgICAgY29uc29s ZS5hc3NlcnQoaWQpOwogICAgICAgICBjb25zb2xlLmFzc2VydCh0YXJnZXQgaW5zdGFuY2VvZiBX SS5UYXJnZXQpOwogICAgICAgICBjb25zb2xlLmFzc2VydChyYW5nZSBpbnN0YW5jZW9mIFdJLlRl eHRSYW5nZSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1Byb3RvY29sL0RlYnVnZ2VyT2JzZXJ2ZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Qcm90b2NvbC9EZWJ1Z2dlck9ic2VydmVyLmpzCmluZGV4IDNmNWJjOGI0 MDY3Li43ZjRmNDdkMjk1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvUHJvdG9jb2wvRGVidWdnZXJPYnNlcnZlci5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9EZWJ1Z2dlck9ic2VydmVyLmpzCkBAIC01 NSw3ICs1NSw4IEBAIFdJLkRlYnVnZ2VyT2JzZXJ2ZXIgPSBjbGFzcyBEZWJ1Z2dlck9ic2VydmVy CiAKICAgICBzY3JpcHRGYWlsZWRUb1BhcnNlKHVybCwgc2NyaXB0U291cmNlLCBzdGFydExpbmUs IGVycm9yTGluZSwgZXJyb3JNZXNzYWdlKQogICAgIHsKLSAgICAgICAgLy8gRklYTUU6IE5vdCBp bXBsZW1lbnRlZC4KKyAgICAgICAgLy8gTk9URTogQSBDb25zb2xlLm1lc3NhZ2VBZGRlZCBldmVu dCB3aWxsIGhhbmRsZSB0aGUgZXJyb3IgbWVzc2FnZS4KKyAgICAgICAgV0kuZGVidWdnZXJNYW5h Z2VyLnNjcmlwdERpZEZhaWwodGhpcy50YXJnZXQsIHVybCwgc2NyaXB0U291cmNlKTsKICAgICB9 CiAKICAgICBicmVha3BvaW50UmVzb2x2ZWQoYnJlYWtwb2ludElkLCBsb2NhdGlvbikK 367659 2019-04-17 11:51:21 -0700 2019-04-17 12:59:30 -0700 [PATCH] Proposed Fix ex-1.patch text/plain 3722 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZkMjgyMWU0YWM4Li4yMzc5N2I2NDY5ZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMDQtMTYgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBFeHRlbnNpb24gc2NyaXB0cyB3aXRoIHBhcnNlIGVycm9ycyBkbyBub3Qgc2hvdyB1cCBpbiBX ZWIgSW5zcGVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTY5OTYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3MDU0ODA0PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9D b250cm9sbGVycy9EZWJ1Z2dlck1hbmFnZXIuanM6CisgICAgICAgIChXSS5EZWJ1Z2dlck1hbmFn ZXIucHJvdG90eXBlLnNjcmlwdERpZEZhaWwpOgorICAgICAgICBDcmVhdGUgYSBMb2NhbFNjcmlw dCB0aGF0IGNhbiBiZSBsaW5rZWQgdG8gYnV0IGlnbm9yZSBpdAorICAgICAgICBpZiB3ZSBhbHJl YWR5IGhhdmUgYSBSZXNvdXJjZSBmb3IgdGhlIFVSTC4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvUHJvdG9jb2wvRGVidWdnZXJPYnNlcnZlci5qczoKKyAgICAgICAgKFdJLkRlYnVnZ2VyT2Jz ZXJ2ZXIucHJvdG90eXBlLnNjcmlwdEZhaWxlZFRvUGFyc2UpOgorICAgICAgICBMZXQgRGVidWdn ZXJNYW5hZ2VyIHBvdGVudGlhbGx5IGNyZWF0ZSBhIHNjcmlwdCBmb3IgdGhpcy4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdC5qczoKKyAgICAgICAgKFdJLlNjcmlwdCk6 CisgICAgICAgIExvY2FsIHNjcmlwdHMgcHJvdmlkZSBhIG51bGwgaWQgYW5kIGlkIGlzIG5vdCBy ZXF1aXJlZCBiZWxvdy4KKwogMjAxOS0wNC0xNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFdvcmtlciBpbXBvcnRlZCBzY3Jp cHRzIG5vdCBzaG93aW5nIHVwIGluIE9wZW4gUXVpY2tseSBkaWFsb2cgaWYgaW5zcGVjdG9yIG9w ZW4gYWZ0ZXIgd29ya2VycyBleGlzdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRGVidWdnZXJNYW5hZ2VyLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRGVidWdnZXJNYW5hZ2VyLmpz CmluZGV4IDY4ZGYzYWY0YjBjLi43YWFlZWI4Njg0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRGVidWdnZXJNYW5hZ2VyLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RlYnVn Z2VyTWFuYWdlci5qcwpAQCAtNzU5LDYgKzc1OSwyMyBAQCBXSS5EZWJ1Z2dlck1hbmFnZXIgPSBj bGFzcyBEZWJ1Z2dlck1hbmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgICAgIHRhcmdl dC5hZGRTY3JpcHQoc2NyaXB0KTsKICAgICB9CiAKKyAgICBzY3JpcHREaWRGYWlsKHRhcmdldCwg dXJsLCBzY3JpcHRTb3VyY2UpCisgICAgeworICAgICAgICBjb25zdCBzb3VyY2VUeXBlID0gV0ku U2NyaXB0LlNvdXJjZVR5cGUuUHJvZ3JhbTsKKyAgICAgICAgbGV0IHNjcmlwdCA9IG5ldyBXSS5M b2NhbFNjcmlwdCh0YXJnZXQsIHVybCwgc291cmNlVHlwZSwgc2NyaXB0U291cmNlKTsKKworICAg ICAgICAvLyBJZiB0aGVyZSBpcyBhbHJlYWR5IGEgcmVzb3VyY2Ugd2UgZG9uJ3QgbmVlZCB0byBo YXZlIHRoZSBzY3JpcHQgYW55bW9yZSwKKyAgICAgICAgLy8gd2Ugb25seSBuZWVkIGEgc2NyaXB0 IHRvIHVzZSBmb3IgcGFyc2VyIGVycm9yIGxvY2F0aW9uIGxpbmtzLgorICAgICAgICBpZiAoc2Ny aXB0LnJlc291cmNlKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIGxldCB0YXJnZXRE YXRhID0gdGhpcy5kYXRhRm9yVGFyZ2V0KHRhcmdldCk7CisgICAgICAgIHRhcmdldERhdGEuYWRk U2NyaXB0KHNjcmlwdCk7CisgICAgICAgIHRhcmdldC5hZGRTY3JpcHQoc2NyaXB0KTsKKworICAg ICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXSS5EZWJ1Z2dlck1hbmFnZXIuRXZl bnQuU2NyaXB0QWRkZWQsIHtzY3JpcHR9KTsKKyAgICB9CisKICAgICBkaWRTYW1wbGVQcm9iZSh0 YXJnZXQsIHNhbXBsZSkKICAgICB7CiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMuX3Byb2Jl c0J5SWRlbnRpZmllci5oYXMoc2FtcGxlLnByb2JlSWQpLCAiVW5rbm93biBwcm9iZSBpZGVudGlm aWVyIHNwZWNpZmllZCBmb3Igc2FtcGxlOiAiLCBzYW1wbGUpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdC5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHQuanMKaW5kZXggOWZiNmQz NjI3ZmEuLjgyYTIxNTFlMjg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Nb2RlbHMvU2NyaXB0LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHQuanMKQEAgLTI5LDcgKzI5LDYgQEAgV0kuU2NyaXB0 ID0gY2xhc3MgU2NyaXB0IGV4dGVuZHMgV0kuU291cmNlQ29kZQogICAgIHsKICAgICAgICAgc3Vw ZXIoKTsKIAotICAgICAgICBjb25zb2xlLmFzc2VydChpZCk7CiAgICAgICAgIGNvbnNvbGUuYXNz ZXJ0KHRhcmdldCBpbnN0YW5jZW9mIFdJLlRhcmdldCk7CiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0 KHJhbmdlIGluc3RhbmNlb2YgV0kuVGV4dFJhbmdlKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvRGVidWdnZXJPYnNlcnZlci5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0RlYnVnZ2VyT2Jz ZXJ2ZXIuanMKaW5kZXggM2Y1YmM4YjQwNjcuLjdmNGY0N2QyOTUzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9EZWJ1Z2dlck9ic2VydmVy LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0Rl YnVnZ2VyT2JzZXJ2ZXIuanMKQEAgLTU1LDcgKzU1LDggQEAgV0kuRGVidWdnZXJPYnNlcnZlciA9 IGNsYXNzIERlYnVnZ2VyT2JzZXJ2ZXIKIAogICAgIHNjcmlwdEZhaWxlZFRvUGFyc2UodXJsLCBz Y3JpcHRTb3VyY2UsIHN0YXJ0TGluZSwgZXJyb3JMaW5lLCBlcnJvck1lc3NhZ2UpCiAgICAgewot ICAgICAgICAvLyBGSVhNRTogTm90IGltcGxlbWVudGVkLgorICAgICAgICAvLyBOT1RFOiBBIENv bnNvbGUubWVzc2FnZUFkZGVkIGV2ZW50IHdpbGwgaGFuZGxlIHRoZSBlcnJvciBtZXNzYWdlLgor ICAgICAgICBXSS5kZWJ1Z2dlck1hbmFnZXIuc2NyaXB0RGlkRmFpbCh0aGlzLnRhcmdldCwgdXJs LCBzY3JpcHRTb3VyY2UpOwogICAgIH0KIAogICAgIGJyZWFrcG9pbnRSZXNvbHZlZChicmVha3Bv aW50SWQsIGxvY2F0aW9uKQo=