196985 2019-04-16 14:25:51 -0700 REGRESSION: (r244182) Layout Test editing/execCommand/insert-nested-lists.html is flaky 2019-04-22 19:39:26 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=197065 InRadar P2 Normal --- 1 tsavell rniwa ap lforschler rniwa ryanhaddad sabouhallawa simon.fraser sroberts webkit-bug-importer wenson_hsieh oldest_to_newest 1527871 0 tsavell 2019-04-16 14:25:51 -0700 The following layout test is flaky on Mac Release WK2 editing/execCommand/insert-nested-lists.html Probable cause: This test became flakey with https://trac.webkit.org/changeset/244182/webkit I reproduced this issue with command: run-webkit-tests editing/execCommand/insert-nested-lists.html --iterations 500 -f The test fails randomly on 244182 and passes fully on 244181. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2FexecCommand%2Finsert-nested-lists.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/editing/execCommand/insert-nested-lists-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/editing/execCommand/insert-nested-lists-actual.txt @@ -43,52 +43,39 @@ | <br> | <ol> | <li> -| "bar" -| <ul> -| <li> -| <#selection-caret> +| <#selection-caret> After selecting a range and inserting another unordered list: | <ul> | <li> | "foo" | <br> -| <ol> +| <ul> | <li> -| "bar" -| <ul> +| <#selection-caret> +| <ol> | <li> -| <#selection-caret> -| <ul> -| <li> After outdenting: | <ul> | <li> | "foo" | <br> -| <ol> -| <li> -| "bar" -| <li> -| <#selection-caret> -| <br> -| <ul> -| <ul> -| <li> +| <li> +| <#selection-caret> +| <br> +| <ul> +| <ol> +| <li> After outdenting again: | <ul> | <li> | "foo" | <br> -| <ol> -| <li> -| "bar" -| <li> -| "baz<#selection-caret>" -| <br> -| <ol> -| <ul> -| <ul> -| <li> +| "baz<#selection-caret>" +| <br> +| <ul> +| <ul> +| <ol> +| <li> 1527872 1 webkit-bug-importer 2019-04-16 14:27:22 -0700 <rdar://problem/49954111> 1528490 2 ap 2019-04-18 10:02:55 -0700 This is a bit surprising. This test doesn't use rAF, and generally looks like it should be deterministic. Said, Wenson, any ideas on how the regression could happen here? 1528491 3 wenson_hsieh 2019-04-18 10:04:47 -0700 (In reply to Alexey Proskuryakov from comment #2) > This is a bit surprising. This test doesn't use rAF, and generally looks > like it should be deterministic. > > Said, Wenson, any ideas on how the regression could happen here? It actually does use requestAnimationFrame: await new Promise(resolve => requestAnimationFrame(resolve)); 1528522 4 sroberts 2019-04-18 11:27:45 -0700 Found another editing test regressed by r244182. Linking to 197065 1528819 5 rniwa 2019-04-19 12:25:33 -0700 There is no reason to believe that waiting for rAF would cause UI process' runloop to run. So we need to be making an explicit round trip to UI process instead. 1528820 6 367811 rniwa 2019-04-19 12:31:12 -0700 Created attachment 367811 Fixes the test 1528821 7 rniwa 2019-04-19 12:33:25 -0700 Committed r244461: <https://trac.webkit.org/changeset/244461> 1529508 8 rniwa 2019-04-22 19:39:26 -0700 Looks like the flakiness is gone! 367811 2019-04-19 12:31:12 -0700 2019-04-19 12:31:53 -0700 Fixes the test bug-196985-20190419123111.patch text/plain 1865 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI0NDQ2MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA0LTE5ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT046IChyMjQ0MTgyKSBMYXlvdXQg VGVzdCBlZGl0aW5nL2V4ZWNDb21tYW5kL2luc2VydC1uZXN0ZWQtbGlzdHMuaHRtbCBpcyBmbGFr eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2OTg1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGZs YWtpbmVzcyB3YXMgY2F1c2VkIGJ5IHRoZSB0ZXN0IGluY29ycmVjdGx5IGFzc3VtaW5nIHRoYXQg ckFGIHdvdWxkCisgICAgICAgIGJlIGVub3VnaCB0byBjbG9zZSB0aGUgdW5kbyBncm91cCBpbiB0 aGUgVUkgcHJvY2Vzcy4KKworICAgICAgICBGaXhlZCB0aGUgdGVzdCBieSBleHBsaWNpdGx5IHdh aXRpbmcgZm9yIHRoZSBydW5sb29wIGluIHRoZSB1aSBwcm9jZXNzIHRvIHJ1bgorICAgICAgICBi eSBleGVjdXRpbmcgYSBVSSBzY3JpcHQuCisKKyAgICAgICAgKiBlZGl0aW5nL2V4ZWNDb21tYW5k L2luc2VydC1uZXN0ZWQtbGlzdHMuaHRtbDoKKwogMjAxOS0wNC0xOCAgTWVnYW4gR2FyZG5lciAg PG1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBhdXRvc2Nyb2xsIHRl c3QgdG8gbGlmdCBhdCB0aGUgZW5kIGFuZCBiZSBsZXNzIGZsYWtleQpJbmRleDogTGF5b3V0VGVz dHMvZWRpdGluZy9leGVjQ29tbWFuZC9pbnNlcnQtbmVzdGVkLWxpc3RzLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9pbnNlcnQtbmVzdGVkLWxpc3Rz Lmh0bWwJKHJldmlzaW9uIDI0NDQ1OCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1h bmQvaW5zZXJ0LW5lc3RlZC1saXN0cy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yMyw3ICsyMywx MiBAQAogCiAgICAgLy8gQnkgZGVmYXVsdCwgQXBwS2l0IG9uIG1hY09TIGNvYWxlc2NlcyB1bmRv IG9wZXJhdGlvbnMgdGhhdCBvY2N1ciB3aXRoaW4gdGhlIHNhbWUgcnVubG9vcC4gV2FpdCB1bnRp bCB0aGUgbmV4dAogICAgIC8vIHJ1bmxvb3AgYmVmb3JlIGluc2VydGluZyBhbm90aGVyIHVub3Jk ZXJlZCBsaXN0IHRvIGVuc3VyZSB0aGF0IGl0IGdldHMgaXRzIG93biBlbnRyeSBpbiB0aGUgdW5k byBzdGFjay4KLSAgICBhd2FpdCBuZXcgUHJvbWlzZShyZXNvbHZlID0+IHJlcXVlc3RBbmltYXRp b25GcmFtZShyZXNvbHZlKSk7CisgICAgYXdhaXQgbmV3IFByb21pc2UoKHJlc29sdmUpID0+IHsK KyAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICAgICAgdGVzdFJ1bm5lci5y dW5VSVNjcmlwdChgKGZ1bmN0aW9uKCkgeyB1aUNvbnRyb2xsZXIudWlTY3JpcHRDb21wbGV0ZSgp OyB9KSgpYCwgcmVzb2x2ZSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHNldFRpbWVvdXQo cmVzb2x2ZSwgNTAwKTsKKyAgICB9KTsKIAogICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJJbnNl cnROZXN0ZWRVbm9yZGVyZWRMaXN0Iik7CiAgICAgTWFya3VwLmR1bXAoImVkaXRvciIsICJBZnRl ciB0aGUgc2Vjb25kIHVub3JkZXJlZCBsaXN0IGluc2VydGlvbiIpOwo=