196983 2019-04-16 13:53:14 -0700 Set test conditions closer to conversion redirect in LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html 2019-04-16 14:35:20 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196838 InRadar P2 Normal --- 1 wilander wilander commit-queue lforschler webkit-bug-importer oldest_to_newest 1527860 0 wilander 2019-04-16 13:53:14 -0700 LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html is still flaky. Let's try some setting the test conditions closer to the redirect event. 1527861 1 webkit-bug-importer 2019-04-16 13:53:37 -0700 <rdar://problem/49952679> 1527863 2 367566 wilander 2019-04-16 13:56:17 -0700 Created attachment 367566 Patch for landing 1527879 3 367566 commit-queue 2019-04-16 14:35:18 -0700 Comment on attachment 367566 Patch for landing Clearing flags on attachment: 367566 Committed r244359: <https://trac.webkit.org/changeset/244359> 1527880 4 commit-queue 2019-04-16 14:35:20 -0700 All reviewed patches have been landed. Closing bug. 367566 2019-04-16 13:56:17 -0700 2019-04-16 14:35:18 -0700 Patch for landing bug-196983-20190416135616.patch text/plain 4026 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MzU1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzY4NGY4MzA4YjIyYWUwZDdlYmU4 YmFjM2U3MzBmMGY5OGVhODIwNy4uYjY0N2I2OWYwMzVlZjY1ZGEzNWYwZTBiZWJhNzgyNDdjNzFk NTRlYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA0LTE2ICBKb2huIFdpbGFuZGVyICA8 d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIFNldCB0ZXN0IGNvbmRpdGlvbnMgY2xvc2Vy IHRvIGNvbnZlcnNpb24gcmVkaXJlY3QgaW4gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hZENsaWNr QXR0cmlidXRpb24vc2VuZC1hdHRyaWJ1dGlvbi1jb252ZXJzaW9uLXJlcXVlc3QuaHRtbAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2OTgzCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS80OTk1MjY3OT4KKworICAgICAgICBVbnJldmlld2VkIHRlc3Qg Z2FyZGVuaW5nLgorCisgICAgICAgICogaHR0cC90ZXN0cy9hZENsaWNrQXR0cmlidXRpb24vcmVz b3VyY2VzL3JlZGlyZWN0VG9Db252ZXJzaW9uLnBocDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL2Fk Q2xpY2tBdHRyaWJ1dGlvbi9zZW5kLWF0dHJpYnV0aW9uLWNvbnZlcnNpb24tcmVxdWVzdC5odG1s OgorCiAyMDE5LTA0LTE2ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAg ICAgICBVbnByZWZpeCAtd2Via2l0LXN0aWNreQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9hZENsaWNrQXR0cmlidXRpb24vcmVzb3VyY2VzL3JlZGlyZWN0VG9Db252ZXJzaW9u LnBocCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvYWRDbGlja0F0dHJpYnV0aW9uL3Jlc291cmNl cy9yZWRpcmVjdFRvQ29udmVyc2lvbi5waHAKaW5kZXggMWFkMzMzY2IwZTNmNjIzMGQ4YWQ1ZDZj NDJhMDY0OGIwMmQwOTUxYS4uM2Q3MWE4MzUwODQ1MjcyNmI4NjJhOGY1YzExOGU1YmM5MDgyNWM5 MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hZENsaWNrQXR0cmlidXRpb24v cmVzb3VyY2VzL3JlZGlyZWN0VG9Db252ZXJzaW9uLnBocAorKysgYi9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL2FkQ2xpY2tBdHRyaWJ1dGlvbi9yZXNvdXJjZXMvcmVkaXJlY3RUb0NvbnZlcnNpb24u cGhwCkBAIC0xLDUgKzEsNiBAQAogPD9waHAKIGhlYWRlcigiSFRUUC8xLjAgMzAyIEZvdW5kIik7 CitoZWFkZXIoIkNhY2hlLUNvbnRyb2w6IG5vLWNhY2hlLCBuby1zdG9yZSwgbXVzdC1yZXZhbGlk YXRlIik7CiBpZiAoaXNzZXQoJF9HRVRbImNvbnZlcnNpb25EYXRhIl0pICYmIGlzc2V0KCRfR0VU WyJwcmlvcml0eSJdKSkgewogICBoZWFkZXIoIkxvY2F0aW9uOiAvLndlbGwta25vd24vYWQtY2xp Y2stYXR0cmlidXRpb24vIiAuICRfR0VUWyJjb252ZXJzaW9uRGF0YSJdIC4gIi8iIC4gJF9HRVRb InByaW9yaXR5Il0pOwogfSBlbHNlIGlmIChpc3NldCgkX0dFVFsiY29udmVyc2lvbkRhdGEiXSkp IHsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvYWRDbGlja0F0dHJpYnV0aW9u L3NlbmQtYXR0cmlidXRpb24tY29udmVyc2lvbi1yZXF1ZXN0Lmh0bWwgYi9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL2FkQ2xpY2tBdHRyaWJ1dGlvbi9zZW5kLWF0dHJpYnV0aW9uLWNvbnZlcnNpb24t cmVxdWVzdC5odG1sCmluZGV4IGY4ZTI2OTYxMDdmMzdmMGI2ZjMyMGJlMjNhNDJkYTVmYjcwM2E3 NDguLjAwMDk4N2ZhYzliMjZiMDI2NjA0MzEyNGU0N2FmYzg2NDEwMTkzNmUgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL2h0dHAvdGVzdHMvYWRDbGlja0F0dHJpYnV0aW9uL3NlbmQtYXR0cmlidXRp b24tY29udmVyc2lvbi1yZXF1ZXN0Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9h ZENsaWNrQXR0cmlidXRpb24vc2VuZC1hdHRyaWJ1dGlvbi1jb252ZXJzaW9uLXJlcXVlc3QuaHRt bApAQCAtMTgsNyArMTgsNiBAQAogICAgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsK ICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQ2hpbGRGcmFtZXNBc1RleHQoKTsKICAgICAgICAgdGVz dFJ1bm5lci5zZXRBbGxvd3NBbnlTU0xDZXJ0aWZpY2F0ZSh0cnVlKTsKLSAgICAgICAgdGVzdFJ1 bm5lci5zZXRBZENsaWNrQXR0cmlidXRpb25PdmVycmlkZVRpbWVyRm9yVGVzdGluZyh0cnVlKTsK ICAgICB9CiAKICAgICBmdW5jdGlvbiBhY3RpdmF0ZUVsZW1lbnQoZWxlbWVudElEKSB7CkBAIC00 MSwyMCArNDAsMjEgQEAKICAgICAgICAgZG9jdW1lbnQuYm9keS5yZW1vdmVDaGlsZChkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgicGl4ZWwiKSk7CiAKICAgICAgICAgbGV0IGlmcmFtZUVsZW1lbnQg PSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJpZnJhbWUiKTsKLSAgICAgICAgaWZyYW1lRWxlbWVu dC5zcmMgPSAiaHR0cDovLzEyNy4wLjAuMTo4MDAwL2FkQ2xpY2tBdHRyaWJ1dGlvbi9yZXNvdXJj ZXMvZ2V0Q29udmVyc2lvbkRhdGEucGhwP2VuZFRlc3Q9dHJ1ZSZ0aW1lb3V0X21zPTQwMDAmbm9u Y2U9IiArIG5vbmNlOworICAgICAgICBpZnJhbWVFbGVtZW50LnNyYyA9ICJodHRwOi8vMTI3LjAu MC4xOjgwMDAvYWRDbGlja0F0dHJpYnV0aW9uL3Jlc291cmNlcy9nZXRDb252ZXJzaW9uRGF0YS5w aHA/ZW5kVGVzdD10cnVlJnRpbWVvdXRfbXM9MjAwMCZub25jZT0iICsgbm9uY2U7CiAgICAgICAg IGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoaWZyYW1lRWxlbWVudCk7CiAgICAgfQogCiAgICAg ZnVuY3Rpb24gcnVuVGVzdCgpIHsKICAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CiAg ICAgICAgICAgICBpZiAod2luZG93LmxvY2F0aW9uLnNlYXJjaCA9PT0gIj9zdGVwVHdvIikgewot ICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIuc2V0QWRDbGlja0F0dHJpYnV0aW9uQ29udmVyc2lv blVSTEZvclRlc3RpbmcoImh0dHA6Ly8xMjcuMC4wLjE6ODAwMC9hZENsaWNrQXR0cmlidXRpb24v cmVzb3VyY2VzL2NvbnZlcnNpb25SZXBvcnQucGhwP25vbmNlPSIgKyBub25jZSk7CiAgICAgICAg ICAgICAgICAgbGV0IGltYWdlRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImltZyIp OwotICAgICAgICAgICAgICAgIGltYWdlRWxlbWVudC5zcmMgPSAiaHR0cHM6Ly8xMjcuMC4wLjE6 ODQ0My9hZENsaWNrQXR0cmlidXRpb24vcmVzb3VyY2VzL3JlZGlyZWN0VG9Db252ZXJzaW9uLnBo cD9jb252ZXJzaW9uRGF0YT0xMiI7CisgICAgICAgICAgICAgICAgaW1hZ2VFbGVtZW50LnNyYyA9 ICJodHRwczovLzEyNy4wLjAuMTo4NDQzL2FkQ2xpY2tBdHRyaWJ1dGlvbi9yZXNvdXJjZXMvcmVk aXJlY3RUb0NvbnZlcnNpb24ucGhwP2NvbnZlcnNpb25EYXRhPTEyJm5vbmNlPSIgKyBub25jZTsK ICAgICAgICAgICAgICAgICBpbWFnZUVsZW1lbnQuaWQgPSAicGl4ZWwiOwogICAgICAgICAgICAg ICAgIGltYWdlRWxlbWVudC5vbmVycm9yID0gZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICAgICAg ICAgIGFwcGVuZENvbnZlcnNpb25EYXRhSWZyYW1lQW5kRmluaXNoKCk7CiAgICAgICAgICAgICAg ICAgfTsKKyAgICAgICAgICAgICAgICB0ZXN0UnVubmVyLnNldEFkQ2xpY2tBdHRyaWJ1dGlvbkNv bnZlcnNpb25VUkxGb3JUZXN0aW5nKCJodHRwOi8vMTI3LjAuMC4xOjgwMDAvYWRDbGlja0F0dHJp YnV0aW9uL3Jlc291cmNlcy9jb252ZXJzaW9uUmVwb3J0LnBocD9ub25jZT0iICsgbm9uY2UpOwor ICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIuc2V0QWRDbGlja0F0dHJpYnV0aW9uT3ZlcnJpZGVU aW1lckZvclRlc3RpbmcodHJ1ZSk7CiAgICAgICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5hcHBl bmRDaGlsZChpbWFnZUVsZW1lbnQpOwogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAg ICAgICBhY3RpdmF0ZUVsZW1lbnQoInRhcmdldExpbmsiKTsK