196981 2019-04-16 13:39:26 -0700 Remove JSCBuiltins.cpp from Copy Headers phase 2019-04-17 10:57:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin achristensen ap bfulgham commit-queue ews-watchlist keith_miller lforschler mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1527843 0 krollin 2019-04-16 13:39:26 -0700 JSCBuiltins.cpp is not a header and so doesn't need to be in the Copy Headers phase. Checking its history, it seems to have been added accidentally at the same time that JSCBuiltins.h was added. 1527844 1 webkit-bug-importer 2019-04-16 13:39:39 -0700 <rdar://problem/49952133> 1527850 2 367561 krollin 2019-04-16 13:42:52 -0700 Created attachment 367561 Patch 1528160 3 367561 commit-queue 2019-04-17 10:57:16 -0700 Comment on attachment 367561 Patch Clearing flags on attachment: 367561 Committed r244385: <https://trac.webkit.org/changeset/244385> 1528161 4 commit-queue 2019-04-17 10:57:18 -0700 All reviewed patches have been landed. Closing bug. 367561 2019-04-16 13:42:52 -0700 2019-04-17 10:57:16 -0700 Patch bug-196981-20190416134251.patch text/plain 3401 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 NDFlNzIwYmQ3YWJiOTVkNWY4NzMwNjk2ZWQ1NzI1Y2IxM2RmMjRhLi5kNTVmNDYyNTE3Yjg4YmRh MmIyNTBhM2NmZGJlZGNmMjk0YTcxYmYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wNC0xNiAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+ CisKKyAgICAgICAgUmVtb3ZlIEpTQ0J1aWx0aW5zLmNwcCBmcm9tIENvcHkgSGVhZGVycyBwaGFz ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2OTgx CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTk1MjEzMz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKU0NCdWlsdGlucy5jcHAgaXMgbm90IGEgaGVh ZGVyIGFuZCBzbyBkb2Vzbid0IG5lZWQgdG8gYmUgaW4gdGhlIENvcHkKKyAgICAgICAgSGVhZGVy cyBwaGFzZS4gQ2hlY2tpbmcgaXRzIGhpc3RvcnksIGl0IHNlZW1zIHRvIGhhdmUgYmVlbiBhZGRl ZAorICAgICAgICBhY2NpZGVudGFsbHkgYXQgdGhlIHNhbWUgdGltZSB0aGF0IEpTQ0J1aWx0aW5z Lmggd2FzIGFkZGVkLgorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2pl Y3QucGJ4cHJvajoKKwogMjAxOS0wNC0xNCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNv bnkuY29tPgogCiAgICAgICAgIFtDTWFrZV0gSmF2YVNjcmlwdENvcmUgZGVyaXZlZCBzb3VyY2Vz IHNob3VsZCBvbmx5IGJlIHJlZmVyZW5jZWQgaW5zaWRlIEphdmFTY3JpcHRDb3JlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2pl Y3QucGJ4cHJvaiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS54Y29kZXBy b2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IGQ1MWQ3ZTY4MDNmZjNlMTk4MDNkNjQ0NzU1NzUyMzAy YWUxMDY0MTEuLmFkYzhiMzY2NmQ0MDliYmY3OTM0ZDhmZmFlNjU1ODhhNGRlMGIxZmYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJv amVjdC5wYnhwcm9qCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS54 Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBAIC05MzIsNyArOTMyLDYgQEAKIAkJNTM1MjlBNEMx QzQ1N0I3NTAwMEI0OUM2IC8qIEFQSVV0aWxzLmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhC dWlsZEZpbGU7IGZpbGVSZWYgPSA1MzUyOUE0QjFDNDU3Qjc1MDAwQjQ5QzYgLyogQVBJVXRpbHMu aCAqLzsgfTsKIAkJNTM1NTU3MTQxRDlEOUVBNTAwNkQ1ODNCIC8qIFdhc21NZW1vcnkuaCBpbiBI ZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDUzNTU1NzEzMUQ5RDlF QTUwMDZENTgzQiAvKiBXYXNtTWVtb3J5LmggKi87IHNldHRpbmdzID0ge0FUVFJJQlVURVMgPSAo UHJpdmF0ZSwgKTsgfTsgfTsKIAkJNTM1QzI0NjExRjc4OTI4RTAwNkVDNDBFIC8qIGNyZWF0ZV9y ZWdleF90YWJsZXMgaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYg PSBBNzE4RjgyMTExNzhFQjRCMDAyNDY1QTcgLyogY3JlYXRlX3JlZ2V4X3RhYmxlcyAqLzsgfTsK LQkJNTM1QzI0NjkxRjdBMTYyNDAwNkVDNDBFIC8qIEpTQ0J1aWx0aW5zLmNwcCBpbiBIZWFkZXJz ICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEE3RDgwMUE2MTg4MEQ2QTgwMDI2 QzM5QiAvKiBKU0NCdWlsdGlucy5jcHAgKi87IH07CiAJCTUzNUMyNDZDMUY3QTE3NzgwMDZFQzQw RSAvKiBVbmlmaWVkU291cmNlMTM2LmNwcCBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxk RmlsZTsgZmlsZVJlZiA9IDUzNUMyNDZCMUY3QTE3NzcwMDZFQzQwRSAvKiBVbmlmaWVkU291cmNl MTM2LmNwcCAqLzsgfTsKIAkJNTM2QjMxMEMxRjcxQzU5OTAwMzdGQzMzIC8qIFVuaWZpZWRTb3Vy Y2UxMTkuY3BwIGluIFNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0g NTM2QjMwODcxRjcxQzUzODAwMzdGQzMzIC8qIFVuaWZpZWRTb3VyY2UxMTkuY3BwICovOyB9Owog CQk1MzZCMzEwRDFGNzFDNTk5MDAzN0ZDMzMgLyogVW5pZmllZFNvdXJjZTEyNS5jcHAgaW4gU291 cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA1MzZCMzA4ODFGNzFDNTM4 MDAzN0ZDMzMgLyogVW5pZmllZFNvdXJjZTEyNS5jcHAgKi87IH07CkBAIC03Nzk4LDggKzc3OTcs OCBAQAogCQkJCTg2RDNCMkMxMTAxNTZCREUwMDI4NjVFNyAvKiBBc3NlbWJsZXJCdWZmZXJXaXRo Q29uc3RhbnRQb29sLmggKi8sCiAJCQkJNDNDMzkyQUExQzNCRUIwMDAwMjQxRjUzIC8qIEFzc2Vt YmxlckNvbW1vbi5oICovLAogCQkJCTg2RTExNkIwMEZFNzVBQzgwMEI1MTJCQyAvKiBDb2RlTG9j YXRpb24uaCAqLywKLQkJCQkwRjMwRDdCRjFEOTVENjJGMDA1MzA4OUQgLyogQ1BVLmggKi8sCiAJ CQkJNTIzMzU2MjgyMjVFQjhFOTAwMjY4QkQyIC8qIENQVS5jcHAgKi8sCisJCQkJMEYzMEQ3QkYx RDk1RDYyRjAwNTMwODlEIC8qIENQVS5oICovLAogCQkJCTBGMzczMDhFMUMwQ0Q2ODUwMDA1MkJG QSAvKiBEaXNhbGxvd01hY3JvU2NyYXRjaFJlZ2lzdGVyVXNhZ2UuaCAqLywKIAkJCQkwRkY0Mjc1 NjE1OTE0QTIwMDA0Q0I5RkYgLyogTGlua0J1ZmZlci5jcHAgKi8sCiAJCQkJODZEM0IzQzExMDE1 OUQ3RjAwMjg2NUU3IC8qIExpbmtCdWZmZXIuaCAqLywKQEAgLTkzNjgsNyArOTM2Nyw2IEBACiAJ CQkJQkMxOEM0MUMwRTE2RjVDRDAwQjM0NDYwIC8qIEpTQ2FsbGJhY2tPYmplY3RGdW5jdGlvbnMu aCBpbiBIZWFkZXJzICovLAogCQkJCTY1N0NGNDU5MTlCRjY2NjIwMDRBQ0JGMiAvKiBKU0NhbGxl ZS5oIGluIEhlYWRlcnMgKi8sCiAJCQkJNTNCNjAxRUMyMDM0QjhDNTAwNkJFNjY3IC8qIEpTQ2Fz dC5oIGluIEhlYWRlcnMgKi8sCi0JCQkJNTM1QzI0NjkxRjdBMTYyNDAwNkVDNDBFIC8qIEpTQ0J1 aWx0aW5zLmNwcCBpbiBIZWFkZXJzICovLAogCQkJCUE3RDgwMUE5MTg4MEQ2QTgwMDI2QzM5QiAv KiBKU0NCdWlsdGlucy5oIGluIEhlYWRlcnMgKi8sCiAJCQkJQkMxMTY3REEwRTE5QkNDOTAwODA2 NkREIC8qIEpTQ2VsbC5oIGluIEhlYWRlcnMgKi8sCiAJCQkJMEY5NzQ5NzExNjg3QURFNDAwQTRG RjZBIC8qIEpTQ2VsbElubGluZXMuaCBpbiBIZWFkZXJzICovLAo=